[Lldb-commits] [lldb] r360146 - [lldb] Add MacroQualified switch cases for r360109

Krasimir Georgiev via lldb-commits lldb-commits at lists.llvm.org
Tue May 7 06:59:30 PDT 2019


Author: krasimir
Date: Tue May  7 06:59:30 2019
New Revision: 360146

URL: http://llvm.org/viewvc/llvm-project?rev=360146&view=rev
Log:
[lldb] Add MacroQualified switch cases for r360109

Summary:
r360109 added a new enum case, causing lldb build to fail with several errors like:
lldb/source/Symbol/ClangASTContext.cpp:4342:11: error: enumeration value 'MacroQualified' not handled in switch [-Werror,-Wswitch]
  switch (qual_type->getTypeClass()) {
          ^
This adds the missing switch cases.
I'm not an lldb maintainer and just used my best judgement that it's probably expected that we break in these cases. Feel free to ping / revert / fix this change if this behavior is not appropriate.

Reviewers: gribozavr

Reviewed By: gribozavr

Differential Revision: https://reviews.llvm.org/D61640

Modified:
    lldb/trunk/source/Symbol/ClangASTContext.cpp

Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=360146&r1=360145&r2=360146&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/ClangASTContext.cpp (original)
+++ lldb/trunk/source/Symbol/ClangASTContext.cpp Tue May  7 06:59:30 2019
@@ -4469,6 +4469,8 @@ ClangASTContext::GetTypeClass(lldb::opaq
 
   case clang::Type::DependentAddressSpace:
     break;
+  case clang::Type::MacroQualified:
+    break;
   }
   // We don't know hot to display this type...
   return lldb::eTypeClassOther;
@@ -5337,6 +5339,8 @@ lldb::Encoding ClangASTContext::GetEncod
 
   case clang::Type::DependentAddressSpace:
     break;
+  case clang::Type::MacroQualified:
+    break;
   }
   count = 0;
   return lldb::eEncodingInvalid;
@@ -5504,6 +5508,8 @@ lldb::Format ClangASTContext::GetFormat(
 
   case clang::Type::DependentAddressSpace:
     break;
+  case clang::Type::MacroQualified:
+    break;
   }
   // We don't know hot to display this type...
   return lldb::eFormatBytes;




More information about the lldb-commits mailing list