[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

That looks fine, thanks for untangling this.

I do like Jonas' suggestion better.  GetVariantMethodNames sounds like "VariantMethods" are a specific thing and you are trying to find their names, whereas this is just variants of the method name.  GetMethodNameVariants makes that clearer.

I was going to quibble a bit about "Method" since this can also happen for regular functions.  This isn't entirely theoretical, macOS used to used to have different variants of some of the standard library routines based on the whether the program was running in strict posix mode or had xmm registers, etc.  Then it had the kernel map in the little block of function pointers and used assembly tricks so the function name would call through this block.  In that case since lldb didn't know which instance of the function was going to be used we had to look for these variants and break on all of them.  That code is gone now - macOS switched to dynamic resolver functions instead.  But this would have been another use for these "Variants".

OTOH, I can't think of a good name for "callable entities" that isn't awful, so I'm fine with Method...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61746/new/

https://reviews.llvm.org/D61746