[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu May 9 07:33:49 PDT 2019
clayborg added inline comments.
================
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:378
+ // Unwind rules are of the form
+ // register1: expression1 register2: expression2 ...
+ // We assume none of the tokens in expression<n> end with a colon.
----------------
This format seems a bit challenging to parse
================
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:418
+ if (name == ".ra")
+ return resolver.ResolveNumber(eRegisterKindGeneric, LLDB_REGNUM_GENERIC_PC);
+ return ResolveRegister(resolver, name);
----------------
LLDB_REGNUM_GENERIC_RA? Do we want the PC here or do we want the link register?
================
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:491-492
+ llvm::Optional<StackCFIRecord> init_record = StackCFIRecord::parse(*It);
+ assert(init_record.hasValue());
+ assert(init_record->Size.hasValue());
+
----------------
will this code be ok if the assertions are compiled out?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61733/new/
https://reviews.llvm.org/D61733
More information about the lldb-commits
mailing list