[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D60153#1495725 <https://reviews.llvm.org/D60153#1495725>, @stella.stamenova wrote:

> A couple of the tests from TestVSCode_attach.py (test_by_pid and test_by_name) are failing for us on Ubuntu because they are failing to attach: `AssertionError: False is not True : attach failed (Operation not permitted)`. It looks like attaching by pid or by name requires elevation - if I rerun the same tests with sudo, they pass reliably. How did you run the tests when they passed for you?
>
> Incidentally, AFAIK there is no Ubuntu lldb bot...


You probably have YAMA enabled on those machines. In the rest of our attach tests, we have the inferiors disable YAMA so that the debugger can attach, but it looks like the vscode tests are not making use of that feature. The fix should be as simple as adding `lldb_enable_attach()` at the start of the inferior main function.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60153/new/

https://reviews.llvm.org/D60153