[Lldb-commits] [PATCH] D61579: Propagate command interpreter errors from lldlbinit

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 7 15:12:32 PDT 2019


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Seems plausible.



================
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2472
+      flags |= eHandleCommandFlagPrintErrors;
+    } else if (m_command_source_flags.back() & eHandleCommandFlagPrintErrors) {
+      flags |= eHandleCommandFlagPrintErrors;
----------------
Is `m_command_source_flags.empty() || Flags(m_command_source_flags.back()).Test(eHandleCommandFlagPrintErrors)` better? Not sure.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61579/new/

https://reviews.llvm.org/D61579





More information about the lldb-commits mailing list