[Lldb-commits] [PATCH] D61648: [DWARF] Centralize user_id <-> DWARFDIE conversions

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:137
 
-  SymbolFileDWARF *GetDWARFForUID(lldb::user_id_t uid);
-
-  DWARFDIE
-  GetDIEFromUID(lldb::user_id_t uid);
+  DWARFDIE GetDIEFromUID(lldb::user_id_t uid);
+  lldb::user_id_t GetUIDFromDIE(DWARFBaseDIE die);
----------------
Maybe just overload?:
```
DWARFDIE GetDIE(lldb::user_id_t uid);
```


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:138-139
+  DWARFDIE GetDIEFromUID(lldb::user_id_t uid);
+  lldb::user_id_t GetUIDFromDIE(DWARFBaseDIE die);
+  lldb::user_id_t GetUIDFromDIERef(DIERef ref);
 
----------------
Maybe just overload these?:
```
lldb::user_id_t GetUID(DWARFBaseDIE die);
lldb::user_id_t GetUID(DIERef ref);
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61648/new/

https://reviews.llvm.org/D61648