[Lldb-commits] [PATCH] D61587: [lldb] Added support for dwarf expressions DW_OP_call2/DW_OP_call4

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

A few nits and waiting for the test case.



================
Comment at: source/Expression/DWARFExpression.cpp:2701-2704
+      auto ref_die = dwarf_cu->GetDIE(die_ref_offset);
+      if (!ref_die.IsValid()) {
+        if (error_ptr)
+          error_ptr->SetErrorString("opcode DW_OP_call2 reference not found");
----------------
Move these lines into EvaluateCall and pass "die_ref_offset" as the argument instead of "ref_die"


================
Comment at: source/Expression/DWARFExpression.cpp:2704
+        if (error_ptr)
+          error_ptr->SetErrorString("opcode DW_OP_call2 reference not found");
+        return false;
----------------
include the calculated DIE offset in the error message


================
Comment at: source/Expression/DWARFExpression.cpp:2733-2736
+      auto ref_die = dwarf_cu->GetDIE(die_ref_offset);
+      if (!ref_die.IsValid()) {
+        if (error_ptr)
+          error_ptr->SetErrorString("opcode DW_OP_call4 reference not found");
----------------
Move these lines into EvaluateCall and pass "die_ref_offset" as the argument instead of "ref_die"


================
Comment at: source/Expression/DWARFExpression.cpp:2736
+        if (error_ptr)
+          error_ptr->SetErrorString("opcode DW_OP_call4 reference not found");
+        return false;
----------------
include the calculated DIE offset in the error message


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61587/new/

https://reviews.llvm.org/D61587