[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D61578#1492422 <https://reviews.llvm.org/D61578#1492422>, @JDevlieghere wrote:

> In D61578#1492086 <https://reviews.llvm.org/D61578#1492086>, @clayborg wrote:
>
> > Just wanted to verify that we can put a:
> >
> >   settings set target.load-cwd-lldbinit true
> >
> >
> > in our ~/.lldbinit file and it will then load the local init file in the current working directory?
>
>
> Yep, that behavior remains unchanged.


Unfortunately, I guess that also means that if somebody does that (set this setting in the global config file), this test will fail for him. I think that means that one day we will have to add a flag to specifically disable reading of the global config file, or find some way to mock its contents.



================
Comment at: lldb/tools/driver/Options.td:94-100
 def: Flag<["-"], "x">,
   Alias<no_lldbinit>,
   HelpText<"Alias for --no-lldbinit">,
   Group<grp_command>;
+def local_lldbinit: F<"local-lldbinit">,
+  HelpText<"Allow the debugger to load the local lldbinit files.">,
+  Group<grp_command>;
----------------
JDevlieghere wrote:
> labath wrote:
> > What's the interaction between these two flags?
> Good question: the `no-lldbinit` flag supersedes the `allow-lldbinit` flag. I'll update the description to make that clear.
Ok, thanks for clarifying.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61578/new/

https://reviews.llvm.org/D61578