[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

António Afonso via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon May 6 11:39:05 PDT 2019


aadsm marked an inline comment as done.
aadsm added inline comments.


================
Comment at: lldb/unittests/TestingSupport/TestUtilities.cpp:12
 #include "llvm/Support/FileSystem.h"
+#include "llvm/Support/FormatVariadic.h"
 #include "llvm/Support/Path.h"
----------------
labath wrote:
> What is this header used for? If need something to include to use `createStringError`, you should include `llvm/Support/Error.h`, as that's what defines it.
I just forgot to remove it, I was using `llvm::formatv` before switching to `createStringError`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61292/new/

https://reviews.llvm.org/D61292





More information about the lldb-commits mailing list