[Lldb-commits] [PATCH] D61543: Initialization: move InstructionEmulation to full initialization
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Sun May 5 06:09:46 PDT 2019
labath accepted this revision.
labath added a comment.
This looks much better, though I'd just change one tiny thing: in the macro "canonicalization" step, I'd define a custom macro, instead of reusing one of the system ones (`_M_ARM` and friends), as those are reserved identifiers and it's bad for your karma to define those.
It might also be nice to make the linking of the relevant plugins conditional in the cmake files, but judging by a quick search, there isn't a very straight forward way to do that (CMAKE_SYSTEM_PROCESSOR would be variable to look at, but it's values aren't very standardized).
CHANGES SINCE LAST ACTION
More information about the lldb-commits