[Lldb-commits] [PATCH] D61498: 01/06: Merge GetCompileUnit + GetCompileUnitContainingDIEOffset

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil updated this revision to Diff 198148.
jankratochvil added a comment.

In D61498#1489682 <https://reviews.llvm.org/D61498#1489682>, @labath wrote:

> What you could do instead is have a single function which returns the CU if it is in the range `cu.GetOffset()  <= input < cu.GetNextUnitOffset()`, then the wrapper functions could just perform a more stricter check on the returned cu (I.e. no templates or callbacks).


OK, I agree; originally I did not want to touch more code than what I needed for .debug_types.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61498/new/

https://reviews.llvm.org/D61498

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61498.198148.patch
Type: text/x-patch
Size: 3913 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190504/3819f4bf/attachment.bin>