[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

Aleksei Sidorin via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat May 4 04:13:38 PDT 2019


a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.

👍



================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:277
   merger.RemoveSources(importer_source);
-  return ret;
+  if (ret_or_error)
+    return *ret_or_error;
----------------
'true' body needs to be surrounded by braces as well. Same below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61438/new/

https://reviews.llvm.org/D61438





More information about the lldb-commits mailing list