[Lldb-commits] [PATCH] D61478: Move decl completion out of the ASTImporterDelegate and document it [NFC]

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 2 23:51:24 PDT 2019

teemperor created this revision.
teemperor added reviewers: shafik, aprantl.
Herald added a reviewer: martong.
Herald added a reviewer: a.sidorin.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
teemperor edited the summary of this revision.
Herald added a subscriber: rnkovacs.

The ASTImporterDelegate is currently responsible for both recording and also completing
types. This patch moves the actual completion and recording code outside the ASTImporterDelegate
to reduce the amount of responsibilities the ASTImporterDelegate has to fulfill.

As I anyway had to touch the code when moving I also documented and refactored most of it
(e.g. no more asserts that we call the deporting start/end function always as a pair).

Note that I had to make the ASTImporterDelegate and it's related functions public now so that
I can move out the functionality in another class (that doesn't need to be in the header).




-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61478.197920.patch
Type: text/x-patch
Size: 13687 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190503/6ab1c285/attachment-0001.bin>

More information about the lldb-commits mailing list