[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu May 2 13:43:49 PDT 2019
clayborg added inline comments.
Comment at: lldb/include/lldb/Symbol/Declaration.h:113
+ /// Compares the specification from \a rhs. If the file specifications are
+ /// equal, then continue to compare the line.
How about just returning a bool:
bool FileAndLineEqual(const Declaration &rhs);
Comment at: lldb/include/lldb/Symbol/LineEntry.h:140
+ AddressRange GetSameLineContiguousAddressRange(
+ bool include_inlined_functions = false) const;
> We try to avoid default arguments unless there's a good reason, and in this case it looks like you pass the argument explicitly in almost all the uses, so I would make this a regular argument.
We tried that but the patch becomes a lot bigger if so. Happy to add all the other changes back, or we can make a new fucntion?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits