[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

Konrad Wilhelm Kleine via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 2 12:50:50 PDT 2019


kwk added a comment.

In D61440#1488450 <https://reviews.llvm.org/D61440#1488450>, @teemperor wrote:

> FYI, I still think there are some style issues there (e.g. the AppleObjCRuntimeV2.cpp change makes it longer than 80 chars) but I can just clang-format this before committing.
>
> Otherwise, unless someone objects to this change I'll merge this tomorrow. Thanks for the patch @kkleine!


@teemperor I've formatted the AppleObjCRuntimeV2.cpp using `git clang-format` and it worked. Thank you for pointing me this handy tool. But as you probably can see now in commit 0b4b24065a12678c773f8c3f0fc722e50405fc85, not all the changes were related to the `override` keyword.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61440/new/

https://reviews.llvm.org/D61440





More information about the lldb-commits mailing list