[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

Konrad Wilhelm Kleine via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 2 12:27:27 PDT 2019


kwk added a comment.

In D61440#1488174 <https://reviews.llvm.org/D61440#1488174>, @teemperor wrote:

> LGTM module some minor code style issues (You removed some `virtual`s but didn't fix the indentation of the parameters on the next line, see the inline comments for examples).


@teemperor I would have loved to use clang-format for this but apparently the LLDB code is still manually formatted. It would be a bliss to just use the LLVM clang-format style and never ever talk about "style" again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61440/new/

https://reviews.llvm.org/D61440





More information about the lldb-commits mailing list