[Lldb-commits] [lldb] r359813 - Remove unnecessary check in SymbolFileDWARF::ParseImportedModules
Raphael Isemann via lldb-commits
lldb-commits at lists.llvm.org
Thu May 2 11:26:59 PDT 2019
Author: teemperor
Date: Thu May 2 11:26:58 2019
New Revision: 359813
URL: http://llvm.org/viewvc/llvm-project?rev=359813&view=rev
Log:
Remove unnecessary check in SymbolFileDWARF::ParseImportedModules
Summary:
This check seems unnecessary as we already assert the same condition above and also access `sc.comp_unit`
before this check.
Reviewers: aprantl
Reviewed By: aprantl
Subscribers: jdoerfert, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D61394
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp?rev=359813&r1=359812&r2=359813&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Thu May 2 11:26:58 2019
@@ -909,9 +909,6 @@ bool SymbolFileDWARF::ParseImportedModul
return false;
UpdateExternalModuleListIfNeeded();
- if (!sc.comp_unit)
- return false;
-
const DWARFDIE die = dwarf_cu->DIE();
if (!die)
return false;
More information about the lldb-commits
mailing list