[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 2 10:59:39 PDT 2019


teemperor added a comment.

I think the best way to handle these errors in LLDB is to just log and then return some default value. That should make the current command print an error, which is better than terminating LLDB.

Otherwise the LLDB part of this patch LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61438/new/

https://reviews.llvm.org/D61438





More information about the lldb-commits mailing list