[Lldb-commits] [PATCH] D61311: PostfixExpression: Use signed integers in IntegerNode

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: include/lldb/Symbol/PostfixExpression.h:97
 private:
-  uint32_t m_value;
+  int64_t m_value;
 };
----------------
Do we want to try and use lldb_private::Scalar here? Then this could handle signed/unsigned ints, floats and anything else that comes along? Might need to be renamed "ScalarNode"? All of the type promotion stuff is already built into those classes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61311/new/

https://reviews.llvm.org/D61311