[Lldb-commits] [PATCH] D61303: [lldb] [lit] Add write tests for MM/XMM/r8-r15 registers

[Pavel Labath via Phabricator via lldb-commits]

labath marked an inline comment as done.
labath added inline comments.


================
Comment at: lldb/lit/Register/Inputs/x86-mm-xmm-write.cpp:10
+int main() {
+  constexpr uint64_t mm_fill = 0x0F0F0F0F0F0F0F0F;
+  constexpr xmm_t xmm_fill = { mm_fill, mm_fill };
----------------
mgorny wrote:
> labath wrote:
> > It looks like `mm_fill` is unused.
> It's used to fill `xmm_fill` ;-). Should I inline it?
What I actually meant here was that I was expecting `mm_fill` to be used to initialize the `mm` registers, but you're initializing them with `xmm_fill` instead. However, that's not really important, as both are technically correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61303/new/

https://reviews.llvm.org/D61303