[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

[Frederic Riss via Phabricator via lldb-commits]

friss added inline comments.


================
Comment at: packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/main.cpp:48-50
+                                // Commenting out some of the expressions because they work for the wrong reasons and will break all together
+                                // once we stop injecting all the local variables into an expression. This case will have to be fixed with
+                                // a future set of changes.
----------------
This is a little vague. Can you replace it with something like: "Disabling until we do template lookup correctly: http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20180507/040689.html"

With this, this LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61266/new/

https://reviews.llvm.org/D61266