[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 29 13:14:09 PDT 2019


teemperor marked 2 inline comments as done.
teemperor added inline comments.


================
Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:249
+    /// it at the end of the scope. Supports being used multiple times on the
+    /// same Minion instance in nested scopes.
+    class CxxModuleScope {
----------------
aprantl wrote:
> I really wish we could rename Minion with something actually descriptive...
I'm still trying to come up with a good name. The whole purpose of the class is to actually extend and listen to the actual ASTImporter. So what about `ASTImporterDecorator`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59537/new/

https://reviews.llvm.org/D59537





More information about the lldb-commits mailing list