[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode
Adrian McCarthy via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Apr 29 13:01:28 PDT 2019
amccarth accepted this revision.
amccarth added a comment.
LGTM, but I found one comment a bit confusing for me.
Comment at: source/Symbol/PostfixExpression.cpp:150
+ /// InitialValueNodes in our input expression, we assume the initial stack
+ /// will contain their value (hence we start with m_stack_depth = 1). If we
+ /// don't have InitialValueNodes, this value is not used, and so its starting
I'm having trouble understanding this comment.
"will contain their value" -- What does "their" refer to here? I guessed InitialValueNodes, but then I'd expect "value" to be "values" (plural), and I'm not sure how that relates to the stack depth.
CHANGES SINCE LAST ACTION
More information about the lldb-commits