[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/include/lldb/Symbol/ClangASTContext.h:1005
+    // May be null if we are already done parsing this ASTContext or the
+    // ASTContext wasn't created by parsing source code.
+    clang::Sema *                                   m_sema = nullptr;
----------------
`///`


================
Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:249
+    /// it at the end of the scope. Supports being used multiple times on the
+    /// same Minion instance in nested scopes.
+    class CxxModuleScope {
----------------
I really wish we could rename Minion with something actually descriptive...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59537/new/

https://reviews.llvm.org/D59537