[Lldb-commits] [PATCH] D61128: Support member function types in PdbAstBuilder

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.

Thanks for the improved commit message.  Again, sorry about the delay.



================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h:183
                                CompilerType ct);
+  lldb::TypeSP CreateFunctionType(PdbTypeSymId type_id,
+                                  const llvm::codeview::MemberFunctionRecord &pr,
----------------
Suggestion:  Consider  `CreateMemberFunctionType` or `CreateMethodType` to avoid confusion with `CreateProcedureType`.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61128/new/

https://reviews.llvm.org/D61128