[Lldb-commits] [PATCH] D61266: Skip TestClassTemplateParameterPack.py on all platforms

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 29 10:12:54 PDT 2019

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

>   So a long-term fix for this would require at least reworking ho that debug information is generated.

I believe the debug information correct but our lookup is just not finding/loading the necessary AST nodes?

Otherwise I assume the radar is keeping track of the fact that this feature is broken, so LGTM so that we unblock the other reviews.

Comment at: packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py:9
         # rdar://problem/48128064
-        decorators.skipIfDarwin])
+        decorators.skipIf])
Nit pick: Isn't there a `skip` or so that's more expressive than `skipIf`?



More information about the lldb-commits mailing list