[Lldb-commits] [PATCH] D61212: [lldb] [lit] Add tests for reading ZMM registers (AVX512)

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a subscriber: JDevlieghere.
labath added a comment.
This revision is now accepted and ready to land.

The test fails on linux even with the right hardware, but that's not surprising as the original test was also @skipUnlessDarwin (and I see no trace of zmm support in the linux part of code). I also don't have mac hardware around that I could try the mac side of things on (maybe @JDevlieghere has?), but I guess you can also just watch the bots carefully after committing this.

In D61212#1481278 <https://reviews.llvm.org/D61212#1481278>, @mgorny wrote:

> For the record, GCC refuses to build this with:
>
>   Inputs/x86-zmm-read.cpp: In function ‘int main()’:
>   Inputs/x86-zmm-read.cpp:193:4: error: more than 30 operands in ‘asm’
>      );
>       ^
>
>
> Not sure if we care about it though; clang doesn't seem to have this limitation.


I don't think we have to worry about that now. If that ever becomes a problem, we can always make the zmm things into an array and pass them via a single memory argument.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61212/new/

https://reviews.llvm.org/D61212