[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 29 02:07:24 PDT 2019


labath added a comment.

LG, but note that this has no effect on the overall set of tests which will run as long as gmodules remains disabled in `test_categories.is_supported_on_platform`.

The other thing to note is that the effect of enabling gmodules extremely strongly depends on how your system is configured. (Almost) none of our test define their own modules, so the only modules that lldb might end up using are the ones from the system libraries. Which is kind of way I think our way of testing module debugging support is broken. We have enough problems with people reporting tests which only break for them because of some quirk in their system libraries without us throwing modules into the mix.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61244/new/

https://reviews.llvm.org/D61244





More information about the lldb-commits mailing list