[Lldb-commits] [PATCH] D61210: [lldb] [lit] Introduce tests for reading x86 general purpose registers

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 29 00:53:42 PDT 2019


labath added a comment.

Looks good to me. In your place, I wouldn't bother with making sure that the process can correctly terminate after we have read the registers, but now that you have done it, there's no reason to take it out. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61210/new/

https://reviews.llvm.org/D61210





More information about the lldb-commits mailing list