[Lldb-commits] [PATCH] D46551: Inject only relevant local variables in the expression evaluation context

[Raphael Isemann via Phabricator via lldb-commits]

teemperor updated this revision to Diff 196965.
teemperor added a comment.

- Disable the variable filtering when during tab completion for now, as it seems our Clang lookup doesn't pull in external types which breaks the completion tests (and others too). This is only a temporary fix to unblock D59960 <https://reviews.llvm.org/D59960>.
- Some minor cleanup and documentation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D46551/new/

https://reviews.llvm.org/D46551

Files:
  lldb/packages/Python/lldbsuite/test/lang/cpp/member-and-local-vars-with-same-name/TestMembersAndLocalsWithSameName.py
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46551.196965.patch
Type: text/x-patch
Size: 11708 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190427/39325337/attachment-0001.bin>