[Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

Christos Zoulas via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 26 09:56:07 PDT 2019

On Apr 26,  3:11pm, reviews at reviews.llvm.org (Pavel Labath via Phabricator) wrote:
-- Subject: [PATCH] D61191: Editline: Fix an msan error

| --b1_b299efcc557883c5ff30a5eebc16e12b
| Content-Type: text/plain; charset=us-ascii
| Content-Transfer-Encoding: quoted-printable
| labath created this revision.
| labath added reviewers: christos, krytarowski, davide.
| Despite the documentation for the el_get(EL_GETTC) function claiming the
| vararg part is (const char *name, void *value), in reality the function
| expects the vararg list to be terminated by a null pointer, which can be
| clearly seen by examining the source code. Although this is mostly
| bening because the extra values are not used it any way, it still lights
| up as an error when running the tests under msan.
| Work around this quirk by adding an explicit nullptr to the end of the
| argument list.
| https://reviews.llvm.org/D61191

fixed, thanks!


More information about the lldb-commits mailing list