[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 25 10:39:47 PDT 2019

jingham added a comment.

I really thought there was one at the SB layer, because in terms of design that is what makes sense.  I guess we never really needed it until now, so we didn't add it.  Once there's more than one hard-coded script interpreter, we will need to add some way to select & direct scripts at the various script interpreters so we will need SBScriptInterpreter at the SB layer.  So maybe now is the time to add it in preparation...

Also, the fact that at the lldb_private layer, the ScriptInterpreter is held onto by the CommandInterpreter is clearly wrong.  The CommandInterpreter should have a member that tells it the currently selected ScriptInterpreter, but the list of script interpreters should belong to the Debugger.  We should probably disentangle that at the same time.

As an aside, IIUC, the current work to support either Python flavor only supports one interpreter at a time because Python doesn't support loading Python 2 & 3 into the same process?  That wouldn't be true for any other script interpreter.  I get LOTS of requests to add Swift as a script interpreter, BTW, though at present Swift isn't really ready for that so far as I can see...



More information about the lldb-commits mailing list