[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 24 16:38:16 PDT 2019


jingham added a comment.

It seems weird to be getting the ScriptInterpreter's ScriptModuleDirectory from the CommandInterpreter.  I would have expected:

m_debugger.GetScriptInterpreter().GetScriptModuleDirectory()

I don't think there's any reason to have the Command Interpreter know which ScriptInterpreter is being used, so entangling them like this is awkward.

Am I missing some reason why it makes sense to do this on the CommandInterpreter?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61090/new/

https://reviews.llvm.org/D61090





More information about the lldb-commits mailing list