[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 24 00:17:26 PDT 2019


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

The chosen approach looks fine to me. The only nit I have is that llvm style prefers `static` functions over ones in anonymous namespaces (though this file is not very consistent in that aspect already).

Do you have commit access or shall I commit this for you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61036/new/

https://reviews.llvm.org/D61036





More information about the lldb-commits mailing list