[Lldb-commits] [PATCH] D61004: FuncUnwinders: Factor out address validity check

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 23 05:35:30 PDT 2019

labath created this revision.
labath added reviewers: jasonmolenda, aprantl.

Some (but not all) of the unwind plan creation functions were checking
the validity of their address range before they attempted to create the
unwind plan.

Since a FuncUnwinders object cannot do anything reasonable with an
invalid address range, in this patch I remove the checks in from the
creation functions, and instead make it's validity a class invariant.
This makes it the responsibility of whoever's creating the FuncUnwinders
to ensure it does that with a valid address range, which is easy to
achieve as there is only one place we are doing that.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61004.196220.patch
Type: text/x-patch
Size: 6079 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190423/b0a821df/attachment-0001.bin>

More information about the lldb-commits mailing list