[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 23 04:44:41 PDT 2019


labath created this revision.
labath added reviewers: amccarth, jingham, clayborg.
Herald added a subscriber: mgorny.

After the last round of cleanups, this script was almost a no-op. The
only piece of functionality that remained was the one which tried to
make the swig-generated function signatures more pythonic.

The "tried" part is important here, as it wasn't doing a really good job
and the end result was not valid python nor c (e.g.,
SetExecutable(SBAttachInfo self, str const * path)).

Doing these transformations another way is not possible, as these
signatures are generated by swig, and not present in source. However,
given that this is the only reason why we need a swig post-process step,
and that the current implementation is pretty sub-optimal, I propose we
simply abandon the the signature fixup idea, and choose to simplify our
build process instead.


https://reviews.llvm.org/D61000

Files:
  lldb.xcodeproj/project.pbxproj
  scripts/CMakeLists.txt
  scripts/Python/modify-python-lldb.py
  scripts/Python/prepare_binding_Python.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61000.196210.patch
Type: text/x-patch
Size: 8886 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190423/a88487eb/attachment.bin>


More information about the lldb-commits mailing list