[Lldb-commits] [PATCH] D60829: FuncUnwinders: remove "current_offset" from function arguments

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.

Sorry for the delay in looking at this.  It looks like a good change, an improvement on the original for sure.  I've never seen multiple eh_frame FDEs for a single function, so that's fine.  The .ARM.exidx format and Apple's compact unwind format can theoretically have multiple different unwind plans for a single function - but I've never seen it done in practice.  More commonly, a single unwind plan will be used for multiple functions that have the same unwind state.  (these two formats don't describe prologue/epilogues - they only describe the unwind state in the middle of the function where exceptions can be thrown)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60829/new/

https://reviews.llvm.org/D60829