[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support
Adrian McCarthy via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 19 08:18:53 PDT 2019
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
Thanks for the changes. If the tests pass, then this LGTM. Just check the one last question I added about the `AC1D` test.
(The diff in Phabricator looks very confused, as though you deleted several hundred lines. Perhaps because the original diff had context and this one didn't. If I'm interpretting the diff correctly, this looks good now.)
Comment at: lit/SymbolFile/NativePDB/ast-types.cpp:22
Should this one start with FIXME rather than CHECK? Isn't this the case that's currently broken?
CHANGES SINCE LAST ACTION
More information about the lldb-commits