[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 17 00:40:03 PDT 2019

labath added a comment.

Thanks for adding the test.

I guess I've touched this bit when I was working on the dwarf5 index thingy, but all my memory of this function has already been swapped out (and I'm not sure I ever fully understood all the nuances of how it was supposed to work).

So yeah, I think this is fine but I don't feel very qualified to make that claim.

Comment at: packages/Python/lldbsuite/test/lang/cpp/global_variables/TestGlobalVariables.py:20
+    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24764")
+    @expectedFailureAll(oslist=["linux"], archs=["aarch64"], bugnumber="llvm.org/pr37301")
+    def test(self):
I don't think this bug applies here, as we're inspecting a running process, though we don't have any arm64 bots running ATM to verify that. I'd just remove this XFAIL.



More information about the lldb-commits mailing list