[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

One picky comment about the test, otherwise this looks good to me.  Pavel had his hands in this code most recently, however, so we should wait on his opinion.



================
Comment at: packages/Python/lldbsuite/test/lang/cpp/global_variables/TestGlobalVariables.py:31-41
+        target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
+        self.assertTrue(target, VALID_TARGET)
+
+        # Break inside the main.
+        lldbutil.run_break_set_by_file_and_line(
+            self, self.source, self.line, num_expected_locations=1, loc_exact=True)
+
----------------
Can you use lldbutil.run_to_source_breakpoint to do this?  Like:

lldbutil.run_to_source_breakpoint(self, "//Set break point at this line", self.source)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60737/new/

https://reviews.llvm.org/D60737