[Lldb-commits] [lldb] r358135 - [NFC] Remove ASCII lines from comments
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 10 13:48:59 PDT 2019
Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Wed Apr 10 13:48:55 2019
@@ -288,9 +288,7 @@ bool ProcessGDBRemote::CanDebug(lldb::Ta
return true;
}
-//----------------------------------------------------------------------
// ProcessGDBRemote constructor
-//----------------------------------------------------------------------
ProcessGDBRemote::ProcessGDBRemote(lldb::TargetSP target_sp,
ListenerSP listener_sp)
: Process(target_sp, listener_sp),
@@ -353,9 +351,7 @@ ProcessGDBRemote::ProcessGDBRemote(lldb:
m_gdb_comm.SetPacketTimeout(std::chrono::seconds(timeout_seconds));
}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
ProcessGDBRemote::~ProcessGDBRemote() {
// m_mach_process.UnregisterNotificationCallbacks (this);
Clear();
@@ -373,9 +369,7 @@ ProcessGDBRemote::~ProcessGDBRemote() {
KillDebugserverProcess();
}
-//----------------------------------------------------------------------
// PluginInterface
-//----------------------------------------------------------------------
ConstString ProcessGDBRemote::GetPluginName() { return GetPluginNameStatic(); }
uint32_t ProcessGDBRemote::GetPluginVersion() { return 1; }
@@ -809,9 +803,7 @@ Status ProcessGDBRemote::WillLaunchOrAtt
return error;
}
-//----------------------------------------------------------------------
// Process Control
-//----------------------------------------------------------------------
Status ProcessGDBRemote::DoLaunch(lldb_private::Module *exe_module,
ProcessLaunchInfo &launch_info) {
Log *log(ProcessGDBRemoteLog::GetLogIfAllCategoriesSet(GDBR_LOG_PROCESS));
@@ -2724,9 +2716,7 @@ void ProcessGDBRemote::SetUnixSignals(co
Process::SetUnixSignals(std::make_shared<GDBRemoteSignals>(signals_sp));
}
-//------------------------------------------------------------------
// Process Queries
-//------------------------------------------------------------------
bool ProcessGDBRemote::IsAlive() {
return m_gdb_comm.IsConnected() && Process::IsAlive();
@@ -2770,9 +2760,7 @@ void ProcessGDBRemote::WillPublicStop()
}
}
-//------------------------------------------------------------------
// Process Memory
-//------------------------------------------------------------------
size_t ProcessGDBRemote::DoReadMemory(addr_t addr, void *buf, size_t size,
Status &error) {
GetMaxMemorySize();
@@ -3133,9 +3121,7 @@ Status ProcessGDBRemote::DoDeallocateMem
return error;
}
-//------------------------------------------------------------------
// Process STDIO
-//------------------------------------------------------------------
size_t ProcessGDBRemote::PutSTDIN(const char *src, size_t src_len,
Status &error) {
if (m_stdio_communication.IsConnected()) {
Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h Wed Apr 10 13:48:55 2019
@@ -67,17 +67,13 @@ public:
static const char *GetPluginDescriptionStatic();
- //------------------------------------------------------------------
// Check if a given Process
- //------------------------------------------------------------------
bool CanDebug(lldb::TargetSP target_sp,
bool plugin_specified_by_name) override;
CommandObject *GetPluginCommandObject() override;
- //------------------------------------------------------------------
// Creating a new process, or attaching to an existing one
- //------------------------------------------------------------------
Status WillLaunch(Module *module) override;
Status DoLaunch(Module *exe_module, ProcessLaunchInfo &launch_info) override;
@@ -102,16 +98,12 @@ public:
void DidAttach(ArchSpec &process_arch) override;
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
- //------------------------------------------------------------------
// Process Control
- //------------------------------------------------------------------
Status WillResume() override;
Status DoResume() override;
@@ -130,18 +122,14 @@ public:
void SetUnixSignals(const lldb::UnixSignalsSP &signals_sp);
- //------------------------------------------------------------------
// Process Queries
- //------------------------------------------------------------------
bool IsAlive() override;
lldb::addr_t GetImageInfoAddress() override;
void WillPublicStop() override;
- //------------------------------------------------------------------
// Process Memory
- //------------------------------------------------------------------
size_t DoReadMemory(lldb::addr_t addr, void *buf, size_t size,
Status &error) override;
@@ -159,21 +147,15 @@ public:
Status DoDeallocateMemory(lldb::addr_t ptr) override;
- //------------------------------------------------------------------
// Process STDIO
- //------------------------------------------------------------------
size_t PutSTDIN(const char *buf, size_t buf_size, Status &error) override;
- //----------------------------------------------------------------------
// Process Breakpoints
- //----------------------------------------------------------------------
Status EnableBreakpointSite(BreakpointSite *bp_site) override;
Status DisableBreakpointSite(BreakpointSite *bp_site) override;
- //----------------------------------------------------------------------
// Process Watchpoints
- //----------------------------------------------------------------------
Status EnableWatchpoint(Watchpoint *wp, bool notify = true) override;
Status DisableWatchpoint(Watchpoint *wp, bool notify = true) override;
@@ -205,9 +187,7 @@ public:
Status SendEventData(const char *data) override;
- //----------------------------------------------------------------------
// Override DidExit so we can disconnect from the remote GDB server
- //----------------------------------------------------------------------
void DidExit() override;
void SetUserSpecifiedMaxMemoryTransferSize(uint64_t user_specified_max);
@@ -255,9 +235,7 @@ protected:
friend class GDBRemoteCommunicationClient;
friend class GDBRemoteRegisterContext;
- //------------------------------------------------------------------
/// Broadcaster event bits definitions.
- //------------------------------------------------------------------
enum {
eBroadcastBitAsyncContinue = (1 << 0),
eBroadcastBitAsyncThreadShouldExit = (1 << 1),
@@ -312,9 +290,7 @@ protected:
using FlashRange = FlashRangeVector::Entry;
FlashRangeVector m_erased_flash_ranges;
- //----------------------------------------------------------------------
// Accessors
- //----------------------------------------------------------------------
bool IsRunning(lldb::StateType state) {
return state == lldb::eStateRunning || IsStepping(state);
}
@@ -427,9 +403,7 @@ protected:
bool HasErased(FlashRange range);
private:
- //------------------------------------------------------------------
// For ProcessGDBRemote only
- //------------------------------------------------------------------
std::string m_partial_profile_data;
std::map<uint64_t, uint32_t> m_thread_id_to_used_usec_map;
uint64_t m_last_signals_version = 0;
@@ -439,9 +413,7 @@ private:
lldb::user_id_t break_id,
lldb::user_id_t break_loc_id);
- //------------------------------------------------------------------
// ContinueDelegate interface
- //------------------------------------------------------------------
void HandleAsyncStdout(llvm::StringRef out) override;
void HandleAsyncMisc(llvm::StringRef data) override;
void HandleStopReply() override;
Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp Wed Apr 10 13:48:55 2019
@@ -31,9 +31,7 @@ using namespace lldb;
using namespace lldb_private;
using namespace lldb_private::process_gdb_remote;
-//----------------------------------------------------------------------
// Thread Registers
-//----------------------------------------------------------------------
ThreadGDBRemote::ThreadGDBRemote(Process &process, lldb::tid_t tid)
: Thread(process, tid), m_thread_name(), m_dispatch_queue_name(),
Modified: lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp (original)
+++ lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp Wed Apr 10 13:48:55 2019
@@ -104,9 +104,7 @@ bool ProcessMachCore::CanDebug(lldb::Tar
return false;
}
-//----------------------------------------------------------------------
// ProcessMachCore constructor
-//----------------------------------------------------------------------
ProcessMachCore::ProcessMachCore(lldb::TargetSP target_sp,
ListenerSP listener_sp,
const FileSpec &core_file)
@@ -115,9 +113,7 @@ ProcessMachCore::ProcessMachCore(lldb::T
m_dyld_addr(LLDB_INVALID_ADDRESS),
m_mach_kernel_addr(LLDB_INVALID_ADDRESS), m_dyld_plugin_name() {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
ProcessMachCore::~ProcessMachCore() {
Clear();
// We need to call finalize on the process before destroying ourselves to
@@ -127,9 +123,7 @@ ProcessMachCore::~ProcessMachCore() {
Finalize();
}
-//----------------------------------------------------------------------
// PluginInterface
-//----------------------------------------------------------------------
ConstString ProcessMachCore::GetPluginName() { return GetPluginNameStatic(); }
uint32_t ProcessMachCore::GetPluginVersion() { return 1; }
@@ -191,9 +185,7 @@ bool ProcessMachCore::GetDynamicLoaderAd
return false;
}
-//----------------------------------------------------------------------
// Process Control
-//----------------------------------------------------------------------
Status ProcessMachCore::DoLoadCore() {
Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER |
LIBLLDB_LOG_PROCESS));
@@ -493,17 +485,13 @@ void ProcessMachCore::RefreshStateAfterS
Status ProcessMachCore::DoDestroy() { return Status(); }
-//------------------------------------------------------------------
// Process Queries
-//------------------------------------------------------------------
bool ProcessMachCore::IsAlive() { return true; }
bool ProcessMachCore::WarnBeforeDetach() const { return false; }
-//------------------------------------------------------------------
// Process Memory
-//------------------------------------------------------------------
size_t ProcessMachCore::ReadMemory(addr_t addr, void *buf, size_t size,
Status &error) {
// Don't allow the caching that lldb_private::Process::ReadMemory does since
@@ -517,7 +505,6 @@ size_t ProcessMachCore::DoReadMemory(add
size_t bytes_read = 0;
if (core_objfile) {
- //----------------------------------------------------------------------
// Segments are not always contiguous in mach-o core files. We have core
// files that have segments like:
// Address Size File off File size
@@ -534,7 +521,6 @@ size_t ProcessMachCore::DoReadMemory(add
// We would attempt to read 32 bytes from 0xf6ff0 but would only get 16
// unless we loop through consecutive memory ranges that are contiguous in
// the address space, but not in the file data.
- //----------------------------------------------------------------------
while (bytes_read < size) {
const addr_t curr_addr = addr + bytes_read;
const VMRangeToFileOffset::Entry *core_memory_entry =
Modified: lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.h (original)
+++ lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.h Wed Apr 10 13:48:55 2019
@@ -20,9 +20,7 @@ class ThreadKDP;
class ProcessMachCore : public lldb_private::Process {
public:
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
ProcessMachCore(lldb::TargetSP target_sp, lldb::ListenerSP listener,
const lldb_private::FileSpec &core_file);
@@ -40,43 +38,31 @@ public:
static const char *GetPluginDescriptionStatic();
- //------------------------------------------------------------------
// Check if a given Process
- //------------------------------------------------------------------
bool CanDebug(lldb::TargetSP target_sp,
bool plugin_specified_by_name) override;
- //------------------------------------------------------------------
// Creating a new process, or attaching to an existing one
- //------------------------------------------------------------------
lldb_private::Status DoLoadCore() override;
lldb_private::DynamicLoader *GetDynamicLoader() override;
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
lldb_private::ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
- //------------------------------------------------------------------
// Process Control
- //------------------------------------------------------------------
lldb_private::Status DoDestroy() override;
void RefreshStateAfterStop() override;
- //------------------------------------------------------------------
// Process Queries
- //------------------------------------------------------------------
bool IsAlive() override;
bool WarnBeforeDetach() const override;
- //------------------------------------------------------------------
// Process Memory
- //------------------------------------------------------------------
size_t ReadMemory(lldb::addr_t addr, void *buf, size_t size,
lldb_private::Status &error) override;
@@ -107,7 +93,6 @@ private:
eKernelCorefile
} CorefilePreferences;
- //------------------------------------------------------------------
/// If a core file can be interpreted multiple ways, this establishes
/// which style wins.
///
@@ -117,7 +102,6 @@ private:
/// memory. Or it could be a user process coredump of lldb while doing
/// kernel debugging - so a copy of the kernel is in its heap. This
/// should become a setting so it can be over-ridden when necessary.
- //------------------------------------------------------------------
CorefilePreference GetCorefilePreference() {
// For now, if both user process and kernel binaries a present,
// assume this is a kernel coredump which has a copy of a user
@@ -125,9 +109,7 @@ private:
return eKernelCorefile;
}
- //------------------------------------------------------------------
// For ProcessMachCore only
- //------------------------------------------------------------------
typedef lldb_private::Range<lldb::addr_t, lldb::addr_t> FileRange;
typedef lldb_private::RangeDataVector<lldb::addr_t, lldb::addr_t, FileRange>
VMRangeToFileOffset;
Modified: lldb/trunk/source/Plugins/Process/mach-core/ThreadMachCore.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/mach-core/ThreadMachCore.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/mach-core/ThreadMachCore.cpp (original)
+++ lldb/trunk/source/Plugins/Process/mach-core/ThreadMachCore.cpp Wed Apr 10 13:48:55 2019
@@ -28,9 +28,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// Thread Registers
-//----------------------------------------------------------------------
ThreadMachCore::ThreadMachCore(Process &process, lldb::tid_t tid)
: Thread(process, tid), m_thread_name(), m_dispatch_queue_name(),
Modified: lldb/trunk/source/Plugins/Process/mach-core/ThreadMachCore.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/mach-core/ThreadMachCore.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/mach-core/ThreadMachCore.h (original)
+++ lldb/trunk/source/Plugins/Process/mach-core/ThreadMachCore.h Wed Apr 10 13:48:55 2019
@@ -52,17 +52,13 @@ public:
protected:
friend class ProcessMachCore;
- //------------------------------------------------------------------
// Member variables.
- //------------------------------------------------------------------
std::string m_thread_name;
std::string m_dispatch_queue_name;
lldb::addr_t m_thread_dispatch_qaddr;
lldb::RegisterContextSP m_thread_reg_ctx_sp;
- //------------------------------------------------------------------
// Protected member functions.
- //------------------------------------------------------------------
bool CalculateStopInfo() override;
};
Modified: lldb/trunk/source/Plugins/ScriptInterpreter/None/ScriptInterpreterNone.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ScriptInterpreter/None/ScriptInterpreterNone.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ScriptInterpreter/None/ScriptInterpreterNone.h (original)
+++ lldb/trunk/source/Plugins/ScriptInterpreter/None/ScriptInterpreterNone.h Wed Apr 10 13:48:55 2019
@@ -25,9 +25,7 @@ public:
void ExecuteInterpreterLoop() override;
- //------------------------------------------------------------------
// Static Functions
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
@@ -39,9 +37,7 @@ public:
static const char *GetPluginDescriptionStatic();
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
lldb_private::ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp (original)
+++ lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp Wed Apr 10 13:48:55 2019
@@ -33,9 +33,7 @@ void StructuredPythonObject::Dump(Stream
s << "Python Obj: 0x" << GetValue();
}
-//----------------------------------------------------------------------
// PythonObject
-//----------------------------------------------------------------------
void PythonObject::Dump(Stream &strm) const {
if (m_py_obj) {
@@ -202,9 +200,7 @@ StructuredData::ObjectSP PythonObject::C
}
}
-//----------------------------------------------------------------------
// PythonString
-//----------------------------------------------------------------------
PythonBytes::PythonBytes() : PythonObject() {}
PythonBytes::PythonBytes(llvm::ArrayRef<uint8_t> bytes) : PythonObject() {
@@ -338,9 +334,7 @@ StructuredData::StringSP PythonByteArray
return result;
}
-//----------------------------------------------------------------------
// PythonString
-//----------------------------------------------------------------------
PythonString::PythonString(PyRefType type, PyObject *py_obj) : PythonObject() {
Reset(type, py_obj); // Use "Reset()" to ensure that py_obj is a string
@@ -438,9 +432,7 @@ StructuredData::StringSP PythonString::C
return result;
}
-//----------------------------------------------------------------------
// PythonInteger
-//----------------------------------------------------------------------
PythonInteger::PythonInteger() : PythonObject() {}
@@ -530,9 +522,7 @@ StructuredData::IntegerSP PythonInteger:
return result;
}
-//----------------------------------------------------------------------
// PythonBoolean
-//----------------------------------------------------------------------
PythonBoolean::PythonBoolean(PyRefType type, PyObject *py_obj)
: PythonObject() {
@@ -579,9 +569,7 @@ StructuredData::BooleanSP PythonBoolean:
return result;
}
-//----------------------------------------------------------------------
// PythonList
-//----------------------------------------------------------------------
PythonList::PythonList(PyInitialValue value) : PythonObject() {
if (value == PyInitialValue::Empty)
@@ -660,9 +648,7 @@ StructuredData::ArraySP PythonList::Crea
return result;
}
-//----------------------------------------------------------------------
// PythonTuple
-//----------------------------------------------------------------------
PythonTuple::PythonTuple(PyInitialValue value) : PythonObject() {
if (value == PyInitialValue::Empty)
@@ -756,9 +742,7 @@ StructuredData::ArraySP PythonTuple::Cre
return result;
}
-//----------------------------------------------------------------------
// PythonDictionary
-//----------------------------------------------------------------------
PythonDictionary::PythonDictionary(PyInitialValue value) : PythonObject() {
if (value == PyInitialValue::Empty)
Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h (original)
+++ lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h Wed Apr 10 13:48:55 2019
@@ -267,9 +267,7 @@ public:
m_command_thread_state = s;
}
- //----------------------------------------------------------------------
// IOHandlerDelegate
- //----------------------------------------------------------------------
void IOHandlerActivated(IOHandler &io_handler, bool interactive) override;
void IOHandlerInputComplete(IOHandler &io_handler,
@@ -278,9 +276,7 @@ public:
static lldb::ScriptInterpreterSP
CreateInstance(CommandInterpreter &interpreter);
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
lldb_private::ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
Modified: lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp (original)
+++ lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp Wed Apr 10 13:48:55 2019
@@ -39,9 +39,7 @@ using namespace lldb_private;
#pragma mark -
#pragma mark Anonymous Namespace
-// -----------------------------------------------------------------------------
// Anonymous namespace
-// -----------------------------------------------------------------------------
namespace sddarwinlog_private {
const uint64_t NANOS_PER_MICRO = 1000;
@@ -52,13 +50,11 @@ const uint64_t NANOS_PER_HOUR = NANOS_PE
static bool DEFAULT_FILTER_FALLTHROUGH_ACCEPTS = true;
-//------------------------------------------------------------------
/// Global, sticky enable switch. If true, the user has explicitly
/// run the enable command. When a process launches or is attached to,
/// we will enable DarwinLog if either the settings for auto-enable is
/// on, or if the user had explicitly run enable at some point prior
/// to the launch/attach.
-//------------------------------------------------------------------
static bool s_is_explicitly_enabled;
class EnableOptions;
@@ -106,9 +102,7 @@ void SetGlobalEnableOptions(const Debugg
#pragma mark -
#pragma mark Settings Handling
-//------------------------------------------------------------------
/// Code to handle the StructuredDataDarwinLog settings
-//------------------------------------------------------------------
static constexpr PropertyDefinition g_properties[] = {
{
@@ -391,12 +385,10 @@ static void RegisterFilterOperations() {
// Commands
// =========================================================================
-// -------------------------------------------------------------------------
/// Provides the main on-off switch for enabling darwin logging.
///
/// It is valid to run the enable command when logging is already enabled.
/// This resets the logging with whatever settings are currently set.
-// -------------------------------------------------------------------------
static constexpr OptionDefinition g_enable_option_table[] = {
// Source stream include/exclude options (the first-level filter). This one
@@ -890,9 +882,7 @@ private:
EnableOptionsSP m_options_sp;
};
-// -------------------------------------------------------------------------
/// Provides the status command.
-// -------------------------------------------------------------------------
class StatusCommand : public CommandObjectParsed {
public:
StatusCommand(CommandInterpreter &interpreter)
@@ -968,9 +958,7 @@ protected:
}
};
-// -------------------------------------------------------------------------
/// Provides the darwin-log base command
-// -------------------------------------------------------------------------
class BaseCommand : public CommandObjectMultiword {
public:
BaseCommand(CommandInterpreter &interpreter)
@@ -1082,9 +1070,7 @@ using namespace sddarwinlog_private;
#pragma mark -
#pragma mark Public static API
-// -----------------------------------------------------------------------------
// Public static API
-// -----------------------------------------------------------------------------
void StructuredDataDarwinLog::Initialize() {
RegisterFilterOperations();
@@ -1105,9 +1091,7 @@ ConstString StructuredDataDarwinLog::Get
#pragma mark -
#pragma mark PluginInterface API
-// -----------------------------------------------------------------------------
// PluginInterface API
-// -----------------------------------------------------------------------------
ConstString StructuredDataDarwinLog::GetPluginName() {
return GetStaticPluginName();
@@ -1118,9 +1102,7 @@ uint32_t StructuredDataDarwinLog::GetPlu
#pragma mark -
#pragma mark StructuredDataPlugin API
-// -----------------------------------------------------------------------------
// StructuredDataPlugin API
-// -----------------------------------------------------------------------------
bool StructuredDataDarwinLog::SupportsStructuredDataType(
ConstString type_name) {
@@ -1370,9 +1352,7 @@ void StructuredDataDarwinLog::ModulesDid
EnableNow();
}
-// -----------------------------------------------------------------------------
// public destructor
-// -----------------------------------------------------------------------------
StructuredDataDarwinLog::~StructuredDataDarwinLog() {
if (m_breakpoint_id != LLDB_INVALID_BREAK_ID) {
@@ -1387,9 +1367,7 @@ StructuredDataDarwinLog::~StructuredData
#pragma mark -
#pragma mark Private instance methods
-// -----------------------------------------------------------------------------
// Private constructors
-// -----------------------------------------------------------------------------
StructuredDataDarwinLog::StructuredDataDarwinLog(const ProcessWP &process_wp)
: StructuredDataPlugin(process_wp), m_recorded_first_timestamp(false),
@@ -1397,9 +1375,7 @@ StructuredDataDarwinLog::StructuredDataD
m_added_breakpoint_mutex(), m_added_breakpoint(),
m_breakpoint_id(LLDB_INVALID_BREAK_ID) {}
-// -----------------------------------------------------------------------------
// Private static methods
-// -----------------------------------------------------------------------------
StructuredDataPluginSP
StructuredDataDarwinLog::CreateInstance(Process &process) {
Modified: lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h (original)
+++ lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h Wed Apr 10 13:48:55 2019
@@ -24,9 +24,7 @@ class StructuredDataDarwinLog : public S
friend sddarwinlog_private::EnableCommand;
public:
- // -------------------------------------------------------------------------
// Public static API
- // -------------------------------------------------------------------------
static void Initialize();
@@ -34,7 +32,6 @@ public:
static ConstString GetStaticPluginName();
- // -------------------------------------------------------------------------
/// Return whether the DarwinLog functionality is enabled.
///
/// The DarwinLog functionality is enabled if the user expicitly enabled
@@ -45,20 +42,15 @@ public:
/// \return
/// True if DarwinLog support is/will be enabled for existing or
/// newly launched/attached processes.
- // -------------------------------------------------------------------------
static bool IsEnabled();
- // -------------------------------------------------------------------------
// PluginInterface API
- // -------------------------------------------------------------------------
ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
- // -------------------------------------------------------------------------
// StructuredDataPlugin API
- // -------------------------------------------------------------------------
bool SupportsStructuredDataType(ConstString type_name) override;
@@ -76,15 +68,11 @@ public:
~StructuredDataDarwinLog();
private:
- // -------------------------------------------------------------------------
// Private constructors
- // -------------------------------------------------------------------------
StructuredDataDarwinLog(const lldb::ProcessWP &process_wp);
- // -------------------------------------------------------------------------
// Private static methods
- // -------------------------------------------------------------------------
static lldb::StructuredDataPluginSP CreateInstance(Process &process);
@@ -98,16 +86,12 @@ private:
static Status FilterLaunchInfo(ProcessLaunchInfo &launch_info,
Target *target);
- // -------------------------------------------------------------------------
// Internal helper methods used by friend classes
- // -------------------------------------------------------------------------
void SetEnabled(bool enabled);
void AddInitCompletionHook(Process &process);
- // -------------------------------------------------------------------------
// Private methods
- // -------------------------------------------------------------------------
void DumpTimestamp(Stream &stream, uint64_t timestamp);
@@ -116,16 +100,12 @@ private:
size_t HandleDisplayOfEvent(const StructuredData::Dictionary &event,
Stream &stream);
- // -------------------------------------------------------------------------
/// Call the enable command again, using whatever settings were initially
/// made.
- // -------------------------------------------------------------------------
void EnableNow();
- // -------------------------------------------------------------------------
// Private data
- // -------------------------------------------------------------------------
bool m_recorded_first_timestamp;
uint64_t m_first_timestamp_seen;
bool m_is_enabled;
Modified: lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h Wed Apr 10 13:48:55 2019
@@ -20,9 +20,7 @@ namespace breakpad {
class SymbolFileBreakpad : public SymbolFile {
public:
- //------------------------------------------------------------------
// Static Functions
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
static void DebuggerInitialize(Debugger &debugger) {}
@@ -36,9 +34,7 @@ public:
return new SymbolFileBreakpad(obj_file);
}
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
SymbolFileBreakpad(ObjectFile *object_file) : SymbolFile(object_file) {}
~SymbolFileBreakpad() override {}
@@ -47,9 +43,7 @@ public:
void InitializeObject() override {}
- //------------------------------------------------------------------
// Compile Unit function calls
- //------------------------------------------------------------------
uint32_t GetNumCompileUnits() override;
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DIERef.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DIERef.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DIERef.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DIERef.cpp Wed Apr 10 13:48:55 2019
@@ -51,14 +51,12 @@ DIERef::DIERef(const DWARFFormValue &for
}
lldb::user_id_t DIERef::GetUID(SymbolFileDWARF *dwarf) const {
- //----------------------------------------------------------------------
// Each SymbolFileDWARF will set its ID to what is expected.
//
// SymbolFileDWARF, when used for DWARF with .o files on MacOSX, has the
// ID set to the compile unit index.
//
// SymbolFileDWARFDwo sets the ID to the compile unit offset.
- //----------------------------------------------------------------------
if (dwarf && die_offset != DW_INVALID_OFFSET)
return dwarf->GetID() | die_offset;
else
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DIERef.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DIERef.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DIERef.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DIERef.h Wed Apr 10 13:48:55 2019
@@ -20,22 +20,18 @@ struct DIERef {
DIERef(dw_offset_t c, dw_offset_t d) : cu_offset(c), die_offset(d) {}
- //----------------------------------------------------------------------
// In order to properly decode a lldb::user_id_t back into a DIERef we
// need the DWARF file since it knows if DWARF in .o files is being used
// (MacOSX) or if DWO files are being used. The encoding of the user ID
// differs between the two types of DWARF.
- //----------------------------------------------------------------------
explicit DIERef(lldb::user_id_t uid, SymbolFileDWARF *dwarf);
explicit DIERef(const DWARFFormValue &form_value);
- //----------------------------------------------------------------------
// In order to properly encode a DIERef unto a lldb::user_id_t we need
// the DWARF file since it knows if DWARF in .o files is being used
// (MacOSX) or if DWO files are being used. The encoding of the user ID
// differs between the two types of DWARF.
- //----------------------------------------------------------------------
lldb::user_id_t GetUID(SymbolFileDWARF *dwarf) const;
bool operator<(const DIERef &ref) const {
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Wed Apr 10 13:48:55 2019
@@ -2115,7 +2115,6 @@ bool DWARFASTParserClang::CompleteTypeFr
return false;
#if defined LLDB_CONFIGURATION_DEBUG
- //----------------------------------------------------------------------
// For debugging purposes, the LLDB_DWARF_DONT_COMPLETE_TYPENAMES environment
// variable can be set with one or more typenames separated by ';'
// characters. This will cause this function to not complete any types whose
@@ -2125,7 +2124,6 @@ bool DWARFASTParserClang::CompleteTypeFr
//
// LLDB_DWARF_DONT_COMPLETE_TYPENAMES=Foo
// LLDB_DWARF_DONT_COMPLETE_TYPENAMES=Foo;Bar;Baz
- //----------------------------------------------------------------------
const char *dont_complete_typenames_cstr =
getenv("LLDB_DWARF_DONT_COMPLETE_TYPENAMES");
if (dont_complete_typenames_cstr && dont_complete_typenames_cstr[0]) {
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h Wed Apr 10 13:48:55 2019
@@ -128,10 +128,8 @@ protected:
lldb::TypeSP ParseTypeFromDWO(const DWARFDIE &die, lldb_private::Log *log);
- //----------------------------------------------------------------------
// Return true if this type is a declaration to a type in an external
// module.
- //----------------------------------------------------------------------
lldb::ModuleSP GetModuleForType(const DWARFDIE &die);
typedef llvm::SmallPtrSet<const DWARFDebugInfoEntry *, 4> DIEPointerSet;
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h Wed Apr 10 13:48:55 2019
@@ -37,9 +37,7 @@ public:
: m_cu(const_cast<DWARFUnit *>(cu)),
m_die(const_cast<DWARFDebugInfoEntry *>(die)) {}
- //----------------------------------------------------------------------
// Tests
- //----------------------------------------------------------------------
explicit operator bool() const { return IsValid(); }
bool IsValid() const { return m_cu && m_die; }
@@ -48,9 +46,7 @@ public:
bool Supports_DW_AT_APPLE_objc_complete_type() const;
- //----------------------------------------------------------------------
// Accessors
- //----------------------------------------------------------------------
SymbolFileDWARF *GetDWARF() const;
DWARFUnit *GetCU() const { return m_cu; }
@@ -77,31 +73,25 @@ public:
m_die = nullptr;
}
- //----------------------------------------------------------------------
// Get the data that contains the attribute values for this DIE. Support
// for .debug_types means that any DIE can have its data either in the
// .debug_info or the .debug_types section; this method will return the
// correct section data.
//
// Clients must validate that this object is valid before calling this.
- //----------------------------------------------------------------------
const lldb_private::DWARFDataExtractor &GetData() const;
- //----------------------------------------------------------------------
// Accessing information about a DIE
- //----------------------------------------------------------------------
dw_tag_t Tag() const;
const char *GetTagAsCString() const;
dw_offset_t GetOffset() const;
- //----------------------------------------------------------------------
// Get the LLDB user ID for this DIE. This is often just the DIE offset,
// but it might have a SymbolFileDWARF::GetID() in the high 32 bits if
// we are doing Darwin DWARF in .o file, or DWARF stand alone debug
// info.
- //----------------------------------------------------------------------
lldb::user_id_t GetID() const;
const char *GetName() const;
@@ -112,13 +102,11 @@ public:
lldb_private::CompileUnit *GetLLDBCompileUnit() const;
- //----------------------------------------------------------------------
// Getting attribute values from the DIE.
//
// GetAttributeValueAsXXX() functions should only be used if you are
// looking for one or two attributes on a DIE. If you are trying to
// parse all attributes, use GetAttributes (...) instead
- //----------------------------------------------------------------------
const char *GetAttributeValueAsString(const dw_attr_t attr,
const char *fail_value) const;
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h Wed Apr 10 13:48:55 2019
@@ -20,22 +20,18 @@ public:
lldb::offset_t *offset_ptr);
void Dump(lldb_private::Stream *s) const override;
- //------------------------------------------------------------------
/// Get the data that contains the DIE information for this unit.
///
/// \return
/// The correct data (.debug_types for DWARF 4 and earlier, and
/// .debug_info for DWARF 5 and later) for the DIE information in
/// this unit.
- //------------------------------------------------------------------
const lldb_private::DWARFDataExtractor &GetData() const override;
- //------------------------------------------------------------------
/// Get the size in bytes of the header.
///
/// \return
/// Byte size of the compile unit header
- //------------------------------------------------------------------
uint32_t GetHeaderByteSize() const override;
private:
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.h Wed Apr 10 13:48:55 2019
@@ -16,24 +16,18 @@ class DWARFDIE : public DWARFBaseDIE {
public:
using DWARFBaseDIE::DWARFBaseDIE;
- //----------------------------------------------------------------------
// Tests
- //----------------------------------------------------------------------
bool IsStructUnionOrClass() const;
bool IsMethod() const;
- //----------------------------------------------------------------------
// Accessors
- //----------------------------------------------------------------------
lldb::ModuleSP GetContainingDWOModule() const;
DWARFDIE
GetContainingDWOModuleDIE() const;
- //----------------------------------------------------------------------
// Accessing information about a DIE
- //----------------------------------------------------------------------
const char *GetMangledName() const;
const char *GetPubname() const;
@@ -42,14 +36,10 @@ public:
lldb_private::Type *ResolveType() const;
- //----------------------------------------------------------------------
// Resolve a type by UID using this DIE's DWARF file
- //----------------------------------------------------------------------
lldb_private::Type *ResolveTypeUID(const DIERef &die_ref) const;
- //----------------------------------------------------------------------
// Functions for obtaining DIE relations and references
- //----------------------------------------------------------------------
DWARFDIE
GetParent() const;
@@ -63,11 +53,9 @@ public:
DWARFDIE
GetReferencedDIE(const dw_attr_t attr) const;
- //----------------------------------------------------------------------
// Get a another DIE from the same DWARF file as this DIE. This will
// check the current DIE's compile unit first to see if "die_offset" is
// in the same compile unit, and fall back to checking the DWARF file.
- //----------------------------------------------------------------------
DWARFDIE
GetDIE(dw_offset_t die_offset) const;
using DWARFBaseDIE::GetDIE;
@@ -78,9 +66,7 @@ public:
DWARFDIE
GetParentDeclContextDIE() const;
- //----------------------------------------------------------------------
// DeclContext related functions
- //----------------------------------------------------------------------
std::vector<DWARFDIE> GetDeclContextDIEs() const;
void GetDWARFDeclContext(DWARFDeclContext &dwarf_decl_ctx) const;
@@ -90,13 +76,11 @@ public:
void
GetDeclContext(std::vector<lldb_private::CompilerContext> &context) const;
- //----------------------------------------------------------------------
// Getting attribute values from the DIE.
//
// GetAttributeValueAsXXX() functions should only be used if you are
// looking for one or two attributes on a DIE. If you are trying to
// parse all attributes, use GetAttributes (...) instead
- //----------------------------------------------------------------------
DWARFDIE
GetAttributeValueAsReferenceDIE(const dw_attr_t attr) const;
@@ -106,9 +90,7 @@ public:
int &call_line, int &call_column,
lldb_private::DWARFExpression *frame_base) const;
- //----------------------------------------------------------------------
// CompilerDecl related functions
- //----------------------------------------------------------------------
lldb_private::CompilerDecl GetDecl() const;
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp Wed Apr 10 13:48:55 2019
@@ -14,17 +14,13 @@ using namespace lldb;
using namespace lldb_private;
using namespace std;
-//----------------------------------------------------------------------
// DWARFAbbreviationDeclarationSet::Clear()
-//----------------------------------------------------------------------
void DWARFAbbreviationDeclarationSet::Clear() {
m_idx_offset = 0;
m_decls.clear();
}
-//----------------------------------------------------------------------
// DWARFAbbreviationDeclarationSet::Extract()
-//----------------------------------------------------------------------
llvm::Error
DWARFAbbreviationDeclarationSet::extract(const DWARFDataExtractor &data,
lldb::offset_t *offset_ptr) {
@@ -54,9 +50,7 @@ DWARFAbbreviationDeclarationSet::extract
return llvm::ErrorSuccess();
}
-//----------------------------------------------------------------------
// DWARFAbbreviationDeclarationSet::GetAbbreviationDeclaration()
-//----------------------------------------------------------------------
const DWARFAbbreviationDeclaration *
DWARFAbbreviationDeclarationSet::GetAbbreviationDeclaration(
dw_uleb128_t abbrCode) const {
@@ -76,9 +70,7 @@ DWARFAbbreviationDeclarationSet::GetAbbr
}
-//----------------------------------------------------------------------
// DWARFAbbreviationDeclarationSet::GetUnsupportedForms()
-//----------------------------------------------------------------------
void DWARFAbbreviationDeclarationSet::GetUnsupportedForms(
std::set<dw_form_t> &invalid_forms) const {
for (const auto &abbr_decl : m_decls) {
@@ -91,13 +83,11 @@ void DWARFAbbreviationDeclarationSet::Ge
}
}
-//----------------------------------------------------------------------
// Encode
//
// Encode the abbreviation table onto the end of the buffer provided into a
// byte representation as would be found in a ".debug_abbrev" debug information
// section.
-//----------------------------------------------------------------------
// void
// DWARFAbbreviationDeclarationSet::Encode(BinaryStreamBuf& debug_abbrev_buf)
// const
@@ -109,15 +99,11 @@ void DWARFAbbreviationDeclarationSet::Ge
// debug_abbrev_buf.Append8(0);
//}
-//----------------------------------------------------------------------
// DWARFDebugAbbrev constructor
-//----------------------------------------------------------------------
DWARFDebugAbbrev::DWARFDebugAbbrev()
: m_abbrevCollMap(), m_prev_abbr_offset_pos(m_abbrevCollMap.end()) {}
-//----------------------------------------------------------------------
// DWARFDebugAbbrev::Parse()
-//----------------------------------------------------------------------
llvm::Error DWARFDebugAbbrev::parse(const DWARFDataExtractor &data) {
lldb::offset_t offset = 0;
@@ -135,9 +121,7 @@ llvm::Error DWARFDebugAbbrev::parse(cons
return llvm::ErrorSuccess();
}
-//----------------------------------------------------------------------
// DWARFDebugAbbrev::GetAbbreviationDeclarationSet()
-//----------------------------------------------------------------------
const DWARFAbbreviationDeclarationSet *
DWARFDebugAbbrev::GetAbbreviationDeclarationSet(
dw_offset_t cu_abbr_offset) const {
@@ -156,9 +140,7 @@ DWARFDebugAbbrev::GetAbbreviationDeclara
return NULL;
}
-//----------------------------------------------------------------------
// DWARFDebugAbbrev::GetUnsupportedForms()
-//----------------------------------------------------------------------
void DWARFDebugAbbrev::GetUnsupportedForms(
std::set<dw_form_t> &invalid_forms) const {
for (const auto &pair : m_abbrevCollMap)
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp Wed Apr 10 13:48:55 2019
@@ -24,14 +24,10 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// Constructor
-//----------------------------------------------------------------------
DWARFDebugAranges::DWARFDebugAranges() : m_aranges() {}
-//----------------------------------------------------------------------
// CountArangeDescriptors
-//----------------------------------------------------------------------
class CountArangeDescriptors {
public:
CountArangeDescriptors(uint32_t &count_ref) : count(count_ref) {
@@ -43,9 +39,7 @@ public:
uint32_t &count;
};
-//----------------------------------------------------------------------
// Extract
-//----------------------------------------------------------------------
llvm::Error
DWARFDebugAranges::extract(const DWARFDataExtractor &debug_aranges_data) {
assert(debug_aranges_data.ValidOffset(0));
@@ -103,9 +97,7 @@ void DWARFDebugAranges::Sort(bool minimi
m_aranges.CombineConsecutiveEntriesWithEqualData();
}
-//----------------------------------------------------------------------
// FindAddress
-//----------------------------------------------------------------------
dw_offset_t DWARFDebugAranges::FindAddress(dw_addr_t address) const {
const RangeToDIE::Entry *entry = m_aranges.FindEntryThatContains(address);
if (entry)
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp Wed Apr 10 13:48:55 2019
@@ -27,16 +27,12 @@ using namespace lldb;
using namespace lldb_private;
using namespace std;
-//----------------------------------------------------------------------
// Constructor
-//----------------------------------------------------------------------
DWARFDebugInfo::DWARFDebugInfo(lldb_private::DWARFContext &context)
: m_dwarf2Data(NULL), m_context(context), m_compile_units(),
m_cu_aranges_up() {}
-//----------------------------------------------------------------------
// SetDwarfData
-//----------------------------------------------------------------------
void DWARFDebugInfo::SetDwarfData(SymbolFileDWARF *dwarf2Data) {
m_dwarf2Data = dwarf2Data;
m_compile_units.clear();
@@ -201,11 +197,9 @@ DWARFDebugInfo::GetDIEForDIEOffset(dw_of
return DWARFDIE();
}
-//----------------------------------------------------------------------
// GetDIE()
//
// Get the DIE (Debug Information Entry) with the specified offset.
-//----------------------------------------------------------------------
DWARFDIE
DWARFDebugInfo::GetDIE(const DIERef &die_ref) {
DWARFUnit *cu = GetCompileUnit(die_ref);
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h Wed Apr 10 13:48:55 2019
@@ -62,9 +62,7 @@ protected:
typedef std::vector<DWARFUnitSP> CompileUnitColl;
- //----------------------------------------------------------------------
// Member variables
- //----------------------------------------------------------------------
SymbolFileDWARF *m_dwarf2Data;
lldb_private::DWARFContext &m_context;
CompileUnitColl m_compile_units;
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp Wed Apr 10 13:48:55 2019
@@ -199,13 +199,11 @@ bool DWARFDebugInfoEntry::FastExtract(
return false;
}
-//----------------------------------------------------------------------
// Extract
//
// Extract a debug info entry for a given compile unit from the .debug_info and
// .debug_abbrev data within the SymbolFileDWARF class starting at the given
// offset
-//----------------------------------------------------------------------
bool DWARFDebugInfoEntry::Extract(const DWARFUnit *cu,
lldb::offset_t *offset_ptr) {
const DWARFDataExtractor &debug_info_data = cu->GetData();
@@ -370,12 +368,10 @@ static dw_offset_t GetRangesOffset(const
return form_value.Unsigned();
}
-//----------------------------------------------------------------------
// GetDIENamesAndRanges
//
// Gets the valid address ranges for a given DIE by looking for a
// DW_AT_low_pc/DW_AT_high_pc pair, DW_AT_entry_pc, or DW_AT_ranges attributes.
-//----------------------------------------------------------------------
bool DWARFDebugInfoEntry::GetDIENamesAndRanges(
SymbolFileDWARF *dwarf2Data, const DWARFUnit *cu, const char *&name,
const char *&mangled, DWARFRangeList &ranges, int &decl_file,
@@ -572,12 +568,10 @@ bool DWARFDebugInfoEntry::GetDIENamesAnd
return !ranges.IsEmpty();
}
-//----------------------------------------------------------------------
// Dump
//
// Dumps a debug information entry and all of it's attributes to the specified
// stream.
-//----------------------------------------------------------------------
void DWARFDebugInfoEntry::Dump(SymbolFileDWARF *dwarf2Data,
const DWARFUnit *cu, Stream &s,
uint32_t recurse_depth) const {
@@ -630,13 +624,11 @@ void DWARFDebugInfoEntry::Dump(SymbolFil
}
}
-//----------------------------------------------------------------------
// DumpAttribute
//
// Dumps a debug information entry attribute along with it's form. Any special
// display of attributes is done (disassemble location lists, show enumeration
// values for attributes, etc).
-//----------------------------------------------------------------------
void DWARFDebugInfoEntry::DumpAttribute(
SymbolFileDWARF *dwarf2Data, const DWARFUnit *cu,
const DWARFDataExtractor &debug_info_data, lldb::offset_t *offset_ptr,
@@ -731,12 +723,10 @@ void DWARFDebugInfoEntry::DumpAttribute(
s.PutCString(" )\n");
}
-//----------------------------------------------------------------------
// Get all attribute values for a given DIE, including following any
// specification or abstract origin attributes and including those in the
// results. Any duplicate attributes will have the first instance take
// precedence (this can happen for declaration attributes).
-//----------------------------------------------------------------------
size_t DWARFDebugInfoEntry::GetAttributes(
const DWARFUnit *cu, DWARFFormValue::FixedFormSizes fixed_form_sizes,
DWARFAttributes &attributes, uint32_t curr_depth) const {
@@ -809,14 +799,12 @@ size_t DWARFDebugInfoEntry::GetAttribute
return attributes.Size();
}
-//----------------------------------------------------------------------
// GetAttributeValue
//
// Get the value of an attribute and return the .debug_info offset of the
// attribute if it was properly extracted into form_value, or zero if we fail
// since an offset of zero is invalid for an attribute (it would be a compile
// unit header).
-//----------------------------------------------------------------------
dw_offset_t DWARFDebugInfoEntry::GetAttributeValue(
SymbolFileDWARF *dwarf2Data, const DWARFUnit *cu,
const dw_attr_t attr, DWARFFormValue &form_value,
@@ -897,14 +885,12 @@ dw_offset_t DWARFDebugInfoEntry::GetAttr
check_specification_or_abstract_origin);
}
-//----------------------------------------------------------------------
// GetAttributeValueAsString
//
// Get the value of an attribute as a string return it. The resulting pointer
// to the string data exists within the supplied SymbolFileDWARF and will only
// be available as long as the SymbolFileDWARF is still around and it's content
// doesn't change.
-//----------------------------------------------------------------------
const char *DWARFDebugInfoEntry::GetAttributeValueAsString(
SymbolFileDWARF *dwarf2Data, const DWARFUnit *cu,
const dw_attr_t attr, const char *fail_value,
@@ -916,11 +902,9 @@ const char *DWARFDebugInfoEntry::GetAttr
return fail_value;
}
-//----------------------------------------------------------------------
// GetAttributeValueAsUnsigned
//
// Get the value of an attribute as unsigned and return it.
-//----------------------------------------------------------------------
uint64_t DWARFDebugInfoEntry::GetAttributeValueAsUnsigned(
SymbolFileDWARF *dwarf2Data, const DWARFUnit *cu,
const dw_attr_t attr, uint64_t fail_value,
@@ -932,12 +916,10 @@ uint64_t DWARFDebugInfoEntry::GetAttribu
return fail_value;
}
-//----------------------------------------------------------------------
// GetAttributeValueAsReference
//
// Get the value of an attribute as reference and fix up and compile unit
// relative offsets as needed.
-//----------------------------------------------------------------------
uint64_t DWARFDebugInfoEntry::GetAttributeValueAsReference(
SymbolFileDWARF *dwarf2Data, const DWARFUnit *cu,
const dw_attr_t attr, uint64_t fail_value,
@@ -960,14 +942,12 @@ uint64_t DWARFDebugInfoEntry::GetAttribu
return fail_value;
}
-//----------------------------------------------------------------------
// GetAttributeHighPC
//
// Get the hi_pc, adding hi_pc to lo_pc when specified as an <offset-from-low-
// pc>.
//
// Returns the hi_pc or fail_value.
-//----------------------------------------------------------------------
dw_addr_t DWARFDebugInfoEntry::GetAttributeHighPC(
SymbolFileDWARF *dwarf2Data, const DWARFUnit *cu, dw_addr_t lo_pc,
uint64_t fail_value, bool check_specification_or_abstract_origin) const {
@@ -985,14 +965,12 @@ dw_addr_t DWARFDebugInfoEntry::GetAttrib
return fail_value;
}
-//----------------------------------------------------------------------
// GetAttributeAddressRange
//
// Get the lo_pc and hi_pc, adding hi_pc to lo_pc when specified as an <offset-
// from-low-pc>.
//
// Returns true or sets lo_pc and hi_pc to fail_value.
-//----------------------------------------------------------------------
bool DWARFDebugInfoEntry::GetAttributeAddressRange(
SymbolFileDWARF *dwarf2Data, const DWARFUnit *cu, dw_addr_t &lo_pc,
dw_addr_t &hi_pc, uint64_t fail_value,
@@ -1034,23 +1012,19 @@ size_t DWARFDebugInfoEntry::GetAttribute
return ranges.GetSize();
}
-//----------------------------------------------------------------------
// GetName
//
// Get value of the DW_AT_name attribute and return it if one exists, else
// return NULL.
-//----------------------------------------------------------------------
const char *DWARFDebugInfoEntry::GetName(SymbolFileDWARF *dwarf2Data,
const DWARFUnit *cu) const {
return GetAttributeValueAsString(dwarf2Data, cu, DW_AT_name, nullptr, true);
}
-//----------------------------------------------------------------------
// GetMangledName
//
// Get value of the DW_AT_MIPS_linkage_name attribute and return it if one
// exists, else return the value of the DW_AT_name attribute
-//----------------------------------------------------------------------
const char *
DWARFDebugInfoEntry::GetMangledName(SymbolFileDWARF *dwarf2Data,
const DWARFUnit *cu,
@@ -1074,12 +1048,10 @@ DWARFDebugInfoEntry::GetMangledName(Symb
return name;
}
-//----------------------------------------------------------------------
// GetPubname
//
// Get value the name for a DIE as it should appear for a .debug_pubnames or
// .debug_pubtypes section.
-//----------------------------------------------------------------------
const char *DWARFDebugInfoEntry::GetPubname(SymbolFileDWARF *dwarf2Data,
const DWARFUnit *cu) const {
const char *name = nullptr;
@@ -1100,14 +1072,12 @@ const char *DWARFDebugInfoEntry::GetPubn
return name;
}
-//----------------------------------------------------------------------
// GetName
//
// Get value of the DW_AT_name attribute for a debug information entry that
// exists at offset "die_offset" and place that value into the supplied stream
// object. If the DIE is a NULL object "NULL" is placed into the stream, and if
// no DW_AT_name attribute exists for the DIE then nothing is printed.
-//----------------------------------------------------------------------
bool DWARFDebugInfoEntry::GetName(SymbolFileDWARF *dwarf2Data,
const DWARFUnit *cu,
const dw_offset_t die_offset, Stream &s) {
@@ -1134,13 +1104,11 @@ bool DWARFDebugInfoEntry::GetName(Symbol
return false;
}
-//----------------------------------------------------------------------
// AppendTypeName
//
// Follows the type name definition down through all needed tags to end up with
// a fully qualified type name and dump the results to the supplied stream.
// This is used to show the name of types given a type identifier.
-//----------------------------------------------------------------------
bool DWARFDebugInfoEntry::AppendTypeName(SymbolFileDWARF *dwarf2Data,
const DWARFUnit *cu,
const dw_offset_t die_offset,
@@ -1266,9 +1234,7 @@ bool DWARFDebugInfoEntry::AppendTypeName
return false;
}
-//----------------------------------------------------------------------
// BuildAddressRangeTable
-//----------------------------------------------------------------------
void DWARFDebugInfoEntry::BuildAddressRangeTable(
SymbolFileDWARF *dwarf2Data, const DWARFUnit *cu,
DWARFDebugAranges *debug_aranges) const {
@@ -1292,14 +1258,12 @@ void DWARFDebugInfoEntry::BuildAddressRa
}
}
-//----------------------------------------------------------------------
// BuildFunctionAddressRangeTable
//
// This function is very similar to the BuildAddressRangeTable function except
// that the actual DIE offset for the function is placed in the table instead
// of the compile unit offset (which is the way the standard .debug_aranges
// section does it).
-//----------------------------------------------------------------------
void DWARFDebugInfoEntry::BuildFunctionAddressRangeTable(
SymbolFileDWARF *dwarf2Data, const DWARFUnit *cu,
DWARFDebugAranges *debug_aranges) const {
@@ -1478,9 +1442,7 @@ const char *DWARFDebugInfoEntry::GetQual
return storage.c_str();
}
-//----------------------------------------------------------------------
// LookupAddress
-//----------------------------------------------------------------------
bool DWARFDebugInfoEntry::LookupAddress(const dw_addr_t address,
SymbolFileDWARF *dwarf2Data,
const DWARFUnit *cu,
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp Wed Apr 10 13:48:55 2019
@@ -27,12 +27,10 @@ using namespace lldb;
using namespace lldb_private;
using namespace std;
-//----------------------------------------------------------------------
// Parse
//
// Parse all information in the debug_line_data into an internal
// representation.
-//----------------------------------------------------------------------
void DWARFDebugLine::Parse(const DWARFDataExtractor &debug_line_data) {
m_lineTableMap.clear();
lldb::offset_t offset = 0;
@@ -61,9 +59,7 @@ void DWARFDebugLine::ParseIfNeeded(const
Parse(debug_line_data);
}
-//----------------------------------------------------------------------
// DWARFDebugLine::GetLineTable
-//----------------------------------------------------------------------
DWARFDebugLine::LineTable::shared_ptr
DWARFDebugLine::GetLineTable(const dw_offset_t offset) const {
DWARFDebugLine::LineTable::shared_ptr line_table_shared_ptr;
@@ -73,13 +69,11 @@ DWARFDebugLine::GetLineTable(const dw_of
return line_table_shared_ptr;
}
-//----------------------------------------------------------------------
// Parse
//
// Parse the entire line table contents calling callback each time a new
// prologue is parsed and every time a new row is to be added to the line
// table.
-//----------------------------------------------------------------------
void DWARFDebugLine::Parse(const DWARFDataExtractor &debug_line_data,
DWARFDebugLine::State::Callback callback,
void *userData) {
@@ -111,9 +105,7 @@ ReadDescriptors(const DWARFDataExtractor
}
} // namespace
-//----------------------------------------------------------------------
// DWARFDebugLine::ParsePrologue
-//----------------------------------------------------------------------
bool DWARFDebugLine::ParsePrologue(const DWARFDataExtractor &debug_line_data,
lldb::offset_t *offset_ptr,
Prologue *prologue, DWARFUnit *dwarf_cu) {
@@ -273,13 +265,11 @@ bool DWARFDebugLine::ParseSupportFiles(
return true;
}
-//----------------------------------------------------------------------
// ParseStatementTable
//
// Parse a single line table (prologue and all rows) and call the callback
// function once for the prologue (row in state will be zero) and each time a
// row is to be added to the line table.
-//----------------------------------------------------------------------
bool DWARFDebugLine::ParseStatementTable(
const DWARFDataExtractor &debug_line_data, lldb::offset_t *offset_ptr,
DWARFDebugLine::State::Callback callback, void *userData, DWARFUnit *dwarf_cu) {
@@ -552,9 +542,7 @@ bool DWARFDebugLine::ParseStatementTable
return end_offset;
}
-//----------------------------------------------------------------------
// ParseStatementTableCallback
-//----------------------------------------------------------------------
static void ParseStatementTableCallback(dw_offset_t offset,
const DWARFDebugLine::State &state,
void *userData) {
@@ -571,12 +559,10 @@ static void ParseStatementTableCallback(
}
}
-//----------------------------------------------------------------------
// ParseStatementTable
//
// Parse a line table at offset and populate the LineTable class with the
// prologue and all rows.
-//----------------------------------------------------------------------
bool DWARFDebugLine::ParseStatementTable(
const DWARFDataExtractor &debug_line_data, lldb::offset_t *offset_ptr,
LineTable *line_table, DWARFUnit *dwarf_cu) {
@@ -588,9 +574,7 @@ inline bool DWARFDebugLine::Prologue::Is
return SymbolFileDWARF::SupportedVersion(version);
}
-//----------------------------------------------------------------------
// DWARFDebugLine::Prologue::Dump
-//----------------------------------------------------------------------
void DWARFDebugLine::Prologue::Dump(Log *log) {
uint32_t i;
@@ -629,11 +613,9 @@ void DWARFDebugLine::Prologue::Dump(Log
}
}
-//----------------------------------------------------------------------
// DWARFDebugLine::ParsePrologue::Append
//
// Append the contents of the prologue to the binary stream buffer
-//----------------------------------------------------------------------
// void
// DWARFDebugLine::Prologue::Append(BinaryStreamBuf& buff) const
//{
@@ -695,18 +677,14 @@ void DWARFDebugLine::LineTable::AppendRo
rows.push_back(state);
}
-//----------------------------------------------------------------------
// Compare function for the binary search in
// DWARFDebugLine::LineTable::LookupAddress()
-//----------------------------------------------------------------------
static bool FindMatchingAddress(const DWARFDebugLine::Row &row1,
const DWARFDebugLine::Row &row2) {
return row1.address < row2.address;
}
-//----------------------------------------------------------------------
// DWARFDebugLine::LineTable::LookupAddress
-//----------------------------------------------------------------------
uint32_t DWARFDebugLine::LineTable::LookupAddress(dw_addr_t address,
dw_addr_t cu_high_pc) const {
uint32_t index = UINT32_MAX;
@@ -739,26 +717,20 @@ uint32_t DWARFDebugLine::LineTable::Look
return index; // Failed to find address
}
-//----------------------------------------------------------------------
// DWARFDebugLine::Row::Row
-//----------------------------------------------------------------------
DWARFDebugLine::Row::Row(bool default_is_stmt)
: address(0), line(1), column(0), file(1), is_stmt(default_is_stmt),
basic_block(false), end_sequence(false), prologue_end(false),
epilogue_begin(false), isa(0) {}
-//----------------------------------------------------------------------
// Called after a row is appended to the matrix
-//----------------------------------------------------------------------
void DWARFDebugLine::Row::PostAppend() {
basic_block = false;
prologue_end = false;
epilogue_begin = false;
}
-//----------------------------------------------------------------------
// DWARFDebugLine::Row::Reset
-//----------------------------------------------------------------------
void DWARFDebugLine::Row::Reset(bool default_is_stmt) {
address = 0;
line = 1;
@@ -771,9 +743,7 @@ void DWARFDebugLine::Row::Reset(bool def
epilogue_begin = false;
isa = 0;
}
-//----------------------------------------------------------------------
// DWARFDebugLine::Row::Dump
-//----------------------------------------------------------------------
void DWARFDebugLine::Row::Dump(Log *log) const {
log->Printf("0x%16.16" PRIx64 " %6u %6u %6u %3u %s%s%s%s%s", address, line,
column, file, isa, is_stmt ? " is_stmt" : "",
@@ -783,9 +753,7 @@ void DWARFDebugLine::Row::Dump(Log *log)
end_sequence ? " end_sequence" : "");
}
-//----------------------------------------------------------------------
// Compare function LineTable structures
-//----------------------------------------------------------------------
static bool AddressLessThan(const DWARFDebugLine::Row &a,
const DWARFDebugLine::Row &b) {
return a.address < b.address;
@@ -825,9 +793,7 @@ void DWARFDebugLine::Row::Insert(Row::co
}
}
-//----------------------------------------------------------------------
// DWARFDebugLine::State::State
-//----------------------------------------------------------------------
DWARFDebugLine::State::State(Prologue::shared_ptr &p, Log *l,
DWARFDebugLine::State::Callback cb, void *userData)
: Row(p->default_is_stmt), prologue(p), log(l), callback(cb),
@@ -837,14 +803,10 @@ DWARFDebugLine::State::State(Prologue::s
callback(0, *this, callbackUserData);
}
-//----------------------------------------------------------------------
// DWARFDebugLine::State::Reset
-//----------------------------------------------------------------------
void DWARFDebugLine::State::Reset() { Row::Reset(prologue->default_is_stmt); }
-//----------------------------------------------------------------------
// DWARFDebugLine::State::AppendRowToMatrix
-//----------------------------------------------------------------------
void DWARFDebugLine::State::AppendRowToMatrix(dw_offset_t offset) {
// Each time we are to add an entry into the line table matrix call the
// callback function so that someone can do something with the current state
@@ -864,9 +826,7 @@ void DWARFDebugLine::State::AppendRowToM
PostAppend();
}
-//----------------------------------------------------------------------
// DWARFDebugLine::State::Finalize
-//----------------------------------------------------------------------
void DWARFDebugLine::State::Finalize(dw_offset_t offset) {
// Call the callback with a special row state when we are done parsing a line
// table
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugLine.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugLine.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugLine.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugLine.h Wed Apr 10 13:48:55 2019
@@ -24,14 +24,10 @@
class DWARFUnit;
class SymbolFileDWARF;
-//----------------------------------------------------------------------
// DWARFDebugLine
-//----------------------------------------------------------------------
class DWARFDebugLine {
public:
- //------------------------------------------------------------------
// FileNameEntry
- //------------------------------------------------------------------
struct FileNameEntry {
FileNameEntry() : name(nullptr), dir_idx(0), mod_time(0), length(0) {}
@@ -42,9 +38,7 @@ public:
llvm::MD5::MD5Result checksum;
};
- //------------------------------------------------------------------
// Prologue
- //------------------------------------------------------------------
struct Prologue {
Prologue()
@@ -145,9 +139,7 @@ public:
// instruction set architecture for the current instruction.
};
- //------------------------------------------------------------------
// LineTable
- //------------------------------------------------------------------
struct LineTable {
typedef std::shared_ptr<LineTable> shared_ptr;
@@ -165,9 +157,7 @@ public:
Row::collection rows;
};
- //------------------------------------------------------------------
// State
- //------------------------------------------------------------------
struct State : public Row {
typedef void (*Callback)(dw_offset_t offset, const State &state,
void *userData);
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h Wed Apr 10 13:48:55 2019
@@ -14,13 +14,11 @@
#include "lldb/Utility/ConstString.h"
#include "DWARFDefines.h"
-//----------------------------------------------------------------------
// DWARFDeclContext
//
// A class that represents a declaration context all the way down to a
// DIE. This is useful when trying to find a DIE in one DWARF to a DIE
// in another DWARF file.
-//----------------------------------------------------------------------
class DWARFDeclContext {
public:
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp Wed Apr 10 13:48:55 2019
@@ -34,9 +34,7 @@ DWARFUnit::DWARFUnit(SymbolFileDWARF *dw
DWARFUnit::~DWARFUnit() {}
-//----------------------------------------------------------------------
// Parses first DIE of a compile unit.
-//----------------------------------------------------------------------
void DWARFUnit::ExtractUnitDIEIfNeeded() {
{
llvm::sys::ScopedReader lock(m_first_die_mutex);
@@ -67,10 +65,8 @@ void DWARFUnit::ExtractUnitDIEIfNeeded()
}
}
-//----------------------------------------------------------------------
// Parses a compile unit and indexes its DIEs if it hasn't already been done.
// It will leave this compile unit extracted forever.
-//----------------------------------------------------------------------
void DWARFUnit::ExtractDIEsIfNeeded() {
m_cancel_scopes = true;
@@ -86,13 +82,11 @@ void DWARFUnit::ExtractDIEsIfNeeded() {
ExtractDIEsRWLocked();
}
-//----------------------------------------------------------------------
// Parses a compile unit and indexes its DIEs if it hasn't already been done.
// It will clear this compile unit after returned instance gets out of scope,
// no other ScopedExtractDIEs instance is running for this compile unit
// and no ExtractDIEsIfNeeded() has been executed during this ScopedExtractDIEs
// lifetime.
-//----------------------------------------------------------------------
DWARFUnit::ScopedExtractDIEs DWARFUnit::ExtractDIEsScoped() {
ScopedExtractDIEs scoped(this);
@@ -145,10 +139,8 @@ DWARFUnit::ScopedExtractDIEs &DWARFUnit:
return *this;
}
-//----------------------------------------------------------------------
// Parses a compile unit and indexes its DIEs, m_die_array_mutex must be
// held R/W and m_die_array must be empty.
-//----------------------------------------------------------------------
void DWARFUnit::ExtractDIEsRWLocked() {
llvm::sys::ScopedWriter first_die_lock(m_first_die_mutex);
@@ -532,21 +524,17 @@ DWARFFormValue::FixedFormSizes DWARFUnit
void DWARFUnit::SetBaseAddress(dw_addr_t base_addr) { m_base_addr = base_addr; }
-//----------------------------------------------------------------------
// Compare function DWARFDebugAranges::Range structures
-//----------------------------------------------------------------------
static bool CompareDIEOffset(const DWARFDebugInfoEntry &die,
const dw_offset_t die_offset) {
return die.GetOffset() < die_offset;
}
-//----------------------------------------------------------------------
// GetDIE()
//
// Get the DIE (Debug Information Entry) with the specified offset by first
// checking if the DIE is contained within this compile unit and grabbing the
// DIE from this compile unit. Otherwise we grab the DIE from the DWARF file.
-//----------------------------------------------------------------------
DWARFDIE
DWARFUnit::GetDIE(dw_offset_t die_offset) {
if (die_offset != DW_INVALID_OFFSET) {
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.h Wed Apr 10 13:48:55 2019
@@ -58,7 +58,6 @@ public:
uint32_t depth = UINT32_MAX) const;
bool Verify(lldb_private::Stream *s) const;
virtual void Dump(lldb_private::Stream *s) const = 0;
- //------------------------------------------------------------------
/// Get the data that contains the DIE information for this unit.
///
/// This will return the correct bytes that contain the data for
@@ -67,26 +66,21 @@ public:
///
/// \return
/// The correct data for the DIE information in this unit.
- //------------------------------------------------------------------
virtual const lldb_private::DWARFDataExtractor &GetData() const = 0;
- //------------------------------------------------------------------
/// Get the size in bytes of the compile unit header.
///
/// \return
/// Byte size of the compile unit header
- //------------------------------------------------------------------
virtual uint32_t GetHeaderByteSize() const = 0;
// Offset of the initial length field.
dw_offset_t GetOffset() const { return m_offset; }
lldb::user_id_t GetID() const;
- //------------------------------------------------------------------
/// Get the size in bytes of the length field in the header.
///
/// In DWARF32 this is just 4 bytes
///
/// \return
/// Byte size of the compile unit header length field
- //------------------------------------------------------------------
size_t GetLengthByteSize() const { return 4; }
bool ContainsDIEOffset(dw_offset_t die_offset) const {
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp Wed Apr 10 13:48:55 2019
@@ -43,10 +43,8 @@ void ManualDWARFIndex::Index() {
std::vector<IndexSet> sets(units_to_index.size());
- //----------------------------------------------------------------------
// Keep memory down by clearing DIEs for any compile units if indexing
// caused us to load the compile unit's DIEs.
- //----------------------------------------------------------------------
std::vector<llvm::Optional<DWARFUnit::ScopedExtractDIEs>> clear_cu_dies(
units_to_index.size());
auto parser_fn = [&](size_t cu_idx) {
@@ -59,14 +57,12 @@ void ManualDWARFIndex::Index() {
// Create a task runner that extracts dies for each DWARF compile unit in a
// separate thread
- //----------------------------------------------------------------------
// First figure out which compile units didn't have their DIEs already
// parsed and remember this. If no DIEs were parsed prior to this index
// function call, we are going to want to clear the CU dies after we are
// done indexing to make sure we don't pull in all DWARF dies, but we need
// to wait until all compile units have been indexed in case a DIE in one
// compile unit refers to another and the indexes accesses those DIEs.
- //----------------------------------------------------------------------
TaskMapOverInt(0, units_to_index.size(), extract_fn);
// Now create a task runner that can index each DWARF compile unit in a
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Wed Apr 10 13:48:55 2019
@@ -328,10 +328,8 @@ size_t SymbolFileDWARF::GetTypes(SymbolC
return num_types_added;
}
-//----------------------------------------------------------------------
// Gets the first parent that is a lexical block, function or inlined
// subroutine, or compile unit.
-//----------------------------------------------------------------------
DWARFDIE
SymbolFileDWARF::GetParentSymbolContextDIE(const DWARFDIE &child_die) {
DWARFDIE die;
@@ -959,9 +957,7 @@ struct ParseDWARFLineTableCallbackInfo {
lldb::addr_t addr_mask;
};
-//----------------------------------------------------------------------
// ParseStatementTableCallback
-//----------------------------------------------------------------------
static void ParseDWARFLineTableCallback(dw_offset_t offset,
const DWARFDebugLine::State &state,
void *userData) {
@@ -2787,7 +2783,6 @@ TypeSP SymbolFileDWARF::FindCompleteObjC
return type_sp;
}
-//----------------------------------------------------------------------
// This function helps to ensure that the declaration contexts match for two
// different DIEs. Often times debug information will refer to a forward
// declaration of a type (the equivalent of "struct my_struct;". There will
@@ -2797,7 +2792,6 @@ TypeSP SymbolFileDWARF::FindCompleteObjC
// type was in the same declaration context as the original DIE. This function
// can efficiently compare two DIEs and will return true when the declaration
// context matches, and false when they don't.
-//----------------------------------------------------------------------
bool SymbolFileDWARF::DIEDeclContextsMatch(const DWARFDIE &die1,
const DWARFDIE &die2) {
if (die1 == die2)
@@ -3788,9 +3782,7 @@ SymbolFileDWARF::ParseCallEdgesInFunctio
return {};
}
-//------------------------------------------------------------------
// PluginInterface protocol
-//------------------------------------------------------------------
ConstString SymbolFileDWARF::GetPluginName() { return GetPluginNameStatic(); }
uint32_t SymbolFileDWARF::GetPluginVersion() { return 1; }
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h Wed Apr 10 13:48:55 2019
@@ -36,9 +36,7 @@
#include "DWARFIndex.h"
#include "UniqueDWARFASTType.h"
-//----------------------------------------------------------------------
// Forward Declarations for this DWARF plugin
-//----------------------------------------------------------------------
class DebugMapModule;
class DWARFAbbreviationDeclaration;
class DWARFAbbreviationDeclarationSet;
@@ -68,9 +66,7 @@ public:
friend class DWARFDIE;
friend class DWARFASTParserClang;
- //------------------------------------------------------------------
// Static Functions
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
@@ -86,9 +82,7 @@ public:
static const lldb_private::FileSpecList &GetSymlinkPaths();
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
SymbolFileDWARF(lldb_private::ObjectFile *ofile);
@@ -98,9 +92,7 @@ public:
void InitializeObject() override;
- //------------------------------------------------------------------
// Compile Unit function calls
- //------------------------------------------------------------------
uint32_t GetNumCompileUnits() override;
@@ -219,9 +211,7 @@ public:
std::recursive_mutex &GetModuleMutex() const override;
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
lldb_private::ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp Wed Apr 10 13:48:55 2019
@@ -1230,9 +1230,7 @@ void SymbolFileDWARFDebugMap::DumpClangA
});
}
-//------------------------------------------------------------------
// PluginInterface protocol
-//------------------------------------------------------------------
lldb_private::ConstString SymbolFileDWARFDebugMap::GetPluginName() {
return GetPluginNameStatic();
}
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h Wed Apr 10 13:48:55 2019
@@ -24,9 +24,7 @@ class DWARFDeclContext;
class SymbolFileDWARFDebugMap : public lldb_private::SymbolFile {
public:
- //------------------------------------------------------------------
// Static Functions
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
@@ -38,18 +36,14 @@ public:
static lldb_private::SymbolFile *
CreateInstance(lldb_private::ObjectFile *obj_file);
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
SymbolFileDWARFDebugMap(lldb_private::ObjectFile *ofile);
~SymbolFileDWARFDebugMap() override;
uint32_t CalculateAbilities() override;
void InitializeObject() override;
- //------------------------------------------------------------------
// Compile Unit function calls
- //------------------------------------------------------------------
uint32_t GetNumCompileUnits() override;
lldb::CompUnitSP ParseCompileUnitAtIndex(uint32_t index) override;
@@ -130,9 +124,7 @@ public:
void DumpClangAST(lldb_private::Stream &s) override;
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
lldb_private::ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
@@ -157,9 +149,7 @@ protected:
lldb::addr_t>
FileRangeMap;
- //------------------------------------------------------------------
// Class specific types
- //------------------------------------------------------------------
struct CompileUnitInfo {
lldb_private::FileSpec so_file;
lldb_private::ConstString oso_path;
@@ -182,9 +172,7 @@ protected:
const FileRangeMap &GetFileRangeMap(SymbolFileDWARFDebugMap *exe_symfile);
};
- //------------------------------------------------------------------
// Protected Member Functions
- //------------------------------------------------------------------
void InitOSO();
static uint32_t GetOSOIndexFromUserID(lldb::user_id_t uid) {
@@ -271,9 +259,7 @@ protected:
return m_unique_ast_type_map;
}
- //------------------------------------------------------------------
// OSOEntry
- //------------------------------------------------------------------
class OSOEntry {
public:
OSOEntry()
@@ -302,9 +288,7 @@ protected:
typedef lldb_private::RangeDataVector<lldb::addr_t, lldb::addr_t, OSOEntry>
DebugMap;
- //------------------------------------------------------------------
// Member Variables
- //------------------------------------------------------------------
std::bitset<kNumFlags> m_flags;
std::vector<CompileUnitInfo> m_compile_unit_infos;
std::vector<uint32_t> m_func_indexes; // Sorted by address
@@ -316,24 +300,19 @@ protected:
lldb_private::LazyBool m_supports_DW_AT_APPLE_objc_complete_type;
DebugMap m_debug_map;
- //------------------------------------------------------------------
// When an object file from the debug map gets parsed in
// SymbolFileDWARF, it needs to tell the debug map about the object
// files addresses by calling this function once for each N_FUN,
// N_GSYM and N_STSYM and after all entries in the debug map have
// been matched up, FinalizeOSOFileRanges() should be called.
- //------------------------------------------------------------------
bool AddOSOFileRange(CompileUnitInfo *cu_info, lldb::addr_t exe_file_addr,
lldb::addr_t exe_byte_size, lldb::addr_t oso_file_addr,
lldb::addr_t oso_byte_size);
- //------------------------------------------------------------------
// Called after calling AddOSOFileRange() for each object file debug
// map entry to finalize the info for the unlinked compile unit.
- //------------------------------------------------------------------
void FinalizeOSOFileRanges(CompileUnitInfo *cu_info);
- //------------------------------------------------------------------
/// Convert \a addr from a .o file address, to an executable address.
///
/// \param[in] addr
@@ -342,10 +321,8 @@ protected:
/// \return
/// Returns true if \a addr was converted to be an executable
/// section/offset address, false otherwise.
- //------------------------------------------------------------------
bool LinkOSOAddress(lldb_private::Address &addr);
- //------------------------------------------------------------------
/// Convert a .o file "file address" to an executable "file address".
///
/// \param[in] oso_symfile
@@ -358,11 +335,9 @@ protected:
/// LLDB_INVALID_ADDRESS if \a oso_file_addr is not in the
/// linked executable, otherwise a valid "file address" from the
/// linked executable that contains the debug map.
- //------------------------------------------------------------------
lldb::addr_t LinkOSOFileAddress(SymbolFileDWARF *oso_symfile,
lldb::addr_t oso_file_addr);
- //------------------------------------------------------------------
/// Given a line table full of lines with "file addresses" that are
/// for a .o file represented by \a oso_symfile, link a new line table
/// and return it.
@@ -377,7 +352,6 @@ protected:
/// Returns a valid line table full of linked addresses, or NULL
/// if none of the line table addresses exist in the main
/// executable.
- //------------------------------------------------------------------
lldb_private::LineTable *
LinkOSOLineTable(SymbolFileDWARF *oso_symfile,
lldb_private::LineTable *line_table);
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.h Wed Apr 10 13:48:55 2019
@@ -18,9 +18,7 @@
class UniqueDWARFASTType {
public:
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
UniqueDWARFASTType()
: m_type_sp(), m_die(), m_declaration(),
m_byte_size(
Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.h Wed Apr 10 13:48:55 2019
@@ -50,9 +50,7 @@ struct DeclStatus {
class PdbAstBuilder {
public:
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
PdbAstBuilder(ObjectFile &obj, PdbIndex &index);
clang::DeclContext &GetTranslationUnitDecl();
Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h Wed Apr 10 13:48:55 2019
@@ -44,9 +44,7 @@ class SymbolFileNativePDB : public Symbo
friend class UdtRecordCompleter;
public:
- //------------------------------------------------------------------
// Static Functions
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
@@ -59,9 +57,7 @@ public:
static SymbolFile *CreateInstance(ObjectFile *obj_file);
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
SymbolFileNativePDB(ObjectFile *ofile);
~SymbolFileNativePDB() override;
@@ -70,9 +66,7 @@ public:
void InitializeObject() override;
- //------------------------------------------------------------------
// Compile Unit function calls
- //------------------------------------------------------------------
uint32_t GetNumCompileUnits() override;
Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h Wed Apr 10 13:48:55 2019
@@ -22,7 +22,6 @@ class PDBSymbolData;
}
} // namespace llvm
-//------------------------------------------------------------------------------
/// Converts a location information from a PDB symbol to a DWARF expression
///
/// \param[in] module
@@ -40,7 +39,6 @@ class PDBSymbolData;
///
/// \return
/// The DWARF expression corresponding to the location data of \a symbol.
-//------------------------------------------------------------------------------
lldb_private::DWARFExpression
ConvertPDBLocationToDWARFExpression(lldb::ModuleSP module,
const llvm::pdb::PDBSymbolData &symbol,
Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.h Wed Apr 10 13:48:55 2019
@@ -23,9 +23,7 @@ class PDBASTParser;
class SymbolFilePDB : public lldb_private::SymbolFile {
public:
- //------------------------------------------------------------------
// Static Functions
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
@@ -39,9 +37,7 @@ public:
static lldb_private::SymbolFile *
CreateInstance(lldb_private::ObjectFile *obj_file);
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
SymbolFilePDB(lldb_private::ObjectFile *ofile);
~SymbolFilePDB() override;
@@ -50,9 +46,7 @@ public:
void InitializeObject() override;
- //------------------------------------------------------------------
// Compile Unit function calls
- //------------------------------------------------------------------
uint32_t GetNumCompileUnits() override;
Modified: lldb/trunk/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp Wed Apr 10 13:48:55 2019
@@ -64,11 +64,9 @@ uint32_t SymbolFileSymtab::CalculateAbil
if (m_obj_file) {
const Symtab *symtab = m_obj_file->GetSymtab();
if (symtab) {
- //----------------------------------------------------------------------
// The snippet of code below will get the indexes the module symbol table
// entries that are code, data, or function related (debug info), sort
// them by value (address) and dump the sorted symbols.
- //----------------------------------------------------------------------
if (symtab->AppendSymbolIndexesWithType(eSymbolTypeSourceFile,
m_source_indexes)) {
abilities |= CompileUnits;
@@ -261,9 +259,7 @@ uint32_t SymbolFileSymtab::ResolveSymbol
return resolved_flags;
}
-//------------------------------------------------------------------
// PluginInterface protocol
-//------------------------------------------------------------------
lldb_private::ConstString SymbolFileSymtab::GetPluginName() {
return GetPluginNameStatic();
}
Modified: lldb/trunk/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.h Wed Apr 10 13:48:55 2019
@@ -17,16 +17,12 @@
class SymbolFileSymtab : public lldb_private::SymbolFile {
public:
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
SymbolFileSymtab(lldb_private::ObjectFile *obj_file);
~SymbolFileSymtab() override;
- //------------------------------------------------------------------
// Static Functions
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
@@ -40,9 +36,7 @@ public:
uint32_t CalculateAbilities() override;
- //------------------------------------------------------------------
// Compile Unit function calls
- //------------------------------------------------------------------
uint32_t GetNumCompileUnits() override;
lldb::CompUnitSP ParseCompileUnitAtIndex(uint32_t index) override;
@@ -85,9 +79,7 @@ public:
lldb::TypeClass type_mask,
lldb_private::TypeList &type_list) override;
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
lldb_private::ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
Modified: lldb/trunk/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp Wed Apr 10 13:48:55 2019
@@ -24,15 +24,11 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// SymbolVendorELF constructor
-//----------------------------------------------------------------------
SymbolVendorELF::SymbolVendorELF(const lldb::ModuleSP &module_sp)
: SymbolVendor(module_sp) {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
SymbolVendorELF::~SymbolVendorELF() {}
void SymbolVendorELF::Initialize() {
@@ -54,13 +50,11 @@ const char *SymbolVendorELF::GetPluginDe
"executables.";
}
-//----------------------------------------------------------------------
// CreateInstance
//
// Platforms can register a callback to use when creating symbol vendors to
// allow for complex debug information file setups, and to also allow for
// finding separate debug information files.
-//----------------------------------------------------------------------
SymbolVendor *
SymbolVendorELF::CreateInstance(const lldb::ModuleSP &module_sp,
lldb_private::Stream *feedback_strm) {
@@ -162,9 +156,7 @@ SymbolVendorELF::CreateInstance(const ll
return NULL;
}
-//------------------------------------------------------------------
// PluginInterface protocol
-//------------------------------------------------------------------
ConstString SymbolVendorELF::GetPluginName() { return GetPluginNameStatic(); }
uint32_t SymbolVendorELF::GetPluginVersion() { return 1; }
Modified: lldb/trunk/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.h (original)
+++ lldb/trunk/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.h Wed Apr 10 13:48:55 2019
@@ -14,16 +14,12 @@
class SymbolVendorELF : public lldb_private::SymbolVendor {
public:
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
SymbolVendorELF(const lldb::ModuleSP &module_sp);
~SymbolVendorELF() override;
- //------------------------------------------------------------------
// Static Functions
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
@@ -36,9 +32,7 @@ public:
CreateInstance(const lldb::ModuleSP &module_sp,
lldb_private::Stream *feedback_strm);
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
lldb_private::ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
Modified: lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp Wed Apr 10 13:48:55 2019
@@ -25,15 +25,11 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// SymbolVendorMacOSX constructor
-//----------------------------------------------------------------------
SymbolVendorMacOSX::SymbolVendorMacOSX(const lldb::ModuleSP &module_sp)
: SymbolVendor(module_sp) {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
SymbolVendorMacOSX::~SymbolVendorMacOSX() {}
static bool UUIDsMatch(Module *module, ObjectFile *ofile,
@@ -90,13 +86,11 @@ const char *SymbolVendorMacOSX::GetPlugi
"executables.";
}
-//----------------------------------------------------------------------
// CreateInstance
//
// Platforms can register a callback to use when creating symbol vendors to
// allow for complex debug information file setups, and to also allow for
// finding separate debug information files.
-//----------------------------------------------------------------------
SymbolVendor *
SymbolVendorMacOSX::CreateInstance(const lldb::ModuleSP &module_sp,
lldb_private::Stream *feedback_strm) {
@@ -312,9 +306,7 @@ SymbolVendorMacOSX::CreateInstance(const
return symbol_vendor;
}
-//------------------------------------------------------------------
// PluginInterface protocol
-//------------------------------------------------------------------
ConstString SymbolVendorMacOSX::GetPluginName() {
return GetPluginNameStatic();
}
Modified: lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.h (original)
+++ lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.h Wed Apr 10 13:48:55 2019
@@ -14,9 +14,7 @@
class SymbolVendorMacOSX : public lldb_private::SymbolVendor {
public:
- //------------------------------------------------------------------
// Static Functions
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
@@ -29,16 +27,12 @@ public:
CreateInstance(const lldb::ModuleSP &module_sp,
lldb_private::Stream *feedback_strm);
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
SymbolVendorMacOSX(const lldb::ModuleSP &module_sp);
virtual ~SymbolVendorMacOSX();
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
virtual lldb_private::ConstString GetPluginName();
virtual uint32_t GetPluginVersion();
Modified: lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.h (original)
+++ lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.h Wed Apr 10 13:48:55 2019
@@ -55,7 +55,6 @@ public:
: item_buffer_ptr(LLDB_INVALID_ADDRESS), item_buffer_size(0) {}
};
- //----------------------------------------------------------
/// Get the information about a work item by calling
/// __introspection_dispatch_queue_item_get_info. If there's a page of
/// memory that needs to be freed, pass in the address and size and it will
@@ -86,7 +85,6 @@ public:
/// failure of any kind while getting
/// the information, the item_buffer_ptr value will be
/// LLDB_INVALID_ADDRESS.
- //----------------------------------------------------------
GetItemInfoReturnInfo GetItemInfo(Thread &thread, lldb::addr_t item,
lldb::addr_t page_to_free,
uint64_t page_to_free_size,
Modified: lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.h (original)
+++ lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.h Wed Apr 10 13:48:55 2019
@@ -60,7 +60,6 @@ public:
count(0) {}
};
- //----------------------------------------------------------
/// Get the list of pending items for a given queue via a call to
/// __introspection_dispatch_queue_get_pending_items. If there's a page of
/// memory that needs to be freed, pass in the address and size and it will
@@ -90,7 +89,6 @@ public:
/// failure of any kind while getting
/// the information, the items_buffer_ptr value will be
/// LLDB_INVALID_ADDRESS.
- //----------------------------------------------------------
GetPendingItemsReturnInfo GetPendingItems(Thread &thread, lldb::addr_t queue,
lldb::addr_t page_to_free,
uint64_t page_to_free_size,
Modified: lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.h (original)
+++ lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.h Wed Apr 10 13:48:55 2019
@@ -56,7 +56,6 @@ public:
count(0) {}
};
- //----------------------------------------------------------
/// Get the list of queues that exist (with any active or pending items) via
/// a call to introspection_get_dispatch_queues(). If there's a page of
/// memory that needs to be freed, pass in the address and size and it will
@@ -83,7 +82,6 @@ public:
/// failure of any kind while getting
/// the information, the queues_buffer_ptr value will be
/// LLDB_INVALID_ADDRESS.
- //----------------------------------------------------------
GetQueuesReturnInfo GetCurrentQueues(Thread &thread,
lldb::addr_t page_to_free,
uint64_t page_to_free_size,
Modified: lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.h (original)
+++ lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.h Wed Apr 10 13:48:55 2019
@@ -56,7 +56,6 @@ public:
: item_buffer_ptr(LLDB_INVALID_ADDRESS), item_buffer_size(0) {}
};
- //----------------------------------------------------------
/// Get the information about a work item by calling
/// __introspection_dispatch_thread_get_item_info. If there's a page of
/// memory that needs to be freed, pass in the address and size and it will
@@ -83,7 +82,6 @@ public:
/// failure of any kind while getting
/// the information, the item_buffer_ptr value will be
/// LLDB_INVALID_ADDRESS.
- //----------------------------------------------------------
GetThreadItemInfoReturnInfo GetThreadItemInfo(Thread &thread,
lldb::tid_t thread_id,
lldb::addr_t page_to_free,
Modified: lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp (original)
+++ lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp Wed Apr 10 13:48:55 2019
@@ -34,11 +34,9 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// Create an instance of this class. This function is filled into the plugin
// info class that gets handed out by the plugin factory and allows the lldb to
// instantiate an instance of this class.
-//----------------------------------------------------------------------
SystemRuntime *SystemRuntimeMacOSX::CreateInstance(Process *process) {
bool create = false;
if (!create) {
@@ -75,9 +73,7 @@ SystemRuntime *SystemRuntimeMacOSX::Crea
return NULL;
}
-//----------------------------------------------------------------------
// Constructor
-//----------------------------------------------------------------------
SystemRuntimeMacOSX::SystemRuntimeMacOSX(Process *process)
: SystemRuntime(process), m_break_id(LLDB_INVALID_BREAK_ID), m_mutex(),
m_get_queues_handler(process), m_get_pending_items_handler(process),
@@ -92,9 +88,7 @@ SystemRuntimeMacOSX::SystemRuntimeMacOSX
m_dispatch_voucher_offsets_addr(LLDB_INVALID_ADDRESS),
m_libdispatch_voucher_offsets() {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
SystemRuntimeMacOSX::~SystemRuntimeMacOSX() { Clear(true); }
void SystemRuntimeMacOSX::Detach() {
@@ -104,9 +98,7 @@ void SystemRuntimeMacOSX::Detach() {
m_get_thread_item_info_handler.Detach();
}
-//----------------------------------------------------------------------
// Clear out the state of this class.
-//----------------------------------------------------------------------
void SystemRuntimeMacOSX::Clear(bool clear_process) {
std::lock_guard<std::recursive_mutex> guard(m_mutex);
@@ -1012,9 +1004,7 @@ const char *SystemRuntimeMacOSX::GetPlug
return "System runtime plugin for Mac OS X native libraries.";
}
-//------------------------------------------------------------------
// PluginInterface protocol
-//------------------------------------------------------------------
lldb_private::ConstString SystemRuntimeMacOSX::GetPluginName() {
return GetPluginNameStatic();
}
Modified: lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h (original)
+++ lldb/trunk/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h Wed Apr 10 13:48:55 2019
@@ -34,9 +34,7 @@ public:
~SystemRuntimeMacOSX() override;
- //------------------------------------------------------------------
// Static Functions
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
@@ -48,9 +46,7 @@ public:
static lldb_private::SystemRuntime *
CreateInstance(lldb_private::Process *process);
- //------------------------------------------------------------------
// instance methods
- //------------------------------------------------------------------
void Clear(bool clear_process);
@@ -101,9 +97,7 @@ public:
bool SafeToCallFunctionsOnThisThread(lldb::ThreadSP thread_sp) override;
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
lldb_private::ConstString GetPluginName() override;
uint32_t GetPluginVersion() override;
Modified: lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp (original)
+++ lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp Wed Apr 10 13:48:55 2019
@@ -28,9 +28,7 @@
using namespace lldb;
using namespace lldb_private;
-//-----------------------------------------------------------------------------------------------
// UnwindAssemblyInstEmulation method definitions
-//-----------------------------------------------------------------------------------------------
bool UnwindAssemblyInstEmulation::GetNonCallSiteUnwindPlanFromAssembly(
AddressRange &range, Thread &thread, UnwindPlan &unwind_plan) {
@@ -305,9 +303,7 @@ UnwindAssemblyInstEmulation::CreateInsta
return NULL;
}
-//------------------------------------------------------------------
// PluginInterface protocol in UnwindAssemblyParser_x86
-//------------------------------------------------------------------
ConstString UnwindAssemblyInstEmulation::GetPluginName() {
return GetPluginNameStatic();
}
Modified: lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.h (original)
+++ lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.h Wed Apr 10 13:48:55 2019
@@ -47,9 +47,7 @@ public:
static lldb_private::UnwindAssembly *
CreateInstance(const lldb_private::ArchSpec &arch);
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
Modified: lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp (original)
+++ lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp Wed Apr 10 13:48:55 2019
@@ -30,9 +30,7 @@
using namespace lldb;
using namespace lldb_private;
-//-----------------------------------------------------------------------------------------------
// UnwindAssemblyParser_x86 method definitions
-//-----------------------------------------------------------------------------------------------
UnwindAssembly_x86::UnwindAssembly_x86(const ArchSpec &arch)
: lldb_private::UnwindAssembly(arch),
@@ -244,9 +242,7 @@ UnwindAssembly *UnwindAssembly_x86::Crea
return NULL;
}
-//------------------------------------------------------------------
// PluginInterface protocol in UnwindAssemblyParser_x86
-//------------------------------------------------------------------
ConstString UnwindAssembly_x86::GetPluginName() {
return GetPluginNameStatic();
Modified: lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.h (original)
+++ lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.h Wed Apr 10 13:48:55 2019
@@ -41,9 +41,7 @@ public:
static lldb_private::UnwindAssembly *
CreateInstance(const lldb_private::ArchSpec &arch);
- //------------------------------------------------------------------
// PluginInterface protocol
- //------------------------------------------------------------------
static void Initialize();
static void Terminate();
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/ClangASTContext.cpp (original)
+++ lldb/trunk/source/Symbol/ClangASTContext.cpp Wed Apr 10 13:48:55 2019
@@ -663,9 +663,7 @@ ClangASTContext::ClangASTContext(const c
SetTargetTriple(target_triple);
}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
ClangASTContext::~ClangASTContext() { Finalize(); }
ConstString ClangASTContext::GetPluginNameStatic() {
@@ -2435,17 +2433,13 @@ void ClangASTContext::DumpDeclHiearchy(c
bool ClangASTContext::DeclsAreEquivalent(clang::Decl *lhs_decl,
clang::Decl *rhs_decl) {
if (lhs_decl && rhs_decl) {
- //----------------------------------------------------------------------
// Make sure the decl kinds match first
- //----------------------------------------------------------------------
const clang::Decl::Kind lhs_decl_kind = lhs_decl->getKind();
const clang::Decl::Kind rhs_decl_kind = rhs_decl->getKind();
if (lhs_decl_kind == rhs_decl_kind) {
- //------------------------------------------------------------------
// Now check that the decl contexts kinds are all equivalent before we
// have to check any names of the decl contexts...
- //------------------------------------------------------------------
clang::DeclContext *lhs_decl_ctx = lhs_decl->getDeclContext();
clang::DeclContext *rhs_decl_ctx = rhs_decl->getDeclContext();
if (lhs_decl_ctx && rhs_decl_ctx) {
@@ -2467,9 +2461,7 @@ bool ClangASTContext::DeclsAreEquivalent
return false;
}
- //--------------------------------------------------------------
// Now make sure the name of the decls match
- //--------------------------------------------------------------
clang::NamedDecl *lhs_named_decl =
llvm::dyn_cast<clang::NamedDecl>(lhs_decl);
clang::NamedDecl *rhs_named_decl =
@@ -2485,10 +2477,8 @@ bool ClangASTContext::DeclsAreEquivalent
} else
return false;
- //--------------------------------------------------------------
// We know that the decl context kinds all match, so now we need to
// make sure the names match as well
- //--------------------------------------------------------------
lhs_decl_ctx = lhs_decl->getDeclContext();
rhs_decl_ctx = rhs_decl->getDeclContext();
while (1) {
@@ -2830,9 +2820,7 @@ ConvertAccessTypeToObjCIvarAccessControl
return clang::ObjCIvarDecl::None;
}
-//----------------------------------------------------------------------
// Tests
-//----------------------------------------------------------------------
bool ClangASTContext::IsAggregateType(lldb::opaque_compiler_type_t type) {
clang::QualType qual_type(GetCanonicalQualType(type));
@@ -3994,9 +3982,7 @@ bool ClangASTContext::GetObjCClassName(c
return false;
}
-//----------------------------------------------------------------------
// Type Completion
-//----------------------------------------------------------------------
bool ClangASTContext::GetCompleteType(lldb::opaque_compiler_type_t type) {
if (!type)
@@ -4485,9 +4471,7 @@ unsigned ClangASTContext::GetTypeQualifi
return 0;
}
-//----------------------------------------------------------------------
// Creating related types
-//----------------------------------------------------------------------
CompilerType
ClangASTContext::GetArrayElementType(lldb::opaque_compiler_type_t type,
@@ -4999,16 +4983,12 @@ ClangASTContext::GetTypedefedType(lldb::
return CompilerType();
}
-//----------------------------------------------------------------------
// Create related types using the current type's AST
-//----------------------------------------------------------------------
CompilerType ClangASTContext::GetBasicTypeFromAST(lldb::BasicType basic_type) {
return ClangASTContext::GetBasicType(getASTContext(), basic_type);
}
-//----------------------------------------------------------------------
// Exploring the type
-//----------------------------------------------------------------------
Optional<uint64_t>
ClangASTContext::GetBitSize(lldb::opaque_compiler_type_t type,
@@ -9081,9 +9061,7 @@ ClangASTContext::ConvertStringToFloatVal
return 0;
}
-//----------------------------------------------------------------------
// Dumping types
-//----------------------------------------------------------------------
#define DEPTH_INCREMENT 2
#ifndef NDEBUG
@@ -9921,9 +9899,7 @@ bool ClangASTContext::LayoutRecordType(
field_offsets, base_offsets, vbase_offsets);
}
-//----------------------------------------------------------------------
// CompilerDecl override functions
-//----------------------------------------------------------------------
ConstString ClangASTContext::DeclGetName(void *opaque_decl) {
if (opaque_decl) {
@@ -10011,9 +9987,7 @@ CompilerType ClangASTContext::DeclGetFun
return CompilerType();
}
-//----------------------------------------------------------------------
// CompilerDeclContext functions
-//----------------------------------------------------------------------
std::vector<CompilerDecl> ClangASTContext::DeclContextFindDeclByName(
void *opaque_decl_ctx, ConstString name, const bool ignore_using_decls) {
Modified: lldb/trunk/source/Symbol/CompactUnwindInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/CompactUnwindInfo.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/CompactUnwindInfo.cpp (original)
+++ lldb/trunk/source/Symbol/CompactUnwindInfo.cpp Wed Apr 10 13:48:55 2019
@@ -157,9 +157,7 @@ FLAGS_ANONYMOUS_ENUM(){
llvm::countTrailingZeros(static_cast<uint32_t>(mask), llvm::ZB_Width)) & \
(((1 << llvm::countPopulation(static_cast<uint32_t>(mask)))) - 1))
-//----------------------
// constructor
-//----------------------
CompactUnwindInfo::CompactUnwindInfo(ObjectFile &objfile, SectionSP §ion_sp)
: m_objfile(objfile), m_section_sp(section_sp),
@@ -167,9 +165,7 @@ CompactUnwindInfo::CompactUnwindInfo(Obj
m_indexes_computed(eLazyBoolCalculate), m_unwindinfo_data(),
m_unwindinfo_data_computed(false), m_unwind_header() {}
-//----------------------
// destructor
-//----------------------
CompactUnwindInfo::~CompactUnwindInfo() {}
Modified: lldb/trunk/source/Symbol/CompileUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/CompileUnit.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/CompileUnit.cpp (original)
+++ lldb/trunk/source/Symbol/CompileUnit.cpp Wed Apr 10 13:48:55 2019
@@ -81,12 +81,10 @@ void CompileUnit::ForeachFunction(
return;
}
-//----------------------------------------------------------------------
// Dump the current contents of this object. No functions that cause on demand
// parsing of functions, globals, statics are called, so this is a good
// function to call to get an idea of the current contents of the CompileUnit
// object.
-//----------------------------------------------------------------------
void CompileUnit::Dump(Stream *s, bool show_context) const {
const char *language = Language::GetNameForLanguageType(m_language);
@@ -116,14 +114,11 @@ void CompileUnit::Dump(Stream *s, bool s
}
}
-//----------------------------------------------------------------------
// Add a function to this compile unit
-//----------------------------------------------------------------------
void CompileUnit::AddFunction(FunctionSP &funcSP) {
m_functions_by_uid[funcSP->GetID()] = funcSP;
}
-//----------------------------------------------------------------------
// Find functions using the Mangled::Tokens token list. This function currently
// implements an interactive approach designed to find all instances of certain
// functions. It isn't designed to the quickest way to lookup functions as it
@@ -145,7 +140,6 @@ void CompileUnit::AddFunction(FunctionSP
// method should be able to take advantage of any accelerator tables available
// in the debug information (which is parsed by the SymbolFile parser plug-ins
// and registered with each Module).
-//----------------------------------------------------------------------
// void
// CompileUnit::FindFunctions(const Mangled::Tokens& tokens)
//{
Modified: lldb/trunk/source/Symbol/CompilerType.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/CompilerType.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/CompilerType.cpp (original)
+++ lldb/trunk/source/Symbol/CompilerType.cpp Wed Apr 10 13:48:55 2019
@@ -41,9 +41,7 @@ CompilerType::CompilerType(clang::ASTCon
CompilerType::~CompilerType() {}
-//----------------------------------------------------------------------
// Tests
-//----------------------------------------------------------------------
bool CompilerType::IsAggregateType() const {
if (IsValid())
@@ -270,9 +268,7 @@ bool CompilerType::IsBeingDefined() cons
return m_type_system->IsBeingDefined(m_type);
}
-//----------------------------------------------------------------------
// Type Completion
-//----------------------------------------------------------------------
bool CompilerType::GetCompleteType() const {
if (!IsValid())
@@ -280,9 +276,7 @@ bool CompilerType::GetCompleteType() con
return m_type_system->GetCompleteType(m_type);
}
-//----------------------------------------------------------------------
// AST related queries
-//----------------------------------------------------------------------
size_t CompilerType::GetPointerByteSize() const {
if (m_type_system)
return m_type_system->GetPointerByteSize();
@@ -351,9 +345,7 @@ unsigned CompilerType::GetTypeQualifiers
return 0;
}
-//----------------------------------------------------------------------
// Creating related types
-//----------------------------------------------------------------------
CompilerType CompilerType::GetArrayElementType(uint64_t *stride) const {
if (IsValid()) {
@@ -487,9 +479,7 @@ CompilerType CompilerType::GetTypedefedT
return CompilerType();
}
-//----------------------------------------------------------------------
// Create related types using the current type's AST
-//----------------------------------------------------------------------
CompilerType
CompilerType::GetBasicTypeFromAST(lldb::BasicType basic_type) const {
@@ -497,9 +487,7 @@ CompilerType::GetBasicTypeFromAST(lldb::
return m_type_system->GetBasicTypeFromAST(basic_type);
return CompilerType();
}
-//----------------------------------------------------------------------
// Exploring the type
-//----------------------------------------------------------------------
llvm::Optional<uint64_t>
CompilerType::GetBitSize(ExecutionContextScope *exe_scope) const {
@@ -748,9 +736,7 @@ size_t CompilerType::ConvertStringToFloa
return 0;
}
-//----------------------------------------------------------------------
// Dumping types
-//----------------------------------------------------------------------
#define DEPTH_INCREMENT 2
void CompilerType::DumpValue(ExecutionContext *exe_ctx, Stream *s,
Modified: lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp (original)
+++ lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp Wed Apr 10 13:48:55 2019
@@ -23,12 +23,10 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// GetDwarfEHPtr
//
// Used for calls when the value type is specified by a DWARF EH Frame pointer
// encoding.
-//----------------------------------------------------------------------
static uint64_t
GetGNUEHPointer(const DataExtractor &DE, offset_t *offset_ptr,
uint32_t eh_ptr_enc, addr_t pc_rel_addr, addr_t text_addr,
Modified: lldb/trunk/source/Symbol/FuncUnwinders.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/FuncUnwinders.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/FuncUnwinders.cpp (original)
+++ lldb/trunk/source/Symbol/FuncUnwinders.cpp Wed Apr 10 13:48:55 2019
@@ -28,9 +28,7 @@
using namespace lldb;
using namespace lldb_private;
-//------------------------------------------------
/// constructor
-//------------------------------------------------
FuncUnwinders::FuncUnwinders(UnwindTable &unwind_table, AddressRange range)
: m_unwind_table(unwind_table), m_range(range), m_mutex(),
@@ -49,9 +47,7 @@ FuncUnwinders::FuncUnwinders(UnwindTable
m_tried_unwind_arch_default_at_func_entry(false),
m_first_non_prologue_insn() {}
-//------------------------------------------------
/// destructor
-//------------------------------------------------
FuncUnwinders::~FuncUnwinders() {}
Modified: lldb/trunk/source/Symbol/Function.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/Function.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/Function.cpp (original)
+++ lldb/trunk/source/Symbol/Function.cpp Wed Apr 10 13:48:55 2019
@@ -24,10 +24,8 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// Basic function information is contained in the FunctionInfo class. It is
// designed to contain the name, linkage name, and declaration location.
-//----------------------------------------------------------------------
FunctionInfo::FunctionInfo(const char *name, const Declaration *decl_ptr)
: m_name(name), m_declaration(decl_ptr) {}
@@ -129,9 +127,7 @@ size_t InlineFunctionInfo::MemorySize()
return FunctionInfo::MemorySize() + m_mangled.MemorySize();
}
-//----------------------------------------------------------------------
//
-//----------------------------------------------------------------------
CallEdge::CallEdge(const char *symbol_name, lldb::addr_t return_pc)
: return_pc(return_pc), resolved(false) {
lazy_callee.symbol_name = symbol_name;
@@ -182,9 +178,7 @@ lldb::addr_t CallEdge::GetReturnPCAddres
return base.GetLoadAddress(&target) + return_pc;
}
-//----------------------------------------------------------------------
//
-//----------------------------------------------------------------------
Function::Function(CompileUnit *comp_unit, lldb::user_id_t func_uid,
lldb::user_id_t type_uid, const Mangled &mangled, Type *type,
const AddressRange &range)
Modified: lldb/trunk/source/Symbol/LineTable.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/LineTable.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/LineTable.cpp (original)
+++ lldb/trunk/source/Symbol/LineTable.cpp Wed Apr 10 13:48:55 2019
@@ -17,15 +17,11 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// LineTable constructor
-//----------------------------------------------------------------------
LineTable::LineTable(CompileUnit *comp_unit)
: m_comp_unit(comp_unit), m_entries() {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
LineTable::~LineTable() {}
void LineTable::InsertLineEntry(lldb::addr_t file_addr, uint32_t line,
@@ -136,7 +132,6 @@ void LineTable::InsertSequence(LineSeque
m_entries.insert(pos, seq->m_entries.begin(), seq->m_entries.end());
}
-//----------------------------------------------------------------------
LineTable::Entry::LessThanBinaryPredicate::LessThanBinaryPredicate(
LineTable *line_table)
: m_line_table(line_table) {}
Modified: lldb/trunk/source/Symbol/ObjectFile.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ObjectFile.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/ObjectFile.cpp (original)
+++ lldb/trunk/source/Symbol/ObjectFile.cpp Wed Apr 10 13:48:55 2019
@@ -533,9 +533,7 @@ size_t ObjectFile::ReadSectionData(Secti
return 0;
}
-//----------------------------------------------------------------------
// Get the section data the file on disk
-//----------------------------------------------------------------------
size_t ObjectFile::ReadSectionData(Section *section,
DataExtractor §ion_data) {
// If some other objectfile owns this data, pass this to them.
Modified: lldb/trunk/source/Symbol/SymbolContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/SymbolContext.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/SymbolContext.cpp (original)
+++ lldb/trunk/source/Symbol/SymbolContext.cpp Wed Apr 10 13:48:55 2019
@@ -586,10 +586,8 @@ void SymbolContext::SortTypeList(TypeMap
curr_block->GetContainingInlinedBlock() != nullptr)
isInlinedblock = true;
- //----------------------------------------------------------------------
// Find all types that match the current block if we have one and put them
// first in the list. Keep iterating up through all blocks.
- //----------------------------------------------------------------------
while (curr_block != nullptr && !isInlinedblock) {
type_map.ForEach(
[curr_block, &type_list](const lldb::TypeSP &type_sp) -> bool {
@@ -607,10 +605,8 @@ void SymbolContext::SortTypeList(TypeMap
});
curr_block = curr_block->GetParent();
}
- //----------------------------------------------------------------------
// Find all types that match the current function, if we have onem, and put
// them next in the list.
- //----------------------------------------------------------------------
if (function != nullptr && !type_map.Empty()) {
const size_t old_type_list_size = type_list.GetSize();
type_map.ForEach([this, &type_list](const lldb::TypeSP &type_sp) -> bool {
@@ -628,10 +624,8 @@ void SymbolContext::SortTypeList(TypeMap
type_map.Remove(type_list.GetTypeAtIndex(i));
}
}
- //----------------------------------------------------------------------
// Find all types that match the current compile unit, if we have one, and
// put them next in the list.
- //----------------------------------------------------------------------
if (comp_unit != nullptr && !type_map.Empty()) {
const size_t old_type_list_size = type_list.GetSize();
@@ -650,10 +644,8 @@ void SymbolContext::SortTypeList(TypeMap
type_map.Remove(type_list.GetTypeAtIndex(i));
}
}
- //----------------------------------------------------------------------
// Find all types that match the current module, if we have one, and put them
// next in the list.
- //----------------------------------------------------------------------
if (module_sp && !type_map.Empty()) {
const size_t old_type_list_size = type_list.GetSize();
type_map.ForEach([this, &type_list](const lldb::TypeSP &type_sp) -> bool {
@@ -670,9 +662,7 @@ void SymbolContext::SortTypeList(TypeMap
type_map.Remove(type_list.GetTypeAtIndex(i));
}
}
- //----------------------------------------------------------------------
// Any types that are left get copied into the list an any order.
- //----------------------------------------------------------------------
if (!type_map.Empty()) {
type_map.ForEach([&type_list](const lldb::TypeSP &type_sp) -> bool {
type_list.Insert(type_sp);
@@ -949,11 +939,9 @@ SymbolContext::FindBestGlobalDataSymbol(
}
-//----------------------------------------------------------------------
//
// SymbolContextSpecifier
//
-//----------------------------------------------------------------------
SymbolContextSpecifier::SymbolContextSpecifier(const TargetSP &target_sp)
: m_target_sp(target_sp), m_module_spec(), m_module_sp(), m_file_spec_up(),
@@ -1213,11 +1201,9 @@ void SymbolContextSpecifier::GetDescript
}
}
-//----------------------------------------------------------------------
//
// SymbolContextList
//
-//----------------------------------------------------------------------
SymbolContextList::SymbolContextList() : m_symbol_contexts() {}
Modified: lldb/trunk/source/Symbol/SymbolVendor.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/SymbolVendor.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/SymbolVendor.cpp (original)
+++ lldb/trunk/source/Symbol/SymbolVendor.cpp Wed Apr 10 13:48:55 2019
@@ -18,13 +18,11 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// FindPlugin
//
// Platforms can register a callback to use when creating symbol vendors to
// allow for complex debug information file setups, and to also allow for
// finding separate debug information files.
-//----------------------------------------------------------------------
SymbolVendor *SymbolVendor::FindPlugin(const lldb::ModuleSP &module_sp,
lldb_private::Stream *feedback_strm) {
std::unique_ptr<SymbolVendor> instance_up;
@@ -58,21 +56,15 @@ SymbolVendor *SymbolVendor::FindPlugin(c
return instance_up.release();
}
-//----------------------------------------------------------------------
// SymbolVendor constructor
-//----------------------------------------------------------------------
SymbolVendor::SymbolVendor(const lldb::ModuleSP &module_sp)
: ModuleChild(module_sp), m_type_list(), m_compile_units(), m_sym_file_up(),
m_symtab() {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
SymbolVendor::~SymbolVendor() {}
-//----------------------------------------------------------------------
// Add a representation given an object file.
-//----------------------------------------------------------------------
void SymbolVendor::AddSymbolFileRepresentation(const ObjectFileSP &objfile_sp) {
ModuleSP module_sp(GetModule());
if (module_sp) {
@@ -488,9 +480,7 @@ void SymbolVendor::SectionFileAddressesC
}
}
-//------------------------------------------------------------------
// PluginInterface protocol
-//------------------------------------------------------------------
lldb_private::ConstString SymbolVendor::GetPluginName() {
static ConstString g_name("vendor-default");
return g_name;
Modified: lldb/trunk/source/Symbol/Symtab.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/Symtab.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/Symtab.cpp (original)
+++ lldb/trunk/source/Symbol/Symtab.cpp Wed Apr 10 13:48:55 2019
@@ -216,9 +216,7 @@ const Symbol *Symtab::SymbolAtIndex(size
return nullptr;
}
-//----------------------------------------------------------------------
// InitNameIndexes
-//----------------------------------------------------------------------
static bool lldb_skip_name(llvm::StringRef mangled,
Mangled::ManglingScheme scheme) {
switch (scheme) {
Modified: lldb/trunk/source/Symbol/TypeList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/TypeList.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/TypeList.cpp (original)
+++ lldb/trunk/source/Symbol/TypeList.cpp Wed Apr 10 13:48:55 2019
@@ -21,9 +21,7 @@ using namespace lldb_private;
TypeList::TypeList() : m_types() {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
TypeList::~TypeList() {}
void TypeList::Insert(const TypeSP &type_sp) {
@@ -33,9 +31,7 @@ void TypeList::Insert(const TypeSP &type
m_types.push_back(type_sp);
}
-//----------------------------------------------------------------------
// Find a base type by its unique ID.
-//----------------------------------------------------------------------
// TypeSP
// TypeList::FindType(lldb::user_id_t uid)
//{
@@ -45,9 +41,7 @@ void TypeList::Insert(const TypeSP &type
// return TypeSP();
//}
-//----------------------------------------------------------------------
// Find a type by name.
-//----------------------------------------------------------------------
// TypeList
// TypeList::FindTypes (ConstString name)
//{
Modified: lldb/trunk/source/Symbol/TypeMap.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/TypeMap.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/TypeMap.cpp (original)
+++ lldb/trunk/source/Symbol/TypeMap.cpp Wed Apr 10 13:48:55 2019
@@ -34,9 +34,7 @@ using namespace clang;
TypeMap::TypeMap() : m_types() {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
TypeMap::~TypeMap() {}
void TypeMap::Insert(const TypeSP &type_sp) {
@@ -61,9 +59,7 @@ bool TypeMap::InsertUnique(const TypeSP
return true;
}
-//----------------------------------------------------------------------
// Find a base type by its unique ID.
-//----------------------------------------------------------------------
// TypeSP
// TypeMap::FindType(lldb::user_id_t uid)
//{
@@ -73,9 +69,7 @@ bool TypeMap::InsertUnique(const TypeSP
// return TypeSP();
//}
-//----------------------------------------------------------------------
// Find a type by name.
-//----------------------------------------------------------------------
// TypeMap
// TypeMap::FindTypes (ConstString name)
//{
Modified: lldb/trunk/source/Symbol/Variable.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/Variable.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/Variable.cpp (original)
+++ lldb/trunk/source/Symbol/Variable.cpp Wed Apr 10 13:48:55 2019
@@ -35,9 +35,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// Variable constructor
-//----------------------------------------------------------------------
Variable::Variable(
lldb::user_id_t uid, const char *name,
const char *mangled, // The mangled or fully qualified name of the variable.
@@ -52,9 +50,7 @@ Variable::Variable(
m_artificial(artificial), m_loc_is_const_data(false),
m_static_member(static_member) {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
Variable::~Variable() {}
lldb::LanguageType Variable::GetLanguage() const {
Modified: lldb/trunk/source/Symbol/VariableList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/VariableList.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/VariableList.cpp (original)
+++ lldb/trunk/source/Symbol/VariableList.cpp Wed Apr 10 13:48:55 2019
@@ -16,14 +16,10 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// VariableList constructor
-//----------------------------------------------------------------------
VariableList::VariableList() : m_variables() {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
VariableList::~VariableList() {}
void VariableList::AddVariable(const VariableSP &var_sp) {
Modified: lldb/trunk/source/Target/CPPLanguageRuntime.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/CPPLanguageRuntime.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/CPPLanguageRuntime.cpp (original)
+++ lldb/trunk/source/Target/CPPLanguageRuntime.cpp Wed Apr 10 13:48:55 2019
@@ -1,5 +1,4 @@
//===-- CPPLanguageRuntime.cpp
-//-------------------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
@@ -32,9 +31,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
CPPLanguageRuntime::~CPPLanguageRuntime() {}
CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
Modified: lldb/trunk/source/Target/Language.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Language.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/Language.cpp (original)
+++ lldb/trunk/source/Target/Language.cpp Wed Apr 10 13:48:55 2019
@@ -443,12 +443,8 @@ void Language::GetDefaultExceptionResolv
s.Printf("Exception breakpoint (catch: %s throw: %s)",
catch_on ? "on" : "off", throw_on ? "on" : "off");
}
-//----------------------------------------------------------------------
// Constructor
-//----------------------------------------------------------------------
Language::Language() {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
Language::~Language() {}
Modified: lldb/trunk/source/Target/Memory.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Memory.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/Memory.cpp (original)
+++ lldb/trunk/source/Target/Memory.cpp Wed Apr 10 13:48:55 2019
@@ -19,17 +19,13 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// MemoryCache constructor
-//----------------------------------------------------------------------
MemoryCache::MemoryCache(Process &process)
: m_mutex(), m_L1_cache(), m_L2_cache(), m_invalid_ranges(),
m_process(process),
m_L2_cache_line_byte_size(process.GetMemoryCacheLineSize()) {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
MemoryCache::~MemoryCache() {}
void MemoryCache::Clear(bool clear_invalid_ranges) {
Modified: lldb/trunk/source/Target/ObjCLanguageRuntime.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ObjCLanguageRuntime.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ObjCLanguageRuntime.cpp (original)
+++ lldb/trunk/source/Target/ObjCLanguageRuntime.cpp Wed Apr 10 13:48:55 2019
@@ -27,9 +27,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
ObjCLanguageRuntime::~ObjCLanguageRuntime() {}
ObjCLanguageRuntime::ObjCLanguageRuntime(Process *process)
@@ -355,9 +353,7 @@ bool ObjCLanguageRuntime::GetTypeBitSize
return found;
}
-//------------------------------------------------------------------
// Exception breakpoint Precondition class for ObjC:
-//------------------------------------------------------------------
void ObjCLanguageRuntime::ObjCExceptionPrecondition::AddClassName(
const char *class_name) {
m_class_names.insert(class_name);
Modified: lldb/trunk/source/Target/PathMappingList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/PathMappingList.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/PathMappingList.cpp (original)
+++ lldb/trunk/source/Target/PathMappingList.cpp Wed Apr 10 13:48:55 2019
@@ -36,9 +36,7 @@ namespace {
return ConstString(FileSpec(path.GetStringRef()).GetPath());
}
}
-//----------------------------------------------------------------------
// PathMappingList constructor
-//----------------------------------------------------------------------
PathMappingList::PathMappingList()
: m_pairs(), m_callback(nullptr), m_callback_baton(nullptr), m_mod_id(0) {}
Modified: lldb/trunk/source/Target/Platform.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Platform.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/Platform.cpp (original)
+++ lldb/trunk/source/Target/Platform.cpp Wed Apr 10 13:48:55 2019
@@ -117,7 +117,6 @@ bool PlatformProperties::SetModuleCacheD
nullptr, ePropertyModuleCacheDirectory, dir_spec);
}
-//------------------------------------------------------------------
/// Get the native host platform plug-in.
///
/// There should only be one of these for each host that LLDB runs
@@ -126,7 +125,6 @@ bool PlatformProperties::SetModuleCacheD
///
/// This platform will be used as the default platform when launching
/// or attaching to processes unless another platform is specified.
-//------------------------------------------------------------------
PlatformSP Platform::GetHostPlatform() { return GetHostPlatformSP(); }
static std::vector<PlatformSP> &GetPlatformList() {
@@ -377,9 +375,7 @@ ArchSpec Platform::GetAugmentedArchSpec(
return HostInfo::GetAugmentedArchSpec(triple);
}
-//------------------------------------------------------------------
/// Default Constructor
-//------------------------------------------------------------------
Platform::Platform(bool is_host)
: m_is_host(is_host), m_os_version_set_while_connected(false),
m_system_arch_set_while_connected(false), m_sdk_sysroot(), m_sdk_build(),
@@ -394,12 +390,10 @@ Platform::Platform(bool is_host)
log->Printf("%p Platform::Platform()", static_cast<void *>(this));
}
-//------------------------------------------------------------------
/// Destructor.
///
/// The destructor is virtual since this class is designed to be
/// inherited from by the plug-in instance.
-//------------------------------------------------------------------
Platform::~Platform() {
Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_OBJECT));
if (log)
@@ -1198,10 +1192,8 @@ Platform::GetPlatformForArchitecture(con
return platform_sp;
}
-//------------------------------------------------------------------
/// Lets a platform answer if it is compatible with a given
/// architecture and the target triple contained within.
-//------------------------------------------------------------------
bool Platform::IsCompatibleArchitecture(const ArchSpec &arch,
bool exact_arch_match,
ArchSpec *compatible_arch_ptr) {
Modified: lldb/trunk/source/Target/Process.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/Process.cpp (original)
+++ lldb/trunk/source/Target/Process.cpp Wed Apr 10 13:48:55 2019
@@ -3910,9 +3910,7 @@ thread_result_t Process::RunPrivateState
return NULL;
}
-//------------------------------------------------------------------
// Process Event Data
-//------------------------------------------------------------------
Process::ProcessEventData::ProcessEventData()
: EventData(), m_process_wp(), m_state(eStateInvalid), m_restarted(false),
@@ -4288,9 +4286,7 @@ size_t Process::GetAsyncProfileData(char
return bytes_available;
}
-//------------------------------------------------------------------
// Process STDIO
-//------------------------------------------------------------------
size_t Process::GetSTDOUT(char *buf, size_t buf_size, Status &error) {
std::lock_guard<std::recursive_mutex> guard(m_stdio_communication_mutex);
Modified: lldb/trunk/source/Target/StackFrame.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrame.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/StackFrame.cpp (original)
+++ lldb/trunk/source/Target/StackFrame.cpp Wed Apr 10 13:48:55 2019
@@ -259,12 +259,10 @@ Block *StackFrame::GetFrameBlock() {
return nullptr;
}
-//----------------------------------------------------------------------
// Get the symbol context if we already haven't done so by resolving the
// PC address as much as possible. This way when we pass around a
// StackFrame object, everyone will have as much information as possible and no
// one will ever have to look things up manually.
-//----------------------------------------------------------------------
const SymbolContext &
StackFrame::GetSymbolContext(SymbolContextItem resolve_scope) {
std::lock_guard<std::recursive_mutex> guard(m_mutex);
@@ -1453,7 +1451,6 @@ ValueObjectSP GetValueForDereferincingOf
return GetValueForOffset(frame, pointee, offset);
}
-//------------------------------------------------------------------
/// Attempt to reconstruct the ValueObject for the address contained in a
/// given register plus an offset.
///
@@ -1479,7 +1476,6 @@ ValueObjectSP GetValueForDereferincingOf
/// A string describing the base for the ExpressionPath. This could be a
/// variable, a register value, an argument, or a function return value.
/// The ValueObject if found. If valid, it has a valid ExpressionPath.
-//------------------------------------------------------------------
lldb::ValueObjectSP DoGuessValueAt(StackFrame &frame, ConstString reg,
int64_t offset, Disassembler &disassembler,
VariableList &variables, const Address &pc) {
Modified: lldb/trunk/source/Target/StackFrameList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrameList.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/StackFrameList.cpp (original)
+++ lldb/trunk/source/Target/StackFrameList.cpp Wed Apr 10 13:48:55 2019
@@ -31,9 +31,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// StackFrameList constructor
-//----------------------------------------------------------------------
StackFrameList::StackFrameList(Thread &thread,
const lldb::StackFrameListSP &prev_frames_sp,
bool show_inline_frames)
Modified: lldb/trunk/source/Target/StopInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StopInfo.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/StopInfo.cpp (original)
+++ lldb/trunk/source/Target/StopInfo.cpp Wed Apr 10 13:48:55 2019
@@ -78,9 +78,7 @@ bool StopInfo::HasTargetRunSinceMe() {
return false;
}
-//----------------------------------------------------------------------
// StopInfoBreakpoint
-//----------------------------------------------------------------------
namespace lldb_private {
class StopInfoBreakpoint : public StopInfo {
@@ -575,9 +573,7 @@ private:
bool m_was_one_shot;
};
-//----------------------------------------------------------------------
// StopInfoWatchpoint
-//----------------------------------------------------------------------
class StopInfoWatchpoint : public StopInfo {
public:
@@ -912,9 +908,7 @@ private:
lldb::addr_t m_watch_hit_addr;
};
-//----------------------------------------------------------------------
// StopInfoUnixSignal
-//----------------------------------------------------------------------
class StopInfoUnixSignal : public StopInfo {
public:
@@ -989,9 +983,7 @@ public:
}
};
-//----------------------------------------------------------------------
// StopInfoTrace
-//----------------------------------------------------------------------
class StopInfoTrace : public StopInfo {
public:
@@ -1009,9 +1001,7 @@ public:
}
};
-//----------------------------------------------------------------------
// StopInfoException
-//----------------------------------------------------------------------
class StopInfoException : public StopInfo {
public:
@@ -1033,9 +1023,7 @@ public:
}
};
-//----------------------------------------------------------------------
// StopInfoThreadPlan
-//----------------------------------------------------------------------
class StopInfoThreadPlan : public StopInfo {
public:
@@ -1078,9 +1066,7 @@ private:
ExpressionVariableSP m_expression_variable_sp;
};
-//----------------------------------------------------------------------
// StopInfoExec
-//----------------------------------------------------------------------
class StopInfoExec : public StopInfo {
public:
Modified: lldb/trunk/source/Target/SystemRuntime.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/SystemRuntime.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/SystemRuntime.cpp (original)
+++ lldb/trunk/source/Target/SystemRuntime.cpp Wed Apr 10 13:48:55 2019
@@ -27,9 +27,7 @@ SystemRuntime *SystemRuntime::FindPlugin
return nullptr;
}
-//----------------------------------------------------------------------
// SystemRuntime constructor
-//----------------------------------------------------------------------
SystemRuntime::SystemRuntime(Process *process)
: m_process(process), m_types() {}
Modified: lldb/trunk/source/Target/Target.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Target.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/Target.cpp (original)
+++ lldb/trunk/source/Target/Target.cpp Wed Apr 10 13:48:55 2019
@@ -3160,9 +3160,7 @@ void Target::FinalizeFileActions(Process
}
}
-//--------------------------------------------------------------
// Target::StopHook
-//--------------------------------------------------------------
Target::StopHook::StopHook(lldb::TargetSP target_sp, lldb::user_id_t uid)
: UserID(uid), m_target_sp(target_sp), m_commands(), m_specifier_sp(),
m_thread_spec_up() {}
@@ -3229,9 +3227,7 @@ void Target::StopHook::GetDescription(St
s->SetIndentLevel(indent_level);
}
-//--------------------------------------------------------------
// class TargetProperties
-//--------------------------------------------------------------
// clang-format off
static constexpr OptionEnumValueElement g_dynamic_value_types[] = {
@@ -3592,9 +3588,7 @@ protected:
mutable bool m_got_host_env;
};
-//----------------------------------------------------------------------
// TargetProperties
-//----------------------------------------------------------------------
static constexpr PropertyDefinition g_experimental_properties[]{
{"inject-local-vars", OptionValue::eTypeBoolean, true, true, nullptr,
{},
@@ -3620,9 +3614,7 @@ TargetExperimentalProperties::TargetExpe
m_collection_sp->Initialize(g_experimental_properties);
}
-//----------------------------------------------------------------------
// TargetProperties
-//----------------------------------------------------------------------
TargetProperties::TargetProperties(Target *target)
: Properties(), m_launch_info() {
if (target) {
@@ -4220,9 +4212,7 @@ void TargetProperties::DisableSTDIOValue
this_->m_launch_info.GetFlags().Clear(lldb::eLaunchFlagDisableSTDIO);
}
-//----------------------------------------------------------------------
// Target::TargetEventData
-//----------------------------------------------------------------------
Target::TargetEventData::TargetEventData(const lldb::TargetSP &target_sp)
: EventData(), m_target_sp(target_sp), m_module_list() {}
Modified: lldb/trunk/source/Target/TargetList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/TargetList.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/TargetList.cpp (original)
+++ lldb/trunk/source/Target/TargetList.cpp Wed Apr 10 13:48:55 2019
@@ -34,9 +34,7 @@ ConstString &TargetList::GetStaticBroadc
return class_name;
}
-//----------------------------------------------------------------------
// TargetList constructor
-//----------------------------------------------------------------------
TargetList::TargetList(Debugger &debugger)
: Broadcaster(debugger.GetBroadcasterManager(),
TargetList::GetStaticBroadcasterClass().AsCString()),
@@ -44,9 +42,7 @@ TargetList::TargetList(Debugger &debugge
CheckInWithManager();
}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
TargetList::~TargetList() {
std::lock_guard<std::recursive_mutex> guard(m_target_list_mutex);
m_target_list.clear();
Modified: lldb/trunk/source/Target/Thread.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Thread.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/Thread.cpp (original)
+++ lldb/trunk/source/Target/Thread.cpp Wed Apr 10 13:48:55 2019
@@ -171,9 +171,7 @@ uint64_t ThreadProperties::GetMaxBacktra
nullptr, idx, g_properties[idx].default_uint_value != 0);
}
-//------------------------------------------------------------------
// Thread Event Data
-//------------------------------------------------------------------
ConstString Thread::ThreadEventData::GetFlavorString() {
static ConstString g_flavor("Thread::ThreadEventData");
@@ -234,9 +232,7 @@ Thread::ThreadEventData::GetStackFrameFr
return frame_sp;
}
-//------------------------------------------------------------------
// Thread class
-//------------------------------------------------------------------
ConstString &Thread::GetStaticBroadcasterClass() {
static ConstString class_name("lldb.thread");
Modified: lldb/trunk/source/Target/ThreadPlan.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlan.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlan.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlan.cpp Wed Apr 10 13:48:55 2019
@@ -18,9 +18,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlan constructor
-//----------------------------------------------------------------------
ThreadPlan::ThreadPlan(ThreadPlanKind kind, const char *name, Thread &thread,
Vote stop_vote, Vote run_vote)
: m_thread(thread), m_stop_vote(stop_vote), m_run_vote(run_vote),
@@ -32,9 +30,7 @@ ThreadPlan::ThreadPlan(ThreadPlanKind ki
SetID(GetNextID());
}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
ThreadPlan::~ThreadPlan() = default;
bool ThreadPlan::PlanExplainsStop(Event *event_ptr) {
@@ -160,9 +156,7 @@ bool ThreadPlan::IsUsuallyUnexplainedSto
}
}
-//----------------------------------------------------------------------
// ThreadPlanNull
-//----------------------------------------------------------------------
ThreadPlanNull::ThreadPlanNull(Thread &thread)
: ThreadPlan(ThreadPlan::eKindNull, "Null Thread Plan", thread,
Modified: lldb/trunk/source/Target/ThreadPlanBase.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanBase.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanBase.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanBase.cpp Wed Apr 10 13:48:55 2019
@@ -22,11 +22,9 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlanBase: This one always stops, and never has anything particular to
// do.
// FIXME: The "signal handling" policies should probably go here.
-//----------------------------------------------------------------------
ThreadPlanBase::ThreadPlanBase(Thread &thread)
: ThreadPlan(ThreadPlan::eKindBase, "base plan", thread, eVoteYes,
Modified: lldb/trunk/source/Target/ThreadPlanCallFunction.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanCallFunction.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanCallFunction.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanCallFunction.cpp Wed Apr 10 13:48:55 2019
@@ -29,9 +29,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlanCallFunction: Plan to call a single function
-//----------------------------------------------------------------------
bool ThreadPlanCallFunction::ConstructorSetup(
Thread &thread, ABI *&abi, lldb::addr_t &start_load_addr,
lldb::addr_t &function_load_addr) {
Modified: lldb/trunk/source/Target/ThreadPlanCallFunctionUsingABI.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanCallFunctionUsingABI.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanCallFunctionUsingABI.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanCallFunctionUsingABI.cpp Wed Apr 10 13:48:55 2019
@@ -18,10 +18,8 @@
using namespace lldb;
using namespace lldb_private;
-//--------------------------------------------------------------------------------------------
// ThreadPlanCallFunctionUsingABI: Plan to call a single function using the ABI
// instead of JIT
-//-------------------------------------------------------------------------------------------
ThreadPlanCallFunctionUsingABI::ThreadPlanCallFunctionUsingABI(
Thread &thread, const Address &function, llvm::Type &prototype,
llvm::Type &return_type, llvm::ArrayRef<ABI::CallArgument> args,
Modified: lldb/trunk/source/Target/ThreadPlanCallOnFunctionExit.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanCallOnFunctionExit.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanCallOnFunctionExit.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanCallOnFunctionExit.cpp Wed Apr 10 13:48:55 2019
@@ -40,9 +40,7 @@ void ThreadPlanCallOnFunctionExit::DidPu
);
}
-// -------------------------------------------------------------------------
// ThreadPlan API
-// -------------------------------------------------------------------------
void ThreadPlanCallOnFunctionExit::GetDescription(
Stream *s, lldb::DescriptionLevel level) {
Modified: lldb/trunk/source/Target/ThreadPlanCallUserExpression.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanCallUserExpression.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanCallUserExpression.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanCallUserExpression.cpp Wed Apr 10 13:48:55 2019
@@ -29,9 +29,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlanCallUserExpression: Plan to call a single function
-//----------------------------------------------------------------------
ThreadPlanCallUserExpression::ThreadPlanCallUserExpression(
Thread &thread, Address &function, llvm::ArrayRef<lldb::addr_t> args,
Modified: lldb/trunk/source/Target/ThreadPlanPython.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanPython.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanPython.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanPython.cpp Wed Apr 10 13:48:55 2019
@@ -23,9 +23,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlanPython
-//----------------------------------------------------------------------
ThreadPlanPython::ThreadPlanPython(Thread &thread, const char *class_name)
: ThreadPlan(ThreadPlan::eKindPython, "Python based Thread Plan", thread,
Modified: lldb/trunk/source/Target/ThreadPlanRunToAddress.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanRunToAddress.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanRunToAddress.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanRunToAddress.cpp Wed Apr 10 13:48:55 2019
@@ -17,9 +17,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlanRunToAddress: Continue plan
-//----------------------------------------------------------------------
ThreadPlanRunToAddress::ThreadPlanRunToAddress(Thread &thread, Address &address,
bool stop_others)
Modified: lldb/trunk/source/Target/ThreadPlanShouldStopHere.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanShouldStopHere.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanShouldStopHere.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanShouldStopHere.cpp Wed Apr 10 13:48:55 2019
@@ -15,9 +15,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlanShouldStopHere constructor
-//----------------------------------------------------------------------
ThreadPlanShouldStopHere::ThreadPlanShouldStopHere(ThreadPlan *owner)
: m_callbacks(), m_baton(nullptr), m_owner(owner),
m_flags(ThreadPlanShouldStopHere::eNone) {
Modified: lldb/trunk/source/Target/ThreadPlanStepInRange.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanStepInRange.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanStepInRange.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanStepInRange.cpp Wed Apr 10 13:48:55 2019
@@ -28,10 +28,8 @@ using namespace lldb_private;
uint32_t ThreadPlanStepInRange::s_default_flag_values =
ThreadPlanShouldStopHere::eStepInAvoidNoDebug;
-//----------------------------------------------------------------------
// ThreadPlanStepInRange: Step through a stack range, either stepping over or
// into based on the value of \a type.
-//----------------------------------------------------------------------
ThreadPlanStepInRange::ThreadPlanStepInRange(
Thread &thread, const AddressRange &range,
Modified: lldb/trunk/source/Target/ThreadPlanStepInstruction.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanStepInstruction.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanStepInstruction.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanStepInstruction.cpp Wed Apr 10 13:48:55 2019
@@ -18,9 +18,7 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlanStepInstruction: Step over the current instruction
-//----------------------------------------------------------------------
ThreadPlanStepInstruction::ThreadPlanStepInstruction(Thread &thread,
bool step_over,
Modified: lldb/trunk/source/Target/ThreadPlanStepOut.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanStepOut.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanStepOut.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanStepOut.cpp Wed Apr 10 13:48:55 2019
@@ -30,9 +30,7 @@ using namespace lldb_private;
uint32_t ThreadPlanStepOut::s_default_flag_values = 0;
-//----------------------------------------------------------------------
// ThreadPlanStepOut: Step out of the current frame
-//----------------------------------------------------------------------
ThreadPlanStepOut::ThreadPlanStepOut(
Thread &thread, SymbolContext *context, bool first_insn, bool stop_others,
Vote stop_vote, Vote run_vote, uint32_t frame_idx,
Modified: lldb/trunk/source/Target/ThreadPlanStepOverBreakpoint.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanStepOverBreakpoint.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanStepOverBreakpoint.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanStepOverBreakpoint.cpp Wed Apr 10 13:48:55 2019
@@ -16,10 +16,8 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlanStepOverBreakpoint: Single steps over a breakpoint bp_site_sp at
// the pc.
-//----------------------------------------------------------------------
ThreadPlanStepOverBreakpoint::ThreadPlanStepOverBreakpoint(Thread &thread)
: ThreadPlan(
Modified: lldb/trunk/source/Target/ThreadPlanStepOverRange.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanStepOverRange.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanStepOverRange.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanStepOverRange.cpp Wed Apr 10 13:48:55 2019
@@ -25,10 +25,8 @@ using namespace lldb;
uint32_t ThreadPlanStepOverRange::s_default_flag_values = 0;
-//----------------------------------------------------------------------
// ThreadPlanStepOverRange: Step through a stack range, either stepping over or
// into based on the value of \a type.
-//----------------------------------------------------------------------
ThreadPlanStepOverRange::ThreadPlanStepOverRange(
Thread &thread, const AddressRange &range,
Modified: lldb/trunk/source/Target/ThreadPlanStepRange.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanStepRange.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanStepRange.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanStepRange.cpp Wed Apr 10 13:48:55 2019
@@ -25,10 +25,8 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlanStepRange: Step through a stack range, either stepping over or
// into based on the value of \a type.
-//----------------------------------------------------------------------
ThreadPlanStepRange::ThreadPlanStepRange(ThreadPlanKind kind, const char *name,
Thread &thread,
Modified: lldb/trunk/source/Target/ThreadPlanStepThrough.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanStepThrough.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanStepThrough.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanStepThrough.cpp Wed Apr 10 13:48:55 2019
@@ -20,12 +20,10 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlanStepThrough: If the current instruction is a trampoline, step
// through it If it is the beginning of the prologue of a function, step
// through that as well.
// FIXME: At present only handles DYLD trampolines.
-//----------------------------------------------------------------------
ThreadPlanStepThrough::ThreadPlanStepThrough(Thread &thread,
StackID &m_stack_id,
Modified: lldb/trunk/source/Target/ThreadPlanStepUntil.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanStepUntil.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanStepUntil.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanStepUntil.cpp Wed Apr 10 13:48:55 2019
@@ -19,10 +19,8 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// ThreadPlanStepUntil: Run until we reach a given line number or step out of
// the current frame
-//----------------------------------------------------------------------
ThreadPlanStepUntil::ThreadPlanStepUntil(Thread &thread,
lldb::addr_t *address_list,
Modified: lldb/trunk/source/Target/UnixSignals.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/UnixSignals.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Target/UnixSignals.cpp (original)
+++ lldb/trunk/source/Target/UnixSignals.cpp Wed Apr 10 13:48:55 2019
@@ -57,9 +57,7 @@ lldb::UnixSignalsSP UnixSignals::CreateF
return s_unix_signals_sp;
}
-//----------------------------------------------------------------------
// UnixSignals constructor
-//----------------------------------------------------------------------
UnixSignals::UnixSignals() { Reset(); }
UnixSignals::UnixSignals(const UnixSignals &rhs) : m_signals(rhs.m_signals) {}
Modified: lldb/trunk/source/Utility/Args.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/Args.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/Args.cpp (original)
+++ lldb/trunk/source/Utility/Args.cpp Wed Apr 10 13:48:55 2019
@@ -165,9 +165,7 @@ Args::ArgEntry::ArgEntry(llvm::StringRef
ref = llvm::StringRef(c_str(), size);
}
-//----------------------------------------------------------------------
// Args constructor
-//----------------------------------------------------------------------
Args::Args(llvm::StringRef command) { SetCommandString(command); }
Args::Args(const Args &rhs) { *this = rhs; }
@@ -190,9 +188,7 @@ Args &Args::operator=(const Args &rhs) {
return *this;
}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
Args::~Args() {}
void Args::Dump(Stream &s, const char *label_name) const {
Modified: lldb/trunk/source/Utility/ConstString.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/ConstString.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/ConstString.cpp (original)
+++ lldb/trunk/source/Utility/ConstString.cpp Wed Apr 10 13:48:55 2019
@@ -149,10 +149,8 @@ public:
return nullptr;
}
- //------------------------------------------------------------------
// Return the size in bytes that this object and any items in its collection
// of uniqued strings + data count values takes in memory.
- //------------------------------------------------------------------
size_t MemorySize() const {
size_t mem_size = sizeof(Pool);
for (const auto &pool : m_string_pools) {
@@ -177,7 +175,6 @@ protected:
std::array<PoolEntry, 256> m_string_pools;
};
-//----------------------------------------------------------------------
// Frameworks and dylibs aren't supposed to have global C++ initializers so we
// hide the string pool in a static function so that it will get initialized on
// the first call to this static function.
@@ -186,7 +183,6 @@ protected:
// can't guarantee that some objects won't get destroyed after the global
// destructor chain is run, and trying to make sure no destructors touch
// ConstStrings is difficult. So we leak the pool instead.
-//----------------------------------------------------------------------
static Pool &StringPool() {
static llvm::once_flag g_pool_initialization_flag;
static Pool *g_string_pool = nullptr;
Modified: lldb/trunk/source/Utility/DataBufferHeap.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/DataBufferHeap.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/DataBufferHeap.cpp (original)
+++ lldb/trunk/source/Utility/DataBufferHeap.cpp Wed Apr 10 13:48:55 2019
@@ -11,57 +11,41 @@
using namespace lldb_private;
-//----------------------------------------------------------------------
// Default constructor
-//----------------------------------------------------------------------
DataBufferHeap::DataBufferHeap() : m_data() {}
-//----------------------------------------------------------------------
// Initialize this class with "n" characters and fill the buffer with "ch".
-//----------------------------------------------------------------------
DataBufferHeap::DataBufferHeap(lldb::offset_t n, uint8_t ch) : m_data() {
if (n < m_data.max_size())
m_data.assign(n, ch);
}
-//----------------------------------------------------------------------
// Initialize this class with a copy of the "n" bytes from the "bytes" buffer.
-//----------------------------------------------------------------------
DataBufferHeap::DataBufferHeap(const void *src, lldb::offset_t src_len)
: m_data() {
CopyData(src, src_len);
}
-//----------------------------------------------------------------------
// Virtual destructor since this class inherits from a pure virtual base class.
-//----------------------------------------------------------------------
DataBufferHeap::~DataBufferHeap() = default;
-//----------------------------------------------------------------------
// Return a pointer to the bytes owned by this object, or nullptr if the object
// contains no bytes.
-//----------------------------------------------------------------------
uint8_t *DataBufferHeap::GetBytes() {
return (m_data.empty() ? nullptr : m_data.data());
}
-//----------------------------------------------------------------------
// Return a const pointer to the bytes owned by this object, or nullptr if the
// object contains no bytes.
-//----------------------------------------------------------------------
const uint8_t *DataBufferHeap::GetBytes() const {
return (m_data.empty() ? nullptr : m_data.data());
}
-//----------------------------------------------------------------------
// Return the number of bytes this object currently contains.
-//----------------------------------------------------------------------
uint64_t DataBufferHeap::GetByteSize() const { return m_data.size(); }
-//----------------------------------------------------------------------
// Sets the number of bytes that this object should be able to contain. This
// can be used prior to copying data into the buffer.
-//----------------------------------------------------------------------
uint64_t DataBufferHeap::SetByteSize(uint64_t new_size) {
m_data.resize(new_size);
return m_data.size();
Modified: lldb/trunk/source/Utility/DataEncoder.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/DataEncoder.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/DataEncoder.cpp (original)
+++ lldb/trunk/source/Utility/DataEncoder.cpp Wed Apr 10 13:48:55 2019
@@ -24,29 +24,23 @@ using namespace lldb;
using namespace lldb_private;
using namespace llvm::support::endian;
-//----------------------------------------------------------------------
// Default constructor.
-//----------------------------------------------------------------------
DataEncoder::DataEncoder()
: m_start(nullptr), m_end(nullptr),
m_byte_order(endian::InlHostByteOrder()), m_addr_size(sizeof(void *)),
m_data_sp() {}
-//----------------------------------------------------------------------
// This constructor allows us to use data that is owned by someone else. The
// data must stay around as long as this object is valid.
-//----------------------------------------------------------------------
DataEncoder::DataEncoder(void *data, uint32_t length, ByteOrder endian,
uint8_t addr_size)
: m_start((uint8_t *)data), m_end((uint8_t *)data + length),
m_byte_order(endian), m_addr_size(addr_size), m_data_sp() {}
-//----------------------------------------------------------------------
// Make a shared pointer reference to the shared data in "data_sp" and set the
// endian swapping setting to "swap", and the address size to "addr_size". The
// shared data reference will ensure the data lives as long as any DataEncoder
// objects exist that have a reference to this data.
-//----------------------------------------------------------------------
DataEncoder::DataEncoder(const DataBufferSP &data_sp, ByteOrder endian,
uint8_t addr_size)
: m_start(nullptr), m_end(nullptr), m_byte_order(endian),
@@ -56,10 +50,8 @@ DataEncoder::DataEncoder(const DataBuffe
DataEncoder::~DataEncoder() = default;
-//------------------------------------------------------------------
// Clears the object contents back to a default invalid state, and release any
// references to shared data that this object may contain.
-//------------------------------------------------------------------
void DataEncoder::Clear() {
m_start = nullptr;
m_end = nullptr;
@@ -68,10 +60,8 @@ void DataEncoder::Clear() {
m_data_sp.reset();
}
-//------------------------------------------------------------------
// If this object contains shared data, this function returns the offset into
// that shared data. Else zero is returned.
-//------------------------------------------------------------------
size_t DataEncoder::GetSharedDataOffset() const {
if (m_start != nullptr) {
const DataBuffer *data = m_data_sp.get();
@@ -86,7 +76,6 @@ size_t DataEncoder::GetSharedDataOffset(
return 0;
}
-//----------------------------------------------------------------------
// Set the data with which this object will extract from to data starting at
// BYTES and set the length of the data to LENGTH bytes long. The data is
// externally owned must be around at least as long as this object points to
@@ -94,7 +83,6 @@ size_t DataEncoder::GetSharedDataOffset(
// and can extract from it. If this object refers to any shared data upon
// entry, the reference to that data will be released. Is SWAP is set to true,
// any data extracted will be endian swapped.
-//----------------------------------------------------------------------
uint32_t DataEncoder::SetData(void *bytes, uint32_t length, ByteOrder endian) {
m_byte_order = endian;
m_data_sp.reset();
@@ -108,7 +96,6 @@ uint32_t DataEncoder::SetData(void *byte
return GetByteSize();
}
-//----------------------------------------------------------------------
// Assign the data for this object to be a subrange of the shared data in
// "data_sp" starting "data_offset" bytes into "data_sp" and ending
// "data_length" bytes later. If "data_offset" is not a valid offset into
@@ -120,7 +107,6 @@ uint32_t DataEncoder::SetData(void *byte
// starting at "data_offset") to ensure the data stays around as long as it is
// needed. The address size and endian swap settings will remain unchanged from
// their current settings.
-//----------------------------------------------------------------------
uint32_t DataEncoder::SetData(const DataBufferSP &data_sp, uint32_t data_offset,
uint32_t data_length) {
m_start = m_end = nullptr;
@@ -152,12 +138,10 @@ uint32_t DataEncoder::SetData(const Data
return new_size;
}
-//----------------------------------------------------------------------
// Extract a single unsigned char from the binary data and update the offset
// pointed to by "offset_ptr".
//
// RETURNS the byte that was extracted, or zero on failure.
-//----------------------------------------------------------------------
uint32_t DataEncoder::PutU8(uint32_t offset, uint8_t value) {
if (ValidOffset(offset)) {
m_start[offset] = value;
@@ -202,7 +186,6 @@ uint32_t DataEncoder::PutU64(uint32_t of
return UINT32_MAX;
}
-//----------------------------------------------------------------------
// Extract a single integer value from the data and update the offset pointed
// to by "offset_ptr". The size of the extracted integer is specified by the
// "byte_size" argument. "byte_size" should have a value >= 1 and <= 8 since
@@ -211,7 +194,6 @@ uint32_t DataEncoder::PutU64(uint32_t of
// returned.
//
// RETURNS the integer value that was extracted, or zero on failure.
-//----------------------------------------------------------------------
uint32_t DataEncoder::PutMaxU64(uint32_t offset, uint32_t byte_size,
uint64_t value) {
switch (byte_size) {
Modified: lldb/trunk/source/Utility/DataExtractor.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/DataExtractor.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/DataExtractor.cpp (original)
+++ lldb/trunk/source/Utility/DataExtractor.cpp Wed Apr 10 13:48:55 2019
@@ -124,10 +124,8 @@ DataExtractor::DataExtractor()
m_byte_order(endian::InlHostByteOrder()), m_addr_size(sizeof(void *)),
m_data_sp(), m_target_byte_size(1) {}
-//----------------------------------------------------------------------
// This constructor allows us to use data that is owned by someone else. The
// data must stay around as long as this object is valid.
-//----------------------------------------------------------------------
DataExtractor::DataExtractor(const void *data, offset_t length,
ByteOrder endian, uint32_t addr_size,
uint32_t target_byte_size /*=1*/)
@@ -139,12 +137,10 @@ DataExtractor::DataExtractor(const void
assert(addr_size == 4 || addr_size == 8);
}
-//----------------------------------------------------------------------
// Make a shared pointer reference to the shared data in "data_sp" and set the
// endian swapping setting to "swap", and the address size to "addr_size". The
// shared data reference will ensure the data lives as long as any
// DataExtractor objects exist that have a reference to this data.
-//----------------------------------------------------------------------
DataExtractor::DataExtractor(const DataBufferSP &data_sp, ByteOrder endian,
uint32_t addr_size,
uint32_t target_byte_size /*=1*/)
@@ -155,13 +151,11 @@ DataExtractor::DataExtractor(const DataB
SetData(data_sp);
}
-//----------------------------------------------------------------------
// Initialize this object with a subset of the data bytes in "data". If "data"
// contains shared data, then a reference to this shared data will added and
// the shared data will stay around as long as any object contains a reference
// to that data. The endian swap and address size settings are copied from
// "data".
-//----------------------------------------------------------------------
DataExtractor::DataExtractor(const DataExtractor &data, offset_t offset,
offset_t length, uint32_t target_byte_size /*=1*/)
: m_start(nullptr), m_end(nullptr), m_byte_order(data.m_byte_order),
@@ -183,9 +177,7 @@ DataExtractor::DataExtractor(const DataE
assert(m_addr_size == 4 || m_addr_size == 8);
}
-//----------------------------------------------------------------------
// Assignment operator
-//----------------------------------------------------------------------
const DataExtractor &DataExtractor::operator=(const DataExtractor &rhs) {
if (this != &rhs) {
m_start = rhs.m_start;
@@ -199,10 +191,8 @@ const DataExtractor &DataExtractor::oper
DataExtractor::~DataExtractor() = default;
-//------------------------------------------------------------------
// Clears the object contents back to a default invalid state, and release any
// references to shared data that this object may contain.
-//------------------------------------------------------------------
void DataExtractor::Clear() {
m_start = nullptr;
m_end = nullptr;
@@ -211,10 +201,8 @@ void DataExtractor::Clear() {
m_data_sp.reset();
}
-//------------------------------------------------------------------
// If this object contains shared data, this function returns the offset into
// that shared data. Else zero is returned.
-//------------------------------------------------------------------
size_t DataExtractor::GetSharedDataOffset() const {
if (m_start != nullptr) {
const DataBuffer *data = m_data_sp.get();
@@ -229,7 +217,6 @@ size_t DataExtractor::GetSharedDataOffse
return 0;
}
-//----------------------------------------------------------------------
// Set the data with which this object will extract from to data starting at
// BYTES and set the length of the data to LENGTH bytes long. The data is
// externally owned must be around at least as long as this object points to
@@ -237,7 +224,6 @@ size_t DataExtractor::GetSharedDataOffse
// and can extract from it. If this object refers to any shared data upon
// entry, the reference to that data will be released. Is SWAP is set to true,
// any data extracted will be endian swapped.
-//----------------------------------------------------------------------
lldb::offset_t DataExtractor::SetData(const void *bytes, offset_t length,
ByteOrder endian) {
m_byte_order = endian;
@@ -252,7 +238,6 @@ lldb::offset_t DataExtractor::SetData(co
return GetByteSize();
}
-//----------------------------------------------------------------------
// Assign the data for this object to be a subrange in "data" starting
// "data_offset" bytes into "data" and ending "data_length" bytes later. If
// "data_offset" is not a valid offset into "data", then this object will
@@ -263,7 +248,6 @@ lldb::offset_t DataExtractor::SetData(co
// a shared pointer to data, then the bytes referred to in "data" will need to
// exist at least as long as this object refers to those bytes. The address
// size and endian swap settings are copied from the current values in "data".
-//----------------------------------------------------------------------
lldb::offset_t DataExtractor::SetData(const DataExtractor &data,
offset_t data_offset,
offset_t data_length) {
@@ -286,7 +270,6 @@ lldb::offset_t DataExtractor::SetData(co
return 0;
}
-//----------------------------------------------------------------------
// Assign the data for this object to be a subrange of the shared data in
// "data_sp" starting "data_offset" bytes into "data_sp" and ending
// "data_length" bytes later. If "data_offset" is not a valid offset into
@@ -298,7 +281,6 @@ lldb::offset_t DataExtractor::SetData(co
// starting at "data_offset") to ensure the data stays around as long as it is
// needed. The address size and endian swap settings will remain unchanged from
// their current settings.
-//----------------------------------------------------------------------
lldb::offset_t DataExtractor::SetData(const DataBufferSP &data_sp,
offset_t data_offset,
offset_t data_length) {
@@ -331,12 +313,10 @@ lldb::offset_t DataExtractor::SetData(co
return new_size;
}
-//----------------------------------------------------------------------
// Extract a single unsigned char from the binary data and update the offset
// pointed to by "offset_ptr".
//
// RETURNS the byte that was extracted, or zero on failure.
-//----------------------------------------------------------------------
uint8_t DataExtractor::GetU8(offset_t *offset_ptr) const {
const uint8_t *data = (const uint8_t *)GetData(offset_ptr, 1);
if (data)
@@ -344,14 +324,12 @@ uint8_t DataExtractor::GetU8(offset_t *o
return 0;
}
-//----------------------------------------------------------------------
// Extract "count" unsigned chars from the binary data and update the offset
// pointed to by "offset_ptr". The extracted data is copied into "dst".
//
// RETURNS the non-nullptr buffer pointer upon successful extraction of
// all the requested bytes, or nullptr when the data is not available in the
// buffer due to being out of bounds, or insufficient data.
-//----------------------------------------------------------------------
void *DataExtractor::GetU8(offset_t *offset_ptr, void *dst,
uint32_t count) const {
const uint8_t *data = (const uint8_t *)GetData(offset_ptr, count);
@@ -365,12 +343,10 @@ void *DataExtractor::GetU8(offset_t *off
return nullptr;
}
-//----------------------------------------------------------------------
// Extract a single uint16_t from the data and update the offset pointed to by
// "offset_ptr".
//
// RETURNS the uint16_t that was extracted, or zero on failure.
-//----------------------------------------------------------------------
uint16_t DataExtractor::GetU16(offset_t *offset_ptr) const {
uint16_t val = 0;
const uint8_t *data = (const uint8_t *)GetData(offset_ptr, sizeof(val));
@@ -413,14 +389,12 @@ uint64_t DataExtractor::GetU64_unchecked
return val;
}
-//----------------------------------------------------------------------
// Extract "count" uint16_t values from the binary data and update the offset
// pointed to by "offset_ptr". The extracted data is copied into "dst".
//
// RETURNS the non-nullptr buffer pointer upon successful extraction of
// all the requested bytes, or nullptr when the data is not available in the
// buffer due to being out of bounds, or insufficient data.
-//----------------------------------------------------------------------
void *DataExtractor::GetU16(offset_t *offset_ptr, void *void_dst,
uint32_t count) const {
const size_t src_size = sizeof(uint16_t) * count;
@@ -445,12 +419,10 @@ void *DataExtractor::GetU16(offset_t *of
return nullptr;
}
-//----------------------------------------------------------------------
// Extract a single uint32_t from the data and update the offset pointed to by
// "offset_ptr".
//
// RETURNS the uint32_t that was extracted, or zero on failure.
-//----------------------------------------------------------------------
uint32_t DataExtractor::GetU32(offset_t *offset_ptr) const {
uint32_t val = 0;
const uint8_t *data = (const uint8_t *)GetData(offset_ptr, sizeof(val));
@@ -464,14 +436,12 @@ uint32_t DataExtractor::GetU32(offset_t
return val;
}
-//----------------------------------------------------------------------
// Extract "count" uint32_t values from the binary data and update the offset
// pointed to by "offset_ptr". The extracted data is copied into "dst".
//
// RETURNS the non-nullptr buffer pointer upon successful extraction of
// all the requested bytes, or nullptr when the data is not available in the
// buffer due to being out of bounds, or insufficient data.
-//----------------------------------------------------------------------
void *DataExtractor::GetU32(offset_t *offset_ptr, void *void_dst,
uint32_t count) const {
const size_t src_size = sizeof(uint32_t) * count;
@@ -496,12 +466,10 @@ void *DataExtractor::GetU32(offset_t *of
return nullptr;
}
-//----------------------------------------------------------------------
// Extract a single uint64_t from the data and update the offset pointed to by
// "offset_ptr".
//
// RETURNS the uint64_t that was extracted, or zero on failure.
-//----------------------------------------------------------------------
uint64_t DataExtractor::GetU64(offset_t *offset_ptr) const {
uint64_t val = 0;
const uint8_t *data = (const uint8_t *)GetData(offset_ptr, sizeof(val));
@@ -515,13 +483,11 @@ uint64_t DataExtractor::GetU64(offset_t
return val;
}
-//----------------------------------------------------------------------
// GetU64
//
// Get multiple consecutive 64 bit values. Return true if the entire read
// succeeds and increment the offset pointed to by offset_ptr, else return
// false and leave the offset pointed to by offset_ptr unchanged.
-//----------------------------------------------------------------------
void *DataExtractor::GetU64(offset_t *offset_ptr, void *void_dst,
uint32_t count) const {
const size_t src_size = sizeof(uint64_t) * count;
@@ -687,14 +653,12 @@ long double DataExtractor::GetLongDouble
return val;
}
-//------------------------------------------------------------------
// Extract a single address from the data and update the offset pointed to by
// "offset_ptr". The size of the extracted address comes from the
// "this->m_addr_size" member variable and should be set correctly prior to
// extracting any address values.
//
// RETURNS the address that was extracted, or zero on failure.
-//------------------------------------------------------------------
uint64_t DataExtractor::GetAddress(offset_t *offset_ptr) const {
assert(m_addr_size == 4 || m_addr_size == 8);
return GetMaxU64(offset_ptr, m_addr_size);
@@ -705,14 +669,12 @@ uint64_t DataExtractor::GetAddress_unche
return GetMaxU64_unchecked(offset_ptr, m_addr_size);
}
-//------------------------------------------------------------------
// Extract a single pointer from the data and update the offset pointed to by
// "offset_ptr". The size of the extracted pointer comes from the
// "this->m_addr_size" member variable and should be set correctly prior to
// extracting any pointer values.
//
// RETURNS the pointer that was extracted, or zero on failure.
-//------------------------------------------------------------------
uint64_t DataExtractor::GetPointer(offset_t *offset_ptr) const {
assert(m_addr_size == 4 || m_addr_size == 8);
return GetMaxU64(offset_ptr, m_addr_size);
@@ -836,7 +798,6 @@ DataExtractor::CopyByteOrderedData(offse
return 0;
}
-//----------------------------------------------------------------------
// Extracts a variable length NULL terminated C string from the data at the
// offset pointed to by "offset_ptr". The "offset_ptr" will be updated with
// the offset of the byte that follows the NULL terminator byte.
@@ -844,7 +805,6 @@ DataExtractor::CopyByteOrderedData(offse
// If the offset pointed to by "offset_ptr" is out of bounds, or if "length" is
// non-zero and there aren't enough available bytes, nullptr will be returned
// and "offset_ptr" will not be updated.
-//----------------------------------------------------------------------
const char *DataExtractor::GetCStr(offset_t *offset_ptr) const {
const char *cstr = (const char *)PeekData(*offset_ptr, 1);
if (cstr) {
@@ -868,7 +828,6 @@ const char *DataExtractor::GetCStr(offse
return nullptr;
}
-//----------------------------------------------------------------------
// Extracts a NULL terminated C string from the fixed length field of length
// "len" at the offset pointed to by "offset_ptr". The "offset_ptr" will be
// updated with the offset of the byte that follows the fixed length field.
@@ -877,7 +836,6 @@ const char *DataExtractor::GetCStr(offse
// plus the length of the field is out of bounds, or if the field does not
// contain a NULL terminator byte, nullptr will be returned and "offset_ptr"
// will not be updated.
-//----------------------------------------------------------------------
const char *DataExtractor::GetCStr(offset_t *offset_ptr, offset_t len) const {
const char *cstr = (const char *)PeekData(*offset_ptr, len);
if (cstr != nullptr) {
@@ -890,26 +848,22 @@ const char *DataExtractor::GetCStr(offse
return nullptr;
}
-//------------------------------------------------------------------
// Peeks at a string in the contained data. No verification is done to make
// sure the entire string lies within the bounds of this object's data, only
// "offset" is verified to be a valid offset.
//
// Returns a valid C string pointer if "offset" is a valid offset in this
// object's data, else nullptr is returned.
-//------------------------------------------------------------------
const char *DataExtractor::PeekCStr(offset_t offset) const {
return (const char *)PeekData(offset, 1);
}
-//----------------------------------------------------------------------
// Extracts an unsigned LEB128 number from this object's data starting at the
// offset pointed to by "offset_ptr". The offset pointed to by "offset_ptr"
// will be updated with the offset of the byte following the last extracted
// byte.
//
// Returned the extracted integer value.
-//----------------------------------------------------------------------
uint64_t DataExtractor::GetULEB128(offset_t *offset_ptr) const {
const uint8_t *src = (const uint8_t *)PeekData(*offset_ptr, 1);
if (src == nullptr)
@@ -937,14 +891,12 @@ uint64_t DataExtractor::GetULEB128(offse
return 0;
}
-//----------------------------------------------------------------------
// Extracts an signed LEB128 number from this object's data starting at the
// offset pointed to by "offset_ptr". The offset pointed to by "offset_ptr"
// will be updated with the offset of the byte following the last extracted
// byte.
//
// Returned the extracted integer value.
-//----------------------------------------------------------------------
int64_t DataExtractor::GetSLEB128(offset_t *offset_ptr) const {
const uint8_t *src = (const uint8_t *)PeekData(*offset_ptr, 1);
if (src == nullptr)
@@ -979,14 +931,12 @@ int64_t DataExtractor::GetSLEB128(offset
return 0;
}
-//----------------------------------------------------------------------
// Skips a ULEB128 number (signed or unsigned) from this object's data starting
// at the offset pointed to by "offset_ptr". The offset pointed to by
// "offset_ptr" will be updated with the offset of the byte following the last
// extracted byte.
//
// Returns the number of bytes consumed during the extraction.
-//----------------------------------------------------------------------
uint32_t DataExtractor::Skip_LEB128(offset_t *offset_ptr) const {
uint32_t bytes_consumed = 0;
const uint8_t *src = (const uint8_t *)PeekData(*offset_ptr, 1);
@@ -1004,7 +954,6 @@ uint32_t DataExtractor::Skip_LEB128(offs
return bytes_consumed;
}
-//----------------------------------------------------------------------
// Dumps bytes from this object's data to the stream "s" starting
// "start_offset" bytes into this data, and ending with the byte before
// "end_offset". "base_addr" will be added to the offset into the dumped data
@@ -1014,7 +963,6 @@ uint32_t DataExtractor::Skip_LEB128(offs
// printf style formatting string. If "type_format" is nullptr, then an
// appropriate format string will be used for the supplied "type". If the
// stream "s" is nullptr, then the output will be send to Log().
-//----------------------------------------------------------------------
lldb::offset_t DataExtractor::PutToLog(Log *log, offset_t start_offset,
offset_t length, uint64_t base_addr,
uint32_t num_per_line,
Modified: lldb/trunk/source/Utility/Event.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/Event.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/Event.cpp (original)
+++ lldb/trunk/source/Utility/Event.cpp Wed Apr 10 13:48:55 2019
@@ -25,9 +25,7 @@ using namespace lldb_private;
#pragma mark -
#pragma mark Event
-//------------------------------------------------------------------
// Event functions
-//------------------------------------------------------------------
Event::Event(Broadcaster *broadcaster, uint32_t event_type, EventData *data)
: m_broadcaster_wp(broadcaster->GetBroadcasterImpl()), m_type(event_type),
@@ -87,9 +85,7 @@ void Event::DoOnRemoval() {
#pragma mark -
#pragma mark EventData
-//------------------------------------------------------------------
// EventData functions
-//------------------------------------------------------------------
EventData::EventData() = default;
@@ -100,9 +96,7 @@ void EventData::Dump(Stream *s) const {
#pragma mark -
#pragma mark EventDataBytes
-//------------------------------------------------------------------
// EventDataBytes functions
-//------------------------------------------------------------------
EventDataBytes::EventDataBytes() : m_bytes() {}
@@ -193,9 +187,7 @@ void EventDataBytes::SwapBytes(std::stri
#pragma mark -
#pragma mark EventStructuredData
-//------------------------------------------------------------------
// EventDataStructuredData definitions
-//------------------------------------------------------------------
EventDataStructuredData::EventDataStructuredData()
: EventData(), m_process_sp(), m_object_sp(), m_plugin_sp() {}
@@ -208,9 +200,7 @@ EventDataStructuredData::EventDataStruct
EventDataStructuredData::~EventDataStructuredData() {}
-//------------------------------------------------------------------
// EventDataStructuredData member functions
-//------------------------------------------------------------------
ConstString EventDataStructuredData::GetFlavor() const {
return EventDataStructuredData::GetFlavorString();
@@ -251,9 +241,7 @@ void EventDataStructuredData::SetStructu
m_plugin_sp = plugin_sp;
}
-//------------------------------------------------------------------
// EventDataStructuredData static functions
-//------------------------------------------------------------------
const EventDataStructuredData *
EventDataStructuredData::GetEventDataFromEvent(const Event *event_ptr) {
Modified: lldb/trunk/source/Utility/FileSpec.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/FileSpec.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/FileSpec.cpp (original)
+++ lldb/trunk/source/Utility/FileSpec.cpp Wed Apr 10 13:48:55 2019
@@ -67,9 +67,7 @@ void Denormalize(llvm::SmallVectorImpl<c
FileSpec::FileSpec() : m_style(GetNativeStyle()) {}
-//------------------------------------------------------------------
// Default constructor that can take an optional full path to a file on disk.
-//------------------------------------------------------------------
FileSpec::FileSpec(llvm::StringRef path, Style style) : m_style(style) {
SetFile(path, style);
}
@@ -77,28 +75,21 @@ FileSpec::FileSpec(llvm::StringRef path,
FileSpec::FileSpec(llvm::StringRef path, const llvm::Triple &Triple)
: FileSpec{path, Triple.isOSWindows() ? Style::windows : Style::posix} {}
-//------------------------------------------------------------------
// Copy constructor
-//------------------------------------------------------------------
FileSpec::FileSpec(const FileSpec &rhs)
: m_directory(rhs.m_directory), m_filename(rhs.m_filename),
m_is_resolved(rhs.m_is_resolved), m_style(rhs.m_style) {}
-//------------------------------------------------------------------
// Copy constructor
-//------------------------------------------------------------------
FileSpec::FileSpec(const FileSpec *rhs) : m_directory(), m_filename() {
if (rhs)
*this = *rhs;
}
-//------------------------------------------------------------------
// Virtual destructor in case anyone inherits from this class.
-//------------------------------------------------------------------
FileSpec::~FileSpec() {}
namespace {
-//------------------------------------------------------------------
/// Safely get a character at the specified index.
///
/// \param[in] path
@@ -110,14 +101,12 @@ namespace {
/// \return
/// The character at index \a i if the index is valid, or 0 if
/// the index is not valid.
-//------------------------------------------------------------------
inline char safeCharAtIndex(const llvm::StringRef &path, size_t i) {
if (i < path.size())
return path[i];
return 0;
}
-//------------------------------------------------------------------
/// Check if a path needs to be normalized.
///
/// Check if a path needs to be normalized. We currently consider a
@@ -135,7 +124,6 @@ inline char safeCharAtIndex(const llvm::
///
/// \return
/// Returns \b true if the path needs to be normalized.
-//------------------------------------------------------------------
bool needsNormalization(const llvm::StringRef &path) {
if (path.empty())
return false;
@@ -191,9 +179,7 @@ bool needsNormalization(const llvm::Stri
}
-//------------------------------------------------------------------
// Assignment operator.
-//------------------------------------------------------------------
const FileSpec &FileSpec::operator=(const FileSpec &rhs) {
if (this != &rhs) {
m_directory = rhs.m_directory;
@@ -206,11 +192,9 @@ const FileSpec &FileSpec::operator=(cons
void FileSpec::SetFile(llvm::StringRef pathname) { SetFile(pathname, m_style); }
-//------------------------------------------------------------------
// Update the contents of this object with a new path. The path will be split
// up into a directory and filename and stored as uniqued string values for
// quick comparison and efficient memory usage.
-//------------------------------------------------------------------
void FileSpec::SetFile(llvm::StringRef pathname, Style style) {
m_filename.Clear();
m_directory.Clear();
@@ -253,22 +237,18 @@ void FileSpec::SetFile(llvm::StringRef p
return SetFile(path, Triple.isOSWindows() ? Style::windows : Style::posix);
}
-//----------------------------------------------------------------------
// Convert to pointer operator. This allows code to check any FileSpec objects
// to see if they contain anything valid using code such as:
//
// if (file_spec)
// {}
-//----------------------------------------------------------------------
FileSpec::operator bool() const { return m_filename || m_directory; }
-//----------------------------------------------------------------------
// Logical NOT operator. This allows code to check any FileSpec objects to see
// if they are invalid using code such as:
//
// if (!file_spec)
// {}
-//----------------------------------------------------------------------
bool FileSpec::operator!() const { return !m_directory && !m_filename; }
bool FileSpec::DirectoryEquals(const FileSpec &rhs) const {
@@ -281,43 +261,32 @@ bool FileSpec::FileEquals(const FileSpec
return ConstString::Equals(m_filename, rhs.m_filename, case_sensitive);
}
-//------------------------------------------------------------------
// Equal to operator
-//------------------------------------------------------------------
bool FileSpec::operator==(const FileSpec &rhs) const {
return FileEquals(rhs) && DirectoryEquals(rhs);
}
-//------------------------------------------------------------------
// Not equal to operator
-//------------------------------------------------------------------
bool FileSpec::operator!=(const FileSpec &rhs) const { return !(*this == rhs); }
-//------------------------------------------------------------------
// Less than operator
-//------------------------------------------------------------------
bool FileSpec::operator<(const FileSpec &rhs) const {
return FileSpec::Compare(*this, rhs, true) < 0;
}
-//------------------------------------------------------------------
// Dump a FileSpec object to a stream
-//------------------------------------------------------------------
Stream &lldb_private::operator<<(Stream &s, const FileSpec &f) {
f.Dump(&s);
return s;
}
-//------------------------------------------------------------------
// Clear this object by releasing both the directory and filename string values
// and making them both the empty string.
-//------------------------------------------------------------------
void FileSpec::Clear() {
m_directory.Clear();
m_filename.Clear();
}
-//------------------------------------------------------------------
// Compare two FileSpec objects. If "full" is true, then both the directory and
// the filename must match. If "full" is false, then the directory names for
// "a" and "b" are only compared if they are both non-empty. This allows a
@@ -326,7 +295,6 @@ void FileSpec::Clear() {
//
// Return -1 if the "a" is less than "b", 0 if "a" is equal to "b" and "1" if
// "a" is greater than "b".
-//------------------------------------------------------------------
int FileSpec::Compare(const FileSpec &a, const FileSpec &b, bool full) {
int result = 0;
@@ -376,11 +344,9 @@ llvm::Optional<FileSpec::Style> FileSpec
return llvm::None;
}
-//------------------------------------------------------------------
// Dump the object to the supplied stream. If the object contains a valid
// directory name, it will be displayed followed by a directory delimiter, and
// the filename.
-//------------------------------------------------------------------
void FileSpec::Dump(Stream *s) const {
if (s) {
std::string path{GetPath(true)};
@@ -393,30 +359,20 @@ void FileSpec::Dump(Stream *s) const {
FileSpec::Style FileSpec::GetPathStyle() const { return m_style; }
-//------------------------------------------------------------------
// Directory string get accessor.
-//------------------------------------------------------------------
ConstString &FileSpec::GetDirectory() { return m_directory; }
-//------------------------------------------------------------------
// Directory string const get accessor.
-//------------------------------------------------------------------
ConstString FileSpec::GetDirectory() const { return m_directory; }
-//------------------------------------------------------------------
// Filename string get accessor.
-//------------------------------------------------------------------
ConstString &FileSpec::GetFilename() { return m_filename; }
-//------------------------------------------------------------------
// Filename string const get accessor.
-//------------------------------------------------------------------
ConstString FileSpec::GetFilename() const { return m_filename; }
-//------------------------------------------------------------------
// Extract the directory and path into a fixed buffer. This is needed as the
// directory and path are stored in separate string values.
-//------------------------------------------------------------------
size_t FileSpec::GetPath(char *path, size_t path_max_len,
bool denormalize) const {
if (!path)
@@ -462,10 +418,8 @@ ConstString FileSpec::GetFileNameStrippi
return ConstString(llvm::sys::path::stem(m_filename.GetStringRef(), m_style));
}
-//------------------------------------------------------------------
// Return the size in bytes that this object takes in memory. This returns the
// size in bytes of this object, not any shared string values it may refer to.
-//------------------------------------------------------------------
size_t FileSpec::MemorySize() const {
return m_filename.MemorySize() + m_directory.MemorySize();
}
@@ -526,7 +480,6 @@ bool FileSpec::RemoveLastPathComponent()
}
return false;
}
-//------------------------------------------------------------------
/// Returns true if the filespec represents an implementation source
/// file (files with a ".c", ".cpp", ".m", ".mm" (many more)
/// extension).
@@ -534,7 +487,6 @@ bool FileSpec::RemoveLastPathComponent()
/// \return
/// \b true if the filespec represents an implementation source
/// file, \b false otherwise.
-//------------------------------------------------------------------
bool FileSpec::IsSourceImplementationFile() const {
ConstString extension(GetFileNameExtension());
if (!extension)
Modified: lldb/trunk/source/Utility/Log.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/Log.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/Log.cpp (original)
+++ lldb/trunk/source/Utility/Log.cpp Wed Apr 10 13:48:55 2019
@@ -109,9 +109,7 @@ const Flags Log::GetMask() const {
void Log::PutCString(const char *cstr) { Printf("%s", cstr); }
void Log::PutString(llvm::StringRef str) { PutCString(str.str().c_str()); }
-//----------------------------------------------------------------------
// Simple variable argument logging with flags.
-//----------------------------------------------------------------------
void Log::Printf(const char *format, ...) {
va_list args;
va_start(args, format);
@@ -119,11 +117,9 @@ void Log::Printf(const char *format, ...
va_end(args);
}
-//----------------------------------------------------------------------
// All logging eventually boils down to this function call. If we have a
// callback registered, then we call the logging callback. If we have a valid
// file handle, we also log to the file.
-//----------------------------------------------------------------------
void Log::VAPrintf(const char *format, va_list args) {
llvm::SmallString<64> FinalMessage;
llvm::raw_svector_ostream Stream(FinalMessage);
@@ -137,9 +133,7 @@ void Log::VAPrintf(const char *format, v
WriteMessage(FinalMessage.str());
}
-//----------------------------------------------------------------------
// Printing of errors that are not fatal.
-//----------------------------------------------------------------------
void Log::Error(const char *format, ...) {
va_list args;
va_start(args, format);
@@ -154,9 +148,7 @@ void Log::VAError(const char *format, va
Printf("error: %s", Content.c_str());
}
-//----------------------------------------------------------------------
// Printing of warnings that are not fatal only if verbose mode is enabled.
-//----------------------------------------------------------------------
void Log::Verbose(const char *format, ...) {
if (!GetVerbose())
return;
@@ -167,9 +159,7 @@ void Log::Verbose(const char *format, ..
va_end(args);
}
-//----------------------------------------------------------------------
// Printing of warnings that are not fatal.
-//----------------------------------------------------------------------
void Log::Warning(const char *format, ...) {
llvm::SmallString<64> Content;
va_list args;
Modified: lldb/trunk/source/Utility/RegularExpression.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/RegularExpression.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/RegularExpression.cpp (original)
+++ lldb/trunk/source/Utility/RegularExpression.cpp Wed Apr 10 13:48:55 2019
@@ -12,10 +12,8 @@
#include <string>
-//----------------------------------------------------------------------
// Enable enhanced mode if it is available. This allows for things like \d for
// digit, \s for space, and many more, but it isn't available everywhere.
-//----------------------------------------------------------------------
#if defined(REG_ENHANCED)
#define DEFAULT_COMPILE_FLAGS (REG_ENHANCED | REG_EXTENDED)
#else
@@ -28,10 +26,8 @@ RegularExpression::RegularExpression() :
memset(&m_preg, 0, sizeof(m_preg));
}
-//----------------------------------------------------------------------
// Constructor that compiles "re" using "flags" and stores the resulting
// compiled regular expression into this object.
-//----------------------------------------------------------------------
RegularExpression::RegularExpression(llvm::StringRef str)
: m_re(), m_comp_err(1), m_preg() {
memset(&m_preg, 0, sizeof(m_preg));
@@ -50,15 +46,12 @@ operator=(const RegularExpression &rhs)
return *this;
}
-//----------------------------------------------------------------------
// Destructor
//
// Any previously compiled regular expression contained in this object will be
// freed.
-//----------------------------------------------------------------------
RegularExpression::~RegularExpression() { Free(); }
-//----------------------------------------------------------------------
// Compile a regular expression using the supplied regular expression text and
// flags. The compiled regular expression lives in this object so that it can
// be readily used for regular expression matches. Execute() can be called
@@ -68,7 +61,6 @@ RegularExpression::~RegularExpression()
// RETURNS
// True if the regular expression compiles successfully, false
// otherwise.
-//----------------------------------------------------------------------
bool RegularExpression::Compile(llvm::StringRef str) {
Free();
@@ -79,13 +71,11 @@ bool RegularExpression::Compile(llvm::St
return m_comp_err == 0;
}
-//----------------------------------------------------------------------
// Execute a regular expression match using the compiled regular expression
// that is already in this object against the match string "s". If any parens
// are used for regular expression matches "match_count" should indicate the
// number of regmatch_t values that are present in "match_ptr". The regular
// expression will be executed using the "execute_flags".
-//---------------------------------------------------------------------
bool RegularExpression::Execute(llvm::StringRef str, Match *match) const {
int err = 1;
if (m_comp_err == 0) {
@@ -154,19 +144,13 @@ bool RegularExpression::Match::GetMatchS
return false;
}
-//----------------------------------------------------------------------
// Returns true if the regular expression compiled and is ready for execution.
-//----------------------------------------------------------------------
bool RegularExpression::IsValid() const { return m_comp_err == 0; }
-//----------------------------------------------------------------------
// Returns the text that was used to compile the current regular expression.
-//----------------------------------------------------------------------
llvm::StringRef RegularExpression::GetText() const { return m_re; }
-//----------------------------------------------------------------------
// Free any contained compiled regular expressions.
-//----------------------------------------------------------------------
void RegularExpression::Free() {
if (m_comp_err == 0) {
m_re.clear();
Modified: lldb/trunk/source/Utility/Scalar.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/Scalar.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/Scalar.cpp (original)
+++ lldb/trunk/source/Utility/Scalar.cpp Wed Apr 10 13:48:55 2019
@@ -22,10 +22,8 @@
using namespace lldb;
using namespace lldb_private;
-//----------------------------------------------------------------------
// Promote to max type currently follows the ANSI C rule for type promotion in
// expressions.
-//----------------------------------------------------------------------
static Scalar::Type PromoteToMaxType(
const Scalar &lhs, // The const left hand side object
const Scalar &rhs, // The const right hand side object
Modified: lldb/trunk/source/Utility/SelectHelper.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/SelectHelper.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/SelectHelper.cpp (original)
+++ lldb/trunk/source/Utility/SelectHelper.cpp Wed Apr 10 13:48:55 2019
@@ -132,9 +132,7 @@ lldb_private::Status SelectHelper::Selec
fd_set *read_fdset_ptr = nullptr;
fd_set *write_fdset_ptr = nullptr;
fd_set *error_fdset_ptr = nullptr;
-//----------------------------------------------------------------------
// Initialize and zero out the fdsets
-//----------------------------------------------------------------------
#if defined(__APPLE__)
llvm::SmallVector<fd_set, 1> read_fdset;
llvm::SmallVector<fd_set, 1> write_fdset;
@@ -176,9 +174,7 @@ lldb_private::Status SelectHelper::Selec
error_fdset_ptr = &error_fdset;
}
#endif
- //----------------------------------------------------------------------
// Set the FD bits in the fdsets for read/write/error
- //----------------------------------------------------------------------
for (auto &pair : m_fd_map) {
const lldb::socket_t fd = pair.first;
@@ -192,17 +188,13 @@ lldb_private::Status SelectHelper::Selec
FD_SET(fd, error_fdset_ptr);
}
- //----------------------------------------------------------------------
// Setup our timeout time value if needed
- //----------------------------------------------------------------------
struct timeval *tv_ptr = nullptr;
struct timeval tv = {0, 0};
while (1) {
using namespace std::chrono;
- //------------------------------------------------------------------
// Setup out relative timeout based on the end time if we have one
- //------------------------------------------------------------------
if (m_end_time.hasValue()) {
tv_ptr = &tv;
const auto remaining_dur = duration_cast<microseconds>(
Modified: lldb/trunk/source/Utility/Status.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/Status.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/Status.cpp (original)
+++ lldb/trunk/source/Utility/Status.cpp Wed Apr 10 13:48:55 2019
@@ -95,9 +95,7 @@ llvm::Error Status::ToError() const {
llvm::inconvertibleErrorCode());
}
-//----------------------------------------------------------------------
// Assignment operator
-//----------------------------------------------------------------------
const Status &Status::operator=(const Status &rhs) {
if (this != &rhs) {
m_code = rhs.m_code;
@@ -126,11 +124,9 @@ static std::string RetrieveWin32ErrorStr
}
#endif
-//----------------------------------------------------------------------
// Get the error value as a NULL C string. The error string will be fetched and
// cached on demand. The cached error string value will remain until the error
// value is changed or cleared.
-//----------------------------------------------------------------------
const char *Status::AsCString(const char *default_error_str) const {
if (Success())
return nullptr;
@@ -167,35 +163,25 @@ const char *Status::AsCString(const char
return m_string.c_str();
}
-//----------------------------------------------------------------------
// Clear the error and any cached error string that it might contain.
-//----------------------------------------------------------------------
void Status::Clear() {
m_code = 0;
m_type = eErrorTypeInvalid;
m_string.clear();
}
-//----------------------------------------------------------------------
// Access the error value.
-//----------------------------------------------------------------------
Status::ValueType Status::GetError() const { return m_code; }
-//----------------------------------------------------------------------
// Access the error type.
-//----------------------------------------------------------------------
ErrorType Status::GetType() const { return m_type; }
-//----------------------------------------------------------------------
// Returns true if this object contains a value that describes an error or
// otherwise non-success result.
-//----------------------------------------------------------------------
bool Status::Fail() const { return m_code != 0; }
-//----------------------------------------------------------------------
// Set accessor for the error value to "err" and the type to
// "eErrorTypeMachKernel"
-//----------------------------------------------------------------------
void Status::SetMachError(uint32_t err) {
m_code = err;
m_type = eErrorTypeMachKernel;
@@ -226,40 +212,32 @@ int Status::SetExpressionErrorWithFormat
return length;
}
-//----------------------------------------------------------------------
// Set accessor for the error value and type.
-//----------------------------------------------------------------------
void Status::SetError(ValueType err, ErrorType type) {
m_code = err;
m_type = type;
m_string.clear();
}
-//----------------------------------------------------------------------
// Update the error value to be "errno" and update the type to be "POSIX".
-//----------------------------------------------------------------------
void Status::SetErrorToErrno() {
m_code = errno;
m_type = eErrorTypePOSIX;
m_string.clear();
}
-//----------------------------------------------------------------------
// Update the error value to be LLDB_GENERIC_ERROR and update the type to be
// "Generic".
-//----------------------------------------------------------------------
void Status::SetErrorToGenericError() {
m_code = LLDB_GENERIC_ERROR;
m_type = eErrorTypeGeneric;
m_string.clear();
}
-//----------------------------------------------------------------------
// Set accessor for the error string value for a specific error. This allows
// any string to be supplied as an error explanation. The error string value
// will remain until the error value is cleared or a new error value/type is
// assigned.
-//----------------------------------------------------------------------
void Status::SetErrorString(llvm::StringRef err_str) {
if (!err_str.empty()) {
// If we have an error string, we should always at least have an error set
@@ -270,12 +248,10 @@ void Status::SetErrorString(llvm::String
m_string = err_str;
}
-//------------------------------------------------------------------
/// Set the current error string to a formatted error string.
///
/// \param format
/// A printf style format string
-//------------------------------------------------------------------
int Status::SetErrorStringWithFormat(const char *format, ...) {
if (format != nullptr && format[0]) {
va_list args;
@@ -306,10 +282,8 @@ int Status::SetErrorStringWithVarArg(con
return 0;
}
-//----------------------------------------------------------------------
// Returns true if the error code in this object is considered a successful
// return value.
-//----------------------------------------------------------------------
bool Status::Success() const { return m_code == 0; }
bool Status::WasInterrupted() const {
Modified: lldb/trunk/source/Utility/Stream.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/Stream.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/Stream.cpp (original)
+++ lldb/trunk/source/Utility/Stream.cpp Wed Apr 10 13:48:55 2019
@@ -29,9 +29,7 @@ Stream::Stream()
: m_flags(0), m_addr_size(4), m_byte_order(endian::InlHostByteOrder()),
m_indent_level(0), m_forwarder(*this) {}
-//------------------------------------------------------------------
// Destructor
-//------------------------------------------------------------------
Stream::~Stream() {}
ByteOrder Stream::SetByteOrder(ByteOrder byte_order) {
@@ -40,14 +38,10 @@ ByteOrder Stream::SetByteOrder(ByteOrder
return old_byte_order;
}
-//------------------------------------------------------------------
// Put an offset "uval" out to the stream using the printf format in "format".
-//------------------------------------------------------------------
void Stream::Offset(uint32_t uval, const char *format) { Printf(format, uval); }
-//------------------------------------------------------------------
// Put an SLEB128 "uval" out to the stream using the printf format in "format".
-//------------------------------------------------------------------
size_t Stream::PutSLEB128(int64_t sval) {
if (m_flags.Test(eBinary))
return llvm::encodeSLEB128(sval, m_forwarder);
@@ -55,9 +49,7 @@ size_t Stream::PutSLEB128(int64_t sval)
return Printf("0x%" PRIi64, sval);
}
-//------------------------------------------------------------------
// Put an ULEB128 "uval" out to the stream using the printf format in "format".
-//------------------------------------------------------------------
size_t Stream::PutULEB128(uint64_t uval) {
if (m_flags.Test(eBinary))
return llvm::encodeULEB128(uval, m_forwarder);
@@ -65,9 +57,7 @@ size_t Stream::PutULEB128(uint64_t uval)
return Printf("0x%" PRIx64, uval);
}
-//------------------------------------------------------------------
// Print a raw NULL terminated C string to the stream.
-//------------------------------------------------------------------
size_t Stream::PutCString(llvm::StringRef str) {
size_t bytes_written = 0;
bytes_written = Write(str.data(), str.size());
@@ -78,18 +68,14 @@ size_t Stream::PutCString(llvm::StringRe
return bytes_written;
}
-//------------------------------------------------------------------
// Print a double quoted NULL terminated C string to the stream using the
// printf format in "format".
-//------------------------------------------------------------------
void Stream::QuotedCString(const char *cstr, const char *format) {
Printf(format, cstr);
}
-//------------------------------------------------------------------
// Put an address "addr" out to the stream with optional prefix and suffix
// strings.
-//------------------------------------------------------------------
void Stream::Address(uint64_t addr, uint32_t addr_size, const char *prefix,
const char *suffix) {
if (prefix == nullptr)
@@ -101,10 +87,8 @@ void Stream::Address(uint64_t addr, uint
Printf("%s0x%0*" PRIx64 "%s", prefix, addr_size * 2, (uint64_t)addr, suffix);
}
-//------------------------------------------------------------------
// Put an address range out to the stream with optional prefix and suffix
// strings.
-//------------------------------------------------------------------
void Stream::AddressRange(uint64_t lo_addr, uint64_t hi_addr,
uint32_t addr_size, const char *prefix,
const char *suffix) {
@@ -118,9 +102,7 @@ void Stream::AddressRange(uint64_t lo_ad
size_t Stream::PutChar(char ch) { return Write(&ch, 1); }
-//------------------------------------------------------------------
// Print some formatted output to the stream.
-//------------------------------------------------------------------
size_t Stream::Printf(const char *format, ...) {
va_list args;
va_start(args, format);
@@ -129,9 +111,7 @@ size_t Stream::Printf(const char *format
return result;
}
-//------------------------------------------------------------------
// Print some formatted output to the stream.
-//------------------------------------------------------------------
size_t Stream::PrintfVarArg(const char *format, va_list args) {
llvm::SmallString<1024> buf;
VASprintf(buf, format, args);
@@ -143,15 +123,11 @@ size_t Stream::PrintfVarArg(const char *
return Write(buf.c_str(), length);
}
-//------------------------------------------------------------------
// Print and End of Line character to the stream
-//------------------------------------------------------------------
size_t Stream::EOL() { return PutChar('\n'); }
-//------------------------------------------------------------------
// Indent the current line using the current indentation level and print an
// optional string following the indentation spaces.
-//------------------------------------------------------------------
size_t Stream::Indent(const char *s) {
return Printf("%*.*s%s", m_indent_level, m_indent_level, "", s ? s : "");
}
@@ -161,17 +137,13 @@ size_t Stream::Indent(llvm::StringRef st
str.str().c_str());
}
-//------------------------------------------------------------------
// Stream a character "ch" out to this stream.
-//------------------------------------------------------------------
Stream &Stream::operator<<(char ch) {
PutChar(ch);
return *this;
}
-//------------------------------------------------------------------
// Stream the NULL terminated C string out to this stream.
-//------------------------------------------------------------------
Stream &Stream::operator<<(const char *s) {
Printf("%s", s);
return *this;
@@ -182,96 +154,70 @@ Stream &Stream::operator<<(llvm::StringR
return *this;
}
-//------------------------------------------------------------------
// Stream the pointer value out to this stream.
-//------------------------------------------------------------------
Stream &Stream::operator<<(const void *p) {
Printf("0x%.*tx", (int)sizeof(const void *) * 2, (ptrdiff_t)p);
return *this;
}
-//------------------------------------------------------------------
// Stream a uint8_t "uval" out to this stream.
-//------------------------------------------------------------------
Stream &Stream::operator<<(uint8_t uval) {
PutHex8(uval);
return *this;
}
-//------------------------------------------------------------------
// Stream a uint16_t "uval" out to this stream.
-//------------------------------------------------------------------
Stream &Stream::operator<<(uint16_t uval) {
PutHex16(uval, m_byte_order);
return *this;
}
-//------------------------------------------------------------------
// Stream a uint32_t "uval" out to this stream.
-//------------------------------------------------------------------
Stream &Stream::operator<<(uint32_t uval) {
PutHex32(uval, m_byte_order);
return *this;
}
-//------------------------------------------------------------------
// Stream a uint64_t "uval" out to this stream.
-//------------------------------------------------------------------
Stream &Stream::operator<<(uint64_t uval) {
PutHex64(uval, m_byte_order);
return *this;
}
-//------------------------------------------------------------------
// Stream a int8_t "sval" out to this stream.
-//------------------------------------------------------------------
Stream &Stream::operator<<(int8_t sval) {
Printf("%i", (int)sval);
return *this;
}
-//------------------------------------------------------------------
// Stream a int16_t "sval" out to this stream.
-//------------------------------------------------------------------
Stream &Stream::operator<<(int16_t sval) {
Printf("%i", (int)sval);
return *this;
}
-//------------------------------------------------------------------
// Stream a int32_t "sval" out to this stream.
-//------------------------------------------------------------------
Stream &Stream::operator<<(int32_t sval) {
Printf("%i", (int)sval);
return *this;
}
-//------------------------------------------------------------------
// Stream a int64_t "sval" out to this stream.
-//------------------------------------------------------------------
Stream &Stream::operator<<(int64_t sval) {
Printf("%" PRIi64, sval);
return *this;
}
-//------------------------------------------------------------------
// Get the current indentation level
-//------------------------------------------------------------------
int Stream::GetIndentLevel() const { return m_indent_level; }
-//------------------------------------------------------------------
// Set the current indentation level
-//------------------------------------------------------------------
void Stream::SetIndentLevel(int indent_level) { m_indent_level = indent_level; }
-//------------------------------------------------------------------
// Increment the current indentation level
-//------------------------------------------------------------------
void Stream::IndentMore(int amount) { m_indent_level += amount; }
-//------------------------------------------------------------------
// Decrement the current indentation level
-//------------------------------------------------------------------
void Stream::IndentLess(int amount) {
if (m_indent_level >= amount)
m_indent_level -= amount;
@@ -279,29 +225,19 @@ void Stream::IndentLess(int amount) {
m_indent_level = 0;
}
-//------------------------------------------------------------------
// Get the address size in bytes
-//------------------------------------------------------------------
uint32_t Stream::GetAddressByteSize() const { return m_addr_size; }
-//------------------------------------------------------------------
// Set the address size in bytes
-//------------------------------------------------------------------
void Stream::SetAddressByteSize(uint32_t addr_size) { m_addr_size = addr_size; }
-//------------------------------------------------------------------
// The flags get accessor
-//------------------------------------------------------------------
Flags &Stream::GetFlags() { return m_flags; }
-//------------------------------------------------------------------
// The flags const get accessor
-//------------------------------------------------------------------
const Flags &Stream::GetFlags() const { return m_flags; }
-//------------------------------------------------------------------
// The byte order get accessor
-//------------------------------------------------------------------
lldb::ByteOrder Stream::GetByteOrder() const { return m_byte_order; }
Modified: lldb/trunk/source/Utility/StringExtractor.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/StringExtractor.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/StringExtractor.cpp (original)
+++ lldb/trunk/source/Utility/StringExtractor.cpp Wed Apr 10 13:48:55 2019
@@ -24,9 +24,7 @@ static inline int xdigit_to_sint(char ch
return -1;
}
-//----------------------------------------------------------------------
// StringExtractor constructor
-//----------------------------------------------------------------------
StringExtractor::StringExtractor() : m_packet(), m_index(0) {}
StringExtractor::StringExtractor(llvm::StringRef packet_str)
@@ -40,15 +38,11 @@ StringExtractor::StringExtractor(const c
m_packet.assign(packet_cstr);
}
-//----------------------------------------------------------------------
// StringExtractor copy constructor
-//----------------------------------------------------------------------
StringExtractor::StringExtractor(const StringExtractor &rhs)
: m_packet(rhs.m_packet), m_index(rhs.m_index) {}
-//----------------------------------------------------------------------
// StringExtractor assignment operator
-//----------------------------------------------------------------------
const StringExtractor &StringExtractor::operator=(const StringExtractor &rhs) {
if (this != &rhs) {
m_packet = rhs.m_packet;
@@ -57,9 +51,7 @@ const StringExtractor &StringExtractor::
return *this;
}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
StringExtractor::~StringExtractor() {}
char StringExtractor::GetChar(char fail_value) {
@@ -72,13 +64,11 @@ char StringExtractor::GetChar(char fail_
return fail_value;
}
-//----------------------------------------------------------------------
// If a pair of valid hex digits exist at the head of the StringExtractor they
// are decoded into an unsigned byte and returned by this function
//
// If there is not a pair of valid hex digits at the head of the
// StringExtractor, it is left unchanged and -1 is returned
-//----------------------------------------------------------------------
int StringExtractor::DecodeHexU8() {
SkipSpaces();
if (GetBytesLeft() < 2) {
@@ -93,10 +83,8 @@ int StringExtractor::DecodeHexU8() {
return (uint8_t)((hi_nibble << 4) + lo_nibble);
}
-//----------------------------------------------------------------------
// Extract an unsigned character from two hex ASCII chars in the packet string,
// or return fail_value on failure
-//----------------------------------------------------------------------
uint8_t StringExtractor::GetHexU8(uint8_t fail_value, bool set_eof_on_fail) {
// On success, fail_value will be overwritten with the next character in the
// stream
@@ -304,12 +292,10 @@ size_t StringExtractor::GetHexBytes(llvm
return bytes_extracted;
}
-//----------------------------------------------------------------------
// Decodes all valid hex encoded bytes at the head of the StringExtractor,
// limited by dst_len.
//
// Returns the number of bytes successfully decoded
-//----------------------------------------------------------------------
size_t StringExtractor::GetHexBytesAvail(llvm::MutableArrayRef<uint8_t> dest) {
size_t bytes_extracted = 0;
while (!dest.empty()) {
Modified: lldb/trunk/source/Utility/StructuredData.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/StructuredData.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/StructuredData.cpp (original)
+++ lldb/trunk/source/Utility/StructuredData.cpp Wed Apr 10 13:48:55 2019
@@ -22,9 +22,7 @@
using namespace lldb_private;
-//----------------------------------------------------------------------
// Functions that use a JSONParser to parse JSON into StructuredData
-//----------------------------------------------------------------------
static StructuredData::ObjectSP ParseJSONValue(JSONParser &json_parser);
static StructuredData::ObjectSP ParseJSONObject(JSONParser &json_parser);
static StructuredData::ObjectSP ParseJSONArray(JSONParser &json_parser);
Modified: lldb/trunk/source/Utility/UriParser.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/UriParser.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/source/Utility/UriParser.cpp (original)
+++ lldb/trunk/source/Utility/UriParser.cpp Wed Apr 10 13:48:55 2019
@@ -15,9 +15,7 @@
using namespace lldb_private;
-//----------------------------------------------------------------------
// UriParser::Parse
-//----------------------------------------------------------------------
bool UriParser::Parse(llvm::StringRef uri, llvm::StringRef &scheme,
llvm::StringRef &hostname, int &port,
llvm::StringRef &path) {
Modified: lldb/trunk/tools/darwin-debug/darwin-debug.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/darwin-debug/darwin-debug.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/darwin-debug/darwin-debug.cpp (original)
+++ lldb/trunk/tools/darwin-debug/darwin-debug.cpp Wed Apr 10 13:48:55 2019
@@ -6,7 +6,6 @@
//
//===----------------------------------------------------------------------===//
-//----------------------------------------------------------------------
// Darwin launch helper
//
// This program was written to allow programs to be launched in a new
@@ -20,7 +19,6 @@
//
// Since it uses darwin specific flags this code should not be compiled
// on other systems.
-//----------------------------------------------------------------------
#if defined(__APPLE__)
#include <crt_externs.h>
Modified: lldb/trunk/tools/debugserver/source/DNB.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/DNB.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/DNB.cpp (original)
+++ lldb/trunk/tools/debugserver/source/DNB.cpp Wed Apr 10 13:48:55 2019
@@ -62,12 +62,10 @@ static size_t
GetAllInfosMatchingName(const char *process_name,
std::vector<struct kinfo_proc> &matching_proc_infos);
-//----------------------------------------------------------------------
// A Thread safe singleton to get a process map pointer.
//
// Returns a pointer to the existing process map, or a pointer to a
// newly created process map if CAN_CREATE is non-zero.
-//----------------------------------------------------------------------
static ProcessMap *GetProcessMap(bool can_create) {
static ProcessMap *g_process_map_ptr = NULL;
@@ -80,13 +78,11 @@ static ProcessMap *GetProcessMap(bool ca
return g_process_map_ptr;
}
-//----------------------------------------------------------------------
// Add PID to the shared process pointer map.
//
// Return non-zero value if we succeed in adding the process to the map.
// The only time this should fail is if we run out of memory and can't
// allocate a ProcessMap.
-//----------------------------------------------------------------------
static nub_bool_t AddProcessToMap(nub_process_t pid, MachProcessSP &procSP) {
ProcessMap *process_map = GetProcessMap(true);
if (process_map) {
@@ -96,11 +92,9 @@ static nub_bool_t AddProcessToMap(nub_pr
return false;
}
-//----------------------------------------------------------------------
// Remove the shared pointer for PID from the process map.
//
// Returns the number of items removed from the process map.
-//----------------------------------------------------------------------
// static size_t
// RemoveProcessFromMap (nub_process_t pid)
//{
@@ -112,12 +106,10 @@ static nub_bool_t AddProcessToMap(nub_pr
// return 0;
//}
-//----------------------------------------------------------------------
// Get the shared pointer for PID from the existing process map.
//
// Returns true if we successfully find a shared pointer to a
// MachProcess object.
-//----------------------------------------------------------------------
static nub_bool_t GetProcessSP(nub_process_t pid, MachProcessSP &procSP) {
ProcessMap *process_map = GetProcessMap(false);
if (process_map != NULL) {
@@ -811,9 +803,7 @@ nub_bool_t DNBProcessIsAlive(nub_process
return eStateInvalid;
}
-//----------------------------------------------------------------------
// Process and Thread state information
-//----------------------------------------------------------------------
nub_state_t DNBProcessGetState(nub_process_t pid) {
MachProcessSP procSP;
if (GetProcessSP(pid, procSP)) {
@@ -822,9 +812,7 @@ nub_state_t DNBProcessGetState(nub_proce
return eStateInvalid;
}
-//----------------------------------------------------------------------
// Process and Thread state information
-//----------------------------------------------------------------------
nub_bool_t DNBProcessGetExitStatus(nub_process_t pid, int *status) {
MachProcessSP procSP;
if (GetProcessSP(pid, procSP)) {
@@ -1031,9 +1019,7 @@ const char *DNBProcessGetArgumentAtIndex
return NULL;
}
-//----------------------------------------------------------------------
// Execution control
-//----------------------------------------------------------------------
nub_bool_t DNBProcessResume(nub_process_t pid,
const DNBThreadResumeAction *actions,
size_t num_actions) {
@@ -1128,9 +1114,7 @@ nub_bool_t DNBBreakpointClear(nub_proces
return false; // Failed
}
-//----------------------------------------------------------------------
// Watchpoints
-//----------------------------------------------------------------------
nub_bool_t DNBWatchpointSet(nub_process_t pid, nub_addr_t addr, nub_size_t size,
uint32_t watch_flags, nub_bool_t hardware) {
MachProcessSP procSP;
@@ -1146,9 +1130,7 @@ nub_bool_t DNBWatchpointClear(nub_proces
return false; // Failed
}
-//----------------------------------------------------------------------
// Return the number of supported hardware watchpoints.
-//----------------------------------------------------------------------
uint32_t DNBWatchpointGetNumSupportedHWP(nub_process_t pid) {
MachProcessSP procSP;
if (GetProcessSP(pid, procSP))
@@ -1156,13 +1138,11 @@ uint32_t DNBWatchpointGetNumSupportedHWP
return 0;
}
-//----------------------------------------------------------------------
// Read memory in the address space of process PID. This call will take
// care of setting and restoring permissions and breaking up the memory
// read into multiple chunks as required.
//
// RETURNS: number of bytes actually read
-//----------------------------------------------------------------------
nub_size_t DNBProcessMemoryRead(nub_process_t pid, nub_addr_t addr,
nub_size_t size, void *buf) {
MachProcessSP procSP;
@@ -1246,13 +1226,11 @@ std::string DNBProcessMemoryReadCStringF
return cstr;
}
-//----------------------------------------------------------------------
// Write memory to the address space of process PID. This call will take
// care of setting and restoring permissions and breaking up the memory
// write into multiple chunks as required.
//
// RETURNS: number of bytes actually written
-//----------------------------------------------------------------------
nub_size_t DNBProcessMemoryWrite(nub_process_t pid, nub_addr_t addr,
nub_size_t size, const void *buf) {
MachProcessSP procSP;
@@ -1276,7 +1254,6 @@ nub_bool_t DNBProcessMemoryDeallocate(nu
return 0;
}
-//----------------------------------------------------------------------
// Find attributes of the memory region that contains ADDR for process PID,
// if possible, and return a string describing those attributes.
//
@@ -1289,7 +1266,6 @@ nub_bool_t DNBProcessMemoryDeallocate(nu
// Returns -1 if this platform cannot look up information about memory regions
// or if we do not yet have a valid launched process.
//
-//----------------------------------------------------------------------
int DNBProcessMemoryRegionInfo(nub_process_t pid, nub_addr_t addr,
DNBRegionInfo *region_info) {
MachProcessSP procSP;
@@ -1321,9 +1297,7 @@ nub_bool_t DNBProcessSetEnableAsyncProfi
return false;
}
-//----------------------------------------------------------------------
// Get the number of threads for the specified process.
-//----------------------------------------------------------------------
nub_size_t DNBProcessGetNumThreads(nub_process_t pid) {
MachProcessSP procSP;
if (GetProcessSP(pid, procSP))
@@ -1331,9 +1305,7 @@ nub_size_t DNBProcessGetNumThreads(nub_p
return 0;
}
-//----------------------------------------------------------------------
// Get the thread ID of the current thread.
-//----------------------------------------------------------------------
nub_thread_t DNBProcessGetCurrentThread(nub_process_t pid) {
MachProcessSP procSP;
if (GetProcessSP(pid, procSP))
@@ -1341,9 +1313,7 @@ nub_thread_t DNBProcessGetCurrentThread(
return 0;
}
-//----------------------------------------------------------------------
// Get the mach port number of the current thread.
-//----------------------------------------------------------------------
nub_thread_t DNBProcessGetCurrentThreadMachPort(nub_process_t pid) {
MachProcessSP procSP;
if (GetProcessSP(pid, procSP))
@@ -1351,9 +1321,7 @@ nub_thread_t DNBProcessGetCurrentThreadM
return 0;
}
-//----------------------------------------------------------------------
// Change the current thread.
-//----------------------------------------------------------------------
nub_thread_t DNBProcessSetCurrentThread(nub_process_t pid, nub_thread_t tid) {
MachProcessSP procSP;
if (GetProcessSP(pid, procSP))
@@ -1361,10 +1329,8 @@ nub_thread_t DNBProcessSetCurrentThread(
return INVALID_NUB_THREAD;
}
-//----------------------------------------------------------------------
// Dump a string describing a thread's stop reason to the specified file
// handle
-//----------------------------------------------------------------------
nub_bool_t DNBThreadGetStopReason(nub_process_t pid, nub_thread_t tid,
struct DNBThreadStopInfo *stop_info) {
MachProcessSP procSP;
@@ -1373,13 +1339,11 @@ nub_bool_t DNBThreadGetStopReason(nub_pr
return false;
}
-//----------------------------------------------------------------------
// Return string description for the specified thread.
//
// RETURNS: NULL if the thread isn't valid, else a NULL terminated C
// string from a static buffer that must be copied prior to subsequent
// calls.
-//----------------------------------------------------------------------
const char *DNBThreadGetInfo(nub_process_t pid, nub_thread_t tid) {
MachProcessSP procSP;
if (GetProcessSP(pid, procSP))
@@ -1387,9 +1351,7 @@ const char *DNBThreadGetInfo(nub_process
return NULL;
}
-//----------------------------------------------------------------------
// Get the thread ID given a thread index.
-//----------------------------------------------------------------------
nub_thread_t DNBProcessGetThreadAtIndex(nub_process_t pid, size_t thread_idx) {
MachProcessSP procSP;
if (GetProcessSP(pid, procSP))
@@ -1397,10 +1359,8 @@ nub_thread_t DNBProcessGetThreadAtIndex(
return INVALID_NUB_THREAD;
}
-//----------------------------------------------------------------------
// Do whatever is needed to sync the thread's register state with it's kernel
// values.
-//----------------------------------------------------------------------
nub_bool_t DNBProcessSyncThreadState(nub_process_t pid, nub_thread_t tid) {
MachProcessSP procSP;
if (GetProcessSP(pid, procSP))
@@ -1440,11 +1400,9 @@ const char *DNBGetDeploymentInfo(nub_pro
}
-//----------------------------------------------------------------------
// Get the current shared library information for a process. Only return
// the shared libraries that have changed since the last shared library
// state changed event if only_changed is non-zero.
-//----------------------------------------------------------------------
nub_size_t
DNBProcessGetSharedLibraryInfo(nub_process_t pid, nub_bool_t only_changed,
struct DNBExecutableImageInfo **image_infos) {
@@ -1461,16 +1419,12 @@ DNBProcessGetSharedLibraryInfo(nub_proce
uint32_t DNBGetRegisterCPUType() {
return DNBArchProtocol::GetRegisterCPUType();
}
-//----------------------------------------------------------------------
// Get the register set information for a specific thread.
-//----------------------------------------------------------------------
const DNBRegisterSetInfo *DNBGetRegisterSetInfo(nub_size_t *num_reg_sets) {
return DNBArchProtocol::GetRegisterSetInfo(num_reg_sets);
}
-//----------------------------------------------------------------------
// Read a register value by register set and register index.
-//----------------------------------------------------------------------
nub_bool_t DNBThreadGetRegisterValueByID(nub_process_t pid, nub_thread_t tid,
uint32_t set, uint32_t reg,
DNBRegisterValue *value) {
@@ -1533,9 +1487,7 @@ nub_bool_t DNBThreadRestoreRegisterState
return false;
}
-//----------------------------------------------------------------------
// Read a register value by name.
-//----------------------------------------------------------------------
nub_bool_t DNBThreadGetRegisterValueByName(nub_process_t pid, nub_thread_t tid,
uint32_t reg_set,
const char *reg_name,
@@ -1567,9 +1519,7 @@ nub_bool_t DNBThreadGetRegisterValueByNa
return false;
}
-//----------------------------------------------------------------------
// Read a register set and register number from the register name.
-//----------------------------------------------------------------------
nub_bool_t DNBGetRegisterInfoByName(const char *reg_name,
DNBRegisterInfo *info) {
const struct DNBRegisterSetInfo *set_info;
@@ -1604,10 +1554,8 @@ nub_bool_t DNBGetRegisterInfoByName(cons
return false;
}
-//----------------------------------------------------------------------
// Set the name to address callback function that this nub can use
// for any name to address lookups that are needed.
-//----------------------------------------------------------------------
nub_bool_t DNBProcessSetNameToAddressCallback(nub_process_t pid,
DNBCallbackNameToAddress callback,
void *baton) {
@@ -1619,10 +1567,8 @@ nub_bool_t DNBProcessSetNameToAddressCal
return false;
}
-//----------------------------------------------------------------------
// Set the name to address callback function that this nub can use
// for any name to address lookups that are needed.
-//----------------------------------------------------------------------
nub_bool_t DNBProcessSetSharedLibraryInfoCallback(
nub_process_t pid, DNBCallbackCopyExecutableImageInfos callback,
void *baton) {
Modified: lldb/trunk/tools/debugserver/source/DNB.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/DNB.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/DNB.h (original)
+++ lldb/trunk/tools/debugserver/source/DNB.h Wed Apr 10 13:48:55 2019
@@ -34,9 +34,7 @@ void DNBTerminate();
nub_bool_t DNBSetArchitecture(const char *arch);
-//----------------------------------------------------------------------
// Process control
-//----------------------------------------------------------------------
nub_process_t DNBProcessLaunch(
const char *path, char const *argv[], const char *envp[],
const char *working_directory, // NULL => don't change, non-NULL => set
@@ -102,9 +100,7 @@ DNBProcessSetEnableAsyncProfiling(nub_pr
DNBProfileDataScanType scan_type) DNB_EXPORT;
DarwinLogEventVector DNBProcessGetAvailableDarwinLogEvents(nub_process_t pid);
-//----------------------------------------------------------------------
// Process status
-//----------------------------------------------------------------------
nub_bool_t DNBProcessIsAlive(nub_process_t pid) DNB_EXPORT;
nub_state_t DNBProcessGetState(nub_process_t pid) DNB_EXPORT;
nub_bool_t DNBProcessGetExitStatus(nub_process_t pid, int *status) DNB_EXPORT;
@@ -149,24 +145,18 @@ nub_size_t DNBProcessGetAvailableProfile
nub_size_t DNBProcessGetStopCount(nub_process_t pid) DNB_EXPORT;
uint32_t DNBProcessGetCPUType(nub_process_t pid) DNB_EXPORT;
-//----------------------------------------------------------------------
// Process executable and arguments
-//----------------------------------------------------------------------
const char *DNBProcessGetExecutablePath(nub_process_t pid);
const char *DNBProcessGetArgumentAtIndex(nub_process_t pid, nub_size_t idx);
nub_size_t DNBProcessGetArgumentCount(nub_process_t pid);
-//----------------------------------------------------------------------
// Process events
-//----------------------------------------------------------------------
nub_event_t DNBProcessWaitForEvents(nub_process_t pid, nub_event_t event_mask,
bool wait_for_set,
struct timespec *timeout);
void DNBProcessResetEvents(nub_process_t pid, nub_event_t event_mask);
-//----------------------------------------------------------------------
// Thread functions
-//----------------------------------------------------------------------
const char *DNBThreadGetName(nub_process_t pid, nub_thread_t tid);
nub_bool_t
DNBThreadGetIdentifierInfo(nub_process_t pid, nub_thread_t tid,
@@ -215,16 +205,12 @@ DNBGetLibrariesInfoForAddresses(nub_proc
JSONGenerator::ObjectSP DNBGetSharedCacheInfo(nub_process_t pid);
//
-//----------------------------------------------------------------------
// Breakpoint functions
-//----------------------------------------------------------------------
nub_bool_t DNBBreakpointSet(nub_process_t pid, nub_addr_t addr, nub_size_t size,
nub_bool_t hardware);
nub_bool_t DNBBreakpointClear(nub_process_t pid, nub_addr_t addr);
-//----------------------------------------------------------------------
// Watchpoint functions
-//----------------------------------------------------------------------
nub_bool_t DNBWatchpointSet(nub_process_t pid, nub_addr_t addr, nub_size_t size,
uint32_t watch_flags, nub_bool_t hardware);
nub_bool_t DNBWatchpointClear(nub_process_t pid, nub_addr_t addr);
@@ -235,9 +221,7 @@ const DNBRegisterSetInfo *DNBGetRegister
nub_bool_t DNBGetRegisterInfoByName(const char *reg_name,
DNBRegisterInfo *info);
-//----------------------------------------------------------------------
// Other static nub information calls.
-//----------------------------------------------------------------------
const char *DNBStateAsString(nub_state_t state);
nub_bool_t DNBResolveExecutablePath(const char *path, char *resolved_path,
size_t resolved_path_size);
Modified: lldb/trunk/tools/debugserver/source/DNBDataRef.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/DNBDataRef.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/DNBDataRef.cpp (original)
+++ lldb/trunk/tools/debugserver/source/DNBDataRef.cpp Wed Apr 10 13:48:55 2019
@@ -16,33 +16,25 @@
#include <ctype.h>
#include <libkern/OSByteOrder.h>
-//----------------------------------------------------------------------
// Constructor
-//----------------------------------------------------------------------
DNBDataRef::DNBDataRef()
: m_start(NULL), m_end(NULL), m_swap(false), m_ptrSize(0),
m_addrPCRelative(INVALID_NUB_ADDRESS), m_addrTEXT(INVALID_NUB_ADDRESS),
m_addrDATA(INVALID_NUB_ADDRESS) {}
-//----------------------------------------------------------------------
// Constructor
-//----------------------------------------------------------------------
DNBDataRef::DNBDataRef(const uint8_t *start, size_t size, bool swap)
: m_start(start), m_end(start + size), m_swap(swap), m_ptrSize(0),
m_addrPCRelative(INVALID_NUB_ADDRESS), m_addrTEXT(INVALID_NUB_ADDRESS),
m_addrDATA(INVALID_NUB_ADDRESS) {}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
DNBDataRef::~DNBDataRef() {}
-//----------------------------------------------------------------------
// Get8
-//----------------------------------------------------------------------
uint8_t DNBDataRef::Get8(offset_t *offset_ptr) const {
uint8_t val = 0;
if (ValidOffsetForDataOfSize(*offset_ptr, sizeof(val))) {
@@ -52,9 +44,7 @@ uint8_t DNBDataRef::Get8(offset_t *offse
return val;
}
-//----------------------------------------------------------------------
// Get16
-//----------------------------------------------------------------------
uint16_t DNBDataRef::Get16(offset_t *offset_ptr) const {
uint16_t val = 0;
if (ValidOffsetForDataOfSize(*offset_ptr, sizeof(val))) {
@@ -70,9 +60,7 @@ uint16_t DNBDataRef::Get16(offset_t *off
return val;
}
-//----------------------------------------------------------------------
// Get32
-//----------------------------------------------------------------------
uint32_t DNBDataRef::Get32(offset_t *offset_ptr) const {
uint32_t val = 0;
if (ValidOffsetForDataOfSize(*offset_ptr, sizeof(val))) {
@@ -87,9 +75,7 @@ uint32_t DNBDataRef::Get32(offset_t *off
return val;
}
-//----------------------------------------------------------------------
// Get64
-//----------------------------------------------------------------------
uint64_t DNBDataRef::Get64(offset_t *offset_ptr) const {
uint64_t val = 0;
if (ValidOffsetForDataOfSize(*offset_ptr, sizeof(val))) {
@@ -104,12 +90,10 @@ uint64_t DNBDataRef::Get64(offset_t *off
return val;
}
-//----------------------------------------------------------------------
// GetMax32
//
// Used for calls when the size can vary. Fill in extra cases if they
// are ever needed.
-//----------------------------------------------------------------------
uint32_t DNBDataRef::GetMax32(offset_t *offset_ptr, uint32_t byte_size) const {
switch (byte_size) {
case 1:
@@ -128,12 +112,10 @@ uint32_t DNBDataRef::GetMax32(offset_t *
return 0;
}
-//----------------------------------------------------------------------
// GetMax64
//
// Used for calls when the size can vary. Fill in extra cases if they
// are ever needed.
-//----------------------------------------------------------------------
uint64_t DNBDataRef::GetMax64(offset_t *offset_ptr, uint32_t size) const {
switch (size) {
case 1:
@@ -155,20 +137,16 @@ uint64_t DNBDataRef::GetMax64(offset_t *
return 0;
}
-//----------------------------------------------------------------------
// GetPointer
//
// Extract a pointer value from the buffer. The pointer size must be
// set prior to using this using one of the SetPointerSize functions.
-//----------------------------------------------------------------------
uint64_t DNBDataRef::GetPointer(offset_t *offset_ptr) const {
// Must set pointer size prior to using this call
assert(m_ptrSize != 0);
return GetMax64(offset_ptr, m_ptrSize);
}
-//----------------------------------------------------------------------
// GetCStr
-//----------------------------------------------------------------------
const char *DNBDataRef::GetCStr(offset_t *offset_ptr,
uint32_t fixed_length) const {
const char *s = NULL;
@@ -184,9 +162,7 @@ const char *DNBDataRef::GetCStr(offset_t
return s;
}
-//----------------------------------------------------------------------
// GetData
-//----------------------------------------------------------------------
const uint8_t *DNBDataRef::GetData(offset_t *offset_ptr,
uint32_t length) const {
const uint8_t *data = NULL;
@@ -197,9 +173,7 @@ const uint8_t *DNBDataRef::GetData(offse
return data;
}
-//----------------------------------------------------------------------
// Get_ULEB128
-//----------------------------------------------------------------------
uint64_t DNBDataRef::Get_ULEB128(offset_t *offset_ptr) const {
uint64_t result = 0;
if (m_start < m_end) {
@@ -222,9 +196,7 @@ uint64_t DNBDataRef::Get_ULEB128(offset_
return result;
}
-//----------------------------------------------------------------------
// Get_SLEB128
-//----------------------------------------------------------------------
int64_t DNBDataRef::Get_SLEB128(offset_t *offset_ptr) const {
int64_t result = 0;
@@ -254,11 +226,9 @@ int64_t DNBDataRef::Get_SLEB128(offset_t
return result;
}
-//----------------------------------------------------------------------
// Skip_LEB128
//
// Skips past ULEB128 and SLEB128 numbers (just updates the offset)
-//----------------------------------------------------------------------
void DNBDataRef::Skip_LEB128(offset_t *offset_ptr) const {
if (m_start < m_end) {
const uint8_t *start = m_start + *offset_ptr;
Modified: lldb/trunk/tools/debugserver/source/DNBDefs.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/DNBDefs.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/DNBDefs.h (original)
+++ lldb/trunk/tools/debugserver/source/DNBDefs.h Wed Apr 10 13:48:55 2019
@@ -19,33 +19,25 @@
#include <sys/syslimits.h>
#include <unistd.h>
-//----------------------------------------------------------------------
// Define nub_addr_t and the invalid address value from the architecture
-//----------------------------------------------------------------------
#if defined(__x86_64__) || defined(__ppc64__) || defined(__arm64__) || \
defined(__aarch64__)
-//----------------------------------------------------------------------
// 64 bit address architectures
-//----------------------------------------------------------------------
typedef uint64_t nub_addr_t;
#define INVALID_NUB_ADDRESS ((nub_addr_t)~0ull)
#elif defined(__i386__) || defined(__powerpc__) || defined(__ppc__) || \
defined(__arm__)
-//----------------------------------------------------------------------
// 32 bit address architectures
-//----------------------------------------------------------------------
typedef uint32_t nub_addr_t;
#define INVALID_NUB_ADDRESS ((nub_addr_t)~0ul)
#else
-//----------------------------------------------------------------------
// Default to 64 bit address for unrecognized architectures.
-//----------------------------------------------------------------------
#warning undefined architecture, defaulting to 8 byte addresses
typedef uint64_t nub_addr_t;
@@ -253,11 +245,9 @@ enum DNBMemoryPermissions {
#define DNB_THREAD_STOP_INFO_MAX_DESC_LENGTH 256
#define DNB_THREAD_STOP_INFO_MAX_EXC_DATA 8
-//----------------------------------------------------------------------
// DNBThreadStopInfo
//
// Describes the reason a thread stopped.
-//----------------------------------------------------------------------
struct DNBThreadStopInfo {
DNBThreadStopType reason;
char description[DNB_THREAD_STOP_INFO_MAX_DESC_LENGTH];
Modified: lldb/trunk/tools/debugserver/source/DNBLog.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/DNBLog.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/DNBLog.cpp (original)
+++ lldb/trunk/tools/debugserver/source/DNBLog.cpp Wed Apr 10 13:48:55 2019
@@ -78,10 +78,8 @@ void _DNBLog(uint32_t flags, const char
va_end(args);
}
-//----------------------------------------------------------------------
// Print debug strings if and only if the global g_debug is set to
// a non-zero value.
-//----------------------------------------------------------------------
void _DNBLogDebug(const char *format, ...) {
if (DNBLogEnabled() && g_debug) {
va_list args;
@@ -91,10 +89,8 @@ void _DNBLogDebug(const char *format, ..
}
}
-//----------------------------------------------------------------------
// Print debug strings if and only if the global g_debug is set to
// a non-zero value.
-//----------------------------------------------------------------------
void _DNBLogDebugVerbose(const char *format, ...) {
if (DNBLogEnabled() && g_debug && g_verbose) {
va_list args;
@@ -106,10 +102,8 @@ void _DNBLogDebugVerbose(const char *for
static uint32_t g_message_id = 0;
-//----------------------------------------------------------------------
// Prefix the formatted log string with process and thread IDs and
// suffix it with a newline.
-//----------------------------------------------------------------------
void _DNBLogThreaded(const char *format, ...) {
if (DNBLogEnabled()) {
// PTHREAD_MUTEX_LOCKER(locker, GetLogThreadedMutex());
@@ -150,10 +144,8 @@ void _DNBLogThreaded(const char *format,
}
}
-//----------------------------------------------------------------------
// Prefix the formatted log string with process and thread IDs and
// suffix it with a newline.
-//----------------------------------------------------------------------
void _DNBLogThreadedIf(uint32_t log_bit, const char *format, ...) {
if (DNBLogEnabled() && (log_bit & g_log_bits) == log_bit) {
// PTHREAD_MUTEX_LOCKER(locker, GetLogThreadedMutex());
@@ -195,9 +187,7 @@ void _DNBLogThreadedIf(uint32_t log_bit,
}
}
-//----------------------------------------------------------------------
// Printing of errors that are not fatal.
-//----------------------------------------------------------------------
void _DNBLogError(const char *format, ...) {
if (DNBLogEnabled()) {
char *arg_msg = NULL;
@@ -213,10 +203,8 @@ void _DNBLogError(const char *format, ..
}
}
-//----------------------------------------------------------------------
// Printing of errors that ARE fatal. Exit with ERR exit code
// immediately.
-//----------------------------------------------------------------------
void _DNBLogFatalError(int err, const char *format, ...) {
if (DNBLogEnabled()) {
char *arg_msg = NULL;
@@ -233,10 +221,8 @@ void _DNBLogFatalError(int err, const ch
}
}
-//----------------------------------------------------------------------
// Printing of warnings that are not fatal only if verbose mode is
// enabled.
-//----------------------------------------------------------------------
void _DNBLogVerbose(const char *format, ...) {
if (DNBLogEnabled() && g_verbose) {
va_list args;
@@ -246,10 +232,8 @@ void _DNBLogVerbose(const char *format,
}
}
-//----------------------------------------------------------------------
// Printing of warnings that are not fatal only if verbose mode is
// enabled.
-//----------------------------------------------------------------------
void _DNBLogWarningVerbose(const char *format, ...) {
if (DNBLogEnabled() && g_verbose) {
char *arg_msg = NULL;
@@ -265,9 +249,7 @@ void _DNBLogWarningVerbose(const char *f
}
}
}
-//----------------------------------------------------------------------
// Printing of warnings that are not fatal.
-//----------------------------------------------------------------------
void _DNBLogWarning(const char *format, ...) {
if (DNBLogEnabled()) {
char *arg_msg = NULL;
Modified: lldb/trunk/tools/debugserver/source/DNBTimer.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/DNBTimer.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/DNBTimer.h (original)
+++ lldb/trunk/tools/debugserver/source/DNBTimer.h Wed Apr 10 13:48:55 2019
@@ -21,9 +21,7 @@
class DNBTimer {
public:
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
DNBTimer(bool threadSafe) : m_mutexAP() {
if (threadSafe)
m_mutexAP.reset(new PThreadMutex(PTHREAD_MUTEX_RECURSIVE));
@@ -50,16 +48,12 @@ public:
~DNBTimer() {}
bool IsThreadSafe() const { return m_mutexAP.get() != NULL; }
- //------------------------------------------------------------------
// Reset the time value to now
- //------------------------------------------------------------------
void Reset() {
PTHREAD_MUTEX_LOCKER(locker, m_mutexAP.get());
gettimeofday(&m_timeval, NULL);
}
- //------------------------------------------------------------------
// Get the total mircoseconds since Jan 1, 1970
- //------------------------------------------------------------------
uint64_t TotalMicroSeconds() const {
PTHREAD_MUTEX_LOCKER(locker, m_mutexAP.get());
return (uint64_t)(m_timeval.tv_sec) * 1000000ull +
@@ -71,10 +65,8 @@ public:
sec = m_timeval.tv_sec;
usec = m_timeval.tv_usec;
}
- //------------------------------------------------------------------
// Return the number of microseconds elapsed between now and the
// m_timeval
- //------------------------------------------------------------------
uint64_t ElapsedMicroSeconds(bool update) {
PTHREAD_MUTEX_LOCKER(locker, m_mutexAP.get());
struct timeval now;
@@ -134,9 +126,7 @@ public:
}
protected:
- //------------------------------------------------------------------
// Classes that inherit from DNBTimer can see and modify these
- //------------------------------------------------------------------
std::unique_ptr<PThreadMutex> m_mutexAP;
struct timeval m_timeval;
};
Modified: lldb/trunk/tools/debugserver/source/JSON.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/JSON.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/JSON.h (original)
+++ lldb/trunk/tools/debugserver/source/JSON.h Wed Apr 10 13:48:55 2019
@@ -203,7 +203,6 @@ public:
JSONValue::SP GetObject(const std::string &key) const;
- // -------------------------------------------------------------------------
/// Return keyed value as bool
///
/// \param[in] key
@@ -217,7 +216,6 @@ public:
/// true if the key existed as was a bool value; false otherwise.
/// Note the return value is *not* the value of the bool, use
/// \b value for that.
- // -------------------------------------------------------------------------
bool GetObjectAsBool(const std::string &key, bool &value) const;
bool GetObjectAsString(const std::string &key, std::string &value) const;
Modified: lldb/trunk/tools/debugserver/source/JSONGenerator.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/JSONGenerator.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/JSONGenerator.h (original)
+++ lldb/trunk/tools/debugserver/source/JSONGenerator.h Wed Apr 10 13:48:55 2019
@@ -16,7 +16,6 @@
#include <utility>
#include <vector>
-//----------------------------------------------------------------------
/// \class JSONGenerator JSONGenerator.h
/// A class which can construct structured data for the sole purpose
/// of printing it in JSON format.
@@ -24,7 +23,6 @@
/// A stripped down version of lldb's StructuredData objects which are much
/// general purpose. This variant is intended only for assembling information
/// and printing it as a JSON string.
-//----------------------------------------------------------------------
class JSONGenerator {
public:
Modified: lldb/trunk/tools/debugserver/source/MacOSX/CFBundle.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/CFBundle.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/CFBundle.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/CFBundle.cpp Wed Apr 10 13:48:55 2019
@@ -13,38 +13,28 @@
#include "CFBundle.h"
#include "CFString.h"
-//----------------------------------------------------------------------
// CFBundle constructor
-//----------------------------------------------------------------------
CFBundle::CFBundle(const char *path)
: CFReleaser<CFBundleRef>(), m_bundle_url() {
if (path && path[0])
SetPath(path);
}
-//----------------------------------------------------------------------
// CFBundle copy constructor
-//----------------------------------------------------------------------
CFBundle::CFBundle(const CFBundle &rhs)
: CFReleaser<CFBundleRef>(rhs), m_bundle_url(rhs.m_bundle_url) {}
-//----------------------------------------------------------------------
// CFBundle copy constructor
-//----------------------------------------------------------------------
CFBundle &CFBundle::operator=(const CFBundle &rhs) {
if (this != &rhs)
*this = rhs;
return *this;
}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
CFBundle::~CFBundle() {}
-//----------------------------------------------------------------------
// Set the path for a bundle by supplying a
-//----------------------------------------------------------------------
bool CFBundle::SetPath(const char *path) {
CFAllocatorRef alloc = kCFAllocatorDefault;
// Release our old bundle and ULR
Modified: lldb/trunk/tools/debugserver/source/MacOSX/CFBundle.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/CFBundle.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/CFBundle.h (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/CFBundle.h Wed Apr 10 13:48:55 2019
@@ -17,9 +17,7 @@
class CFBundle : public CFReleaser<CFBundleRef> {
public:
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
CFBundle(const char *path = NULL);
CFBundle(const CFBundle &rhs);
CFBundle &operator=(const CFBundle &rhs);
Modified: lldb/trunk/tools/debugserver/source/MacOSX/CFString.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/CFString.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/CFString.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/CFString.cpp Wed Apr 10 13:48:55 2019
@@ -14,19 +14,13 @@
#include <glob.h>
#include <string>
-//----------------------------------------------------------------------
// CFString constructor
-//----------------------------------------------------------------------
CFString::CFString(CFStringRef s) : CFReleaser<CFStringRef>(s) {}
-//----------------------------------------------------------------------
// CFString copy constructor
-//----------------------------------------------------------------------
CFString::CFString(const CFString &rhs) : CFReleaser<CFStringRef>(rhs) {}
-//----------------------------------------------------------------------
// CFString copy constructor
-//----------------------------------------------------------------------
CFString &CFString::operator=(const CFString &rhs) {
if (this != &rhs)
*this = rhs;
@@ -41,9 +35,7 @@ CFString::CFString(const char *cstr, CFS
}
}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
CFString::~CFString() {}
const char *CFString::GetFileSystemRepresentation(std::string &s) {
Modified: lldb/trunk/tools/debugserver/source/MacOSX/CFString.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/CFString.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/CFString.h (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/CFString.h Wed Apr 10 13:48:55 2019
@@ -18,9 +18,7 @@
class CFString : public CFReleaser<CFStringRef> {
public:
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
CFString(CFStringRef cf_str = NULL);
CFString(const char *s, CFStringEncoding encoding = kCFStringEncodingUTF8);
CFString(const CFString &rhs);
Modified: lldb/trunk/tools/debugserver/source/MacOSX/CFUtils.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/CFUtils.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/CFUtils.h (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/CFUtils.h Wed Apr 10 13:48:55 2019
@@ -17,11 +17,9 @@
#ifdef __cplusplus
-//----------------------------------------------------------------------
// Templatized CF helper class that can own any CF pointer and will
// call CFRelease() on any valid pointer it owns unless that pointer is
// explicitly released using the release() member function.
-//----------------------------------------------------------------------
template <class T> class CFReleaser {
public:
// Type names for the avlue
Modified: lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.h (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.h Wed Apr 10 13:48:55 2019
@@ -29,21 +29,17 @@ class DarwinLogCollector
: public std::enable_shared_from_this<DarwinLogCollector>,
public ActivityStore {
public:
- //------------------------------------------------------------------
/// Return whether the os_log and activity tracing SPI is available.
///
/// \return \b true if the activity stream support is available,
/// \b false otherwise.
- //------------------------------------------------------------------
static bool IsSupported();
- //------------------------------------------------------------------
/// Return a log function suitable for DNBLog to use as the internal
/// logging function.
///
/// \return a DNBLog-style logging function if IsSupported() returns
/// true; otherwise, returns nullptr.
- //------------------------------------------------------------------
static DNBCallbackLog GetLogFunction();
static bool StartCollectingForProcess(nub_process_t pid,
@@ -57,9 +53,7 @@ public:
pid_t GetProcessID() const { return m_pid; }
- //------------------------------------------------------------------
// ActivityStore API
- //------------------------------------------------------------------
const char *GetActivityForID(os_activity_id_t activity_id) const override;
std::string
Modified: lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/LogFilterRegex.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/LogFilterRegex.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/LogFilterRegex.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/LogFilterRegex.cpp Wed Apr 10 13:48:55 2019
@@ -11,11 +11,9 @@
#include "DNBLog.h"
#include "LogMessage.h"
-//----------------------------------------------------------------------
// Enable enhanced mode if it is available. This allows for things like
// \d for digit, \s for space, and many more, but it isn't available
// everywhere.
-//----------------------------------------------------------------------
#if defined(REG_ENHANCED)
#define DEFAULT_COMPILE_FLAGS (REG_ENHANCED | REG_EXTENDED)
#else
Modified: lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/LogMessageOsLog.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/LogMessageOsLog.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/LogMessageOsLog.h (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/LogMessageOsLog.h Wed Apr 10 13:48:55 2019
@@ -16,13 +16,11 @@
using ActivityStreamEntry = struct os_activity_stream_entry_s;
-// -----------------------------------------------------------------------------
/// Provides a unified wrapper around os_log()-style log messages.
///
/// The lifetime of this class is intended to be very short. The caller
/// must ensure that the passed in ActivityStore and ActivityStreamEntry
/// outlive this LogMessageOsLog entry.
-// -----------------------------------------------------------------------------
class LogMessageOsLog : public LogMessage {
public:
Modified: lldb/trunk/tools/debugserver/source/MacOSX/Genealogy.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/Genealogy.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/Genealogy.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/Genealogy.cpp Wed Apr 10 13:48:55 2019
@@ -16,9 +16,7 @@
#include "GenealogySPI.h"
#include "MachThreadList.h"
-//---------------------------
/// Constructor
-//---------------------------
Genealogy::Genealogy()
: m_os_activity_diagnostic_for_pid(nullptr),
Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.h (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.h Wed Apr 10 13:48:55 2019
@@ -40,9 +40,7 @@ class DNBThreadResumeActions;
class MachProcess {
public:
- //----------------------------------------------------------------------
// Constructors and Destructors
- //----------------------------------------------------------------------
MachProcess();
~MachProcess();
@@ -79,9 +77,7 @@ public:
: filename(), load_address(INVALID_NUB_ADDRESS), mod_date(0) {}
};
- //----------------------------------------------------------------------
// Child process control
- //----------------------------------------------------------------------
pid_t AttachForDebug(pid_t pid, char *err_str, size_t err_len);
pid_t LaunchForDebug(const char *path, char const *argv[], char const *envp[],
const char *working_directory, const char *stdin_path,
@@ -160,9 +156,7 @@ public:
nub_size_t ReadMemory(nub_addr_t addr, nub_size_t size, void *buf);
nub_size_t WriteMemory(nub_addr_t addr, nub_size_t size, const void *buf);
- //----------------------------------------------------------------------
// Path and arg accessors
- //----------------------------------------------------------------------
const char *Path() const { return m_path.c_str(); }
size_t ArgumentCount() const { return m_args.size(); }
const char *ArgumentAtIndex(size_t arg_idx) const {
@@ -171,9 +165,7 @@ public:
return NULL;
}
- //----------------------------------------------------------------------
// Breakpoint functions
- //----------------------------------------------------------------------
DNBBreakpoint *CreateBreakpoint(nub_addr_t addr, nub_size_t length,
bool hardware);
bool DisableBreakpoint(nub_addr_t addr, bool remove);
@@ -182,9 +174,7 @@ public:
DNBBreakpointList &Breakpoints() { return m_breakpoints; }
const DNBBreakpointList &Breakpoints() const { return m_breakpoints; }
- //----------------------------------------------------------------------
// Watchpoint functions
- //----------------------------------------------------------------------
DNBBreakpoint *CreateWatchpoint(nub_addr_t addr, nub_size_t length,
uint32_t watch_type, bool hardware);
bool DisableWatchpoint(nub_addr_t addr, bool remove);
@@ -194,9 +184,7 @@ public:
DNBBreakpointList &Watchpoints() { return m_watchpoints; }
const DNBBreakpointList &Watchpoints() const { return m_watchpoints; }
- //----------------------------------------------------------------------
// Exception thread functions
- //----------------------------------------------------------------------
bool StartSTDIOThread();
static void *STDIOThread(void *arg);
void ExceptionMessageReceived(const MachException::Message &exceptionMessage);
@@ -205,9 +193,7 @@ public:
nub_size_t CopyImageInfos(struct DNBExecutableImageInfo **image_infos,
bool only_changed);
- //----------------------------------------------------------------------
// Profile functions
- //----------------------------------------------------------------------
void SetEnableAsyncProfiling(bool enable, uint64_t internal_usec,
DNBProfileDataScanType scan_type);
bool IsProfilingEnabled() { return m_profile_enabled; }
@@ -217,9 +203,7 @@ public:
void SignalAsyncProfileData(const char *info);
size_t GetAsyncProfileData(char *buf, size_t buf_size);
- //----------------------------------------------------------------------
// Accessors
- //----------------------------------------------------------------------
pid_t ProcessID() const { return m_pid; }
bool ProcessIDIsValid() const { return m_pid > 0; }
pid_t SetProcessID(pid_t pid);
Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachTask.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/MachTask.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/MachTask.h (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/MachTask.h Wed Apr 10 13:48:55 2019
@@ -5,7 +5,6 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
-//----------------------------------------------------------------------
//
// MachTask.h
// debugserver
@@ -45,9 +44,7 @@ struct MachMallocEvent {
class MachTask {
public:
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
MachTask(MachProcess *process);
virtual ~MachTask();
Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachThreadList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/MachThreadList.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/MachThreadList.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/MachThreadList.cpp Wed Apr 10 13:48:55 2019
@@ -451,7 +451,6 @@ uint32_t MachThreadList::ProcessDidStop(
return num_threads;
}
-//----------------------------------------------------------------------
// Check each thread in our thread list to see if we should notify our
// client of the current halt in execution.
//
@@ -461,7 +460,6 @@ uint32_t MachThreadList::ProcessDidStop(
// RETURNS
// true if we should stop and notify our clients
// false if we should resume our child process and skip notification
-//----------------------------------------------------------------------
bool MachThreadList::ShouldStop(bool &step_more) {
PTHREAD_MUTEX_LOCKER(locker, m_threads_mutex);
uint32_t should_stop = false;
Modified: lldb/trunk/tools/debugserver/source/MacOSX/OsLogger.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/OsLogger.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/OsLogger.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/OsLogger.cpp Wed Apr 10 13:48:55 2019
@@ -19,10 +19,8 @@
#define LLDB_OS_LOG_MAX_BUFFER_LENGTH 256
namespace {
-//----------------------------------------------------------------------
// Darwin os_log logging callback that can be registered with
// DNBLogSetLogCallback
-//----------------------------------------------------------------------
void DarwinLogCallback(void *baton, uint32_t flags, const char *format,
va_list args) {
if (format == nullptr)
Modified: lldb/trunk/tools/debugserver/source/MacOSX/arm/DNBArchImpl.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/arm/DNBArchImpl.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/arm/DNBArchImpl.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/arm/DNBArchImpl.cpp Wed Apr 10 13:48:55 2019
@@ -1423,9 +1423,7 @@ nub_addr_t DNBArchMachARM::GetWatchAddre
return bits(debug_state.__wvr[hw_index], 31, 0);
}
-//----------------------------------------------------------------------
// Register information definitions for 32 bit ARMV7.
-//----------------------------------------------------------------------
enum gpr_regnums {
gpr_r0 = 0,
gpr_r1,
@@ -1776,11 +1774,9 @@ const size_t DNBArchMachARM::k_num_exc_r
const size_t DNBArchMachARM::k_num_all_registers =
k_num_gpr_registers + k_num_vfp_registers + k_num_exc_registers;
-//----------------------------------------------------------------------
// Register set definitions. The first definitions at register set index
// of zero is for all registers, followed by other registers sets. The
// register information for the all register set need not be filled in.
-//----------------------------------------------------------------------
const DNBRegisterSetInfo DNBArchMachARM::g_reg_sets[] = {
{"ARM Registers", NULL, k_num_all_registers},
{"General Purpose Registers", g_gpr_registers, k_num_gpr_registers},
Modified: lldb/trunk/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp Wed Apr 10 13:48:55 2019
@@ -947,9 +947,7 @@ nub_addr_t DNBArchMachARM64::GetWatchAdd
return bits(debug_state.__wvr[hw_index], 63, 0);
}
-//----------------------------------------------------------------------
// Register information definitions for 64 bit ARMv8.
-//----------------------------------------------------------------------
enum gpr_regnums {
gpr_x0 = 0,
gpr_x1,
@@ -1689,11 +1687,9 @@ const size_t DNBArchMachARM64::k_num_exc
const size_t DNBArchMachARM64::k_num_all_registers =
k_num_gpr_registers + k_num_vfp_registers + k_num_exc_registers;
-//----------------------------------------------------------------------
// Register set definitions. The first definitions at register set index
// of zero is for all registers, followed by other registers sets. The
// register information for the all register set need not be filled in.
-//----------------------------------------------------------------------
const DNBRegisterSetInfo DNBArchMachARM64::g_reg_sets[] = {
{"ARM64 Registers", NULL, k_num_all_registers},
{"General Purpose Registers", g_gpr_registers, k_num_gpr_registers},
Modified: lldb/trunk/tools/debugserver/source/MacOSX/i386/DNBArchImplI386.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/i386/DNBArchImplI386.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/i386/DNBArchImplI386.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/i386/DNBArchImplI386.cpp Wed Apr 10 13:48:55 2019
@@ -1025,9 +1025,7 @@ kern_return_t DNBArchImplI386::EnableHar
return m_state.GetError(e_regSetGPR, Read);
}
-//----------------------------------------------------------------------
// Register information definitions
-//----------------------------------------------------------------------
#define DEFINE_GPR_PSEUDO_16(reg16, reg32) \
{ \
@@ -1540,11 +1538,9 @@ const size_t DNBArchImplI386::k_num_all_
const size_t DNBArchImplI386::k_num_all_registers_avx512f =
k_num_gpr_registers + k_num_fpu_registers_avx512f + k_num_exc_registers;
-//----------------------------------------------------------------------
// Register set definitions. The first definitions at register set index
// of zero is for all registers, followed by other registers sets. The
// register information for the all register set need not be filled in.
-//----------------------------------------------------------------------
const DNBRegisterSetInfo DNBArchImplI386::g_reg_sets_no_avx[] = {
{"i386 Registers", NULL, k_num_all_registers_no_avx},
{"General Purpose Registers", g_gpr_registers, k_num_gpr_registers},
Modified: lldb/trunk/tools/debugserver/source/MacOSX/ppc/DNBArchImpl.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/ppc/DNBArchImpl.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/ppc/DNBArchImpl.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/ppc/DNBArchImpl.cpp Wed Apr 10 13:48:55 2019
@@ -178,9 +178,7 @@ kern_return_t DNBArchMachPPC::EnableHard
return m_state.GetError(e_regSetGPR, Read);
}
-//----------------------------------------------------------------------
// Register information definitions for 32 bit PowerPC.
-//----------------------------------------------------------------------
enum gpr_regnums {
e_regNumGPR_srr0,
@@ -319,11 +317,9 @@ const size_t k_num_vec_registers =
const size_t k_num_ppc_registers = k_num_gpr_registers + k_num_fpr_registers +
k_num_exc_registers + k_num_vec_registers;
-//----------------------------------------------------------------------
// Register set definitions. The first definitions at register set index
// of zero is for all registers, followed by other registers sets. The
// register information for the all register set need not be filled in.
-//----------------------------------------------------------------------
static const DNBRegisterSetInfo g_reg_sets[] = {
{"PowerPC Registers", NULL, k_num_ppc_registers},
{"General Purpose Registers", g_gpr_registers, k_num_gpr_registers},
Modified: lldb/trunk/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp Wed Apr 10 13:48:55 2019
@@ -980,9 +980,7 @@ kern_return_t DNBArchImplX86_64::EnableH
return m_state.GetError(e_regSetGPR, Read);
}
-//----------------------------------------------------------------------
// Register information definitions
-//----------------------------------------------------------------------
enum {
gpr_rax = 0,
@@ -2062,11 +2060,9 @@ const size_t DNBArchImplX86_64::k_num_fp
const size_t DNBArchImplX86_64::k_num_all_registers_avx512f =
k_num_gpr_registers + k_num_fpu_registers_avx512f + k_num_exc_registers;
-//----------------------------------------------------------------------
// Register set definitions. The first definitions at register set index
// of zero is for all registers, followed by other registers sets. The
// register information for the all register set need not be filled in.
-//----------------------------------------------------------------------
const DNBRegisterSetInfo DNBArchImplX86_64::g_reg_sets_no_avx[] = {
{"x86_64 Registers", NULL, k_num_all_registers_no_avx},
{"General Purpose Registers", g_gpr_registers, k_num_gpr_registers},
Modified: lldb/trunk/tools/debugserver/source/PThreadEvent.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/PThreadEvent.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/PThreadEvent.cpp (original)
+++ lldb/trunk/tools/debugserver/source/PThreadEvent.cpp Wed Apr 10 13:48:55 2019
@@ -105,10 +105,8 @@ void PThreadEvent::ResetEvents(const uin
}
}
-//----------------------------------------------------------------------
// Wait until 'timeout_abstime' for any events that are set in
// 'mask'. If 'timeout_abstime' is NULL, then wait forever.
-//----------------------------------------------------------------------
uint32_t
PThreadEvent::WaitForSetEvents(const uint32_t mask,
const struct timespec *timeout_abstime) const {
@@ -149,10 +147,8 @@ PThreadEvent::WaitForSetEvents(const uin
return 0;
}
-//----------------------------------------------------------------------
// Wait until 'timeout_abstime' for any events in 'mask' to reset.
// If 'timeout_abstime' is NULL, then wait forever.
-//----------------------------------------------------------------------
uint32_t PThreadEvent::WaitForEventsToReset(
const uint32_t mask, const struct timespec *timeout_abstime) const {
// DNBLogThreadedIf(LOG_EVENTS, "%p PThreadEvent::%s (0x%8.8x, %p)", this,
Modified: lldb/trunk/tools/debugserver/source/PThreadEvent.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/PThreadEvent.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/PThreadEvent.h (original)
+++ lldb/trunk/tools/debugserver/source/PThreadEvent.h Wed Apr 10 13:48:55 2019
@@ -44,10 +44,8 @@ public:
const struct timespec *timeout_abstime = NULL) const;
protected:
- //----------------------------------------------------------------------
// pthread condition and mutex variable to control access and allow
// blocking between the main thread and the spotlight index thread.
- //----------------------------------------------------------------------
mutable PThreadMutex m_mutex;
mutable PThreadCondition m_set_condition;
mutable PThreadCondition m_reset_condition;
Modified: lldb/trunk/tools/debugserver/source/PseudoTerminal.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/PseudoTerminal.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/PseudoTerminal.cpp (original)
+++ lldb/trunk/tools/debugserver/source/PseudoTerminal.cpp Wed Apr 10 13:48:55 2019
@@ -15,27 +15,21 @@
#include <sys/ioctl.h>
#include <unistd.h>
-//----------------------------------------------------------------------
// PseudoTerminal constructor
-//----------------------------------------------------------------------
PseudoTerminal::PseudoTerminal()
: m_master_fd(invalid_fd), m_slave_fd(invalid_fd) {}
-//----------------------------------------------------------------------
// Destructor
// The master and slave file descriptors will get closed if they are
// valid. Call the ReleaseMasterFD()/ReleaseSlaveFD() member functions
// to release any file descriptors that are needed beyond the lifespan
// of this object.
-//----------------------------------------------------------------------
PseudoTerminal::~PseudoTerminal() {
CloseMaster();
CloseSlave();
}
-//----------------------------------------------------------------------
// Close the master file descriptor if it is valid.
-//----------------------------------------------------------------------
void PseudoTerminal::CloseMaster() {
if (m_master_fd > 0) {
::close(m_master_fd);
@@ -43,9 +37,7 @@ void PseudoTerminal::CloseMaster() {
}
}
-//----------------------------------------------------------------------
// Close the slave file descriptor if it is valid.
-//----------------------------------------------------------------------
void PseudoTerminal::CloseSlave() {
if (m_slave_fd > 0) {
::close(m_slave_fd);
@@ -53,7 +45,6 @@ void PseudoTerminal::CloseSlave() {
}
}
-//----------------------------------------------------------------------
// Open the first available pseudo terminal with OFLAG as the
// permissions. The file descriptor is store in the m_master_fd member
// variable and can be accessed via the MasterFD() or ReleaseMasterFD()
@@ -63,7 +54,6 @@ void PseudoTerminal::CloseSlave() {
//
// RETURNS:
// Zero when successful, non-zero indicating an error occurred.
-//----------------------------------------------------------------------
PseudoTerminal::Status PseudoTerminal::OpenFirstAvailableMaster(int oflag) {
// Open the master side of a pseudo terminal
m_master_fd = ::posix_openpt(oflag);
@@ -86,7 +76,6 @@ PseudoTerminal::Status PseudoTerminal::O
return success;
}
-//----------------------------------------------------------------------
// Open the slave pseudo terminal for the current master pseudo
// terminal. A master pseudo terminal should already be valid prior to
// calling this function (see PseudoTerminal::OpenFirstAvailableMaster()).
@@ -95,7 +84,6 @@ PseudoTerminal::Status PseudoTerminal::O
//
// RETURNS:
// Zero when successful, non-zero indicating an error occurred.
-//----------------------------------------------------------------------
PseudoTerminal::Status PseudoTerminal::OpenSlave(int oflag) {
CloseSlave();
@@ -113,7 +101,6 @@ PseudoTerminal::Status PseudoTerminal::O
return success;
}
-//----------------------------------------------------------------------
// Get the name of the slave pseudo terminal. A master pseudo terminal
// should already be valid prior to calling this function (see
// PseudoTerminal::OpenFirstAvailableMaster()).
@@ -123,14 +110,12 @@ PseudoTerminal::Status PseudoTerminal::O
// The name of the slave pseudo terminal as a NULL terminated C string
// that comes from static memory, so a copy of the string should be
// made as subsequent calls can change this value.
-//----------------------------------------------------------------------
const char *PseudoTerminal::SlaveName() const {
if (m_master_fd < 0)
return NULL;
return ::ptsname(m_master_fd);
}
-//----------------------------------------------------------------------
// Fork a child process that and have its stdio routed to a pseudo
// terminal.
//
@@ -150,7 +135,6 @@ const char *PseudoTerminal::SlaveName()
// RETURNS:
// in the parent process: the pid of the child, or -1 if fork fails
// in the child process: zero
-//----------------------------------------------------------------------
pid_t PseudoTerminal::Fork(PseudoTerminal::Status &error) {
pid_t pid = invalid_pid;
Modified: lldb/trunk/tools/debugserver/source/PseudoTerminal.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/PseudoTerminal.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/PseudoTerminal.h (original)
+++ lldb/trunk/tools/debugserver/source/PseudoTerminal.h Wed Apr 10 13:48:55 2019
@@ -35,9 +35,7 @@ public:
err_dup2_failed_on_stdout = -11,
err_dup2_failed_on_stderr = -12
};
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
PseudoTerminal();
~PseudoTerminal();
@@ -69,16 +67,12 @@ public:
pid_t Fork(Status &error);
protected:
- //------------------------------------------------------------------
// Classes that inherit from PseudoTerminal can see and modify these
- //------------------------------------------------------------------
int m_master_fd;
int m_slave_fd;
private:
- //------------------------------------------------------------------
// Outlaw copy and assignment constructors
- //------------------------------------------------------------------
PseudoTerminal(const PseudoTerminal &rhs);
PseudoTerminal &operator=(const PseudoTerminal &rhs);
};
Modified: lldb/trunk/tools/debugserver/source/RNBContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/RNBContext.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/RNBContext.cpp (original)
+++ lldb/trunk/tools/debugserver/source/RNBContext.cpp Wed Apr 10 13:48:55 2019
@@ -25,14 +25,10 @@
#include "DNBLog.h"
#include "RNBRemote.h"
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
RNBContext::~RNBContext() { SetProcessID(INVALID_NUB_PROCESS); }
-//----------------------------------------------------------------------
// RNBContext constructor
-//----------------------------------------------------------------------
const char *RNBContext::EnvironmentAtIndex(size_t index) {
if (index < m_env_vec.size())
@@ -134,10 +130,8 @@ void RNBContext::StopProcessStatusThread
}
}
-//----------------------------------------------------------------------
// This thread's sole purpose is to watch for any status changes in the
// child process.
-//----------------------------------------------------------------------
void *RNBContext::ThreadFunctionProcessStatus(void *arg) {
RNBRemoteSP remoteSP(g_remoteSP);
RNBRemote *remote = remoteSP.get();
Modified: lldb/trunk/tools/debugserver/source/RNBContext.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/RNBContext.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/RNBContext.h (original)
+++ lldb/trunk/tools/debugserver/source/RNBContext.h Wed Apr 10 13:48:55 2019
@@ -42,9 +42,7 @@ public:
all_event_bits = sticky_event_bits | normal_event_bits
} event_t;
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
RNBContext()
: m_pid(INVALID_NUB_PROCESS), m_pid_stop_count(0),
m_events(0, all_event_bits), m_pid_pthread(), m_launch_status(),
@@ -127,9 +125,7 @@ public:
bool GetDetachOnError() { return m_detach_on_error; }
protected:
- //------------------------------------------------------------------
// Classes that inherit from RNBContext can see and modify these
- //------------------------------------------------------------------
nub_process_t m_pid;
std::string m_stdin;
std::string m_stdout;
@@ -153,9 +149,7 @@ protected:
static void *ThreadFunctionProcessStatus(void *arg);
private:
- //------------------------------------------------------------------
// Outlaw copy and assignment operators
- //------------------------------------------------------------------
RNBContext(const RNBContext &rhs);
RNBContext &operator=(const RNBContext &rhs);
};
Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/RNBRemote.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/RNBRemote.cpp (original)
+++ lldb/trunk/tools/debugserver/source/RNBRemote.cpp Wed Apr 10 13:48:55 2019
@@ -49,18 +49,14 @@
#include <sstream>
#include <unordered_set>
-//----------------------------------------------------------------------
// constants
-//----------------------------------------------------------------------
static const std::string OS_LOG_EVENTS_KEY_NAME("events");
static const std::string JSON_ASYNC_TYPE_KEY_NAME("type");
static const DarwinLogEventVector::size_type DARWIN_LOG_MAX_EVENTS_PER_PACKET =
10;
-//----------------------------------------------------------------------
// std::iostream formatting macros
-//----------------------------------------------------------------------
#define RAW_HEXBASE std::setfill('0') << std::hex << std::right
#define HEXBASE '0' << 'x' << RAW_HEXBASE
#define RAWHEX8(x) RAW_HEXBASE << std::setw(2) << ((uint32_t)((uint8_t)x))
@@ -89,16 +85,12 @@ static const DarwinLogEventVector::size_
std::setfill('\t') << std::setw((iword_idx)) << ""
// Class to handle communications via gdb remote protocol.
-//----------------------------------------------------------------------
// Prototypes
-//----------------------------------------------------------------------
static std::string binary_encode_string(const std::string &s);
-//----------------------------------------------------------------------
// Decode a single hex character and return the hex value as a number or
// -1 if "ch" is not a hex character.
-//----------------------------------------------------------------------
static inline int xdigit_to_sint(char ch) {
if (ch >= 'a' && ch <= 'f')
return 10 + ch - 'a';
@@ -109,10 +101,8 @@ static inline int xdigit_to_sint(char ch
return -1;
}
-//----------------------------------------------------------------------
// Decode a single hex ASCII byte. Return -1 on failure, a value 0-255
// on success.
-//----------------------------------------------------------------------
static inline int decoded_hex_ascii_char(const char *p) {
const int hi_nibble = xdigit_to_sint(p[0]);
if (hi_nibble == -1)
@@ -123,9 +113,7 @@ static inline int decoded_hex_ascii_char
return (uint8_t)((hi_nibble << 4) + lo_nibble);
}
-//----------------------------------------------------------------------
// Decode a hex ASCII string back into a string
-//----------------------------------------------------------------------
static std::string decode_hex_ascii_string(const char *p,
uint32_t max_length = UINT32_MAX) {
std::string arg;
@@ -4414,10 +4402,8 @@ rnb_err_t RNBRemote::HandlePacket_C(cons
return rnb_success;
}
-//----------------------------------------------------------------------
// 'D' packet
// Detach from gdb.
-//----------------------------------------------------------------------
rnb_err_t RNBRemote::HandlePacket_D(const char *p) {
if (m_ctx.HasValidProcessID()) {
if (DNBProcessDetach(m_ctx.ProcessID()))
@@ -5821,13 +5807,11 @@ static nub_addr_t GetMachHeaderForMainEx
DNBDataRef::offset_t offset = 0;
data.SetPointerSize(addr_size);
- //----------------------------------------------------------------------
// When we are sitting at __dyld_start, the kernel has placed the
// address of the mach header of the main executable on the stack. If we
// read the SP and dereference a pointer, we might find the mach header
// for the executable. We also just make sure there is only 1 thread
// since if we are at __dyld_start we shouldn't have multiple threads.
- //----------------------------------------------------------------------
if (DNBProcessGetNumThreads(pid) == 1) {
nub_thread_t tid = DNBProcessGetThreadAtIndex(pid, 0);
if (tid != INVALID_NUB_THREAD) {
@@ -5847,10 +5831,8 @@ static nub_addr_t GetMachHeaderForMainEx
}
}
- //----------------------------------------------------------------------
// Check the dyld_all_image_info structure for a list of mach header
// since it is a very easy thing to check
- //----------------------------------------------------------------------
if (shlib_addr != INVALID_NUB_ADDRESS) {
bytes_read =
DNBProcessMemoryRead(pid, shlib_addr, sizeof(AllImageInfos), bytes);
@@ -5880,12 +5862,10 @@ static nub_addr_t GetMachHeaderForMainEx
}
}
- //----------------------------------------------------------------------
// We failed to find the executable's mach header from the all image
// infos and by dereferencing the stack pointer. Now we fall back to
// enumerating the memory regions and looking for regions that are
// executable.
- //----------------------------------------------------------------------
DNBRegionInfo region_info;
mach_header_addr = 0;
while (DNBProcessMemoryRegionInfo(pid, mach_header_addr, ®ion_info)) {
Modified: lldb/trunk/tools/debugserver/source/StdStringExtractor.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/StdStringExtractor.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/StdStringExtractor.cpp (original)
+++ lldb/trunk/tools/debugserver/source/StdStringExtractor.cpp Wed Apr 10 13:48:55 2019
@@ -21,9 +21,7 @@ static inline int xdigit_to_sint(char ch
return -1;
}
-//----------------------------------------------------------------------
// StdStringExtractor constructor
-//----------------------------------------------------------------------
StdStringExtractor::StdStringExtractor() : m_packet(), m_index(0) {}
StdStringExtractor::StdStringExtractor(const char *packet_cstr)
@@ -32,15 +30,11 @@ StdStringExtractor::StdStringExtractor(c
m_packet.assign(packet_cstr);
}
-//----------------------------------------------------------------------
// StdStringExtractor copy constructor
-//----------------------------------------------------------------------
StdStringExtractor::StdStringExtractor(const StdStringExtractor &rhs)
: m_packet(rhs.m_packet), m_index(rhs.m_index) {}
-//----------------------------------------------------------------------
// StdStringExtractor assignment operator
-//----------------------------------------------------------------------
const StdStringExtractor &StdStringExtractor::
operator=(const StdStringExtractor &rhs) {
if (this != &rhs) {
@@ -50,9 +44,7 @@ operator=(const StdStringExtractor &rhs)
return *this;
}
-//----------------------------------------------------------------------
// Destructor
-//----------------------------------------------------------------------
StdStringExtractor::~StdStringExtractor() {}
char StdStringExtractor::GetChar(char fail_value) {
@@ -65,14 +57,12 @@ char StdStringExtractor::GetChar(char fa
return fail_value;
}
-//----------------------------------------------------------------------
// If a pair of valid hex digits exist at the head of the
// StdStringExtractor they are decoded into an unsigned byte and returned
// by this function
//
// If there is not a pair of valid hex digits at the head of the
// StdStringExtractor, it is left unchanged and -1 is returned
-//----------------------------------------------------------------------
int StdStringExtractor::DecodeHexU8() {
SkipSpaces();
if (GetBytesLeft() < 2) {
@@ -87,10 +77,8 @@ int StdStringExtractor::DecodeHexU8() {
return (uint8_t)((hi_nibble << 4) + lo_nibble);
}
-//----------------------------------------------------------------------
// Extract an unsigned character from two hex ASCII chars in the packet
// string, or return fail_value on failure
-//----------------------------------------------------------------------
uint8_t StdStringExtractor::GetHexU8(uint8_t fail_value, bool set_eof_on_fail) {
// On success, fail_value will be overwritten with the next
// character in the stream
@@ -290,12 +278,10 @@ size_t StdStringExtractor::GetHexBytes(v
return bytes_extracted;
}
-//----------------------------------------------------------------------
// Decodes all valid hex encoded bytes at the head of the
// StdStringExtractor, limited by dst_len.
//
// Returns the number of bytes successfully decoded
-//----------------------------------------------------------------------
size_t StdStringExtractor::GetHexBytesAvail(void *dst_void, size_t dst_len) {
uint8_t *dst = (uint8_t *)dst_void;
size_t bytes_extracted = 0;
Modified: lldb/trunk/tools/debugserver/source/StdStringExtractor.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/StdStringExtractor.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/StdStringExtractor.h (original)
+++ lldb/trunk/tools/debugserver/source/StdStringExtractor.h Wed Apr 10 13:48:55 2019
@@ -18,17 +18,13 @@
class StdStringExtractor {
public:
enum { BigEndian = 0, LittleEndian = 1 };
- //------------------------------------------------------------------
// Constructors and Destructors
- //------------------------------------------------------------------
StdStringExtractor();
StdStringExtractor(const char *packet_cstr);
StdStringExtractor(const StdStringExtractor &rhs);
virtual ~StdStringExtractor();
- //------------------------------------------------------------------
// Operators
- //------------------------------------------------------------------
const StdStringExtractor &operator=(const StdStringExtractor &rhs);
// Returns true if the file position is still valid for the data
@@ -107,9 +103,7 @@ public:
}
protected:
- //------------------------------------------------------------------
// For StdStringExtractor only
- //------------------------------------------------------------------
std::string m_packet; // The string in which to extract data.
uint64_t m_index; // When extracting data from a packet, this index
// will march along as things get extracted. If set
Modified: lldb/trunk/tools/debugserver/source/debugserver.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/debugserver.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/debugserver.cpp (original)
+++ lldb/trunk/tools/debugserver/source/debugserver.cpp Wed Apr 10 13:48:55 2019
@@ -45,9 +45,7 @@ extern "C" int proc_set_wakemon_params(p
// Global PID in case we get a signal and need to stop the process...
nub_process_t g_pid = INVALID_NUB_PROCESS;
-//----------------------------------------------------------------------
// Run loop modes which determine which run loop function will be called
-//----------------------------------------------------------------------
typedef enum {
eRNBRunLoopModeInvalid = 0,
eRNBRunLoopModeGetStartModeFromRemoteProtocol,
@@ -58,9 +56,7 @@ typedef enum {
eRNBRunLoopModeExit
} RNBRunLoopMode;
-//----------------------------------------------------------------------
// Global Variables
-//----------------------------------------------------------------------
RNBRemoteSP g_remoteSP;
static int g_lockdown_opt = 0;
static int g_applist_opt = 0;
@@ -87,12 +83,10 @@ bool g_detach_on_error = true;
} \
} while (0)
-//----------------------------------------------------------------------
// Get our program path and arguments from the remote connection.
// We will need to start up the remote connection without a PID, get the
// arguments, wait for the new process to finish launching and hit its
// entry point, and then return the run loop mode that should come next.
-//----------------------------------------------------------------------
RNBRunLoopMode RNBRunLoopGetStartModeFromRemote(RNBRemote *remote) {
std::string packet;
@@ -162,12 +156,10 @@ RNBRunLoopMode RNBRunLoopGetStartModeFro
return eRNBRunLoopModeExit;
}
-//----------------------------------------------------------------------
// This run loop mode will wait for the process to launch and hit its
// entry point. It will currently ignore all events except for the
// process state changed event, where it watches for the process stopped
// or crash process state.
-//----------------------------------------------------------------------
RNBRunLoopMode RNBRunLoopLaunchInferior(RNBRemote *remote,
const char *stdin_path,
const char *stdout_path,
@@ -351,12 +343,10 @@ RNBRunLoopMode RNBRunLoopLaunchInferior(
return eRNBRunLoopModeExit;
}
-//----------------------------------------------------------------------
// This run loop mode will wait for the process to launch and hit its
// entry point. It will currently ignore all events except for the
// process state changed event, where it watches for the process stopped
// or crash process state.
-//----------------------------------------------------------------------
RNBRunLoopMode RNBRunLoopLaunchAttaching(RNBRemote *remote,
nub_process_t attach_pid,
nub_process_t &pid) {
@@ -379,11 +369,9 @@ RNBRunLoopMode RNBRunLoopLaunchAttaching
}
}
-//----------------------------------------------------------------------
// Watch for signals:
// SIGINT: so we can halt our inferior. (disabled for now)
// SIGPIPE: in case our child process dies
-//----------------------------------------------------------------------
int g_sigint_received = 0;
int g_sigpipe_received = 0;
void signal_handler(int signo) {
@@ -654,10 +642,8 @@ RNBRunLoopMode RNBRunLoopPlatform(RNBRem
return eRNBRunLoopModeExit;
}
-//----------------------------------------------------------------------
// Convenience function to set up the remote listening port
// Returns 1 for success 0 for failure.
-//----------------------------------------------------------------------
static void PortWasBoundCallbackUnixSocket(const void *baton, in_port_t port) {
//::printf ("PortWasBoundCallbackUnixSocket (baton = %p, port = %u)\n", baton,
@@ -761,9 +747,7 @@ static int ConnectRemote(RNBRemote *remo
return 1;
}
-//----------------------------------------------------------------------
// ASL Logging callback that can be registered with DNBLogSetLogCallback
-//----------------------------------------------------------------------
void ASLLogCallback(void *baton, uint32_t flags, const char *format,
va_list args) {
if (format == NULL)
@@ -792,10 +776,8 @@ void ASLLogCallback(void *baton, uint32_
::asl_vlog(NULL, g_aslmsg, asl_level, format, args);
}
-//----------------------------------------------------------------------
// FILE based Logging callback that can be registered with
// DNBLogSetLogCallback
-//----------------------------------------------------------------------
void FileLogCallback(void *baton, uint32_t flags, const char *format,
va_list args) {
if (baton == NULL || format == NULL)
@@ -821,9 +803,7 @@ void show_usage_and_exit(int exit_code)
exit(exit_code);
}
-//----------------------------------------------------------------------
// option descriptors for getopt_long_only()
-//----------------------------------------------------------------------
static struct option g_long_options[] = {
{"attach", required_argument, NULL, 'a'},
{"arch", required_argument, NULL, 'A'},
@@ -890,9 +870,7 @@ static struct option g_long_options[] =
// -F localhost:1234 -- /bin/ls"
{NULL, 0, NULL, 0}};
-//----------------------------------------------------------------------
// main
-//----------------------------------------------------------------------
int main(int argc, char *argv[]) {
// If debugserver is launched with DYLD_INSERT_LIBRARIES, unset it so we
// don't spawn child processes with this enabled.
Modified: lldb/trunk/tools/debugserver/source/libdebugserver.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/libdebugserver.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/libdebugserver.cpp (original)
+++ lldb/trunk/tools/debugserver/source/libdebugserver.cpp Wed Apr 10 13:48:55 2019
@@ -26,9 +26,7 @@
#include "RNBSocket.h"
#include "SysSignal.h"
-//----------------------------------------------------------------------
// Run loop modes which determine which run loop function will be called
-//----------------------------------------------------------------------
typedef enum {
eRNBRunLoopModeInvalid = 0,
eRNBRunLoopModeGetStartModeFromRemoteProtocol,
@@ -36,9 +34,7 @@ typedef enum {
eRNBRunLoopModeExit
} RNBRunLoopMode;
-//----------------------------------------------------------------------
// Global Variables
-//----------------------------------------------------------------------
RNBRemoteSP g_remoteSP;
int g_disable_aslr = 0;
int g_isatty = 0;
@@ -60,12 +56,10 @@ int g_isatty = 0;
} \
} while (0)
-//----------------------------------------------------------------------
// Get our program path and arguments from the remote connection.
// We will need to start up the remote connection without a PID, get the
// arguments, wait for the new process to finish launching and hit its
// entry point, and then return the run loop mode that should come next.
-//----------------------------------------------------------------------
RNBRunLoopMode RNBRunLoopGetStartModeFromRemote(RNBRemoteSP &remoteSP) {
std::string packet;
@@ -125,11 +119,9 @@ RNBRunLoopMode RNBRunLoopGetStartModeFro
return eRNBRunLoopModeExit;
}
-//----------------------------------------------------------------------
// Watch for signals:
// SIGINT: so we can halt our inferior. (disabled for now)
// SIGPIPE: in case our child process dies
-//----------------------------------------------------------------------
nub_process_t g_pid;
int g_sigpipe_received = 0;
void signal_handler(int signo) {
Modified: lldb/trunk/tools/intel-features/intel-pt/Decoder.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/intel-features/intel-pt/Decoder.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/intel-features/intel-pt/Decoder.h (original)
+++ lldb/trunk/tools/intel-features/intel-pt/Decoder.h Wed Apr 10 13:48:55 2019
@@ -29,13 +29,11 @@
#include "intel-pt.h"
namespace ptdecoder_private {
-//----------------------------------------------------------------------
/// \class Instruction
/// Represents an assembly instruction containing raw
/// instruction bytes, instruction address along with information
/// regarding execution flow context and Intel(R) Processor Trace
/// context.
-//----------------------------------------------------------------------
class Instruction {
public:
Instruction() : ip(0), data(), error(), iclass(ptic_error), speculative(0) {}
@@ -79,11 +77,9 @@ private:
uint32_t speculative : 1; // Instruction was executed speculatively or not
};
-//---------------------------------------------------------------------------
/// \class InstructionList
/// Represents a list of assembly instructions. Each instruction is of
/// type Instruction.
-//---------------------------------------------------------------------------
class InstructionList {
public:
InstructionList() : m_insn_vec() {}
@@ -109,41 +105,34 @@ private:
std::vector<Instruction> m_insn_vec;
};
-//----------------------------------------------------------------------
/// \class TraceOptions
/// Provides Intel(R) Processor Trace specific configuration options and
/// other information obtained by decoding and post-processing the trace
/// data. Currently, this information comprises of the total number of
/// assembly instructions executed for an inferior.
-//----------------------------------------------------------------------
class TraceOptions : public lldb::SBTraceOptions {
public:
TraceOptions() : lldb::SBTraceOptions(), m_insn_log_size(0) {}
~TraceOptions() {}
- //------------------------------------------------------------------
/// Get total number of assembly instructions obtained after decoding the
/// complete Intel(R) Processor Trace data obtained from LLDB.
///
/// \return
/// Total number of instructions.
- //------------------------------------------------------------------
uint32_t getInstructionLogSize() const { return m_insn_log_size; }
- //------------------------------------------------------------------
/// Set total number of assembly instructions.
///
/// \param[in] size
/// Value to be set.
- //------------------------------------------------------------------
void setInstructionLogSize(uint32_t size) { m_insn_log_size = size; }
private:
uint32_t m_insn_log_size;
};
-//----------------------------------------------------------------------
/// \class Decoder
/// This class makes use of Intel(R) Processor Trace hardware feature
/// (implememted inside LLDB) to gather trace data for an inferior (being
@@ -156,7 +145,6 @@ private:
/// - stop the trace for a thread/process,
/// - get the execution flow (assembly instructions) for a thread and
/// - get trace specific information for a thread
-//----------------------------------------------------------------------
class Decoder {
public:
typedef std::vector<Instruction> Instructions;
@@ -216,7 +204,6 @@ private:
void ParseCPUInfo(CPUInfo &pt_cpu, lldb::SBStructuredData &s,
lldb::SBError &sberror);
- ///------------------------------------------------------------------------
/// Function performs following tasks for a given process and thread:
/// - Checks if the given thread is registered in the class or not. If not
/// then tries to register it if trace was ever started on the entire
@@ -224,7 +211,6 @@ private:
/// - fetches trace and other necessary information from LLDB (using
/// ReadTraceDataAndImageInfo()) and decodes the trace (using
/// DecodeProcessorTrace())
- ///------------------------------------------------------------------------
void FetchAndDecode(lldb::SBProcess &sbprocess, lldb::tid_t tid,
lldb::SBError &sberror,
ThreadTraceInfo **threadTraceInfo);
@@ -248,12 +234,10 @@ private:
ReadExecuteSectionInfos &readExecuteSectionInfos,
lldb::SBError &sberror);
- ///------------------------------------------------------------------------
/// Helper functions of DecodeProcessorTrace() function for:
/// - initializing raw trace decoder (provided by Intel(R) Processor Trace
/// Decoding library)
/// - start trace decoding
- ///------------------------------------------------------------------------
void InitializePTInstDecoder(
struct pt_insn_decoder **decoder, struct pt_config *config,
const CPUInfo &pt_cpu, Buffer &pt_buffer,
Modified: lldb/trunk/tools/intel-features/intel-pt/PTDecoder.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/intel-features/intel-pt/PTDecoder.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/intel-features/intel-pt/PTDecoder.h (original)
+++ lldb/trunk/tools/intel-features/intel-pt/PTDecoder.h Wed Apr 10 13:48:55 2019
@@ -29,13 +29,11 @@ class Decoder;
namespace ptdecoder {
-//----------------------------------------------------------------------
/// \class PTInstruction
/// Represents an assembly instruction containing raw
/// instruction bytes, instruction address along with information
/// regarding execution flow context and Intel(R) Processor Trace
/// context.
-//----------------------------------------------------------------------
class PTInstruction {
public:
PTInstruction();
@@ -49,7 +47,6 @@ public:
// Get instruction address in inferior's memory image
uint64_t GetInsnAddress() const;
- //------------------------------------------------------------------
/// Get raw bytes of the instruction in the buffer.
///
/// \param[out] buf
@@ -67,7 +64,6 @@ public:
/// Number of bytes of the instruction actually written to @buf if API
/// succeeds. In case of errors, total number of raw bytes of the
/// instruction is returned.
- //------------------------------------------------------------------
size_t GetRawBytes(void *buf, size_t size) const;
// Get error string if it represents an invalid instruction. For a valid
@@ -81,11 +77,9 @@ private:
std::shared_ptr<ptdecoder_private::Instruction> m_opaque_sp;
};
-//---------------------------------------------------------------------------
/// \class PTInstructionList
/// Represents a list of assembly instructions. Each instruction is of
/// type PTInstruction.
-//---------------------------------------------------------------------------
class PTInstructionList {
public:
PTInstructionList();
@@ -110,12 +104,10 @@ private:
std::shared_ptr<ptdecoder_private::InstructionList> m_opaque_sp;
};
-//----------------------------------------------------------------------
/// \class PTTraceOptions
/// Provides configuration options like trace type, trace buffer size,
/// meta data buffer size along with other Intel(R) Processor Trace
/// specific options.
-//----------------------------------------------------------------------
class PTTraceOptions {
public:
PTTraceOptions();
@@ -130,7 +122,6 @@ public:
uint64_t GetMetaDataBufferSize() const;
- //------------------------------------------------------------------
/// Get Intel(R) Processor Trace specific configuration options (apart from
/// trace buffer size, meta data buffer size and TraceType) formatted as
/// json text i.e. {"Name":Value,"Name":Value} pairs, where "Value" is a
@@ -139,7 +130,6 @@ public:
///
/// \return
/// A string formatted as json text {"Name":Value,"Name":Value}
- //------------------------------------------------------------------
lldb::SBStructuredData GetTraceParams(lldb::SBError &error);
private:
@@ -150,7 +140,6 @@ private:
std::shared_ptr<ptdecoder_private::TraceOptions> m_opaque_sp;
};
-//----------------------------------------------------------------------
/// \class PTDecoder
/// This class makes use of Intel(R) Processor Trace hardware feature
/// (implememted inside LLDB) to gather trace data for an inferior (being
@@ -163,7 +152,6 @@ private:
/// - stop the trace for a thread/process,
/// - get the execution flow (assembly instructions) for a thread and
/// - get trace specific information for a thread
-//----------------------------------------------------------------------
class PTDecoder {
public:
PTDecoder(lldb::SBDebugger &sbdebugger);
@@ -172,7 +160,6 @@ public:
~PTDecoder();
- //------------------------------------------------------------------
/// Start Intel(R) Processor Trace on a thread or complete process with
/// Intel(R) Processor Trace specific configuration options
///
@@ -211,12 +198,10 @@ public:
///
/// \param[out] sberror
/// An error with the failure reason if API fails. Else success.
- //------------------------------------------------------------------
void StartProcessorTrace(lldb::SBProcess &sbprocess,
lldb::SBTraceOptions &sbtraceoptions,
lldb::SBError &sberror);
- //------------------------------------------------------------------
/// Stop Intel(R) Processor Trace on a thread or complete process.
///
/// \param[in] sbprocess
@@ -231,11 +216,9 @@ public:
///
/// \param[out] sberror
/// An error with the failure reason if API fails. Else success.
- //------------------------------------------------------------------
void StopProcessorTrace(lldb::SBProcess &sbprocess, lldb::SBError &sberror,
lldb::tid_t tid = LLDB_INVALID_THREAD_ID);
- //------------------------------------------------------------------
/// Get instruction log containing the execution flow for a thread of a
/// process in terms of assembly instructions executed.
///
@@ -269,13 +252,11 @@ public:
///
/// \param[out] sberror
/// An error with the failure reason if API fails. Else success.
- //------------------------------------------------------------------
void GetInstructionLogAtOffset(lldb::SBProcess &sbprocess, lldb::tid_t tid,
uint32_t offset, uint32_t count,
PTInstructionList &result_list,
lldb::SBError &sberror);
- //------------------------------------------------------------------
/// Get Intel(R) Processor Trace specific information for a thread of a
/// process. The information contains the actual configuration options with
/// which the trace was started for this thread.
@@ -296,7 +277,6 @@ public:
///
/// \param[out] sberror
/// An error with the failure reason if API fails. Else success.
- //------------------------------------------------------------------
void GetProcessorTraceInfo(lldb::SBProcess &sbprocess, lldb::tid_t tid,
PTTraceOptions &options, lldb::SBError &sberror);
Modified: lldb/trunk/tools/lldb-mi/MICmdArgContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgContext.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgContext.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgContext.cpp Wed Apr 10 13:48:55 2019
@@ -10,7 +10,6 @@
#include "MICmdArgContext.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgContext constructor.
// Type: Method.
// Args: None.
@@ -20,7 +19,6 @@
CMICmdArgContext::CMICmdArgContext() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgContext constructor.
// Type: Method.
// Args: vrCmdLineArgsRaw - (R) The text description of the arguments
@@ -32,7 +30,6 @@ CMICmdArgContext::CMICmdArgContext(const
: m_strCmdArgsAndOptions(vrCmdLineArgsRaw) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgContext destructor.
// Type: Method.
// Args: None.
@@ -42,7 +39,6 @@ CMICmdArgContext::CMICmdArgContext(const
CMICmdArgContext::~CMICmdArgContext() {}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the remainder of the command's argument options left to
// parse.
// Type: Method.
@@ -55,7 +51,6 @@ const CMIUtilString &CMICmdArgContext::G
}
//++
-//------------------------------------------------------------------------------------
// Details: Ask if this arguments string has any arguments.
// Type: Method.
// Args: None.
@@ -68,7 +63,6 @@ bool CMICmdArgContext::IsEmpty() const {
}
//++
-//------------------------------------------------------------------------------------
// Details: Remove the argument from the options text and any space after the
// argument
// if applicable.
@@ -127,7 +121,6 @@ bool CMICmdArgContext::RemoveArg(const C
}
//++
-//------------------------------------------------------------------------------------
// Details: Remove the argument at the Nth word position along in the context
// string.
// Any space after the argument is removed if applicable. A search is
@@ -187,7 +180,6 @@ bool CMICmdArgContext::RemoveArgAtPos(co
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve number of arguments or options present in the command's
// option text.
// Type: Method.
@@ -201,7 +193,6 @@ size_t CMICmdArgContext::GetNumberArgsPr
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve all the arguments or options remaining in *this context.
// Type: Method.
// Args: None.
@@ -215,7 +206,6 @@ CMIUtilString::VecString_t CMICmdArgCont
}
//++
-//------------------------------------------------------------------------------------
// Details: Copy assignment operator.
// Type: Method.
// Args: vOther - (R) The variable to copy from.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgSet.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgSet.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgSet.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgSet.cpp Wed Apr 10 13:48:55 2019
@@ -13,7 +13,6 @@
#include "MICmnResources.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgSet constructor.
// Type: Method.
// Args: None.
@@ -24,7 +23,6 @@ CMICmdArgSet::CMICmdArgSet()
: m_bIsArgsPresentButNotHandledByCmd(false), m_constStrCommaSpc(", ") {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgSet destructor.
// Type: Method.
// Args: None.
@@ -37,7 +35,6 @@ CMICmdArgSet::~CMICmdArgSet() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources used by *this container object.
// Type: Method.
// Args: None.
@@ -66,7 +63,6 @@ void CMICmdArgSet::Destroy() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the state flag indicating that the command set up ready to
// parse
// command arguments or options found that one or more arguments was
@@ -83,7 +79,6 @@ bool CMICmdArgSet::IsArgsPresentButNotHa
}
//++
-//------------------------------------------------------------------------------------
// Details: Add the list of command's arguments to parse and validate another
// one.
// Type: Method.
@@ -94,7 +89,6 @@ bool CMICmdArgSet::IsArgsPresentButNotHa
void CMICmdArgSet::Add(CMICmdArgValBase *vArg) { m_setCmdArgs.push_back(vArg); }
//++
-//------------------------------------------------------------------------------------
// Details: After validating an options line of text (the context) and there is
// a failure,
// it is likely a mandatory command argument that is required is
@@ -110,7 +104,6 @@ const CMICmdArgSet::SetCmdArgs_t &CMICmd
}
//++
-//------------------------------------------------------------------------------------
// Details: After validating an options line of text (the context) and there is
// a failure,
// it may be because one or more arguments were unable to extract a
@@ -126,7 +119,6 @@ const CMICmdArgSet::SetCmdArgs_t &CMICmd
}
//++
-//------------------------------------------------------------------------------------
// Details: The list of argument or option (objects) that were specified by the
// command
// and so recognised when parsed but were not handled. Ideally the
@@ -148,7 +140,6 @@ const CMICmdArgSet::SetCmdArgs_t &CMICmd
}
//++
-//------------------------------------------------------------------------------------
// Details: Given a set of command argument objects parse the context option
// string to
// find those argument and retrieve their value. If the function fails
@@ -199,7 +190,6 @@ bool CMICmdArgSet::Validate(const CMIUti
}
//++
-//------------------------------------------------------------------------------------
// Details: Having validated the command's options text and failed for some
// reason form
// the error message made up with the faults found.
@@ -310,7 +300,6 @@ bool CMICmdArgSet::ValidationFormErrorMe
}
//++
-//------------------------------------------------------------------------------------
// Details: Ask if the command's argument options text had any arguments.
// Type: Method.
// Args: None.
@@ -323,7 +312,6 @@ bool CMICmdArgSet::IsArgContextEmpty() c
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the number of arguments that are being used for the
// command.
// Type: Method.
@@ -334,7 +322,6 @@ bool CMICmdArgSet::IsArgContextEmpty() c
size_t CMICmdArgSet::GetCount() const { return m_setCmdArgs.size(); }
//++
-//------------------------------------------------------------------------------------
// Details: Given a set of command argument objects retrieve the argument with
// the
// specified name.
@@ -364,7 +351,6 @@ bool CMICmdArgSet::GetArg(const CMIUtilS
}
//++
-//------------------------------------------------------------------------------------
// Details: Write a warning message to the MI Log file about the command's
// arguments or
// options that were found present but not handled.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValBase.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValBase.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValBase.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValBase.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MIUtilString.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValBase constructor.
// Type: Method.
// Args: None.
@@ -23,7 +22,6 @@ CMICmdArgValBase::CMICmdArgValBase()
m_bIsMissingOptions(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValBase constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -42,7 +40,6 @@ CMICmdArgValBase::CMICmdArgValBase(const
m_bIsMissingOptions(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the state flag of whether the argument is handled by the
// command or
// not.
@@ -57,7 +54,6 @@ bool CMICmdArgValBase::GetIsMissingOptio
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the state flag of whether the argument is handled by the
// command or
// not.
@@ -70,7 +66,6 @@ bool CMICmdArgValBase::GetIsMissingOptio
bool CMICmdArgValBase::GetIsHandledByCmd() const { return m_bHandled; }
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the name of *this argument.
// Type: Method.
// Args: None.
@@ -80,7 +75,6 @@ bool CMICmdArgValBase::GetIsHandledByCmd
const CMIUtilString &CMICmdArgValBase::GetName() const { return m_strArgName; }
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the state flag of whether the argument was found in the
// command's
// argument / options string.
@@ -93,7 +87,6 @@ const CMIUtilString &CMICmdArgValBase::G
bool CMICmdArgValBase::GetFound() const { return m_bFound; }
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the state flag indicating whether the value was obtained
// from the
// text arguments string and is valid.
@@ -106,7 +99,6 @@ bool CMICmdArgValBase::GetFound() const
bool CMICmdArgValBase::GetValid() const { return m_bValid; }
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the state flag indicating whether *this argument is a
// mandatory
// argument for the command or is optional to be present.
@@ -119,7 +111,6 @@ bool CMICmdArgValBase::GetValid() const
bool CMICmdArgValBase::GetIsMandatory() const { return m_bMandatory; }
//++
-//------------------------------------------------------------------------------------
// Details: Parse the command's argument options string and try to extract the
// value *this
// argument is looking for.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValBase.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValBase.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValBase.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValBase.h Wed Apr 10 13:48:55 2019
@@ -85,7 +85,6 @@ protected:
};
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValBaseTemplate constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -103,7 +102,6 @@ CMICmdArgValBaseTemplate<T>::CMICmdArgVa
: CMICmdArgValBase(vrArgName, vbMandatory, vbHandleByCmd) {}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the value the argument parsed from the command's argument /
// options
// text string.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValConsume.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValConsume.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValConsume.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValConsume.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmdArgContext.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValConsume constructor.
// Type: Method.
// Args: None.
@@ -21,7 +20,6 @@
CMICmdArgValConsume::CMICmdArgValConsume() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValConsume constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -35,7 +33,6 @@ CMICmdArgValConsume::CMICmdArgValConsume
: CMICmdArgValBaseTemplate(vrArgName, vbMandatory, true) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValConsume destructor.
// Type: Overidden.
// Args: None.
@@ -45,7 +42,6 @@ CMICmdArgValConsume::CMICmdArgValConsume
CMICmdArgValConsume::~CMICmdArgValConsume() {}
//++
-//------------------------------------------------------------------------------------
// Details: Parse the command's argument options string and try to extract the
// value *this
// argument is looking for.
@@ -81,7 +77,6 @@ bool CMICmdArgValConsume::Validate(CMICm
}
//++
-//------------------------------------------------------------------------------------
// Details: Nothing to examine as we just want to consume the argument or option
// (ignore
// it).
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValFile.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValFile.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValFile.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValFile.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmdArgContext.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValFile constructor.
// Type: Method.
// Args: None.
@@ -21,7 +20,6 @@
CMICmdArgValFile::CMICmdArgValFile() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValFile constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -38,7 +36,6 @@ CMICmdArgValFile::CMICmdArgValFile(const
: CMICmdArgValBaseTemplate(vrArgName, vbMandatory, vbHandleByCmd) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValFile destructor.
// Type: Overridden.
// Args: None.
@@ -48,7 +45,6 @@ CMICmdArgValFile::CMICmdArgValFile(const
CMICmdArgValFile::~CMICmdArgValFile() {}
//++
-//------------------------------------------------------------------------------------
// Details: Parse the command's argument options string and try to extract the
// value *this
// argument is looking for.
@@ -101,7 +97,6 @@ bool CMICmdArgValFile::Validate(CMICmdAr
}
//++
-//------------------------------------------------------------------------------------
// Details: Given some text extract the file name path from it. If a space is
// found in
// path done return the path surrounded in quotes.
@@ -124,7 +119,6 @@ CMICmdArgValFile::GetFileNamePath(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid file name path.
// Type: Method.
// Args: vrFileNamePath - (R) File's name and directory path.
@@ -161,7 +155,6 @@ bool CMICmdArgValFile::IsFilePath(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Determine if the path contains valid characters for a file path.
// Letters can be
// either upper or lower case.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValListBase.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValListBase.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValListBase.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValListBase.cpp Wed Apr 10 13:48:55 2019
@@ -18,7 +18,6 @@
#include "MICmdArgValThreadGrp.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValListBase constructor.
// Type: Method.
// Args: None.
@@ -29,7 +28,6 @@ CMICmdArgValListBase::CMICmdArgValListBa
: m_eArgType(eArgValType_invalid) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValListBase constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -47,7 +45,6 @@ CMICmdArgValListBase::CMICmdArgValListBa
m_eArgType(eArgValType_invalid) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValListBase constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -68,7 +65,6 @@ CMICmdArgValListBase::CMICmdArgValListBa
m_eArgType(veType) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValListBase destructor.
// Type: Overridden.
// Args: None.
@@ -81,7 +77,6 @@ CMICmdArgValListBase::~CMICmdArgValListB
}
//++
-//------------------------------------------------------------------------------------
// Details: Tear down resources used by *this object.
// Type: Method.
// Args: None.
@@ -102,7 +97,6 @@ void CMICmdArgValListBase::Destroy() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Create an CMICmdArgValBase derived object matching the type
// specified
// and put the option or argument's value inside it.
@@ -163,7 +157,6 @@ CMICmdArgValListBase::CreationObj(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Validate the option or argument is the correct type.
// Type: Method.
// Args: vrTxt - (R) Text version the option or argument.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValListBase.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValListBase.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValListBase.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValListBase.h Wed Apr 10 13:48:55 2019
@@ -45,7 +45,6 @@ public:
// Enums:
public:
//++
- //---------------------------------------------------------------------------------
// Details: CMICmdArgValListBase needs to know what type of argument to look
// for in
// the command options text. It also needs to create argument objects
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValListOfN.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValListOfN.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValListOfN.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValListOfN.cpp Wed Apr 10 13:48:55 2019
@@ -17,7 +17,6 @@
#include "MICmdArgValThreadGrp.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValListOfN constructor.
// Type: Method.
// Args: None.
@@ -27,7 +26,6 @@
CMICmdArgValListOfN::CMICmdArgValListOfN() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValListOfN constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -47,7 +45,6 @@ CMICmdArgValListOfN::CMICmdArgValListOfN
: CMICmdArgValListBase(vrArgName, vbMandatory, vbHandleByCmd, veType) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValListOfN destructor.
// Type: Overridden.
// Args: None.
@@ -57,7 +54,6 @@ CMICmdArgValListOfN::CMICmdArgValListOfN
CMICmdArgValListOfN::~CMICmdArgValListOfN() {}
//++
-//------------------------------------------------------------------------------------
// Details: Parse the command's argument options string and try to extract the
// list of
// arguments based on the argument object type to look for.
@@ -87,7 +83,6 @@ bool CMICmdArgValListOfN::Validate(CMICm
}
//++
-//------------------------------------------------------------------------------------
// Details: Create list of argument objects each holding a value extract from
// the command
// options line.
@@ -124,7 +119,6 @@ bool CMICmdArgValListOfN::CreateList(con
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid string type
// argument.
// Type: Method.
@@ -157,7 +151,6 @@ bool CMICmdArgValListOfN::IsListOfN(cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the list of CMICmdArgValBase derived option objects found
// following
// *this long option argument. For example "list-thread-groups [
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValListOfN.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValListOfN.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValListOfN.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValListOfN.h Wed Apr 10 13:48:55 2019
@@ -61,7 +61,6 @@ private:
};
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the first argument or option value from the list of 1 or
// more options
// parsed from the command's options string.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValNumber.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValNumber.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValNumber.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValNumber.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmdArgContext.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValNumber constructor.
// Type: Method.
// Args: None.
@@ -23,7 +22,6 @@ CMICmdArgValNumber::CMICmdArgValNumber()
m_nNumber(0) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValNumber constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -45,7 +43,6 @@ CMICmdArgValNumber::CMICmdArgValNumber(
m_nNumberFormatMask(vnNumberFormatMask), m_nNumber(0) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValNumber destructor.
// Type: Overridden.
// Args: None.
@@ -55,7 +52,6 @@ CMICmdArgValNumber::CMICmdArgValNumber(
CMICmdArgValNumber::~CMICmdArgValNumber() {}
//++
-//------------------------------------------------------------------------------------
// Details: Parse the command's argument options string and try to extract the
// value *this
// argument is looking for.
@@ -105,7 +101,6 @@ bool CMICmdArgValNumber::Validate(CMICmd
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid string type
// argument.
// Type: Method.
@@ -134,7 +129,6 @@ bool CMICmdArgValNumber::IsArgNumber(con
}
//++
-//------------------------------------------------------------------------------------
// Details: Extract the thread group number from the thread group argument.
// Type: Method.
// Args: vrTxt - (R) Some text.
@@ -153,7 +147,6 @@ bool CMICmdArgValNumber::ExtractNumber(c
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the thread group ID found in the argument.
// Type: Method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValNumber.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValNumber.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValNumber.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValNumber.h Wed Apr 10 13:48:55 2019
@@ -28,7 +28,6 @@ class CMICmdArgValNumber : public CMICmd
// Enums:
public:
//++
- //---------------------------------------------------------------------------------
// Details: CMICmdArgValNumber needs to know what format of argument to look
// for in
// the command options text.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValOptionLong.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValOptionLong.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValOptionLong.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValOptionLong.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmdArgContext.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValOptionLong constructor.
// Type: Method.
// Args: None.
@@ -22,7 +21,6 @@ CMICmdArgValOptionLong::CMICmdArgValOpti
: m_nExpectingNOptions(0), m_eExpectingOptionType(eArgValType_invalid) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValOptionLong constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -40,7 +38,6 @@ CMICmdArgValOptionLong::CMICmdArgValOpti
m_nExpectingNOptions(0), m_eExpectingOptionType(eArgValType_invalid) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValOptionLong constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -65,7 +62,6 @@ CMICmdArgValOptionLong::CMICmdArgValOpti
m_eExpectingOptionType(veType) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValOptionLong destructor.
// Type: Overridden.
// Args: None.
@@ -78,7 +74,6 @@ CMICmdArgValOptionLong::~CMICmdArgValOpt
}
//++
-//------------------------------------------------------------------------------------
// Details: Tear down resources used by *this object.
// Type: Method.
// Args: None.
@@ -99,7 +94,6 @@ void CMICmdArgValOptionLong::Destroy() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Parse the command's argument options string and try to extract the
// long
// argument *this argument type is looking for.
@@ -167,7 +161,6 @@ bool CMICmdArgValOptionLong::Validate(CM
}
//++
-//------------------------------------------------------------------------------------
// Details: Parse the text following *this argument and extract the options the
// values of
// CMICmdArgValListBase::m_eArgType forming argument objects for each
@@ -228,7 +221,6 @@ bool CMICmdArgValOptionLong::ExtractExpe
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid long type option
// argument.
// Long type argument looks like --someLongOption.
@@ -255,7 +247,6 @@ bool CMICmdArgValOptionLong::IsArgLongOp
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid long type option
// argument.
// Long type argument looks like --someLongOption.
@@ -270,7 +261,6 @@ bool CMICmdArgValOptionLong::IsArgOption
}
//++
-//------------------------------------------------------------------------------------
// Details: Does the argument name of the argument being parsed ATM match the
// name of
// *this argument object.
@@ -285,7 +275,6 @@ bool CMICmdArgValOptionLong::ArgNameMatc
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the list of CMICmdArgValBase derived option objects found
// following
// *this long option argument. For example "list-thread-groups [
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValOptionLong.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValOptionLong.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValOptionLong.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValOptionLong.h Wed Apr 10 13:48:55 2019
@@ -78,7 +78,6 @@ private:
};
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the first argument or option value from the list of 1 or
// more options
// parsed from the command's options string.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValOptionShort.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValOptionShort.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValOptionShort.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValOptionShort.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmdArgContext.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValOptionShort constructor.
// Type: Method.
// Args: None.
@@ -21,7 +20,6 @@
CMICmdArgValOptionShort::CMICmdArgValOptionShort() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValOptionShort constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -38,7 +36,6 @@ CMICmdArgValOptionShort::CMICmdArgValOpt
: CMICmdArgValOptionLong(vrArgName, vbMandatory, vbHandleByCmd) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValOptionLong constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -61,7 +58,6 @@ CMICmdArgValOptionShort::CMICmdArgValOpt
vnExpectingNOptions) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValOptionShort destructor.
// Type: Overridden.
// Args: None.
@@ -71,7 +67,6 @@ CMICmdArgValOptionShort::CMICmdArgValOpt
CMICmdArgValOptionShort::~CMICmdArgValOptionShort() {}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid short type option
// argument.
// Type: Method.
@@ -98,7 +93,6 @@ bool CMICmdArgValOptionShort::IsArgShort
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid short type option
// argument.
// Long type argument looks like -f some short option.
@@ -113,7 +107,6 @@ bool CMICmdArgValOptionShort::IsArgOptio
}
//++
-//------------------------------------------------------------------------------------
// Details: Does the argument name of the argument being parsed ATM match the
// name of
// *this argument object.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValPrintValues.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValPrintValues.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValPrintValues.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValPrintValues.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmdArgContext.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValPrintValues constructor.
// Type: Method.
// Args: None.
@@ -21,7 +20,6 @@
CMICmdArgValPrintValues::CMICmdArgValPrintValues() : m_nPrintValues(0) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValPrintValues constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -39,7 +37,6 @@ CMICmdArgValPrintValues::CMICmdArgValPri
m_nPrintValues(0) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValPrintValues destructor.
// Type: Overridden.
// Args: None.
@@ -49,7 +46,6 @@ CMICmdArgValPrintValues::CMICmdArgValPri
CMICmdArgValPrintValues::~CMICmdArgValPrintValues() {}
//++
-//------------------------------------------------------------------------------------
// Details: Parse the command's argument options string and try to extract the
// value *this
// argument is looking for.
@@ -76,7 +72,6 @@ bool CMICmdArgValPrintValues::Validate(C
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid string type
// argument.
// Type: Method.
@@ -95,7 +90,6 @@ bool CMICmdArgValPrintValues::IsArgPrint
}
//++
-//------------------------------------------------------------------------------------
// Details: Extract the print-values from the print-values argument.
// Type: Method.
// Args: vrTxt - (R) Some text.
@@ -120,7 +114,6 @@ bool CMICmdArgValPrintValues::ExtractPri
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the print-values found in the argument.
// Type: Method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValString.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValString.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValString.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValString.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmdArgContext.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValString constructor.
// Type: Method.
// Args: None.
@@ -23,7 +22,6 @@ CMICmdArgValString::CMICmdArgValString()
m_bHandleDirPaths(false), m_bHandleAnything(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValString constructor.
// Type: Method.
// Args: vbAnything - (R) True = Parse a string and accept anything, false =
@@ -36,7 +34,6 @@ CMICmdArgValString::CMICmdArgValString(c
m_bHandleDirPaths(false), m_bHandleAnything(vbAnything) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValString constructor.
// Type: Method.
// Args: vbHandleQuotes - (R) True = Parse a string surrounded by quotes
@@ -58,7 +55,6 @@ CMICmdArgValString::CMICmdArgValString(c
m_bHandleDirPaths(vbHandleDirPaths), m_bHandleAnything(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValString constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -85,7 +81,6 @@ CMICmdArgValString::CMICmdArgValString(c
m_bHandleDirPaths(false), m_bHandleAnything(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValString constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -115,7 +110,6 @@ CMICmdArgValString::CMICmdArgValString(c
m_bHandleDirPaths(vbHandleDirPaths), m_bHandleAnything(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValString destructor.
// Type: Overridden.
// Args: None.
@@ -125,7 +119,6 @@ CMICmdArgValString::CMICmdArgValString(c
CMICmdArgValString::~CMICmdArgValString() {}
//++
-//------------------------------------------------------------------------------------
// Details: Parse the command's argument options string and try to extract the
// value *this
// argument is looking for.
@@ -146,7 +139,6 @@ bool CMICmdArgValString::Validate(CMICmd
}
//++
-//------------------------------------------------------------------------------------
// Details: Parse the command's argument options string and try to extract only
// the next
// word delimited by the next space.
@@ -180,7 +172,6 @@ bool CMICmdArgValString::ValidateSingleT
}
//++
-//------------------------------------------------------------------------------------
// Details: Parse the command's argument options string and try to extract all
// the words
// between quotes then delimited by the next space.
@@ -212,7 +203,6 @@ bool CMICmdArgValString::ValidateQuotedT
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid string type
// argument.
// Type: Method.
@@ -232,7 +222,6 @@ bool CMICmdArgValString::IsStringArg(con
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid string type
// argument or
// option value. If the string looks like a long option, short option,
@@ -275,7 +264,6 @@ bool CMICmdArgValString::IsStringArgSing
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid string type
// argument.
// Take into account quotes surrounding the text. Note this function
@@ -326,7 +314,6 @@ bool CMICmdArgValString::IsStringArgQuot
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid string type
// argument.
// Take into account quotes surrounding the text. Take into account
@@ -365,7 +352,6 @@ bool CMICmdArgValString::IsStringArgQuot
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid string type
// argument.
// Take into account quotes surrounding the text. Take into account
Modified: lldb/trunk/tools/lldb-mi/MICmdArgValThreadGrp.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdArgValThreadGrp.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdArgValThreadGrp.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdArgValThreadGrp.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmdArgContext.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValThreadGrp constructor.
// Type: Method.
// Args: None.
@@ -21,7 +20,6 @@
CMICmdArgValThreadGrp::CMICmdArgValThreadGrp() : m_nThreadGrp(0) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValThreadGrp constructor.
// Type: Method.
// Args: vrArgName - (R) Argument's name to search by.
@@ -39,7 +37,6 @@ CMICmdArgValThreadGrp::CMICmdArgValThrea
m_nThreadGrp(0) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdArgValThreadGrp destructor.
// Type: Overridden.
// Args: None.
@@ -49,7 +46,6 @@ CMICmdArgValThreadGrp::CMICmdArgValThrea
CMICmdArgValThreadGrp::~CMICmdArgValThreadGrp() {}
//++
-//------------------------------------------------------------------------------------
// Details: Parse the command's argument options string and try to extract the
// value *this
// argument is looking for.
@@ -99,7 +95,6 @@ bool CMICmdArgValThreadGrp::Validate(CMI
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the string and determine if it is a valid string type
// argument.
// Type: Method.
@@ -118,7 +113,6 @@ bool CMICmdArgValThreadGrp::IsArgThreadG
}
//++
-//------------------------------------------------------------------------------------
// Details: Extract the thread group number from the thread group argument.
// Type: Method.
// Args: vrTxt - (R) Some text.
@@ -138,7 +132,6 @@ bool CMICmdArgValThreadGrp::ExtractNumbe
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the thread group ID found in the argument.
// Type: Method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MICmdBase.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdBase.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdBase.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdBase.cpp Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
#include "MICmnMIValueConst.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdBase constructor.
// Type: Method.
// Args: None.
@@ -30,7 +29,6 @@ CMICmdBase::CMICmdBase()
m_ThreadArgMandatory(false), m_FrameArgMandatory(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdBase destructor.
// Type: Overrideable.
// Args: None.
@@ -40,7 +38,6 @@ CMICmdBase::CMICmdBase()
CMICmdBase::~CMICmdBase() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function.
// Type: Overridden.
// Args: None.
@@ -50,7 +47,6 @@ CMICmdBase::~CMICmdBase() {}
const SMICmdData &CMICmdBase::GetCmdData() const { return m_cmdData; }
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function.
// Type: Overridden.
// Args: None.
@@ -63,7 +59,6 @@ const CMIUtilString &CMICmdBase::GetErro
}
//++
-//------------------------------------------------------------------------------------
// Details: The CMICmdFactory requires this function. Retrieve the command and
// argument
// options description string.
@@ -75,7 +70,6 @@ const CMIUtilString &CMICmdBase::GetErro
const CMIUtilString &CMICmdBase::GetMiCmd() const { return m_strMiCmd; }
//++
-//------------------------------------------------------------------------------------
// Details: Help parse the arguments that are common to all commands.
// Args: None.
// Return: None
@@ -95,7 +89,6 @@ void CMICmdBase::AddCommonArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. A command must be given working
// data and
// provide data about its status or provide information to other
@@ -110,7 +103,6 @@ void CMICmdBase::SetCmdData(const SMICmd
}
//++
-//------------------------------------------------------------------------------------
// Details: The command factory requires this function. The factory calls this
// function
// so it can obtain *this command's creation function.
@@ -124,7 +116,6 @@ CMICmdFactory::CmdCreatorFnPtr CMICmdBas
}
//++
-//------------------------------------------------------------------------------------
// Details: If a command is an event type (has callbacks registered with
// SBListener) it
// needs to inform the Invoker that it has finished its work so that
@@ -143,7 +134,6 @@ void CMICmdBase::CmdFinishedTellInvoker(
}
//++
-//------------------------------------------------------------------------------------
// Details: Returns the final version of the MI result record built up in the
// command's
// Acknowledge function. The one line text of MI result.
@@ -157,7 +147,6 @@ const CMIUtilString &CMICmdBase::GetMIRe
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve from the command additional MI result to its 1 line
// response.
// Because of using LLDB additional 'fake'/hack output is sometimes
@@ -173,7 +162,6 @@ const CMIUtilString &CMICmdBase::GetMIRe
}
//++
-//------------------------------------------------------------------------------------
// Details: Hss *this command got additional MI result to its 1 line response.
// Because of using LLDB additional 'fake'/hack output is sometimes
// required to
@@ -189,7 +177,6 @@ bool CMICmdBase::HasMIResultRecordExtra(
}
//++
-//------------------------------------------------------------------------------------
// Details: Short cut function to enter error information into the command's
// metadata
// object and set the command's error status.
@@ -212,7 +199,6 @@ void CMICmdBase::SetError(const CMIUtilS
}
//++
-//------------------------------------------------------------------------------------
// Details: Short cut function to check MI command's execute status and
// set an error in case of failure.
// Type: Method.
@@ -236,7 +222,6 @@ bool CMICmdBase::HandleSBError(const lld
}
//++
-//------------------------------------------------------------------------------------
// Details: Short cut function to check MI command's execute status and
// call specified handler function for success case.
// Type: Method.
@@ -253,7 +238,6 @@ bool CMICmdBase::HandleSBErrorWithSucces
}
//++
-//------------------------------------------------------------------------------------
// Details: Short cut function to check MI command's execute status and
// call specified handler function for error case.
// Type: Method.
@@ -270,7 +254,6 @@ bool CMICmdBase::HandleSBErrorWithFailur
}
//++
-//------------------------------------------------------------------------------------
// Details: Ask a command to provide its unique identifier.
// Type: Method.
// Args: A unique identifier for this command class.
@@ -286,7 +269,6 @@ MIuint CMICmdBase::GetGUID() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -303,7 +285,6 @@ bool CMICmdBase::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Having previously given CMICmdArgSet m_setCmdArgs all the argument
// or option
// definitions for the command to handle proceed to parse and validate
@@ -330,7 +311,6 @@ bool CMICmdBase::ParseValidateCmdOptions
}
//++
-//------------------------------------------------------------------------------------
// Details: If the MI Driver is not operating via a client i.e. Eclipse but say
// operating
// on a executable passed in as a argument to the drive then what
Modified: lldb/trunk/tools/lldb-mi/MICmdBase.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdBase.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdBase.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmdBase.h Wed Apr 10 13:48:55 2019
@@ -136,7 +136,6 @@ protected:
};
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the command argument or option object pointer so that it
// can be
// examined. If the option found and valid get the value (number,
@@ -170,7 +169,6 @@ T *CMICmdBase::GetOption(const CMIUtilSt
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the command argument or option object pointer using
// template function
// CMICmdBase::GetOption(). Should the argument (by name) not be found
Modified: lldb/trunk/tools/lldb-mi/MICmdCmd.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmd.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmd.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmd.cpp Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
#include "MICmdCmd.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdEnablePrettyPrinting constructor.
// Type: Method.
// Args: None.
@@ -30,7 +29,6 @@ CMICmdCmdEnablePrettyPrinting::CMICmdCmd
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdEnablePrettyPrinting destructor.
// Type: Overrideable.
// Args: None.
@@ -40,7 +38,6 @@ CMICmdCmdEnablePrettyPrinting::CMICmdCmd
CMICmdCmdEnablePrettyPrinting::~CMICmdCmdEnablePrettyPrinting() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -57,7 +54,6 @@ bool CMICmdCmdEnablePrettyPrinting::Exec
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -79,7 +75,6 @@ bool CMICmdCmdEnablePrettyPrinting::Ackn
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -92,12 +87,8 @@ CMICmdBase *CMICmdCmdEnablePrettyPrintin
return new CMICmdCmdEnablePrettyPrinting();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdSource constructor.
// Type: Method.
// Args: None.
@@ -113,7 +104,6 @@ CMICmdCmdSource::CMICmdCmdSource() {
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdSource destructor.
// Type: Overrideable.
// Args: None.
@@ -123,7 +113,6 @@ CMICmdCmdSource::CMICmdCmdSource() {
CMICmdCmdSource::~CMICmdCmdSource() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -140,7 +129,6 @@ bool CMICmdCmdSource::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -159,7 +147,6 @@ bool CMICmdCmdSource::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdBreak.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdBreak.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdBreak.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdBreak.cpp Wed Apr 10 13:48:55 2019
@@ -33,7 +33,6 @@
#include "MICmnStreamStdout.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakInsert constructor.
// Type: Method.
// Args: None.
@@ -57,7 +56,6 @@ CMICmdCmdBreakInsert::CMICmdCmdBreakInse
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakInsert destructor.
// Type: Overrideable.
// Args: None.
@@ -67,7 +65,6 @@ CMICmdCmdBreakInsert::CMICmdCmdBreakInse
CMICmdCmdBreakInsert::~CMICmdCmdBreakInsert() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -104,7 +101,6 @@ bool CMICmdCmdBreakInsert::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Helper function for CMICmdCmdBreakInsert::Execute().
//
// Given a string, return the position of the ':' separator in 'file:func'
@@ -122,7 +118,6 @@ static size_t findFileSeparatorPos(const
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -323,7 +318,6 @@ bool CMICmdCmdBreakInsert::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -359,7 +353,6 @@ bool CMICmdCmdBreakInsert::Acknowledge()
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -372,12 +365,8 @@ CMICmdBase *CMICmdCmdBreakInsert::Create
return new CMICmdCmdBreakInsert();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakDelete constructor.
// Type: Method.
// Args: None.
@@ -394,7 +383,6 @@ CMICmdCmdBreakDelete::CMICmdCmdBreakDele
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakDelete destructor.
// Type: Overrideable.
// Args: None.
@@ -404,7 +392,6 @@ CMICmdCmdBreakDelete::CMICmdCmdBreakDele
CMICmdCmdBreakDelete::~CMICmdCmdBreakDelete() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -422,7 +409,6 @@ bool CMICmdCmdBreakDelete::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -461,7 +447,6 @@ bool CMICmdCmdBreakDelete::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -480,7 +465,6 @@ bool CMICmdCmdBreakDelete::Acknowledge()
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -493,12 +477,8 @@ CMICmdBase *CMICmdCmdBreakDelete::Create
return new CMICmdCmdBreakDelete();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakDisable constructor.
// Type: Method.
// Args: None.
@@ -516,7 +496,6 @@ CMICmdCmdBreakDisable::CMICmdCmdBreakDis
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakDisable destructor.
// Type: Overrideable.
// Args: None.
@@ -526,7 +505,6 @@ CMICmdCmdBreakDisable::CMICmdCmdBreakDis
CMICmdCmdBreakDisable::~CMICmdCmdBreakDisable() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -544,7 +522,6 @@ bool CMICmdCmdBreakDisable::ParseArgs()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -581,7 +558,6 @@ bool CMICmdCmdBreakDisable::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -612,7 +588,6 @@ bool CMICmdCmdBreakDisable::Acknowledge(
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -625,12 +600,8 @@ CMICmdBase *CMICmdCmdBreakDisable::Creat
return new CMICmdCmdBreakDisable();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakEnable constructor.
// Type: Method.
// Args: None.
@@ -648,7 +619,6 @@ CMICmdCmdBreakEnable::CMICmdCmdBreakEnab
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakEnable destructor.
// Type: Overrideable.
// Args: None.
@@ -658,7 +628,6 @@ CMICmdCmdBreakEnable::CMICmdCmdBreakEnab
CMICmdCmdBreakEnable::~CMICmdCmdBreakEnable() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -676,7 +645,6 @@ bool CMICmdCmdBreakEnable::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -713,7 +681,6 @@ bool CMICmdCmdBreakEnable::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -744,7 +711,6 @@ bool CMICmdCmdBreakEnable::Acknowledge()
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -757,12 +723,8 @@ CMICmdBase *CMICmdCmdBreakEnable::Create
return new CMICmdCmdBreakEnable();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakAfter constructor.
// Type: Method.
// Args: None.
@@ -780,7 +742,6 @@ CMICmdCmdBreakAfter::CMICmdCmdBreakAfter
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakAfter destructor.
// Type: Overrideable.
// Args: None.
@@ -790,7 +751,6 @@ CMICmdCmdBreakAfter::CMICmdCmdBreakAfter
CMICmdCmdBreakAfter::~CMICmdCmdBreakAfter() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -808,7 +768,6 @@ bool CMICmdCmdBreakAfter::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -854,7 +813,6 @@ bool CMICmdCmdBreakAfter::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -873,7 +831,6 @@ bool CMICmdCmdBreakAfter::Acknowledge()
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -886,12 +843,8 @@ CMICmdBase *CMICmdCmdBreakAfter::CreateS
return new CMICmdCmdBreakAfter();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakCondition constructor.
// Type: Method.
// Args: None.
@@ -914,7 +867,6 @@ CMICmdCmdBreakCondition::CMICmdCmdBreakC
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdBreakCondition destructor.
// Type: Overrideable.
// Args: None.
@@ -924,7 +876,6 @@ CMICmdCmdBreakCondition::CMICmdCmdBreakC
CMICmdCmdBreakCondition::~CMICmdCmdBreakCondition() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -946,7 +897,6 @@ bool CMICmdCmdBreakCondition::ParseArgs(
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -993,7 +943,6 @@ bool CMICmdCmdBreakCondition::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1012,7 +961,6 @@ bool CMICmdCmdBreakCondition::Acknowledg
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -1026,7 +974,6 @@ CMICmdBase *CMICmdCmdBreakCondition::Cre
}
//++
-//------------------------------------------------------------------------------------
// Details: A breakpoint expression can be passed to *this command as:
// a single string i.e. '2' -> ok.
// a quoted string i.e. "a > 100" -> ok
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdData.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdData.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdData.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdData.cpp Wed Apr 10 13:48:55 2019
@@ -52,7 +52,6 @@ CMIUtilString IntToHexAddrStr(uint32_t n
} // namespace
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataEvaluateExpression constructor.
// Type: Method.
// Args: None.
@@ -71,7 +70,6 @@ CMICmdCmdDataEvaluateExpression::CMICmdC
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataEvaluateExpression destructor.
// Type: Overrideable.
// Args: None.
@@ -81,7 +79,6 @@ CMICmdCmdDataEvaluateExpression::CMICmdC
CMICmdCmdDataEvaluateExpression::~CMICmdCmdDataEvaluateExpression() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -98,7 +95,6 @@ bool CMICmdCmdDataEvaluateExpression::Pa
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -150,7 +146,6 @@ bool CMICmdCmdDataEvaluateExpression::Ex
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -205,7 +200,6 @@ bool CMICmdCmdDataEvaluateExpression::Ac
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -219,7 +213,6 @@ CMICmdBase *CMICmdCmdDataEvaluateExpress
}
//++
-//------------------------------------------------------------------------------------
// Details: Examine the expression string to see if it contains invalid
// characters.
// Type: Method.
@@ -241,12 +234,8 @@ bool CMICmdCmdDataEvaluateExpression::Ha
return bFoundInvalidCharInExpression;
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataDisassemble constructor.
// Type: Method.
// Args: None.
@@ -264,7 +253,6 @@ CMICmdCmdDataDisassemble::CMICmdCmdDataD
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataDisassemble destructor.
// Type: Overrideable.
// Args: None.
@@ -274,7 +262,6 @@ CMICmdCmdDataDisassemble::CMICmdCmdDataD
CMICmdCmdDataDisassemble::~CMICmdCmdDataDisassemble() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -296,7 +283,6 @@ bool CMICmdCmdDataDisassemble::ParseArgs
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -439,7 +425,6 @@ bool CMICmdCmdDataDisassemble::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -460,7 +445,6 @@ bool CMICmdCmdDataDisassemble::Acknowled
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -473,12 +457,8 @@ CMICmdBase *CMICmdCmdDataDisassemble::Cr
return new CMICmdCmdDataDisassemble();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataReadMemoryBytes constructor.
// Type: Method.
// Args: None.
@@ -497,7 +477,6 @@ CMICmdCmdDataReadMemoryBytes::CMICmdCmdD
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataReadMemoryBytes destructor.
// Type: Overrideable.
// Args: None.
@@ -512,7 +491,6 @@ CMICmdCmdDataReadMemoryBytes::~CMICmdCmd
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -533,7 +511,6 @@ bool CMICmdCmdDataReadMemoryBytes::Parse
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -663,7 +640,6 @@ bool CMICmdCmdDataReadMemoryBytes::Execu
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -711,7 +687,6 @@ bool CMICmdCmdDataReadMemoryBytes::Ackno
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -724,12 +699,8 @@ CMICmdBase *CMICmdCmdDataReadMemoryBytes
return new CMICmdCmdDataReadMemoryBytes();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataReadMemory constructor.
// Type: Method.
// Args: None.
@@ -745,7 +716,6 @@ CMICmdCmdDataReadMemory::CMICmdCmdDataRe
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataReadMemory destructor.
// Type: Overrideable.
// Args: None.
@@ -755,7 +725,6 @@ CMICmdCmdDataReadMemory::CMICmdCmdDataRe
CMICmdCmdDataReadMemory::~CMICmdCmdDataReadMemory() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -772,7 +741,6 @@ bool CMICmdCmdDataReadMemory::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -797,7 +765,6 @@ bool CMICmdCmdDataReadMemory::Acknowledg
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -810,12 +777,8 @@ CMICmdBase *CMICmdCmdDataReadMemory::Cre
return new CMICmdCmdDataReadMemory();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataListRegisterNames constructor.
// Type: Method.
// Args: None.
@@ -832,7 +795,6 @@ CMICmdCmdDataListRegisterNames::CMICmdCm
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataReadMemoryBytes destructor.
// Type: Overrideable.
// Args: None.
@@ -842,7 +804,6 @@ CMICmdCmdDataListRegisterNames::CMICmdCm
CMICmdCmdDataListRegisterNames::~CMICmdCmdDataListRegisterNames() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -860,7 +821,6 @@ bool CMICmdCmdDataListRegisterNames::Par
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -925,7 +885,6 @@ bool CMICmdCmdDataListRegisterNames::Exe
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -946,7 +905,6 @@ bool CMICmdCmdDataListRegisterNames::Ack
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -960,7 +918,6 @@ CMICmdBase *CMICmdCmdDataListRegisterNam
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -994,12 +951,8 @@ CMICmdCmdDataListRegisterNames::GetRegis
return lldb::SBValue();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataListRegisterValues constructor.
// Type: Method.
// Args: None.
@@ -1017,7 +970,6 @@ CMICmdCmdDataListRegisterValues::CMICmdC
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataListRegisterValues destructor.
// Type: Overrideable.
// Args: None.
@@ -1027,7 +979,6 @@ CMICmdCmdDataListRegisterValues::CMICmdC
CMICmdCmdDataListRegisterValues::~CMICmdCmdDataListRegisterValues() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -1050,7 +1001,6 @@ bool CMICmdCmdDataListRegisterValues::Pa
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1132,7 +1082,6 @@ bool CMICmdCmdDataListRegisterValues::Ex
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1153,7 +1102,6 @@ bool CMICmdCmdDataListRegisterValues::Ac
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -1167,7 +1115,6 @@ CMICmdBase *CMICmdCmdDataListRegisterVal
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -1202,7 +1149,6 @@ lldb::SBValue CMICmdCmdDataListRegisterV
}
//++
-//------------------------------------------------------------------------------------
// Details: Adds the register value to the output list.
// Type: Method.
// Args: Value of the register, its index and output format.
@@ -1224,12 +1170,8 @@ void CMICmdCmdDataListRegisterValues::Ad
m_miValueList.Add(miValueTuple);
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataListRegisterChanged constructor.
// Type: Method.
// Args: None.
@@ -1245,7 +1187,6 @@ CMICmdCmdDataListRegisterChanged::CMICmd
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataListRegisterChanged destructor.
// Type: Overrideable.
// Args: None.
@@ -1255,7 +1196,6 @@ CMICmdCmdDataListRegisterChanged::CMICmd
CMICmdCmdDataListRegisterChanged::~CMICmdCmdDataListRegisterChanged() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1273,7 +1213,6 @@ bool CMICmdCmdDataListRegisterChanged::E
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1295,7 +1234,6 @@ bool CMICmdCmdDataListRegisterChanged::A
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -1308,12 +1246,8 @@ CMICmdBase *CMICmdCmdDataListRegisterCha
return new CMICmdCmdDataListRegisterChanged();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataWriteMemoryBytes constructor.
// Type: Method.
// Args: None.
@@ -1331,7 +1265,6 @@ CMICmdCmdDataWriteMemoryBytes::CMICmdCmd
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataWriteMemoryBytes destructor.
// Type: Overrideable.
// Args: None.
@@ -1341,7 +1274,6 @@ CMICmdCmdDataWriteMemoryBytes::CMICmdCmd
CMICmdCmdDataWriteMemoryBytes::~CMICmdCmdDataWriteMemoryBytes() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -1362,7 +1294,6 @@ bool CMICmdCmdDataWriteMemoryBytes::Pars
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1387,7 +1318,6 @@ bool CMICmdCmdDataWriteMemoryBytes::Exec
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1409,7 +1339,6 @@ bool CMICmdCmdDataWriteMemoryBytes::Ackn
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -1422,12 +1351,8 @@ CMICmdBase *CMICmdCmdDataWriteMemoryByte
return new CMICmdCmdDataWriteMemoryBytes();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataWriteMemory constructor.
// Type: Method.
// Args: None.
@@ -1447,7 +1372,6 @@ CMICmdCmdDataWriteMemory::CMICmdCmdDataW
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataWriteMemory destructor.
// Type: Overrideable.
// Args: None.
@@ -1462,7 +1386,6 @@ CMICmdCmdDataWriteMemory::~CMICmdCmdData
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -1484,7 +1407,6 @@ bool CMICmdCmdDataWriteMemory::ParseArgs
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1548,7 +1470,6 @@ bool CMICmdCmdDataWriteMemory::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1567,7 +1488,6 @@ bool CMICmdCmdDataWriteMemory::Acknowled
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -1580,12 +1500,8 @@ CMICmdBase *CMICmdCmdDataWriteMemory::Cr
return new CMICmdCmdDataWriteMemory();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataInfoLine constructor.
// Type: Method.
// Args: None.
@@ -1604,7 +1520,6 @@ CMICmdCmdDataInfoLine::CMICmdCmdDataInfo
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdDataInfoLine destructor.
// Type: Overrideable.
// Args: None.
@@ -1614,7 +1529,6 @@ CMICmdCmdDataInfoLine::CMICmdCmdDataInfo
CMICmdCmdDataInfoLine::~CMICmdCmdDataInfoLine() = default;
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -1630,7 +1544,6 @@ bool CMICmdCmdDataInfoLine::ParseArgs()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1725,7 +1638,6 @@ bool CMICmdCmdDataInfoLine::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1741,7 +1653,6 @@ bool CMICmdCmdDataInfoLine::Acknowledge(
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdEnviro.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdEnviro.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdEnviro.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdEnviro.cpp Wed Apr 10 13:48:55 2019
@@ -17,7 +17,6 @@
#include "MICmnMIValueConst.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdEnvironmentCd constructor.
// Type: Method.
// Args: None.
@@ -34,7 +33,6 @@ CMICmdCmdEnvironmentCd::CMICmdCmdEnviron
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdEnvironmentCd destructor.
// Type: Overrideable.
// Args: None.
@@ -44,7 +42,6 @@ CMICmdCmdEnvironmentCd::CMICmdCmdEnviron
CMICmdCmdEnvironmentCd::~CMICmdCmdEnvironmentCd() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -61,7 +58,6 @@ bool CMICmdCmdEnvironmentCd::ParseArgs()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -104,7 +100,6 @@ bool CMICmdCmdEnvironmentCd::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -137,7 +132,6 @@ bool CMICmdCmdEnvironmentCd::Acknowledge
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdExec.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdExec.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdExec.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdExec.cpp Wed Apr 10 13:48:55 2019
@@ -41,7 +41,6 @@
#include "MIDriver.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecRun constructor.
// Type: Method.
// Args: None.
@@ -57,7 +56,6 @@ CMICmdCmdExecRun::CMICmdCmdExecRun() : m
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecRun destructor.
// Type: Overrideable.
// Args: None.
@@ -67,7 +65,6 @@ CMICmdCmdExecRun::CMICmdCmdExecRun() : m
CMICmdCmdExecRun::~CMICmdCmdExecRun() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. It parses the command line
// options'
// arguments to extract values for each of those arguments.
@@ -85,7 +82,6 @@ bool CMICmdCmdExecRun::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -147,7 +143,6 @@ bool CMICmdCmdExecRun::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -181,7 +176,6 @@ bool CMICmdCmdExecRun::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -192,12 +186,8 @@ bool CMICmdCmdExecRun::Acknowledge() {
//--
CMICmdBase *CMICmdCmdExecRun::CreateSelf() { return new CMICmdCmdExecRun(); }
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecContinue constructor.
// Type: Method.
// Args: None.
@@ -213,7 +203,6 @@ CMICmdCmdExecContinue::CMICmdCmdExecCont
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecContinue destructor.
// Type: Overrideable.
// Args: None.
@@ -223,7 +212,6 @@ CMICmdCmdExecContinue::CMICmdCmdExecCont
CMICmdCmdExecContinue::~CMICmdCmdExecContinue() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -253,7 +241,6 @@ bool CMICmdCmdExecContinue::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -270,7 +257,6 @@ bool CMICmdCmdExecContinue::Acknowledge(
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -283,12 +269,8 @@ CMICmdBase *CMICmdCmdExecContinue::Creat
return new CMICmdCmdExecContinue();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecNext constructor.
// Type: Method.
// Args: None.
@@ -304,7 +286,6 @@ CMICmdCmdExecNext::CMICmdCmdExecNext() :
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecNext destructor.
// Type: Overrideable.
// Args: None.
@@ -314,7 +295,6 @@ CMICmdCmdExecNext::CMICmdCmdExecNext() :
CMICmdCmdExecNext::~CMICmdCmdExecNext() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -330,7 +310,6 @@ bool CMICmdCmdExecNext::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -375,7 +354,6 @@ bool CMICmdCmdExecNext::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -392,7 +370,6 @@ bool CMICmdCmdExecNext::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -403,12 +380,8 @@ bool CMICmdCmdExecNext::Acknowledge() {
//--
CMICmdBase *CMICmdCmdExecNext::CreateSelf() { return new CMICmdCmdExecNext(); }
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecStep constructor.
// Type: Method.
// Args: None.
@@ -424,7 +397,6 @@ CMICmdCmdExecStep::CMICmdCmdExecStep() :
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecStep destructor.
// Type: Overrideable.
// Args: None.
@@ -434,7 +406,6 @@ CMICmdCmdExecStep::CMICmdCmdExecStep() :
CMICmdCmdExecStep::~CMICmdCmdExecStep() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -450,7 +421,6 @@ bool CMICmdCmdExecStep::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -496,7 +466,6 @@ bool CMICmdCmdExecStep::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -513,7 +482,6 @@ bool CMICmdCmdExecStep::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -524,12 +492,8 @@ bool CMICmdCmdExecStep::Acknowledge() {
//--
CMICmdBase *CMICmdCmdExecStep::CreateSelf() { return new CMICmdCmdExecStep(); }
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecNextInstruction constructor.
// Type: Method.
// Args: None.
@@ -546,7 +510,6 @@ CMICmdCmdExecNextInstruction::CMICmdCmdE
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecNextInstruction destructor.
// Type: Overrideable.
// Args: None.
@@ -556,7 +519,6 @@ CMICmdCmdExecNextInstruction::CMICmdCmdE
CMICmdCmdExecNextInstruction::~CMICmdCmdExecNextInstruction() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -572,7 +534,6 @@ bool CMICmdCmdExecNextInstruction::Parse
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -618,7 +579,6 @@ bool CMICmdCmdExecNextInstruction::Execu
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -635,7 +595,6 @@ bool CMICmdCmdExecNextInstruction::Ackno
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -648,12 +607,8 @@ CMICmdBase *CMICmdCmdExecNextInstruction
return new CMICmdCmdExecNextInstruction();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecStepInstruction constructor.
// Type: Method.
// Args: None.
@@ -670,7 +625,6 @@ CMICmdCmdExecStepInstruction::CMICmdCmdE
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecStepInstruction destructor.
// Type: Overrideable.
// Args: None.
@@ -680,7 +634,6 @@ CMICmdCmdExecStepInstruction::CMICmdCmdE
CMICmdCmdExecStepInstruction::~CMICmdCmdExecStepInstruction() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -696,7 +649,6 @@ bool CMICmdCmdExecStepInstruction::Parse
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -742,7 +694,6 @@ bool CMICmdCmdExecStepInstruction::Execu
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -759,7 +710,6 @@ bool CMICmdCmdExecStepInstruction::Ackno
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -772,12 +722,8 @@ CMICmdBase *CMICmdCmdExecStepInstruction
return new CMICmdCmdExecStepInstruction();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecFinish constructor.
// Type: Method.
// Args: None.
@@ -793,7 +739,6 @@ CMICmdCmdExecFinish::CMICmdCmdExecFinish
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecFinish destructor.
// Type: Overrideable.
// Args: None.
@@ -803,7 +748,6 @@ CMICmdCmdExecFinish::CMICmdCmdExecFinish
CMICmdCmdExecFinish::~CMICmdCmdExecFinish() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -816,7 +760,6 @@ CMICmdCmdExecFinish::~CMICmdCmdExecFinis
bool CMICmdCmdExecFinish::ParseArgs() { return ParseValidateCmdOptions(); }
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -861,7 +804,6 @@ bool CMICmdCmdExecFinish::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -878,7 +820,6 @@ bool CMICmdCmdExecFinish::Acknowledge()
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -891,12 +832,8 @@ CMICmdBase *CMICmdCmdExecFinish::CreateS
return new CMICmdCmdExecFinish();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecInterrupt constructor.
// Type: Method.
// Args: None.
@@ -912,7 +849,6 @@ CMICmdCmdExecInterrupt::CMICmdCmdExecInt
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecInterrupt destructor.
// Type: Overrideable.
// Args: None.
@@ -922,7 +858,6 @@ CMICmdCmdExecInterrupt::CMICmdCmdExecInt
CMICmdCmdExecInterrupt::~CMICmdCmdExecInterrupt() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -953,7 +888,6 @@ bool CMICmdCmdExecInterrupt::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -970,7 +904,6 @@ bool CMICmdCmdExecInterrupt::Acknowledge
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -983,12 +916,8 @@ CMICmdBase *CMICmdCmdExecInterrupt::Crea
return new CMICmdCmdExecInterrupt();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecArguments constructor.
// Type: Method.
// Args: None.
@@ -1005,7 +934,6 @@ CMICmdCmdExecArguments::CMICmdCmdExecArg
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecArguments destructor.
// Type: Overrideable.
// Args: None.
@@ -1015,7 +943,6 @@ CMICmdCmdExecArguments::CMICmdCmdExecArg
CMICmdCmdExecArguments::~CMICmdCmdExecArguments() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -1033,7 +960,6 @@ bool CMICmdCmdExecArguments::ParseArgs()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1074,7 +1000,6 @@ bool CMICmdCmdExecArguments::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1091,7 +1016,6 @@ bool CMICmdCmdExecArguments::Acknowledge
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -1104,12 +1028,8 @@ CMICmdBase *CMICmdCmdExecArguments::Crea
return new CMICmdCmdExecArguments();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecAbort constructor.
// Type: Method.
// Args: None.
@@ -1125,7 +1045,6 @@ CMICmdCmdExecAbort::CMICmdCmdExecAbort()
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdExecAbort destructor.
// Type: Overrideable.
// Args: None.
@@ -1135,7 +1054,6 @@ CMICmdCmdExecAbort::CMICmdCmdExecAbort()
CMICmdCmdExecAbort::~CMICmdCmdExecAbort() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1168,7 +1086,6 @@ bool CMICmdCmdExecAbort::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1185,7 +1102,6 @@ bool CMICmdCmdExecAbort::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdFile.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdFile.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdFile.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdFile.cpp Wed Apr 10 13:48:55 2019
@@ -23,7 +23,6 @@
#include "MIUtilFileStd.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdFileExecAndSymbols constructor.
// Type: Method.
// Args: None.
@@ -41,7 +40,6 @@ CMICmdCmdFileExecAndSymbols::CMICmdCmdFi
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdFileExecAndSymbols destructor.
// Type: Overrideable.
// Args: None.
@@ -51,7 +49,6 @@ CMICmdCmdFileExecAndSymbols::CMICmdCmdFi
CMICmdCmdFileExecAndSymbols::~CMICmdCmdFileExecAndSymbols() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -73,7 +70,6 @@ bool CMICmdCmdFileExecAndSymbols::ParseA
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -159,7 +155,6 @@ bool CMICmdCmdFileExecAndSymbols::Execut
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -178,7 +173,6 @@ bool CMICmdCmdFileExecAndSymbols::Acknow
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -192,7 +186,6 @@ CMICmdBase *CMICmdCmdFileExecAndSymbols:
}
//++
-//------------------------------------------------------------------------------------
// Details: If the MI Driver is not operating via a client i.e. Eclipse but say
// operating
// on a executable passed in as a argument to the drive then what
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdGdbInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdGdbInfo.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdGdbInfo.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdGdbInfo.cpp Wed Apr 10 13:48:55 2019
@@ -26,7 +26,6 @@ const CMICmdCmdGdbInfo::MapPrintFnNameTo
{"sharedlibrary", &CMICmdCmdGdbInfo::PrintFnSharedLibrary}};
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdGdbInfo constructor.
// Type: Method.
// Args: None.
@@ -45,7 +44,6 @@ CMICmdCmdGdbInfo::CMICmdCmdGdbInfo()
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdGdbInfo destructor.
// Type: Overrideable.
// Args: None.
@@ -55,7 +53,6 @@ CMICmdCmdGdbInfo::CMICmdCmdGdbInfo()
CMICmdCmdGdbInfo::~CMICmdCmdGdbInfo() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -71,7 +68,6 @@ bool CMICmdCmdGdbInfo::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -99,7 +95,6 @@ bool CMICmdCmdGdbInfo::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -140,7 +135,6 @@ bool CMICmdCmdGdbInfo::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -152,7 +146,6 @@ bool CMICmdCmdGdbInfo::Acknowledge() {
CMICmdBase *CMICmdCmdGdbInfo::CreateSelf() { return new CMICmdCmdGdbInfo(); }
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the print function's pointer for the matching print
// request.
// Type: Method.
@@ -177,7 +170,6 @@ bool CMICmdCmdGdbInfo::GetPrintFn(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the request to prepare and send back
// information
// asked for.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdGdbSet.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdGdbSet.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdGdbSet.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdGdbSet.cpp Wed Apr 10 13:48:55 2019
@@ -31,7 +31,6 @@ const CMICmdCmdGdbSet::MapGdbOptionNameT
{"breakpoint", &CMICmdCmdGdbSet::OptionFnBreakpoint}};
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdGdbSet constructor.
// Type: Method.
// Args: None.
@@ -50,7 +49,6 @@ CMICmdCmdGdbSet::CMICmdCmdGdbSet()
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdGdbSet destructor.
// Type: Overrideable.
// Args: None.
@@ -60,7 +58,6 @@ CMICmdCmdGdbSet::CMICmdCmdGdbSet()
CMICmdCmdGdbSet::~CMICmdCmdGdbSet() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -78,7 +75,6 @@ bool CMICmdCmdGdbSet::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command is executed in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -132,7 +128,6 @@ bool CMICmdCmdGdbSet::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute() method.
@@ -179,7 +174,6 @@ bool CMICmdCmdGdbSet::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -191,7 +185,6 @@ bool CMICmdCmdGdbSet::Acknowledge() {
CMICmdBase *CMICmdCmdGdbSet::CreateSelf() { return new CMICmdCmdGdbSet(); }
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the print function's pointer for the matching print
// request.
// Type: Method.
@@ -216,7 +209,6 @@ bool CMICmdCmdGdbSet::GetOptionFn(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB set option 'target-async' to
// prepare
// and send back information asked for.
@@ -261,7 +253,6 @@ bool CMICmdCmdGdbSet::OptionFnTargetAsyn
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB set option
// 'print-char-array-as-string' to
// prepare and send back information asked for.
@@ -312,7 +303,6 @@ bool CMICmdCmdGdbSet::OptionFnPrint(cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB set option 'solib-search-path' to
// prepare
// and send back information asked for.
@@ -348,7 +338,6 @@ bool CMICmdCmdGdbSet::OptionFnSolibSearc
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB set option 'output-radix' to
// prepare
// and send back information asked for.
@@ -399,7 +388,6 @@ bool CMICmdCmdGdbSet::OptionFnOutputRadi
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB set option 'disassembly-flavor'
// to prepare
// and send back information asked for.
@@ -432,7 +420,6 @@ bool CMICmdCmdGdbSet::OptionFnDisassembl
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB set option 'breakpoint' to
// prepare
// and send back information asked for.
@@ -482,7 +469,6 @@ bool CMICmdCmdGdbSet::OptionFnBreakpoint
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB set option to prepare and send
// back the
// requested information.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdGdbShow.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdGdbShow.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdGdbShow.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdGdbShow.cpp Wed Apr 10 13:48:55 2019
@@ -35,7 +35,6 @@ const CMICmdCmdGdbShow::MapGdbOptionName
{"breakpoint", &CMICmdCmdGdbShow::OptionFnBreakpoint}};
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdGdbShow constructor.
// Type: Method.
// Args: None.
@@ -54,7 +53,6 @@ CMICmdCmdGdbShow::CMICmdCmdGdbShow()
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdGdbShow destructor.
// Type: Overrideable.
// Args: None.
@@ -64,7 +62,6 @@ CMICmdCmdGdbShow::CMICmdCmdGdbShow()
CMICmdCmdGdbShow::~CMICmdCmdGdbShow() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -82,7 +79,6 @@ bool CMICmdCmdGdbShow::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command is executed in this
// function.
// Type: Overridden.
@@ -134,7 +130,6 @@ bool CMICmdCmdGdbShow::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute() method.
@@ -190,7 +185,6 @@ bool CMICmdCmdGdbShow::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -202,7 +196,6 @@ bool CMICmdCmdGdbShow::Acknowledge() {
CMICmdBase *CMICmdCmdGdbShow::CreateSelf() { return new CMICmdCmdGdbShow(); }
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the print function's pointer for the matching print
// request.
// Type: Method.
@@ -227,7 +220,6 @@ bool CMICmdCmdGdbShow::GetOptionFn(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB show option 'target-async' to
// prepare
// and send back the requested information.
@@ -251,7 +243,6 @@ bool CMICmdCmdGdbShow::OptionFnTargetAsy
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB show option 'print' to prepare
// and send
// back the requested information.
@@ -302,7 +293,6 @@ bool CMICmdCmdGdbShow::OptionFnPrint(
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB show option 'language' to prepare
// and send back the requested information.
// Type: Method.
@@ -328,7 +318,6 @@ bool CMICmdCmdGdbShow::OptionFnLanguage(
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB show option 'disassembly-flavor' to prepare
// and send back the requested information.
// Type: Method.
@@ -348,7 +337,6 @@ bool CMICmdCmdGdbShow::OptionFnDisassemb
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB show option 'breakpoint' to
// prepare
// and send back the requested information.
@@ -385,7 +373,6 @@ bool CMICmdCmdGdbShow::OptionFnBreakpoin
}
//++
-//------------------------------------------------------------------------------------
// Details: Carry out work to complete the GDB show option to prepare and send
// back the
// requested information.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdGdbThread.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdGdbThread.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdGdbThread.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdGdbThread.cpp Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
#include "MICmnMIValueConst.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdGdbThread constructor.
// Type: Method.
// Args: None.
@@ -30,7 +29,6 @@ CMICmdCmdGdbThread::CMICmdCmdGdbThread()
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdThread destructor.
// Type: Overrideable.
// Args: None.
@@ -40,7 +38,6 @@ CMICmdCmdGdbThread::CMICmdCmdGdbThread()
CMICmdCmdGdbThread::~CMICmdCmdGdbThread() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -58,7 +55,6 @@ bool CMICmdCmdGdbThread::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -80,7 +76,6 @@ bool CMICmdCmdGdbThread::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdMiscellanous.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdMiscellanous.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdMiscellanous.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdMiscellanous.cpp Wed Apr 10 13:48:55 2019
@@ -34,7 +34,6 @@
#include "MIDriverBase.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdGdbExit constructor.
// Type: Method.
// Args: None.
@@ -50,7 +49,6 @@ CMICmdCmdGdbExit::CMICmdCmdGdbExit() {
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdGdbExit destructor.
// Type: Overrideable.
// Args: None.
@@ -60,7 +58,6 @@ CMICmdCmdGdbExit::CMICmdCmdGdbExit() {
CMICmdCmdGdbExit::~CMICmdCmdGdbExit() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -80,7 +77,6 @@ bool CMICmdCmdGdbExit::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -109,7 +105,6 @@ bool CMICmdCmdGdbExit::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -120,12 +115,8 @@ bool CMICmdCmdGdbExit::Acknowledge() {
//--
CMICmdBase *CMICmdCmdGdbExit::CreateSelf() { return new CMICmdCmdGdbExit(); }
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdListThreadGroups constructor.
// Type: Method.
// Args: None.
@@ -145,7 +136,6 @@ CMICmdCmdListThreadGroups::CMICmdCmdList
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdListThreadGroups destructor.
// Type: Overrideable.
// Args: None.
@@ -157,7 +147,6 @@ CMICmdCmdListThreadGroups::~CMICmdCmdLis
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -182,7 +171,6 @@ bool CMICmdCmdListThreadGroups::ParseArg
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -253,7 +241,6 @@ bool CMICmdCmdListThreadGroups::Execute(
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -387,7 +374,6 @@ bool CMICmdCmdListThreadGroups::Acknowle
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -400,12 +386,8 @@ CMICmdBase *CMICmdCmdListThreadGroups::C
return new CMICmdCmdListThreadGroups();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdInterpreterExec constructor.
// Type: Method.
// Args: None.
@@ -423,7 +405,6 @@ CMICmdCmdInterpreterExec::CMICmdCmdInter
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdInterpreterExec destructor.
// Type: Overrideable.
// Args: None.
@@ -433,7 +414,6 @@ CMICmdCmdInterpreterExec::CMICmdCmdInter
CMICmdCmdInterpreterExec::~CMICmdCmdInterpreterExec() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -452,7 +432,6 @@ bool CMICmdCmdInterpreterExec::ParseArgs
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -484,7 +463,6 @@ bool CMICmdCmdInterpreterExec::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -522,7 +500,6 @@ bool CMICmdCmdInterpreterExec::Acknowled
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -535,12 +512,8 @@ CMICmdBase *CMICmdCmdInterpreterExec::Cr
return new CMICmdCmdInterpreterExec();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdInferiorTtySet constructor.
// Type: Method.
// Args: None.
@@ -556,7 +529,6 @@ CMICmdCmdInferiorTtySet::CMICmdCmdInferi
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdInferiorTtySet destructor.
// Type: Overrideable.
// Args: None.
@@ -566,7 +538,6 @@ CMICmdCmdInferiorTtySet::CMICmdCmdInferi
CMICmdCmdInferiorTtySet::~CMICmdCmdInferiorTtySet() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -584,7 +555,6 @@ bool CMICmdCmdInferiorTtySet::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -603,7 +573,6 @@ bool CMICmdCmdInferiorTtySet::Acknowledg
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdStack.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdStack.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdStack.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdStack.cpp Wed Apr 10 13:48:55 2019
@@ -34,7 +34,6 @@
#include <algorithm>
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackInfoDepth constructor.
// Type: Method.
// Args: None.
@@ -51,7 +50,6 @@ CMICmdCmdStackInfoDepth::CMICmdCmdStackI
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackInfoDepth destructor.
// Type: Overrideable.
// Args: None.
@@ -61,7 +59,6 @@ CMICmdCmdStackInfoDepth::CMICmdCmdStackI
CMICmdCmdStackInfoDepth::~CMICmdCmdStackInfoDepth() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -77,7 +74,6 @@ bool CMICmdCmdStackInfoDepth::ParseArgs(
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -114,7 +110,6 @@ bool CMICmdCmdStackInfoDepth::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -137,7 +132,6 @@ bool CMICmdCmdStackInfoDepth::Acknowledg
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -150,12 +144,8 @@ CMICmdBase *CMICmdCmdStackInfoDepth::Cre
return new CMICmdCmdStackInfoDepth();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackInfoFrame constructor.
// Type: Method.
// Args: None.
@@ -171,7 +161,6 @@ CMICmdCmdStackInfoFrame::CMICmdCmdStackI
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackInfoFrame destructor.
// Type: Overrideable.
// Args: None.
@@ -181,7 +170,6 @@ CMICmdCmdStackInfoFrame::CMICmdCmdStackI
CMICmdCmdStackInfoFrame::~CMICmdCmdStackInfoFrame() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -194,7 +182,6 @@ CMICmdCmdStackInfoFrame::~CMICmdCmdStack
bool CMICmdCmdStackInfoFrame::ParseArgs() { return ParseValidateCmdOptions(); }
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -227,7 +214,6 @@ bool CMICmdCmdStackInfoFrame::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -248,7 +234,6 @@ bool CMICmdCmdStackInfoFrame::Acknowledg
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -261,12 +246,8 @@ CMICmdBase *CMICmdCmdStackInfoFrame::Cre
return new CMICmdCmdStackInfoFrame();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackListFrames constructor.
// Type: Method.
// Args: None.
@@ -284,7 +265,6 @@ CMICmdCmdStackListFrames::CMICmdCmdStack
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackListFrames destructor.
// Type: Overrideable.
// Args: None.
@@ -296,7 +276,6 @@ CMICmdCmdStackListFrames::~CMICmdCmdStac
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -313,7 +292,6 @@ bool CMICmdCmdStackListFrames::ParseArgs
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -382,7 +360,6 @@ bool CMICmdCmdStackListFrames::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -438,7 +415,6 @@ bool CMICmdCmdStackListFrames::Acknowled
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -451,12 +427,8 @@ CMICmdBase *CMICmdCmdStackListFrames::Cr
return new CMICmdCmdStackListFrames();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackListArguments constructor.
// Type: Method.
// Args: None.
@@ -475,7 +447,6 @@ CMICmdCmdStackListArguments::CMICmdCmdSt
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackListArguments destructor.
// Type: Overrideable.
// Args: None.
@@ -485,7 +456,6 @@ CMICmdCmdStackListArguments::CMICmdCmdSt
CMICmdCmdStackListArguments::~CMICmdCmdStackListArguments() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -504,7 +474,6 @@ bool CMICmdCmdStackListArguments::ParseA
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -598,7 +567,6 @@ bool CMICmdCmdStackListArguments::Execut
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -632,7 +600,6 @@ bool CMICmdCmdStackListArguments::Acknow
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -645,12 +612,8 @@ CMICmdBase *CMICmdCmdStackListArguments:
return new CMICmdCmdStackListArguments();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackListLocals constructor.
// Type: Method.
// Args: None.
@@ -668,7 +631,6 @@ CMICmdCmdStackListLocals::CMICmdCmdStack
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackListLocals destructor.
// Type: Overrideable.
// Args: None.
@@ -678,7 +640,6 @@ CMICmdCmdStackListLocals::CMICmdCmdStack
CMICmdCmdStackListLocals::~CMICmdCmdStackListLocals() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -695,7 +656,6 @@ bool CMICmdCmdStackListLocals::ParseArgs
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -770,7 +730,6 @@ bool CMICmdCmdStackListLocals::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -803,7 +762,6 @@ bool CMICmdCmdStackListLocals::Acknowled
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -816,12 +774,8 @@ CMICmdBase *CMICmdCmdStackListLocals::Cr
return new CMICmdCmdStackListLocals();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackListVariables constructor.
// Type: Method.
// Args: None.
@@ -839,7 +793,6 @@ CMICmdCmdStackListVariables::CMICmdCmdSt
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackListVariables destructor.
// Type: Overrideable.
// Args: None.
@@ -849,7 +802,6 @@ CMICmdCmdStackListVariables::CMICmdCmdSt
CMICmdCmdStackListVariables::~CMICmdCmdStackListVariables() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -866,7 +818,6 @@ bool CMICmdCmdStackListVariables::ParseA
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -942,7 +893,6 @@ bool CMICmdCmdStackListVariables::Execut
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -975,7 +925,6 @@ bool CMICmdCmdStackListVariables::Acknow
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -988,12 +937,8 @@ CMICmdBase *CMICmdCmdStackListVariables:
return new CMICmdCmdStackListVariables();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackSelectFrame constructor.
// Type: Method.
// Args: None.
@@ -1010,7 +955,6 @@ CMICmdCmdStackSelectFrame::CMICmdCmdStac
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdStackSelectFrame destructor.
// Type: Overrideable.
// Args: None.
@@ -1020,7 +964,6 @@ CMICmdCmdStackSelectFrame::CMICmdCmdStac
CMICmdCmdStackSelectFrame::~CMICmdCmdStackSelectFrame() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -1036,7 +979,6 @@ bool CMICmdCmdStackSelectFrame::ParseArg
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1066,7 +1008,6 @@ bool CMICmdCmdStackSelectFrame::Execute(
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1099,7 +1040,6 @@ bool CMICmdCmdStackSelectFrame::Acknowle
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdSupportInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdSupportInfo.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdSupportInfo.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdSupportInfo.cpp Wed Apr 10 13:48:55 2019
@@ -17,7 +17,6 @@
#include "MICmnMIValueTuple.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdSupportInfoMiCmdQuery constructor.
// Type: Method.
// Args: None.
@@ -34,7 +33,6 @@ CMICmdCmdSupportInfoMiCmdQuery::CMICmdCm
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdSupportInfoMiCmdQuery destructor.
// Type: Overrideable.
// Args: None.
@@ -44,7 +42,6 @@ CMICmdCmdSupportInfoMiCmdQuery::CMICmdCm
CMICmdCmdSupportInfoMiCmdQuery::~CMICmdCmdSupportInfoMiCmdQuery() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -60,7 +57,6 @@ bool CMICmdCmdSupportInfoMiCmdQuery::Par
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -85,7 +81,6 @@ bool CMICmdCmdSupportInfoMiCmdQuery::Exe
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -109,7 +104,6 @@ bool CMICmdCmdSupportInfoMiCmdQuery::Ack
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdSupportList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdSupportList.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdSupportList.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdSupportList.cpp Wed Apr 10 13:48:55 2019
@@ -15,7 +15,6 @@
#include "MICmnMIValueList.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdSupportListFeatures constructor.
// Type: Method.
// Args: None.
@@ -31,7 +30,6 @@ CMICmdCmdSupportListFeatures::CMICmdCmdS
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdSupportListFeatures destructor.
// Type: Overrideable.
// Args: None.
@@ -41,7 +39,6 @@ CMICmdCmdSupportListFeatures::CMICmdCmdS
CMICmdCmdSupportListFeatures::~CMICmdCmdSupportListFeatures() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -59,7 +56,6 @@ bool CMICmdCmdSupportListFeatures::Execu
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -87,7 +83,6 @@ bool CMICmdCmdSupportListFeatures::Ackno
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdSymbol.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdSymbol.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdSymbol.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdSymbol.cpp Wed Apr 10 13:48:55 2019
@@ -41,7 +41,6 @@ CreateMITuplePCLine(const uint32_t addr,
using namespace lldb; // For operator==(const SBAddress &, const SBAddress &).
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdSymbolListLines constructor.
// Type: Method.
// Args: None.
@@ -58,7 +57,6 @@ CMICmdCmdSymbolListLines::CMICmdCmdSymbo
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdSymbolListLines destructor.
// Type: Overrideable.
// Args: None.
@@ -68,7 +66,6 @@ CMICmdCmdSymbolListLines::CMICmdCmdSymbo
CMICmdCmdSymbolListLines::~CMICmdCmdSymbolListLines() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -84,7 +81,6 @@ bool CMICmdCmdSymbolListLines::ParseArgs
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -149,7 +145,6 @@ bool CMICmdCmdSymbolListLines::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -169,7 +164,6 @@ bool CMICmdCmdSymbolListLines::Acknowled
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdTarget.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdTarget.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdTarget.cpp Wed Apr 10 13:48:55 2019
@@ -25,7 +25,6 @@
#include "MICmnMIValueConst.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdTargetSelect constructor.
// Type: Method.
// Args: None.
@@ -43,7 +42,6 @@ CMICmdCmdTargetSelect::CMICmdCmdTargetSe
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdTargetSelect destructor.
// Type: Overrideable.
// Args: None.
@@ -53,7 +51,6 @@ CMICmdCmdTargetSelect::CMICmdCmdTargetSe
CMICmdCmdTargetSelect::~CMICmdCmdTargetSelect() = default;
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -71,7 +68,6 @@ bool CMICmdCmdTargetSelect::ParseArgs()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -151,7 +147,6 @@ bool CMICmdCmdTargetSelect::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -187,7 +182,6 @@ bool CMICmdCmdTargetSelect::Acknowledge(
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -201,7 +195,6 @@ CMICmdBase *CMICmdCmdTargetSelect::Creat
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdTargetAttach constructor.
// Type: Method.
// Args: None.
@@ -219,7 +212,6 @@ CMICmdCmdTargetAttach::CMICmdCmdTargetAt
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdTargetAttach destructor.
// Type: Overrideable.
// Args: None.
@@ -229,7 +221,6 @@ CMICmdCmdTargetAttach::CMICmdCmdTargetAt
CMICmdCmdTargetAttach::~CMICmdCmdTargetAttach() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -250,7 +241,6 @@ bool CMICmdCmdTargetAttach::ParseArgs()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -312,7 +302,6 @@ bool CMICmdCmdTargetAttach::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -348,7 +337,6 @@ bool CMICmdCmdTargetAttach::Acknowledge(
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -362,7 +350,6 @@ CMICmdBase *CMICmdCmdTargetAttach::Creat
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdTargetDetach constructor.
// Type: Method.
// Args: None.
@@ -378,7 +365,6 @@ CMICmdCmdTargetDetach::CMICmdCmdTargetDe
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdTargetDetach destructor.
// Type: Overrideable.
// Args: None.
@@ -388,7 +374,6 @@ CMICmdCmdTargetDetach::CMICmdCmdTargetDe
CMICmdCmdTargetDetach::~CMICmdCmdTargetDetach() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -401,7 +386,6 @@ CMICmdCmdTargetDetach::~CMICmdCmdTargetD
bool CMICmdCmdTargetDetach::ParseArgs() { return MIstatus::success; }
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -433,7 +417,6 @@ bool CMICmdCmdTargetDetach::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -451,7 +434,6 @@ bool CMICmdCmdTargetDetach::Acknowledge(
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdThread.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdThread.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdThread.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdThread.cpp Wed Apr 10 13:48:55 2019
@@ -21,7 +21,6 @@
#include "MICmnMIValueConst.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdThreadInfo constructor.
// Type: Method.
// Args: None.
@@ -39,7 +38,6 @@ CMICmdCmdThreadInfo::CMICmdCmdThreadInfo
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdThreadInfo destructor.
// Type: Overrideable.
// Args: None.
@@ -49,7 +47,6 @@ CMICmdCmdThreadInfo::CMICmdCmdThreadInfo
CMICmdCmdThreadInfo::~CMICmdCmdThreadInfo() { m_vecMIValueTuple.clear(); }
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -66,7 +63,6 @@ bool CMICmdCmdThreadInfo::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -135,7 +131,6 @@ bool CMICmdCmdThreadInfo::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -203,7 +198,6 @@ bool CMICmdCmdThreadInfo::Acknowledge()
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdTrace.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdTrace.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdTrace.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdTrace.cpp Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
#include "MICmnMIValueConst.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdTraceStatus constructor.
// Type: Method.
// Args: None.
@@ -30,7 +29,6 @@ CMICmdCmdTraceStatus::CMICmdCmdTraceStat
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdTraceStatus destructor.
// Type: Overrideable.
// Args: None.
@@ -40,7 +38,6 @@ CMICmdCmdTraceStatus::CMICmdCmdTraceStat
CMICmdCmdTraceStatus::~CMICmdCmdTraceStatus() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -57,7 +54,6 @@ bool CMICmdCmdTraceStatus::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -79,7 +75,6 @@ bool CMICmdCmdTraceStatus::Acknowledge()
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdVar.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCmdVar.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCmdVar.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCmdVar.cpp Wed Apr 10 13:48:55 2019
@@ -40,7 +40,6 @@
#include <algorithm>
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarCreate constructor.
// Type: Method.
// Args: None.
@@ -60,7 +59,6 @@ CMICmdCmdVarCreate::CMICmdCmdVarCreate()
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarCreate destructor.
// Type: Overrideable.
// Args: None.
@@ -70,7 +68,6 @@ CMICmdCmdVarCreate::CMICmdCmdVarCreate()
CMICmdCmdVarCreate::~CMICmdCmdVarCreate() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -89,7 +86,6 @@ bool CMICmdCmdVarCreate::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -211,7 +207,6 @@ bool CMICmdCmdVarCreate::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -264,7 +259,6 @@ bool CMICmdCmdVarCreate::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -278,7 +272,6 @@ CMICmdBase *CMICmdCmdVarCreate::CreateSe
}
//++
-//------------------------------------------------------------------------------------
// Details: Complete SBValue object and its children to get
// SBValue::GetValueDidChange
// work.
@@ -304,12 +297,8 @@ void CMICmdCmdVarCreate::CompleteSBValue
}
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarUpdate constructor.
// Type: Method.
// Args: None.
@@ -327,7 +316,6 @@ CMICmdCmdVarUpdate::CMICmdCmdVarUpdate()
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarUpdate destructor.
// Type: Overrideable.
// Args: None.
@@ -337,7 +325,6 @@ CMICmdCmdVarUpdate::CMICmdCmdVarUpdate()
CMICmdCmdVarUpdate::~CMICmdCmdVarUpdate() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -355,7 +342,6 @@ bool CMICmdCmdVarUpdate::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -408,7 +394,6 @@ bool CMICmdCmdVarUpdate::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -441,7 +426,6 @@ bool CMICmdCmdVarUpdate::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -455,7 +439,6 @@ CMICmdBase *CMICmdCmdVarUpdate::CreateSe
}
//++
-//------------------------------------------------------------------------------------
// Details: Form the MI response for multiple variables.
// Type: Method.
// Args: vrStrVarName - (R) Session var object's name.
@@ -491,7 +474,6 @@ void CMICmdCmdVarUpdate::MIFormResponse(
}
//++
-//------------------------------------------------------------------------------------
// Details: Determine if the var object was changed.
// Type: Method.
// Args: vrVarObj - (R) Session var object to examine.
@@ -527,12 +509,8 @@ bool CMICmdCmdVarUpdate::ExamineSBValueF
return MIstatus::success;
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarDelete constructor.
// Type: Method.
// Args: None.
@@ -548,7 +526,6 @@ CMICmdCmdVarDelete::CMICmdCmdVarDelete()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -564,7 +541,6 @@ bool CMICmdCmdVarDelete::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarDelete destructor.
// Type: Overrideable.
// Args: None.
@@ -574,7 +550,6 @@ bool CMICmdCmdVarDelete::ParseArgs() {
CMICmdCmdVarDelete::~CMICmdCmdVarDelete() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -595,7 +570,6 @@ bool CMICmdCmdVarDelete::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -614,7 +588,6 @@ bool CMICmdCmdVarDelete::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -627,12 +600,8 @@ CMICmdBase *CMICmdCmdVarDelete::CreateSe
return new CMICmdCmdVarDelete();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarAssign constructor.
// Type: Method.
// Args: None.
@@ -650,7 +619,6 @@ CMICmdCmdVarAssign::CMICmdCmdVarAssign()
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarAssign destructor.
// Type: Overrideable.
// Args: None.
@@ -660,7 +628,6 @@ CMICmdCmdVarAssign::CMICmdCmdVarAssign()
CMICmdCmdVarAssign::~CMICmdCmdVarAssign() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -677,7 +644,6 @@ bool CMICmdCmdVarAssign::ParseArgs() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -715,7 +681,6 @@ bool CMICmdCmdVarAssign::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -751,7 +716,6 @@ bool CMICmdCmdVarAssign::Acknowledge() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -764,12 +728,8 @@ CMICmdBase *CMICmdCmdVarAssign::CreateSe
return new CMICmdCmdVarAssign();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarSetFormat constructor.
// Type: Method.
// Args: None.
@@ -786,7 +746,6 @@ CMICmdCmdVarSetFormat::CMICmdCmdVarSetFo
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarSetFormat destructor.
// Type: Overrideable.
// Args: None.
@@ -796,7 +755,6 @@ CMICmdCmdVarSetFormat::CMICmdCmdVarSetFo
CMICmdCmdVarSetFormat::~CMICmdCmdVarSetFormat() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -813,7 +771,6 @@ bool CMICmdCmdVarSetFormat::ParseArgs()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -854,7 +811,6 @@ bool CMICmdCmdVarSetFormat::Execute() {
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -897,7 +853,6 @@ bool CMICmdCmdVarSetFormat::Acknowledge(
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -910,12 +865,8 @@ CMICmdBase *CMICmdCmdVarSetFormat::Creat
return new CMICmdCmdVarSetFormat();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarListChildren constructor.
// Type: Method.
// Args: None.
@@ -934,7 +885,6 @@ CMICmdCmdVarListChildren::CMICmdCmdVarLi
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarListChildren destructor.
// Type: Overrideable.
// Args: None.
@@ -944,7 +894,6 @@ CMICmdCmdVarListChildren::CMICmdCmdVarLi
CMICmdCmdVarListChildren::~CMICmdCmdVarListChildren() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -964,7 +913,6 @@ bool CMICmdCmdVarListChildren::ParseArgs
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1077,7 +1025,6 @@ bool CMICmdCmdVarListChildren::Execute()
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1119,7 +1066,6 @@ bool CMICmdCmdVarListChildren::Acknowled
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -1132,12 +1078,8 @@ CMICmdBase *CMICmdCmdVarListChildren::Cr
return new CMICmdCmdVarListChildren();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarEvaluateExpression constructor.
// Type: Method.
// Args: None.
@@ -1155,7 +1097,6 @@ CMICmdCmdVarEvaluateExpression::CMICmdCm
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarEvaluateExpression destructor.
// Type: Overrideable.
// Args: None.
@@ -1165,7 +1106,6 @@ CMICmdCmdVarEvaluateExpression::CMICmdCm
CMICmdCmdVarEvaluateExpression::~CMICmdCmdVarEvaluateExpression() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -1184,7 +1124,6 @@ bool CMICmdCmdVarEvaluateExpression::Par
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1219,7 +1158,6 @@ bool CMICmdCmdVarEvaluateExpression::Exe
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1252,7 +1190,6 @@ bool CMICmdCmdVarEvaluateExpression::Ack
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -1265,12 +1202,8 @@ CMICmdBase *CMICmdCmdVarEvaluateExpressi
return new CMICmdCmdVarEvaluateExpression();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarInfoPathExpression constructor.
// Type: Method.
// Args: None.
@@ -1287,7 +1220,6 @@ CMICmdCmdVarInfoPathExpression::CMICmdCm
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarInfoPathExpression destructor.
// Type: Overrideable.
// Args: None.
@@ -1297,7 +1229,6 @@ CMICmdCmdVarInfoPathExpression::CMICmdCm
CMICmdCmdVarInfoPathExpression::~CMICmdCmdVarInfoPathExpression() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -1313,7 +1244,6 @@ bool CMICmdCmdVarInfoPathExpression::Par
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1384,7 +1314,6 @@ bool CMICmdCmdVarInfoPathExpression::Exe
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1416,7 +1345,6 @@ bool CMICmdCmdVarInfoPathExpression::Ack
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
@@ -1429,12 +1357,8 @@ CMICmdBase *CMICmdCmdVarInfoPathExpressi
return new CMICmdCmdVarInfoPathExpression();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarShowAttributes constructor.
// Type: Method.
// Args: None.
@@ -1451,7 +1375,6 @@ CMICmdCmdVarShowAttributes::CMICmdCmdVar
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdCmdVarShowAttributes destructor.
// Type: Overrideable.
// Args: None.
@@ -1461,7 +1384,6 @@ CMICmdCmdVarShowAttributes::CMICmdCmdVar
CMICmdCmdVarShowAttributes::~CMICmdCmdVarShowAttributes() {}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The parses the command line
// options
// arguments to extract values for each of those arguments.
@@ -1477,7 +1399,6 @@ bool CMICmdCmdVarShowAttributes::ParseAr
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command does work in this
// function.
// The command is likely to communicate with the LLDB SBDebugger in
@@ -1504,7 +1425,6 @@ bool CMICmdCmdVarShowAttributes::Execute
}
//++
-//------------------------------------------------------------------------------------
// Details: The invoker requires this function. The command prepares a MI Record
// Result
// for the work carried out in the Execute().
@@ -1527,7 +1447,6 @@ bool CMICmdCmdVarShowAttributes::Acknowl
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdFactory when registering *this command. The
// factory
// calls this function to create an instance of *this command.
Modified: lldb/trunk/tools/lldb-mi/MICmdCommands.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdCommands.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdCommands.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdCommands.cpp Wed Apr 10 13:48:55 2019
@@ -45,7 +45,6 @@ template <typename T> static bool Regist
}
//++
-//------------------------------------------------------------------------------------
// Details: Command to command factory registration function.
// Type: Template function.
// Args: typename T - A command type class.
@@ -61,7 +60,6 @@ template <typename T> static bool MICmnC
}
//++
-//------------------------------------------------------------------------------------
// Details: Register commands with MI command factory
// Type: Function.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MICmdFactory.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdFactory.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdFactory.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdFactory.cpp Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
#include "MICmnResources.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdFactory constructor.
// Type: Method.
// Args: None.
@@ -24,7 +23,6 @@
CMICmdFactory::CMICmdFactory() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdFactory destructor.
// Type: Overridable.
// Args: None.
@@ -34,7 +32,6 @@ CMICmdFactory::CMICmdFactory() {}
CMICmdFactory::~CMICmdFactory() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this Command factory.
// Type: Method.
// Args: None.
@@ -56,7 +53,6 @@ bool CMICmdFactory::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this Command Factory.
// Type: Method.
// Args: None.
@@ -79,7 +75,6 @@ bool CMICmdFactory::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Register a command's creator function with the command identifier
// the MI
// command name i.e. 'file-exec-and-symbols'.
@@ -116,7 +111,6 @@ bool CMICmdFactory::CmdRegister(const CM
}
//++
-//------------------------------------------------------------------------------------
// Details: Check a command is already registered.
// Type: Method.
// Args: vMiCmd - (R) Command's name, the MI command.
@@ -131,7 +125,6 @@ bool CMICmdFactory::HaveAlready(const CM
}
//++
-//------------------------------------------------------------------------------------
// Details: Check a command's name is valid:
// - name is not empty
// - name does not have spaces
@@ -157,7 +150,6 @@ bool CMICmdFactory::IsValid(const CMIUti
}
//++
-//------------------------------------------------------------------------------------
// Details: Check a command is already registered.
// Type: Method.
// Args: vMiCmd - (R) Command's name, the MI command.
@@ -170,7 +162,6 @@ bool CMICmdFactory::CmdExist(const CMIUt
}
//++
-//------------------------------------------------------------------------------------
// Details: Create a command given the specified MI command name. The command
// data object
// contains the options for the command.
Modified: lldb/trunk/tools/lldb-mi/MICmdInterpreter.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdInterpreter.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdInterpreter.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdInterpreter.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmdFactory.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdInterpreter constructor.
// Type: Method.
// Args: None.
@@ -22,7 +21,6 @@ CMICmdInterpreter::CMICmdInterpreter()
: m_rCmdFactory(CMICmdFactory::Instance()) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdInterpreter destructor.
// Type: Overridable.
// Args: None.
@@ -32,7 +30,6 @@ CMICmdInterpreter::CMICmdInterpreter()
CMICmdInterpreter::~CMICmdInterpreter() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this Command Interpreter.
// Type: Method.
// Args: None.
@@ -52,7 +49,6 @@ bool CMICmdInterpreter::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this Command Interpreter.
// Type: Method.
// Args: None.
@@ -73,7 +69,6 @@ bool CMICmdInterpreter::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Establish whether the text data is an MI format type command.
// Type: Method.
// Args: vTextLine - (R) Text data to interpret.
@@ -122,7 +117,6 @@ bool CMICmdInterpreter::ValidateIsMi(con
}
//++
-//------------------------------------------------------------------------------------
// Details: Establish whether the command name entered on the stdin stream is
// recognised by
// the MI driver.
@@ -137,7 +131,6 @@ bool CMICmdInterpreter::HasCmdFactoryGot
}
//++
-//------------------------------------------------------------------------------------
// Details: Does the command entered match the criteria for a MI command format.
// The format to validate against is 'nn-' where there can be 1 to n
// digits.
@@ -174,7 +167,6 @@ bool CMICmdInterpreter::MiHasCmdTokenEnd
}
//++
-//------------------------------------------------------------------------------------
// Details: Does the command entered match the criteria for a MI command format.
// The format to validate against is 'nnA' where there can be 1 to n
// digits.
@@ -210,7 +202,6 @@ bool CMICmdInterpreter::MiHasCmdTokenEnd
}
//++
-//------------------------------------------------------------------------------------
// Details: Does the command entered match the criteria for a MI command format.
// Is the command token present before the hyphen?
// Type: Method.
@@ -224,7 +215,6 @@ bool CMICmdInterpreter::MiHasCmdTokenPre
}
//++
-//------------------------------------------------------------------------------------
// Details: Does the command name entered match the criteria for a MI command
// format.
// Is a recognised command present? The command name is entered into
@@ -287,7 +277,6 @@ bool CMICmdInterpreter::MiHasCmd(const C
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the just entered new command from stdin. It contains the
// command
// name, number and any options.
Modified: lldb/trunk/tools/lldb-mi/MICmdInvoker.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdInvoker.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdInvoker.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdInvoker.cpp Wed Apr 10 13:48:55 2019
@@ -15,7 +15,6 @@
#include "MIDriver.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdInvoker constructor.
// Type: Method.
// Args: None.
@@ -25,7 +24,6 @@
CMICmdInvoker::CMICmdInvoker() : m_rStreamOut(CMICmnStreamStdout::Instance()) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdInvoker destructor.
// Type: Overridable.
// Args: None.
@@ -35,7 +33,6 @@ CMICmdInvoker::CMICmdInvoker() : m_rStre
CMICmdInvoker::~CMICmdInvoker() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this Command Invoker.
// Type: Method.
// Args: None.
@@ -55,7 +52,6 @@ bool CMICmdInvoker::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this Stdin stream.
// Type: Method.
// Args: None.
@@ -78,7 +74,6 @@ bool CMICmdInvoker::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Empty the map of invoked commands doing work. Command objects are
// deleted too.
// Type: Method.
@@ -104,7 +99,6 @@ void CMICmdInvoker::CmdDeleteAll() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Remove from the map of invoked commands doing work a command that
// has finished
// its work. The command object is deleted too.
@@ -138,7 +132,6 @@ bool CMICmdInvoker::CmdDelete(const MIui
}
//++
-//------------------------------------------------------------------------------------
// Details: Add to the map of invoked commands doing work a command that is
// about to
// start to do work.
@@ -165,7 +158,6 @@ bool CMICmdInvoker::CmdAdd(const CMICmdB
}
//++
-//------------------------------------------------------------------------------------
// Details: Having previously had the potential command validated and found
// valid now
// get the command executed.
@@ -212,7 +204,6 @@ bool CMICmdInvoker::CmdExecute(CMICmdBas
}
//++
-//------------------------------------------------------------------------------------
// Details: Called when a command has finished its Execution() work either
// synchronously
// because the command executed was the type a non event type or
@@ -269,7 +260,6 @@ bool CMICmdInvoker::CmdExecuteFinished(C
}
//++
-//------------------------------------------------------------------------------------
// Details: If the MI Driver is not operating via a client i.e. Eclipse check
// the command
// on failure suggests the application exits. A command can be such
@@ -290,7 +280,6 @@ void CMICmdInvoker::CmdCauseAppExit(cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Write to stdout and the Log file the command's MI formatted result.
// Type: vCmdData - (R) A command's information.
// Return: MIstatus::success - Functionality succeeded.
@@ -312,7 +301,6 @@ bool CMICmdInvoker::CmdStdout(const SMIC
}
//++
-//------------------------------------------------------------------------------------
// Details: Required by the CMICmdMgr::ICmdDeleteCallback. *this object is
// registered
// with the Command Manager to receive callbacks when a command is
Modified: lldb/trunk/tools/lldb-mi/MICmdMgr.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdMgr.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdMgr.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdMgr.cpp Wed Apr 10 13:48:55 2019
@@ -18,7 +18,6 @@
#include "MIUtilSingletonHelper.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdMgr constructor.
// Type: Method.
// Args: None.
@@ -31,7 +30,6 @@ CMICmdMgr::CMICmdMgr()
m_invoker(CMICmdInvoker::Instance()) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmdMgr destructor.
// Type: Overridable.
// Args: None.
@@ -41,7 +39,6 @@ CMICmdMgr::CMICmdMgr()
CMICmdMgr::~CMICmdMgr() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this Command Manager.
// Type: Method.
// Args: None.
@@ -90,7 +87,6 @@ bool CMICmdMgr::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this Command Manager.
// Type: Method.
// Args: None.
@@ -147,7 +143,6 @@ bool CMICmdMgr::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Establish whether the text data is an MI format type command.
// Type: Method.
// Args: vTextLine - (R) Text data to interpret.
@@ -167,7 +162,6 @@ bool CMICmdMgr::CmdInterpret(const CMIUt
}
//++
-//------------------------------------------------------------------------------------
// Details: Having previously had the potential command validated and found
// valid now
// get the command executed.
@@ -209,7 +203,6 @@ bool CMICmdMgr::CmdExecute(const SMICmdD
}
//++
-//------------------------------------------------------------------------------------
// Details: Iterate all interested clients and tell them a command is being
// deleted.
// Type: Method.
@@ -228,7 +221,6 @@ bool CMICmdMgr::CmdDelete(SMICmdData vCm
}
//++
-//------------------------------------------------------------------------------------
// Details: Register an object to be called when a command object is deleted.
// Type: Method.
// Args: vObject - (R) A new interested client.
@@ -242,7 +234,6 @@ bool CMICmdMgr::CmdRegisterForDeleteNoti
}
//++
-//------------------------------------------------------------------------------------
// Details: Unregister an object from being called when a command object is
// deleted.
// Type: Method.
Modified: lldb/trunk/tools/lldb-mi/MICmdMgrSetCmdDeleteCallback.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdMgrSetCmdDeleteCallback.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmdMgrSetCmdDeleteCallback.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmdMgrSetCmdDeleteCallback.cpp Wed Apr 10 13:48:55 2019
@@ -12,7 +12,6 @@
namespace CMICmdMgrSetCmdDeleteCallback {
//++
-//------------------------------------------------------------------------------------
// Details: CSetClients constructor.
// Type: Method.
// Args: None.
@@ -22,7 +21,6 @@ namespace CMICmdMgrSetCmdDeleteCallback
CSetClients::CSetClients() : m_bClientUnregistered(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: CSetClients destructor.
// Type: Method.
// Args: None.
@@ -32,7 +30,6 @@ CSetClients::CSetClients() : m_bClientUn
CSetClients::~CSetClients() {}
//++
-//------------------------------------------------------------------------------------
// Details: Register an object to be called when a command object is deleted.
// Type: Method.
// Args: vObject - (R) A new interested client.
@@ -47,7 +44,6 @@ bool CSetClients::Register(ICallback &vO
}
//++
-//------------------------------------------------------------------------------------
// Details: Unregister an object from being called when a command object is
// deleted.
// Type: Method.
@@ -64,7 +60,6 @@ bool CSetClients::Unregister(ICallback &
}
//++
-//------------------------------------------------------------------------------------
// Details: Iterate all interested clients and tell them a command is being
// deleted.
// Type: Method.
Modified: lldb/trunk/tools/lldb-mi/MICmnBase.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnBase.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnBase.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnBase.cpp Wed Apr 10 13:48:55 2019
@@ -15,7 +15,6 @@
#include "MICmnStreamStderr.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnBase constructor.
// Type: Method.
// Args: None.
@@ -27,7 +26,6 @@ CMICmnBase::CMICmnBase()
m_pLog(&CMICmnLog::Instance()), m_clientUsageRefCnt(0) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnBase destructor.
// Type: Overrideable.
// Args: None.
@@ -37,7 +35,6 @@ CMICmnBase::CMICmnBase()
CMICmnBase::~CMICmnBase() { m_pLog = NULL; }
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve whether *this object has an error description set.
// Type: Method.
// Args: None.
@@ -49,7 +46,6 @@ bool CMICmnBase::HaveErrorDescription()
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve MI's last error condition.
// Type: Method.
// Args: None.
@@ -61,7 +57,6 @@ const CMIUtilString &CMICmnBase::GetErro
}
//++
-//------------------------------------------------------------------------------------
// Details: Set MI's error condition description. This may be accessed by
// clients and
// seen by users. Message is available to the client using the server
@@ -81,7 +76,6 @@ void CMICmnBase::SetErrorDescription(con
}
//++
-//------------------------------------------------------------------------------------
// Details: Set MI's error condition description. This may be accessed by
// clients and
// seen by users. Message is available to the client using the server
@@ -97,7 +91,6 @@ void CMICmnBase::SetErrorDescriptionNoLo
}
//++
-//------------------------------------------------------------------------------------
// Details: Clear MI's error condition description.
// Type: Method.
// Args: None.
@@ -109,7 +102,6 @@ void CMICmnBase::ClrErrorDescription() c
}
//++
-//------------------------------------------------------------------------------------
// Details: Set MI's error condition description. This may be accessed by
// clients and
// seen by users. Message is available to the client using the server
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBBroadcaster.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLLDBBroadcaster.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnLLDBBroadcaster.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLLDBBroadcaster.cpp Wed Apr 10 13:48:55 2019
@@ -10,7 +10,6 @@
#include "MICmnLLDBBroadcaster.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBBroadcaster constructor.
// Type: Method.
// Args: None.
@@ -21,7 +20,6 @@ CMICmnLLDBBroadcaster::CMICmnLLDBBroadca
: lldb::SBBroadcaster("MI driver") {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBBroadcaster destructor.
// Type: Overridable.
// Args: None.
@@ -31,7 +29,6 @@ CMICmnLLDBBroadcaster::CMICmnLLDBBroadca
CMICmnLLDBBroadcaster::~CMICmnLLDBBroadcaster() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this broadcaster object.
// Type: Method.
// Args: None.
@@ -51,7 +48,6 @@ bool CMICmnLLDBBroadcaster::Initialize()
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this broadcaster object.
// Type: Method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp Wed Apr 10 13:48:55 2019
@@ -29,7 +29,6 @@
#include "Platform.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugSessionInfo constructor.
// Type: Method.
// Args: None.
@@ -46,7 +45,6 @@ CMICmnLLDBDebugSessionInfo::CMICmnLLDBDe
m_constStrPrintAggregateFieldNames("Print AggregateFieldNames") {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugSessionInfo destructor.
// Type: Overridable.
// Args: None.
@@ -56,7 +54,6 @@ CMICmnLLDBDebugSessionInfo::CMICmnLLDBDe
CMICmnLLDBDebugSessionInfo::~CMICmnLLDBDebugSessionInfo() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this object.
// Type: Method.
// Args: None.
@@ -79,7 +76,6 @@ bool CMICmnLLDBDebugSessionInfo::Initial
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this object.
// Type: Method.
// Args: None.
@@ -106,7 +102,6 @@ bool CMICmnLLDBDebugSessionInfo::Shutdow
}
//++
-//------------------------------------------------------------------------------------
// Details: Command instances can create and share data between other instances
// of commands.
// Data can also be assigned by a command and retrieved by LLDB event
@@ -128,7 +123,6 @@ void CMICmnLLDBDebugSessionInfo::SharedD
}
//++
-//------------------------------------------------------------------------------------
// Details: Record information about a LLDB break point so that is can be
// recalled in other
// commands or LLDB event handling functions.
@@ -148,7 +142,6 @@ bool CMICmnLLDBDebugSessionInfo::RecordB
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve information about a LLDB break point previous recorded
// either by
// commands or LLDB event handling functions.
@@ -172,7 +165,6 @@ bool CMICmnLLDBDebugSessionInfo::RecordB
}
//++
-//------------------------------------------------------------------------------------
// Details: Delete information about a specific LLDB break point object. This
// function
// should be called when a LLDB break point is deleted.
@@ -194,7 +186,6 @@ bool CMICmnLLDBDebugSessionInfo::RecordB
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the specified thread's frame information.
// Type: Method.
// Args: vCmdData - (R) A command's information.
@@ -241,7 +232,6 @@ bool CMICmnLLDBDebugSessionInfo::GetThre
}
//++
-//------------------------------------------------------------------------------------
// Details: Return the resolved file's path for the given file.
// Type: Method.
// Args: vCmdData - (R) A command's information.
@@ -272,7 +262,6 @@ bool CMICmnLLDBDebugSessionInfo::Resolve
}
//++
-//------------------------------------------------------------------------------------
// Details: Return the resolved file's path for the given file.
// Type: Method.
// Args: vstrUnknown - (R) String assigned to path when resolved path
@@ -320,7 +309,6 @@ bool CMICmnLLDBDebugSessionInfo::Resolve
}
//++
-//------------------------------------------------------------------------------------
// Details: Determine the given file path exists or not.
// Type: Method.
// Args: vPath - (R) File name path.
@@ -342,7 +330,6 @@ bool CMICmnLLDBDebugSessionInfo::AccessP
}
//++
-//------------------------------------------------------------------------------------
// Details: Form MI partial response by appending more MI value type objects to
// the
// tuple type object past in.
@@ -408,7 +395,6 @@ bool CMICmnLLDBDebugSessionInfo::MIRespo
}
//++
-//------------------------------------------------------------------------------------
// Details: Form MI partial response by appending more MI value type objects to
// the
// tuple type object past in.
@@ -511,7 +497,6 @@ bool CMICmnLLDBDebugSessionInfo::MIRespo
}
//++
-//------------------------------------------------------------------------------------
// Details: Extract the value's name and value or recurse into child value
// object.
// Type: Method.
@@ -535,7 +520,6 @@ bool CMICmnLLDBDebugSessionInfo::GetVari
}
//++
-//------------------------------------------------------------------------------------
// Details: Form MI partial response by appending more MI value type objects to
// the
// tuple type object past in.
@@ -606,7 +590,6 @@ bool CMICmnLLDBDebugSessionInfo::MIRespo
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the frame information from LLDB frame object.
// Type: Method.
// Args: vrFrame - (R) LLDB thread object.
@@ -648,7 +631,6 @@ bool CMICmnLLDBDebugSessionInfo::GetFram
}
//++
-//------------------------------------------------------------------------------------
// Details: Form MI partial response by appending more MI value type objects to
// the
// tuple type object past in.
@@ -683,7 +665,6 @@ void CMICmnLLDBDebugSessionInfo::MIRespo
}
//++
-//------------------------------------------------------------------------------------
// Details: Form MI partial response by appending more MI value type objects to
// the
// tuple type object past in.
@@ -773,7 +754,6 @@ bool CMICmnLLDBDebugSessionInfo::MIRespo
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve breakpoint information and write into the given breakpoint
// information
// object. Note not all possible information is retrieved and so the
@@ -836,7 +816,6 @@ bool CMICmnLLDBDebugSessionInfo::GetBrkP
}
//++
-//------------------------------------------------------------------------------------
// Details: Get current debugger.
// Type: Method.
// Args: None.
@@ -848,7 +827,6 @@ lldb::SBDebugger &CMICmnLLDBDebugSession
}
//++
-//------------------------------------------------------------------------------------
// Details: Get current listener.
// Type: Method.
// Args: None.
@@ -860,7 +838,6 @@ lldb::SBListener &CMICmnLLDBDebugSession
}
//++
-//------------------------------------------------------------------------------------
// Details: Get current target.
// Type: Method.
// Args: None.
@@ -875,7 +852,6 @@ lldb::SBTarget CMICmnLLDBDebugSessionInf
}
//++
-//------------------------------------------------------------------------------------
// Details: Get current process.
// Type: Method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfo.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfo.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfo.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfo.h Wed Apr 10 13:48:55 2019
@@ -242,7 +242,6 @@ private:
};
//++
-//------------------------------------------------------------------------------------
// Details: Command instances can create and share data between other instances
// of commands.
// This function adds new data to the shared data. Using the same ID
@@ -268,7 +267,6 @@ bool CMICmnLLDBDebugSessionInfo::SharedD
}
//++
-//------------------------------------------------------------------------------------
// Details: Command instances can create and share data between other instances
// of commands.
// This function retrieves data from the shared data container.
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfoVarObj.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfoVarObj.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfoVarObj.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfoVarObj.cpp Wed Apr 10 13:48:55 2019
@@ -28,7 +28,6 @@ CMICmnLLDBDebugSessionInfoVarObj::varFor
CMICmnLLDBDebugSessionInfoVarObj::ms_eDefaultFormat = eVarFormat_Natural;
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugSessionInfoVarObj constructor.
// Type: Method.
// Args: None.
@@ -41,7 +40,6 @@ CMICmnLLDBDebugSessionInfoVarObj::CMICmn
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugSessionInfoVarObj constructor.
// Type: Method.
// Args: vrStrNameReal - (R) The actual name of the variable, the
@@ -61,7 +59,6 @@ CMICmnLLDBDebugSessionInfoVarObj::CMICmn
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugSessionInfoVarObj constructor.
// Type: Method.
// Args: vrStrNameReal - (R) The actual name of the variable, the
@@ -84,7 +81,6 @@ CMICmnLLDBDebugSessionInfoVarObj::CMICmn
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugSessionInfoVarObj copy constructor.
// Type: Method.
// Args: vrOther - (R) The object to copy from.
@@ -97,7 +93,6 @@ CMICmnLLDBDebugSessionInfoVarObj::CMICmn
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugSessionInfoVarObj copy constructor.
// Type: Method.
// Args: vrOther - (R) The object to copy from.
@@ -110,7 +105,6 @@ CMICmnLLDBDebugSessionInfoVarObj::CMICmn
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugSessionInfoVarObj move constructor.
// Type: Method.
// Args: vrwOther - (R) The object to copy from.
@@ -123,7 +117,6 @@ CMICmnLLDBDebugSessionInfoVarObj::CMICmn
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugSessionInfoVarObj assignment operator.
// Type: Method.
// Args: vrOther - (R) The object to copy from.
@@ -138,7 +131,6 @@ operator=(const CMICmnLLDBDebugSessionIn
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugSessionInfoVarObj assignment operator.
// Type: Method.
// Args: vrwOther - (R) The object to copy from.
@@ -153,7 +145,6 @@ operator=(CMICmnLLDBDebugSessionInfoVarO
}
//++
-//------------------------------------------------------------------------------------
// Details: Copy the other instance of that object to *this object.
// Type: Method.
// Args: vrOther - (R) The object to copy from.
@@ -179,7 +170,6 @@ bool CMICmnLLDBDebugSessionInfoVarObj::C
}
//++
-//------------------------------------------------------------------------------------
// Details: Move that object to *this object.
// Type: Method.
// Args: vrwOther - (RW) The object to copy from.
@@ -206,7 +196,6 @@ bool CMICmnLLDBDebugSessionInfoVarObj::M
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugSessionInfoVarObj destructor.
// Type: Overridden.
// Args: None.
@@ -216,7 +205,6 @@ bool CMICmnLLDBDebugSessionInfoVarObj::M
CMICmnLLDBDebugSessionInfoVarObj::~CMICmnLLDBDebugSessionInfoVarObj() {}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the var format enumeration for the specified string.
// Type: Static method.
// Args: vrStrFormat - (R) Text description of the var format.
@@ -238,7 +226,6 @@ CMICmnLLDBDebugSessionInfoVarObj::GetVar
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the var format enumeration for the specified character.
// Type: Static method.
// Args: vcFormat - Character representing the var format.
@@ -262,7 +249,6 @@ CMICmnLLDBDebugSessionInfoVarObj::GetVar
}
//++
-//------------------------------------------------------------------------------------
// Details: Return the equivalent var value formatted string for the given value
// type,
// which was prepared for printing (i.e. value was escaped and now it's
@@ -297,7 +283,6 @@ CMIUtilString CMICmnLLDBDebugSessionInfo
}
//++
-//------------------------------------------------------------------------------------
// Details: Return number formatted string according to the given value type.
// Type: Static method.
// Args: vnValue - (R) The number value to get formatted.
@@ -340,7 +325,6 @@ CMIUtilString CMICmnLLDBDebugSessionInfo
}
//++
-//------------------------------------------------------------------------------------
// Details: Delete internal container contents.
// Type: Static method.
// Args: None.
@@ -352,7 +336,6 @@ void CMICmnLLDBDebugSessionInfoVarObj::V
}
//++
-//------------------------------------------------------------------------------------
// Details: Add a var object to the internal container.
// Type: Static method.
// Args: vrVarObj - (R) The var value object.
@@ -367,7 +350,6 @@ void CMICmnLLDBDebugSessionInfoVarObj::V
}
//++
-//------------------------------------------------------------------------------------
// Details: Delete the var object from the internal container matching the
// specified name.
// Type: Static method.
@@ -385,7 +367,6 @@ void CMICmnLLDBDebugSessionInfoVarObj::V
}
//++
-//------------------------------------------------------------------------------------
// Details: Update an existing var object in the internal container.
// Type: Static method.
// Args: vrVarObj - (R) The var value object.
@@ -398,7 +379,6 @@ void CMICmnLLDBDebugSessionInfoVarObj::V
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the var object matching the specified name.
// Type: Static method.
// Args: vrVarName - (R) The var value name.
@@ -421,7 +401,6 @@ bool CMICmnLLDBDebugSessionInfoVarObj::V
}
//++
-//------------------------------------------------------------------------------------
// Details: A count is kept of the number of var value objects created. This is
// count is
// used to ID the var value object. Reset the count to 0.
@@ -435,7 +414,6 @@ void CMICmnLLDBDebugSessionInfoVarObj::V
}
//++
-//------------------------------------------------------------------------------------
// Details: Default format is globally used as the data format when "natural" is
// in effect, that is, this overrides the default
// Type: Static method.
@@ -449,7 +427,6 @@ void CMICmnLLDBDebugSessionInfoVarObj::V
}
//++
-//------------------------------------------------------------------------------------
// Details: A count is kept of the number of var value objects created. This is
// count is
// used to ID the var value object. Increment the count by 1.
@@ -461,7 +438,6 @@ void CMICmnLLDBDebugSessionInfoVarObj::V
void CMICmnLLDBDebugSessionInfoVarObj::VarObjIdInc() { ms_nVarUniqueId++; }
//++
-//------------------------------------------------------------------------------------
// Details: A count is kept of the number of var value objects created. This is
// count is
// used to ID the var value object. Retrieve ID.
@@ -475,7 +451,6 @@ MIuint CMICmnLLDBDebugSessionInfoVarObj:
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the value formatted object's name.
// Type: Method.
// Args: None.
@@ -487,7 +462,6 @@ const CMIUtilString &CMICmnLLDBDebugSess
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the value formatted object's variable name as given in the
// MI command
// to create the var object.
@@ -501,7 +475,6 @@ const CMIUtilString &CMICmnLLDBDebugSess
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the value formatted string.
// Type: Method.
// Args: None.
@@ -514,7 +487,6 @@ CMICmnLLDBDebugSessionInfoVarObj::GetVal
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the LLDB Value object.
// Type: Method.
// Args: None.
@@ -526,7 +498,6 @@ lldb::SBValue &CMICmnLLDBDebugSessionInf
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the LLDB Value object.
// Type: Method.
// Args: None.
@@ -538,7 +509,6 @@ const lldb::SBValue &CMICmnLLDBDebugSess
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the var format type for *this object and update the formatting.
// Type: Method.
// Args: None.
@@ -557,7 +527,6 @@ bool CMICmnLLDBDebugSessionInfoVarObj::S
}
//++
-//------------------------------------------------------------------------------------
// Details: Update *this var obj. Update it's value and type.
// Type: Method.
// Args: None.
@@ -576,7 +545,6 @@ void CMICmnLLDBDebugSessionInfoVarObj::U
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the enumeration type of the var object.
// Type: Method.
// Args: None.
@@ -589,7 +557,6 @@ CMICmnLLDBDebugSessionInfoVarObj::GetTyp
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the parent var object's name, the parent var object to
// *this var
// object (if assigned). The parent is equivalent to LLDB SBValue
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp Wed Apr 10 13:48:55 2019
@@ -29,7 +29,6 @@
#include "MIUtilSingletonHelper.h"
//++
-//------------------------------------------------------------------------------------
// MI private summary providers
static inline bool MI_char_summary_provider(lldb::SBValue value,
lldb::SBTypeSummaryOptions options,
@@ -55,7 +54,6 @@ static inline bool MI_char_summary_provi
}
//++
-//------------------------------------------------------------------------------------
// MI summary helper routines
static inline bool MI_add_summary(lldb::SBTypeCategory category,
const char *typeName,
@@ -74,7 +72,6 @@ static inline bool MI_add_summary(lldb::
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugger constructor.
// Type: Method.
// Args: None.
@@ -85,7 +82,6 @@ CMICmnLLDBDebugger::CMICmnLLDBDebugger()
: m_constStrThisThreadId("MI debugger event") {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebugger destructor.
// Type: Overridable.
// Args: None.
@@ -95,7 +91,6 @@ CMICmnLLDBDebugger::CMICmnLLDBDebugger()
CMICmnLLDBDebugger::~CMICmnLLDBDebugger() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this debugger object.
// Type: Method.
// Args: None.
@@ -157,7 +152,6 @@ bool CMICmnLLDBDebugger::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this debugger object.
// Type: Method.
// Args: None.
@@ -217,7 +211,6 @@ bool CMICmnLLDBDebugger::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Return the LLDB debugger instance created for this debug session.
// Type: Method.
// Args: None.
@@ -229,7 +222,6 @@ lldb::SBDebugger &CMICmnLLDBDebugger::Ge
}
//++
-//------------------------------------------------------------------------------------
// Details: Return the LLDB listener instance created for this debug session.
// Type: Method.
// Args: None.
@@ -241,7 +233,6 @@ lldb::SBListener &CMICmnLLDBDebugger::Ge
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the client driver that wants to use *this LLDB debugger. Call
// this function
// prior to Initialize().
@@ -258,7 +249,6 @@ bool CMICmnLLDBDebugger::SetDriver(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Get the client driver that is use *this LLDB debugger.
// Type: Method.
// Args: vClientDriver - (R) A driver.
@@ -270,7 +260,6 @@ CMIDriverBase &CMICmnLLDBDebugger::GetDr
}
//++
-//------------------------------------------------------------------------------------
// Details: Wait until all events have been handled.
// This function works in pair with
// CMICmnLLDBDebugger::MonitorSBListenerEvents
@@ -294,7 +283,6 @@ void CMICmnLLDBDebugger::WaitForHandleEv
}
//++
-//------------------------------------------------------------------------------------
// Details: Check if need to rebroadcast stop event. This function will return
// true if
// debugger is in synchronouse mode. In such case the
@@ -321,7 +309,6 @@ bool CMICmnLLDBDebugger::CheckIfNeedToRe
}
//++
-//------------------------------------------------------------------------------------
// Details: Rebroadcast stop event if needed. This function should be called
// only if the
// CMICmnLLDBDebugger::CheckIfNeedToRebroadcastStopEvent() returned
@@ -342,7 +329,6 @@ void CMICmnLLDBDebugger::RebroadcastStop
}
//++
-//------------------------------------------------------------------------------------
// Details: Initialize the LLDB Debugger object.
// Type: Method.
// Args: None.
@@ -363,7 +349,6 @@ bool CMICmnLLDBDebugger::InitSBDebugger(
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the LLDB Debugger's std in, err and out streams. (Not
// implemented left
// here for reference. Was called in the
@@ -388,7 +373,6 @@ bool CMICmnLLDBDebugger::InitStdStreams(
}
//++
-//------------------------------------------------------------------------------------
// Details: Set up the events from the SBDebugger's we would like to listen to.
// Type: Method.
// Args: None.
@@ -443,7 +427,6 @@ bool CMICmnLLDBDebugger::InitSBListener(
}
//++
-//------------------------------------------------------------------------------------
// Details: Register with the debugger, the SBListener, the type of events you
// are interested
// in. Others, like commands, may have already set the mask.
@@ -481,7 +464,6 @@ bool CMICmnLLDBDebugger::RegisterForEven
}
//++
-//------------------------------------------------------------------------------------
// Details: Register with the debugger, the SBListener, the type of events you
// are interested
// in. Others, like commands, may have already set the mask.
@@ -532,7 +514,6 @@ bool CMICmnLLDBDebugger::RegisterForEven
}
//++
-//------------------------------------------------------------------------------------
// Details: Unregister with the debugger, the SBListener, the type of events you
// are no
// longer interested in. Others, like commands, may still remain
@@ -579,7 +560,6 @@ bool CMICmnLLDBDebugger::UnregisterForEv
}
//++
-//------------------------------------------------------------------------------------
// Details: Given the SBBroadcaster class name retrieve it's current event mask.
// Type: Method.
// Args: vBroadcasterClass - (R) The SBBroadcaster's class name.
@@ -609,7 +589,6 @@ bool CMICmnLLDBDebugger::BroadcasterGetM
}
//++
-//------------------------------------------------------------------------------------
// Details: Remove the event mask for the specified SBBroadcaster class name.
// Type: Method.
// Args: vBroadcasterClass - (R) The SBBroadcaster's class name.
@@ -629,7 +608,6 @@ bool CMICmnLLDBDebugger::BroadcasterRemo
}
//++
-//------------------------------------------------------------------------------------
// Details: Given the SBBroadcaster class name save it's current event mask.
// Type: Method.
// Args: vBroadcasterClass - (R) The SBBroadcaster's class name.
@@ -655,7 +633,6 @@ bool CMICmnLLDBDebugger::BroadcasterSave
}
//++
-//------------------------------------------------------------------------------------
// Details: Iterate all the clients who have registered event masks against
// particular
// SBBroadcasters and build up the mask that is for all of them.
@@ -683,7 +660,6 @@ MIuint CMICmnLLDBDebugger::ClientGetMask
}
//++
-//------------------------------------------------------------------------------------
// Details: Given the client save its particular event requirements.
// Type: Method.
// Args: vClientName - (R) The Client's unique ID.
@@ -714,7 +690,6 @@ bool CMICmnLLDBDebugger::ClientSaveMask(
}
//++
-//------------------------------------------------------------------------------------
// Details: Given the client remove it's particular event requirements.
// Type: Method.
// Args: vClientName - (R) The Client's unique ID.
@@ -743,7 +718,6 @@ bool CMICmnLLDBDebugger::ClientRemoveThe
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the client's event mask used for on a particular
// SBBroadcaster.
// Type: Method.
@@ -778,7 +752,6 @@ bool CMICmnLLDBDebugger::ClientGetTheirM
}
//++
-//------------------------------------------------------------------------------------
// Details: Momentarily wait for an events being broadcast and inspect those
// that do
// come this way. Check if the target should exit event if so start
@@ -848,7 +821,6 @@ bool CMICmnLLDBDebugger::MonitorSBListen
}
//++
-//------------------------------------------------------------------------------------
// Details: The main worker method for this thread.
// Type: Method.
// Args: vrbIsAlive - (W) True = *this thread is working, false = thread has
@@ -862,7 +834,6 @@ bool CMICmnLLDBDebugger::ThreadRun(bool
}
//++
-//------------------------------------------------------------------------------------
// Details: Let this thread clean up after itself.
// Type: Method.
// Args:
@@ -873,7 +844,6 @@ bool CMICmnLLDBDebugger::ThreadRun(bool
bool CMICmnLLDBDebugger::ThreadFinish() { return MIstatus::success; }
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve *this thread object's name.
// Type: Overridden.
// Args: None.
@@ -885,7 +855,6 @@ const CMIUtilString &CMICmnLLDBDebugger:
}
//++
-//------------------------------------------------------------------------------------
// Details: Loads lldb-mi formatters
// Type: Method.
// Args: None.
@@ -913,7 +882,6 @@ bool CMICmnLLDBDebugger::LoadMIFormatter
}
//++
-//------------------------------------------------------------------------------------
// Details: Registers lldb-mi custom summary providers
// Type: Method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp Wed Apr 10 13:48:55 2019
@@ -43,7 +43,6 @@
#include <algorithm>
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebuggerHandleEvents constructor.
// Type: Method.
// Args: None.
@@ -53,7 +52,6 @@
CMICmnLLDBDebuggerHandleEvents::CMICmnLLDBDebuggerHandleEvents() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBDebuggerHandleEvents destructor.
// Type: Overridable.
// Args: None.
@@ -65,7 +63,6 @@ CMICmnLLDBDebuggerHandleEvents::~CMICmnL
}
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this broadcaster object.
// Type: Method.
// Args: None.
@@ -90,7 +87,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Ini
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this broadcaster object.
// Type: Method.
// Args: None.
@@ -111,7 +107,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Shu
}
//++
-//------------------------------------------------------------------------------------
// Details: Interpret the event object to ascertain the action to take or
// information to
// to form and put in a MI Out-of-band record object which is given to
@@ -150,7 +145,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Handle a LLDB SBProcess event.
// Type: Method.
// Args: vEvent - (R) An LLDB broadcast event.
@@ -201,7 +195,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Handle a LLDB SBBreakpoint event.
// Type: Method.
// Args: vEvent - (R) An LLDB broadcast event.
@@ -274,7 +267,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Handle a LLDB SBBreakpoint event.
// Type: Method.
// Args: vEvent - (R) An LLDB broadcast event.
@@ -299,7 +291,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Handle a LLDB SBBreakpoint event.
// Type: Method.
// Args: vEvent - (R) An LLDB broadcast event.
@@ -368,7 +359,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Handle a LLDB SBBreakpoint added event.
// Add more breakpoint information or overwrite existing information.
// Normally a break point session info objects exists by now when an MI
@@ -493,7 +483,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Handle a LLDB SBThread event.
// Type: Method.
// Args: vEvent - (R) An LLDB broadcast event.
@@ -542,7 +531,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Handle a LLDB SBThread event.
// Type: Method.
// Args: vEvent - (R) An LLDB broadcast event.
@@ -576,7 +564,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Handle a LLDB SBThread event.
// Type: Method.
// Args: vEvent - (R) An LLDB broadcast event.
@@ -596,7 +583,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Handle a LLDB SBTarget event.
// Type: Method.
// Args: vEvent - (R) An LLDB broadcast event.
@@ -645,7 +631,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Print to stdout
// "=library-loaded,id=\"%s\",target-name=\"%s\",host-name=\"%s\",symbols-loaded="%d"[,symbols-path=\"%s\"],loaded_addr=\"0x%016"
// PRIx64"\""
@@ -675,7 +660,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Print to stdout
// "=library-unloaded,id=\"%s\",target-name=\"%s\",host-name=\"%s\",symbols-loaded="%d"[,symbols-path=\"%s\"],loaded_addr=\"0x%016"
// PRIx64"\""
@@ -705,7 +689,6 @@ bool CMICmnLLDBDebuggerHandleEvents::
}
//++
-//------------------------------------------------------------------------------------
// Details: Build module information for =library-loaded/=library-unloaded:
// "id=\"%s\",target-name=\"%s\",host-name=\"%s\",symbols-loaded="%d"[,symbols-path=\"%s\"],loaded_addr=\"0x%016"
// PRIx64"\""
@@ -783,7 +766,6 @@ bool CMICmnLLDBDebuggerHandleEvents::MiH
}
//++
-//------------------------------------------------------------------------------------
// Details: Handle a LLDB SBCommandInterpreter event.
// Type: Method.
// Args: vEvent - (R) An LLDB command interpreter event.
@@ -842,7 +824,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Handle SBProcess event eBroadcastBitStateChanged.
// Type: Method.
// Args: vEvent - (R) An LLDB event object.
@@ -938,7 +919,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Asynchronous event handler for LLDB Process state suspended.
// Type: Method.
// Args: vEvent - (R) An LLDB event object.
@@ -983,7 +963,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Print to stdout MI formatted text to indicate process stopped.
// Type: Method.
// Args: vwrbShouldBrk - (W) True = Yes break, false = do not.
@@ -1052,7 +1031,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Asynchronous event handler for LLDB Process stop signal.
// Type: Method.
// Args: vrEvent - (R) An LLDB broadcast event.
@@ -1203,7 +1181,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Asynchronous event handler for LLDB Process stop exception.
// Type: Method.
// Args: None.
@@ -1244,7 +1221,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Form partial MI response in a MI value tuple object.
// Type: Method.
// Args: vwrMiValueTuple - (W) MI value tuple object.
@@ -1295,7 +1271,6 @@ bool CMICmnLLDBDebuggerHandleEvents::MiH
}
//++
-//------------------------------------------------------------------------------------
// Details: Asynchronous event handler for LLDB Process stop reason breakpoint.
// Type: Method.
// Args: None.
@@ -1325,7 +1300,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Form the MI Out-of-band response for stopped reason on hitting a
// break point.
// Type: Method.
@@ -1425,7 +1399,6 @@ bool CMICmnLLDBDebuggerHandleEvents::MiS
}
//++
-//------------------------------------------------------------------------------------
// Details: Asynchronous event handler for LLDB Process stop reason trace.
// Type: Method.
// Args: None.
@@ -1491,7 +1464,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Asynchronous function update selected thread.
// Type: Method.
// Args: None.
@@ -1564,7 +1536,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Upd
}
//++
-//------------------------------------------------------------------------------------
// Details: Print to stdout "*running,thread-id=\"all\"", "(gdb)".
// Type: Method.
// Args: None.
@@ -1584,7 +1555,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Print to stdout "=thread-exited,id=\"%ld\",group-id=\"i1\"",
// "=thread-group-exited,id=\"i1\",exit-code=\"0\""),
// "*stopped,reason=\"exited-normally\"",
@@ -1628,7 +1598,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Han
}
//++
-//------------------------------------------------------------------------------------
// Details: Drain all stdout so we don't see any output come after we print our
// prompts.
// The process has stuff waiting for stdout; get it and write it out to
@@ -1684,7 +1653,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Get
}
//++
-//------------------------------------------------------------------------------------
// Details: Drain all stderr so we don't see any output come after we print our
// prompts.
// The process has stuff waiting for stderr; get it and write it out to
@@ -1739,7 +1707,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Get
}
//++
-//------------------------------------------------------------------------------------
// Details: Asynchronous event function check for state changes.
// Type: Method.
// Args: None.
@@ -1835,7 +1802,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Chk
}
//++
-//------------------------------------------------------------------------------------
// Details: Take a fully formed MI result record and send to the stdout stream.
// Also output to the MI Log file.
// Type: Method.
@@ -1850,7 +1816,6 @@ bool CMICmnLLDBDebuggerHandleEvents::MiR
}
//++
-//------------------------------------------------------------------------------------
// Details: Take a fully formed MI Out-of-band record and send to the stdout
// stream.
// Also output to the MI Log file.
@@ -1866,7 +1831,6 @@ bool CMICmnLLDBDebuggerHandleEvents::MiO
}
//++
-//------------------------------------------------------------------------------------
// Details: Take a text data and send to the stdout stream. Also output to the
// MI Log
// file.
@@ -1881,7 +1845,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Tex
}
//++
-//------------------------------------------------------------------------------------
// Details: Take a text data and send to the stderr stream. Also output to the
// MI Log
// file.
@@ -1896,7 +1859,6 @@ bool CMICmnLLDBDebuggerHandleEvents::Tex
}
//++
-//------------------------------------------------------------------------------------
// Details: Initialize the member variables with the signal values in this
// process
// file.
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBProxySBValue.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLLDBProxySBValue.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnLLDBProxySBValue.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLLDBProxySBValue.cpp Wed Apr 10 13:48:55 2019
@@ -17,7 +17,6 @@
#include "MIUtilString.h"
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the numerical value from the SBValue object. If the
// function fails
// it could indicate the SBValue object does not represent an internal
@@ -51,7 +50,6 @@ bool CMICmnLLDBProxySBValue::GetValueAsU
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the numerical value from the SBValue object. If the
// function fails
// it could indicate the SBValue object does not represent an internal
@@ -85,7 +83,6 @@ bool CMICmnLLDBProxySBValue::GetValueAsS
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the NUL terminated string from the SBValue object if it of
// the type
// unsigned char *.
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBUtilSBValue.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLLDBUtilSBValue.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnLLDBUtilSBValue.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLLDBUtilSBValue.cpp Wed Apr 10 13:48:55 2019
@@ -21,7 +21,6 @@ static const char *kUnknownValue = "??";
static const char *kUnresolvedCompositeValue = "{...}";
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBUtilSBValue constructor.
// Type: Method.
// Args: vrValue - (R) The LLDB value object.
@@ -41,7 +40,6 @@ CMICmnLLDBUtilSBValue::CMICmnLLDBUtilSBV
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLLDBUtilSBValue destructor.
// Type: Method.
// Args: None.
@@ -51,7 +49,6 @@ CMICmnLLDBUtilSBValue::CMICmnLLDBUtilSBV
CMICmnLLDBUtilSBValue::~CMICmnLLDBUtilSBValue() {}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve from the LLDB SB Value object the name of the variable. If
// the name
// is invalid (or the SBValue object invalid) then "??" is returned.
@@ -68,7 +65,6 @@ CMIUtilString CMICmnLLDBUtilSBValue::Get
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve from the LLDB SB Value object the value of the variable
// described in
// text. If the value is invalid (or the SBValue object invalid) then
@@ -119,7 +115,6 @@ CMIUtilString CMICmnLLDBUtilSBValue::Get
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve from the LLDB SB Value object the value of the variable
// described in
// text if it has a simple format (not composite).
@@ -246,7 +241,6 @@ CMICmnLLDBUtilSBValue::GetValueSummary(b
}
//++
-//------------------------------------------------------------------------------------
// Details: Check that basic type is a char type. Char type can be signed or
// unsigned.
// Type: Static.
@@ -268,7 +262,6 @@ bool CMICmnLLDBUtilSBValue::IsCharBasicT
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the flag stating whether this value object is a char type
// or some
// other type. Char type can be signed or unsigned.
@@ -283,7 +276,6 @@ bool CMICmnLLDBUtilSBValue::IsCharType()
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the flag stating whether first child value object of *this
// object is
// a char type or some other type. Returns false if there are not
@@ -307,7 +299,6 @@ bool CMICmnLLDBUtilSBValue::IsFirstChild
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the flag stating whether pointee object of *this object is
// a char type or some other type. Returns false if there are not
// children. Char
@@ -330,7 +321,6 @@ bool CMICmnLLDBUtilSBValue::IsPointeeCha
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the flag stating whether this value object is a integer
// type or some
// other type. Char type can be signed or unsigned and short or
@@ -355,7 +345,6 @@ bool CMICmnLLDBUtilSBValue::IsIntegerTyp
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the flag stating whether this value object is a pointer
// type or some
// other type.
@@ -369,7 +358,6 @@ bool CMICmnLLDBUtilSBValue::IsPointerTyp
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the flag stating whether this value object is an array type
// or some
// other type.
@@ -383,7 +371,6 @@ bool CMICmnLLDBUtilSBValue::IsArrayType(
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the C string data of value object by read the memory where
// the
// variable is held.
@@ -418,7 +405,6 @@ CMICmnLLDBUtilSBValue::ReadCStringFromHo
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the state of the value object's name.
// Type: Method.
// Args: None.
@@ -431,7 +417,6 @@ bool CMICmnLLDBUtilSBValue::IsNameUnknow
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the state of the value object's value data.
// Type: Method.
// Args: None.
@@ -444,7 +429,6 @@ bool CMICmnLLDBUtilSBValue::IsValueUnkno
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the value object's type name if valid.
// Type: Method.
// Args: None.
@@ -459,7 +443,6 @@ CMIUtilString CMICmnLLDBUtilSBValue::Get
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the value object's display type name if valid.
// Type: Method.
// Args: None.
@@ -474,7 +457,6 @@ CMIUtilString CMICmnLLDBUtilSBValue::Get
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve whether the value object's is valid or not.
// Type: Method.
// Args: None.
@@ -484,7 +466,6 @@ CMIUtilString CMICmnLLDBUtilSBValue::Get
bool CMICmnLLDBUtilSBValue::IsValid() const { return m_bValidSBValue; }
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the value object' has a name. A value object can be valid
// but still
// have no name which suggest it is not a variable.
@@ -505,7 +486,6 @@ bool CMICmnLLDBUtilSBValue::HasName() co
}
//++
-//------------------------------------------------------------------------------------
// Details: Determine if the value object' represents a LLDB variable i.e. "$0".
// Type: Method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MICmnLog.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLog.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnLog.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLog.cpp Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
#include "MIUtilDateTimeStd.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLog constructor.
// Type: Method.
// Args: None.
@@ -26,7 +25,6 @@ CMICmnLog::CMICmnLog() : m_bEnabled(fals
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLog destructor.
// Type: Method.
// Args: None.
@@ -36,7 +34,6 @@ CMICmnLog::CMICmnLog() : m_bEnabled(fals
CMICmnLog::~CMICmnLog() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this Logger.
// Type: Method.
// Args: None.
@@ -94,7 +91,6 @@ bool CMICmnLog::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this Logger.
// Type: Method.
// Args: None.
@@ -119,7 +115,6 @@ bool CMICmnLog::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Enabled or disable *this Logger from writing any data to registered
// clients.
// Type: Method.
@@ -135,7 +130,6 @@ bool CMICmnLog::SetEnabled(const bool vb
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve state whether *this Logger is enabled writing data to
// registered clients.
// Type: Method.
@@ -147,7 +141,6 @@ bool CMICmnLog::SetEnabled(const bool vb
bool CMICmnLog::GetEnabled() const { return m_bEnabled; }
//++
-//------------------------------------------------------------------------------------
// Details: Unregister all the Mediums registered with *this Logger.
// Type: Method.
// Args: None.
@@ -168,7 +161,6 @@ bool CMICmnLog::UnregisterMediumAll() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Register a Medium with *this Logger.
// Type: Method.
// Args: vrMedium - (R) The medium to register.
@@ -197,7 +189,6 @@ bool CMICmnLog::RegisterMedium(const IMe
}
//++
-//------------------------------------------------------------------------------------
// Details: Query the Logger to see if a medium is already registered.
// Type: Method.
// Args: vrMedium - (R) The medium to query.
@@ -212,7 +203,6 @@ bool CMICmnLog::HaveMediumAlready(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Unregister a medium from the Logger.
// Type: Method.
// Args: vrMedium - (R) The medium to unregister.
@@ -228,7 +218,6 @@ bool CMICmnLog::UnregisterMedium(const I
}
//++
-//------------------------------------------------------------------------------------
// Details: The callee client uses this function to write to the Logger. The
// data to be
// written is given out to all the mediums registered. The verbosity
@@ -293,7 +282,6 @@ bool CMICmnLog::Write(const CMIUtilStrin
}
//++
-//------------------------------------------------------------------------------------
// Details: Short cut function call to write only to the Log file.
// The logger must be initialized successfully before a write to any
// registered
@@ -309,7 +297,6 @@ bool CMICmnLog::WriteLog(const CMIUtilSt
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve a string detailing the last error.
// Type: Method.
// Args: None,
@@ -321,7 +308,6 @@ const CMIUtilString &CMICmnLog::GetError
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the internal description of the last error.
// Type: Method.
// Args: (R) String containing a description of the last error.
@@ -333,7 +319,6 @@ void CMICmnLog::SetErrorDescription(cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Clear the last error.
// Type: None.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MICmnLogMediumFile.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnLogMediumFile.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnLogMediumFile.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnLogMediumFile.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmnResources.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLogMediumFile constructor.
// Type: Method.
// Args: None.
@@ -29,7 +28,6 @@ CMICmnLogMediumFile::CMICmnLogMediumFile
m_fileHeaderTxt(MIRSRC(IDS_MEDIUMFILE_ERR_FILE_HEADER)) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnLogMediumFile destructor.
// Type: Overridden.
// Args: None.
@@ -39,7 +37,6 @@ CMICmnLogMediumFile::CMICmnLogMediumFile
CMICmnLogMediumFile::~CMICmnLogMediumFile() {}
//++
-//------------------------------------------------------------------------------------
// Details: Get the singleton instance of *this class.
// Type: Static.
// Args: None.
@@ -53,7 +50,6 @@ CMICmnLogMediumFile &CMICmnLogMediumFile
}
//++
-//------------------------------------------------------------------------------------
// Details: Initialize setup *this medium ready for use.
// Type: Overridden.
// Args: None.
@@ -67,7 +63,6 @@ bool CMICmnLogMediumFile::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Unbind detach or release resources used by *this medium.
// Type: Method.
// Args: None.
@@ -83,7 +78,6 @@ bool CMICmnLogMediumFile::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the name of *this medium.
// Type: Overridden.
// Args: None.
@@ -95,7 +89,6 @@ const CMIUtilString &CMICmnLogMediumFile
}
//++
-//------------------------------------------------------------------------------------
// Details: The callee client calls the write function on the Logger. The data
// to be
// written is given out to all the mediums registered. The verbosity
@@ -132,7 +125,6 @@ bool CMICmnLogMediumFile::Write(const CM
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve *this medium's last error condition.
// Type: Method.
// Args: None.
@@ -144,7 +136,6 @@ const CMIUtilString &CMICmnLogMediumFile
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the verbosity mode for this medium.
// Type: Method.
// Args: veType - (R) Mask value.
@@ -158,7 +149,6 @@ bool CMICmnLogMediumFile::SetVerbosity(c
}
//++
-//------------------------------------------------------------------------------------
// Details: Get the verbosity mode for this medium.
// Type: Method.
// Args: veType - (R) Mask value.
@@ -168,7 +158,6 @@ bool CMICmnLogMediumFile::SetVerbosity(c
MIuint CMICmnLogMediumFile::GetVerbosity() const { return m_eVerbosityType; }
//++
-//------------------------------------------------------------------------------------
// Details: Write data to a file English font.
// Type: Method.
// Args: vData - (R) The data to write to the logger.
@@ -180,7 +169,6 @@ bool CMICmnLogMediumFile::FileWriteEngli
}
//++
-//------------------------------------------------------------------------------------
// Details: Determine and form the medium file's directory path and name.
// Type: Method.
// Args: None.
@@ -210,7 +198,6 @@ bool CMICmnLogMediumFile::FileFormFileNa
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the medium file's directory path and name.
// Type: Method.
// Args: None.
@@ -222,7 +209,6 @@ const CMIUtilString &CMICmnLogMediumFile
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the medium file's name.
// Type: Method.
// Args: None.
@@ -234,7 +220,6 @@ const CMIUtilString &CMICmnLogMediumFile
}
//++
-//------------------------------------------------------------------------------------
// Details: Massage the data to behave correct when submitted to file. Insert
// extra log
// specific text. The veType is there to allow in the future to parse
@@ -272,7 +257,6 @@ CMICmnLogMediumFile::MassagedData(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Convert the Log's verbosity type number into a single char
// character.
// Type: Method.
@@ -299,7 +283,6 @@ char CMICmnLogMediumFile::ConvertLogVerb
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve state of whether the file medium is ok.
// Type: Method.
// Args: None.
@@ -310,7 +293,6 @@ char CMICmnLogMediumFile::ConvertLogVerb
bool CMICmnLogMediumFile::IsOk() const { return m_file.IsOk(); }
//++
-//------------------------------------------------------------------------------------
// Details: Status on the file log medium existing already.
// Type: Method.
// Args: None.
@@ -323,7 +305,6 @@ bool CMICmnLogMediumFile::IsFileExist()
}
//++
-//------------------------------------------------------------------------------------
// Details: Write the header text the logger file.
// Type: Method.
// Args: vText - (R) Text.
@@ -336,7 +317,6 @@ bool CMICmnLogMediumFile::FileWriteHeade
}
//++
-//------------------------------------------------------------------------------------
// Details: Convert any carriage line returns to be compatible with the platform
// the
// Log file is being written to.
@@ -365,7 +345,6 @@ CMIUtilString CMICmnLogMediumFile::Conve
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the header text that is written to the logger file at the
// beginning.
// Type: Method.
@@ -381,7 +360,6 @@ bool CMICmnLogMediumFile::SetHeaderTxt(c
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the file current carriage line return characters used.
// Type: Method.
// Args: None.
@@ -393,7 +371,6 @@ const CMIUtilString &CMICmnLogMediumFile
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the directory to place the log file.
// Type: Method.
// Args: vPath - (R) Path to log.
Modified: lldb/trunk/tools/lldb-mi/MICmnMIOutOfBandRecord.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnMIOutOfBandRecord.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnMIOutOfBandRecord.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnMIOutOfBandRecord.cpp Wed Apr 10 13:48:55 2019
@@ -99,7 +99,6 @@ MapOutOfBandToToken(CMICmnMIOutOfBandRec
}
//++
-//------------------------------------------------------------------------------------
// Details: Build the Out-of-band record's mandatory data part. The part up to
// the first
// (additional) result i.e. async-record ==> "*" type.
@@ -116,7 +115,6 @@ BuildAsyncRecord(CMICmnMIOutOfBandRecord
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIOutOfBandRecord constructor.
// Type: Method.
// Args: None.
@@ -127,7 +125,6 @@ CMICmnMIOutOfBandRecord::CMICmnMIOutOfBa
: m_strAsyncRecord(MIRSRC(IDS_CMD_ERR_EVENT_HANDLED_BUT_NO_ACTION)) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIOutOfBandRecord constructor.
// Type: Method.
// Args: veType - (R) A MI Out-of-Bound enumeration.
@@ -138,7 +135,6 @@ CMICmnMIOutOfBandRecord::CMICmnMIOutOfBa
: m_strAsyncRecord(BuildAsyncRecord(veType)) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIOutOfBandRecord constructor.
// Type: Method.
// Args: veType - (R) A MI Out-of-Bound enumeration.
@@ -153,7 +149,6 @@ CMICmnMIOutOfBandRecord::CMICmnMIOutOfBa
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIOutOfBandRecord constructor.
// Type: Method.
// Args: veType - (R) A MI Out-of-Bound enumeration.
@@ -168,7 +163,6 @@ CMICmnMIOutOfBandRecord::CMICmnMIOutOfBa
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIOutOfBandRecord destructor.
// Type: Overrideable.
// Args: None.
@@ -178,7 +172,6 @@ CMICmnMIOutOfBandRecord::CMICmnMIOutOfBa
CMICmnMIOutOfBandRecord::~CMICmnMIOutOfBandRecord() {}
//++
-//------------------------------------------------------------------------------------
// Details: Return the MI Out-of-band record as a string. The string is a direct
// result of
// work done on *this Out-of-band record so if not enough data is added
@@ -197,7 +190,6 @@ const CMIUtilString &CMICmnMIOutOfBandRe
}
//++
-//------------------------------------------------------------------------------------
// Details: Add to *this Out-of-band record additional information.
// Type: Method.
// Args: vResult - (R) A MI result object.
Modified: lldb/trunk/tools/lldb-mi/MICmnMIResultRecord.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnMIResultRecord.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnMIResultRecord.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnMIResultRecord.cpp Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
#include "MICmnResources.h"
//++
-//------------------------------------------------------------------------------------
// Details: Map a result class to the corresponding string.
// Args: veType - (R) A MI result class enumeration.
// Return: const char* - The string corresponding to the result class.
@@ -39,7 +38,6 @@ MapResultClassToResultClassText(CMICmnMI
}
//++
-//------------------------------------------------------------------------------------
// Details: Build the result record's mandatory data part. The part up to the
// first
// (additional) result i.e. result-record ==> [ token ] "^"
@@ -58,7 +56,6 @@ BuildResultRecord(const CMIUtilString &v
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIResultRecord constructor.
// Type: Method.
// Args: None.
@@ -69,7 +66,6 @@ CMICmnMIResultRecord::CMICmnMIResultReco
: m_strResultRecord(MIRSRC(IDS_CMD_ERR_CMD_RUN_BUT_NO_ACTION)) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIResultRecord constructor.
// Type: Method.
// Args: vrToken - (R) The command's transaction ID or token.
@@ -82,7 +78,6 @@ CMICmnMIResultRecord::CMICmnMIResultReco
: m_strResultRecord(BuildResultRecord(vrToken, veType)) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIResultRecord constructor.
// Type: Method.
// Args: vrToken - (R) The command's transaction ID or token.
@@ -99,7 +94,6 @@ CMICmnMIResultRecord::CMICmnMIResultReco
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIResultRecord destructor.
// Type: Overrideable.
// Args: None.
@@ -109,7 +103,6 @@ CMICmnMIResultRecord::CMICmnMIResultReco
CMICmnMIResultRecord::~CMICmnMIResultRecord() {}
//++
-//------------------------------------------------------------------------------------
// Details: Return the MI result record as a string. The string is a direct
// result of
// work done on *this result record so if not enough data is added then
@@ -128,7 +121,6 @@ const CMIUtilString &CMICmnMIResultRecor
}
//++
-//------------------------------------------------------------------------------------
// Details: Add to *this result record additional information.
// Type: Method.
// Args: vMIValue - (R) A MI value derived object.
Modified: lldb/trunk/tools/lldb-mi/MICmnMIValue.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnMIValue.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnMIValue.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnMIValue.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmnResources.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValue constructor.
// Type: Method.
// Args: None.
@@ -22,7 +21,6 @@ CMICmnMIValue::CMICmnMIValue()
: m_strValue(MIRSRC(IDS_WORD_INVALIDBRKTS)), m_bJustConstructed(true) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValue destructor.
// Type: Overrideable.
// Args: None.
@@ -32,7 +30,6 @@ CMICmnMIValue::CMICmnMIValue()
CMICmnMIValue::~CMICmnMIValue() {}
//++
-//------------------------------------------------------------------------------------
// Details: Return the MI value as a string. The string is a direct result of
// work done on *this value so if not enough data is added then it is
// possible to return a malformed value. If nothing has been set or
Modified: lldb/trunk/tools/lldb-mi/MICmnMIValueConst.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnMIValueConst.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnMIValueConst.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnMIValueConst.cpp Wed Apr 10 13:48:55 2019
@@ -13,7 +13,6 @@
const CMIUtilString CMICmnMIValueConst::ms_constStrDblQuote("\"");
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueConst constructor.
// Type: Method.
// Args: vString - (R) MI Const c-string value.
@@ -26,7 +25,6 @@ CMICmnMIValueConst::CMICmnMIValueConst(c
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueConst constructor.
// Type: Method.
// Args: vString - (R) MI Const c-string value.
@@ -42,7 +40,6 @@ CMICmnMIValueConst::CMICmnMIValueConst(c
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueConst destructor.
// Type: Overrideable.
// Args: None.
@@ -52,7 +49,6 @@ CMICmnMIValueConst::CMICmnMIValueConst(c
CMICmnMIValueConst::~CMICmnMIValueConst() {}
//++
-//------------------------------------------------------------------------------------
// Details: Build the Value Const data.
// Type: Method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MICmnMIValueList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnMIValueList.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnMIValueList.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnMIValueList.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmnResources.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueList constructor.
// Type: Method.
// Args: vbValueTypeList - (R) True = yes value type list, false = result
@@ -24,7 +23,6 @@ CMICmnMIValueList::CMICmnMIValueList(con
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueList constructor.
// Construct a results only list.
// return MIstatus::failure.
@@ -40,7 +38,6 @@ CMICmnMIValueList::CMICmnMIValueList(con
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueList constructor.
// Construct a value only list.
// Type: Method.
@@ -55,7 +52,6 @@ CMICmnMIValueList::CMICmnMIValueList(con
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueList destructor.
// Type: Overrideable.
// Args: None.
@@ -65,7 +61,6 @@ CMICmnMIValueList::CMICmnMIValueList(con
CMICmnMIValueList::~CMICmnMIValueList() {}
//++
-//------------------------------------------------------------------------------------
// Details: Build the result value's mandatory data part, one tuple
// Type: Method.
// Args: None.
@@ -78,7 +73,6 @@ void CMICmnMIValueList::BuildList() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Add another MI result object to the value list's of list is
// results.
// Only result objects can be added to a list of result otherwise this
@@ -94,7 +88,6 @@ void CMICmnMIValueList::Add(const CMICmn
}
//++
-//------------------------------------------------------------------------------------
// Details: Add another MI value object to the value list's of list is values.
// Only values objects can be added to a list of values otherwise this
// function
@@ -107,7 +100,6 @@ void CMICmnMIValueList::Add(const CMICmn
void CMICmnMIValueList::Add(const CMICmnMIValue &vValue) { BuildList(vValue); }
//++
-//------------------------------------------------------------------------------------
// Details: Add another MI result object to the value list's of list is
// results.
// Only result objects can be added to a list of result otherwise this
@@ -134,7 +126,6 @@ void CMICmnMIValueList::BuildList(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Add another MI value object to the value list's of list is values.
// Only values objects can be added to a list of values otherwise this
// function
@@ -164,7 +155,6 @@ void CMICmnMIValueList::BuildList(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the contents of *this value object but without the outer
// most
// brackets.
Modified: lldb/trunk/tools/lldb-mi/MICmnMIValueResult.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnMIValueResult.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnMIValueResult.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnMIValueResult.cpp Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
const CMIUtilString CMICmnMIValueResult::ms_constStrEqual("=");
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueResult constructor.
// Type: Method.
// Args: None.
@@ -24,7 +23,6 @@ const CMIUtilString CMICmnMIValueResult:
CMICmnMIValueResult::CMICmnMIValueResult() : m_bEmptyConstruction(true) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueResult constructor.
// Type: Method.
// Args: vrVariable - (R) MI value's name.
@@ -40,7 +38,6 @@ CMICmnMIValueResult::CMICmnMIValueResult
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueResult constructor.
// Type: Method.
// Args: vrVariable - (R) MI value's name.
@@ -59,7 +56,6 @@ CMICmnMIValueResult::CMICmnMIValueResult
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueResult destructor.
// Type: Overrideable.
// Args: None.
@@ -69,7 +65,6 @@ CMICmnMIValueResult::CMICmnMIValueResult
CMICmnMIValueResult::~CMICmnMIValueResult() {}
//++
-//------------------------------------------------------------------------------------
// Details: Build the MI value result string.
// Type: Method.
// Args: None.
@@ -84,7 +79,6 @@ void CMICmnMIValueResult::BuildResult()
}
//++
-//------------------------------------------------------------------------------------
// Details: Build the MI value result string.
// Type: Method.
// Args: vrVariable - (R) MI value's name.
@@ -101,7 +95,6 @@ void CMICmnMIValueResult::BuildResult(co
}
//++
-//------------------------------------------------------------------------------------
// Details: Append another MI value object to *this MI value result.
// Type: Method.
// Args: vrVariable - (R) MI value's name.
Modified: lldb/trunk/tools/lldb-mi/MICmnMIValueTuple.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnMIValueTuple.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnMIValueTuple.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnMIValueTuple.cpp Wed Apr 10 13:48:55 2019
@@ -10,7 +10,6 @@
#include "MICmnMIValueTuple.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueTuple constructor.
// Type: Method.
// Args: None.
@@ -22,7 +21,6 @@ CMICmnMIValueTuple::CMICmnMIValueTuple()
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueTuple constructor.
// Type: Method.
// Args: vResult - (R) MI result object.
@@ -37,7 +35,6 @@ CMICmnMIValueTuple::CMICmnMIValueTuple(c
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueTuple constructor.
// Type: Method.
// Args: vResult - (R) MI result object.
@@ -55,7 +52,6 @@ CMICmnMIValueTuple::CMICmnMIValueTuple(c
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnMIValueTuple destructor.
// Type: Overrideable.
// Args: None.
@@ -65,7 +61,6 @@ CMICmnMIValueTuple::CMICmnMIValueTuple(c
CMICmnMIValueTuple::~CMICmnMIValueTuple() {}
//++
-//------------------------------------------------------------------------------------
// Details: Build the result value's mandatory data part, one tuple
// Type: Method.
// Args: None.
@@ -78,7 +73,6 @@ void CMICmnMIValueTuple::BuildTuple() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Add another MI result object to the value's list of tuples.
// Type: Method.
// Args: vResult - (R) The MI result object.
@@ -107,7 +101,6 @@ void CMICmnMIValueTuple::BuildTuple(cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Add string value to the value's list of tuples.
// Type: Method.
// Args: vValue - (R) The string object.
@@ -129,7 +122,6 @@ void CMICmnMIValueTuple::BuildTuple(cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Add another MI value object to the value list's of list is values.
// Only values objects can be added to a list of values otherwise this
// function
@@ -144,7 +136,6 @@ void CMICmnMIValueTuple::Add(const CMICm
}
//++
-//------------------------------------------------------------------------------------
// Details: Add another MI value object to the value list's of list is values.
// Only values objects can be added to a list of values otherwise this
// function
@@ -163,7 +154,6 @@ void CMICmnMIValueTuple::Add(const CMICm
}
//++
-//------------------------------------------------------------------------------------
// Details: Add another MI value object to the value list's of list is values.
// Only values objects can be added to a list of values otherwise this
// function
@@ -182,7 +172,6 @@ void CMICmnMIValueTuple::Add(const CMICm
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the contents of *this value object but without the outer
// most
// brackets.
Modified: lldb/trunk/tools/lldb-mi/MICmnResources.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnResources.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnResources.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnResources.cpp Wed Apr 10 13:48:55 2019
@@ -461,7 +461,6 @@ const CMICmnResources::SRsrcTextData
"Command '%s'. Must specify either a PID or a Name"}};
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnResources constructor.
// Type: Method.
// Args: None.
@@ -473,7 +472,6 @@ CMICmnResources::CMICmnResources() : m_n
}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnResources destructor.
// Type: Overridden.
// Args: None.
@@ -485,7 +483,6 @@ CMICmnResources::~CMICmnResources() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Initialize the resources and set locality for the server.
// Type: Method.
// Args: None.
@@ -505,7 +502,6 @@ bool CMICmnResources::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this object.
// Type: Method.
// Args: None.
@@ -529,7 +525,6 @@ bool CMICmnResources::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Initialize the resources and set locality for the server.
// Type: Method.
// Args: None.
@@ -550,7 +545,6 @@ bool CMICmnResources::ReadResourceString
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the corresponding text assigned to the resource ID.
// Type: Method.
// Args: vResourceId - (R) MI resource ID.
@@ -567,7 +561,6 @@ CMIUtilString CMICmnResources::GetString
}
//++
-//------------------------------------------------------------------------------------
// Details: Determine the MI resource ID existings.
// Type: Method.
// Args: vResourceId - (R) MI resource ID.
@@ -581,7 +574,6 @@ bool CMICmnResources::HasString(const MI
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the resource text data for the given resource ID. If a
// resource ID
// cannot be found and error is given returning the ID of the resource
Modified: lldb/trunk/tools/lldb-mi/MICmnStreamStderr.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnStreamStderr.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnStreamStderr.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnStreamStderr.cpp Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
#include "MIDriver.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnStreamStderr constructor.
// Type: Method.
// Args: None.
@@ -24,7 +23,6 @@
CMICmnStreamStderr::CMICmnStreamStderr() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnStreamStderr destructor.
// Type: Overridable.
// Args: None.
@@ -34,7 +32,6 @@ CMICmnStreamStderr::CMICmnStreamStderr()
CMICmnStreamStderr::~CMICmnStreamStderr() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this stderr stream.
// Type: Method.
// Args: None.
@@ -64,7 +61,6 @@ bool CMICmnStreamStderr::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this stderr stream.
// Type: Method.
// Args: None.
@@ -87,7 +83,6 @@ bool CMICmnStreamStderr::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Write text data to stderr. Prefix the message with "MI:". The text
// data does
// not need to include a carriage line return as this is added to the
@@ -114,7 +109,6 @@ bool CMICmnStreamStderr::Write(const CMI
}
//++
-//------------------------------------------------------------------------------------
// Details: Write an LLDB text message to stderr.
// The text data does not need to include a carriage line return as
// this is added
@@ -141,7 +135,6 @@ bool CMICmnStreamStderr::WriteLLDBMsg(co
}
//++
-//------------------------------------------------------------------------------------
// Details: Write text data to stderr. The text data does not need to
// include a carriage line return as this is added to the text. The
// function also
@@ -188,7 +181,6 @@ bool CMICmnStreamStderr::WritePriv(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Lock the availability of the stream stderr. Other users of *this
// stream will
// be stalled until it is available (Unlock()).
@@ -204,7 +196,6 @@ bool CMICmnStreamStderr::Lock() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release a previously locked stderr.
// Type: Method.
// Args: None.
@@ -218,7 +209,6 @@ bool CMICmnStreamStderr::Unlock() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Take MI Driver text message and send to the stderr stream. Also
// output to the
// MI Log file.
@@ -237,7 +227,6 @@ bool CMICmnStreamStderr::TextToStderr(co
}
//++
-//------------------------------------------------------------------------------------
// Details: Take an LLDB message and send to the stderr stream. The message is
// not always
// an error message. The user has typed a command in to the Eclipse
Modified: lldb/trunk/tools/lldb-mi/MICmnStreamStdin.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnStreamStdin.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnStreamStdin.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnStreamStdin.cpp Wed Apr 10 13:48:55 2019
@@ -21,7 +21,6 @@
#include "MIUtilSingletonHelper.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnStreamStdin constructor.
// Type: Method.
// Args: None.
@@ -32,7 +31,6 @@ CMICmnStreamStdin::CMICmnStreamStdin()
: m_strPromptCurrent("(gdb)"), m_bShowPrompt(true), m_pCmdBuffer(nullptr) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnStreamStdin destructor.
// Type: Overridable.
// Args: None.
@@ -42,7 +40,6 @@ CMICmnStreamStdin::CMICmnStreamStdin()
CMICmnStreamStdin::~CMICmnStreamStdin() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this Stdin stream.
// Type: Method.
// Args: None.
@@ -79,7 +76,6 @@ bool CMICmnStreamStdin::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this Stdin stream.
// Type: Method.
// Args: None.
@@ -117,7 +113,6 @@ bool CMICmnStreamStdin::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Validate and set the text that forms the prompt on the command line.
// Type: Method.
// Args: vNewPrompt - (R) Text description.
@@ -139,7 +134,6 @@ bool CMICmnStreamStdin::SetPrompt(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the command line prompt text currently being used.
// Type: Method.
// Args: None.
@@ -151,7 +145,6 @@ const CMIUtilString &CMICmnStreamStdin::
}
//++
-//------------------------------------------------------------------------------------
// Details: Set whether to display optional command line prompt. The prompt is
// output to
// stdout. Disable it when this may interfere with the client reading
@@ -169,7 +162,6 @@ void CMICmnStreamStdin::SetEnablePrompt(
}
//++
-//------------------------------------------------------------------------------------
// Details: Get whether to display optional command line prompt. The prompt is
// output to
// stdout. Disable it when this may interfere with the client reading
@@ -184,7 +176,6 @@ void CMICmnStreamStdin::SetEnablePrompt(
bool CMICmnStreamStdin::GetEnablePrompt() const { return m_bShowPrompt; }
//++
-//------------------------------------------------------------------------------------
// Details: Wait on new line of data from stdin stream (completed by '\n' or
// '\r').
// Type: Method.
Modified: lldb/trunk/tools/lldb-mi/MICmnStreamStdout.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnStreamStdout.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnStreamStdout.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnStreamStdout.cpp Wed Apr 10 13:48:55 2019
@@ -13,7 +13,6 @@
#include "MIDriver.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnStreamStdout constructor.
// Type: Method.
// Args: None.
@@ -23,7 +22,6 @@
CMICmnStreamStdout::CMICmnStreamStdout() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnStreamStdout destructor.
// Type: Overridable.
// Args: None.
@@ -33,7 +31,6 @@ CMICmnStreamStdout::CMICmnStreamStdout()
CMICmnStreamStdout::~CMICmnStreamStdout() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize resources for *this Stdout stream.
// Type: Method.
// Args: None.
@@ -63,7 +60,6 @@ bool CMICmnStreamStdout::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this Stdout stream.
// Type: Method.
// Args: None.
@@ -86,7 +82,6 @@ bool CMICmnStreamStdout::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Write an MI format type response to stdout. The text data does not
// need to
// include a carriage line return as this is added to the text. The
@@ -106,7 +101,6 @@ bool CMICmnStreamStdout::WriteMIResponse
}
//++
-//------------------------------------------------------------------------------------
// Details: Write text data to stdout. The text data does not need to
// include a carriage line return as this is added to the text. The
// function also
@@ -132,7 +126,6 @@ bool CMICmnStreamStdout::Write(const CMI
}
//++
-//------------------------------------------------------------------------------------
// Details: Write text data to stdout. The text data does not need to
// include a carriage line return as this is added to the text. The
// function also
@@ -179,7 +172,6 @@ bool CMICmnStreamStdout::WritePriv(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Lock the availability of the stream stdout. Other users of *this
// stream will
// be stalled until it is available (Unlock()).
@@ -195,7 +187,6 @@ bool CMICmnStreamStdout::Lock() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release a previously locked stdout.
// Type: Method.
// Args: None.
@@ -209,7 +200,6 @@ bool CMICmnStreamStdout::Unlock() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Take a text data and send to the stdout stream. Also output to the
// MI Log
// file.
@@ -225,7 +215,6 @@ bool CMICmnStreamStdout::TextToStdout(co
}
//++
-//------------------------------------------------------------------------------------
// Details: Write prompt to stdout if it's enabled.
// Type: Static method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MICmnThreadMgrStd.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnThreadMgrStd.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnThreadMgrStd.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnThreadMgrStd.cpp Wed Apr 10 13:48:55 2019
@@ -13,7 +13,6 @@
#include "MIUtilSingletonHelper.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnThreadMgr constructor.
// Type: Method.
// Args: None.
@@ -23,7 +22,6 @@
CMICmnThreadMgrStd::CMICmnThreadMgrStd() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMICmnThreadMgr destructor.
// Type: Method.
// Args: None.
@@ -33,7 +31,6 @@ CMICmnThreadMgrStd::CMICmnThreadMgrStd()
CMICmnThreadMgrStd::~CMICmnThreadMgrStd() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialise resources for *this thread manager.
// Type: Method.
// Args: None.
@@ -70,7 +67,6 @@ bool CMICmnThreadMgrStd::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Release resources for *this thread manager.
// Type: Method.
// Args: None.
@@ -107,7 +103,6 @@ bool CMICmnThreadMgrStd::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Ask the thread manager to kill all threads and wait until they have
// died
// Type: Method.
@@ -134,7 +129,6 @@ bool CMICmnThreadMgrStd::ThreadAllTermin
}
//++
-//------------------------------------------------------------------------------------
// Details: Add a thread object to *this manager's list of thread objects. The
// list to
// used to manage thread objects centrally.
Modified: lldb/trunk/tools/lldb-mi/MICmnThreadMgrStd.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnThreadMgrStd.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MICmnThreadMgrStd.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmnThreadMgrStd.h Wed Apr 10 13:48:55 2019
@@ -64,7 +64,6 @@ private:
};
//++
-//------------------------------------------------------------------------------------
// Details: Given a thread object start its (worker) thread to do work. The
// object is
// added to the *this manager for housekeeping and deletion of all
Modified: lldb/trunk/tools/lldb-mi/MIDataTypes.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIDataTypes.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIDataTypes.h (original)
+++ lldb/trunk/tools/lldb-mi/MIDataTypes.h Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
#pragma once
-//--------------------------------------------------------------------------------------
// Windows headers:
#ifdef _WIN32
@@ -25,7 +24,6 @@
#endif // _WIN32
-//--------------------------------------------------------------------------------------
// Common definitions:
// Function return status
@@ -55,7 +53,6 @@ typedef unsigned int MIuint;
#endif // _WIN32
#endif // _WIN64
-//--------------------------------------------------------------------------------------
// Common types:
// Fundamentals:
Modified: lldb/trunk/tools/lldb-mi/MIDriver.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIDriver.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIDriver.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIDriver.cpp Wed Apr 10 13:48:55 2019
@@ -43,7 +43,6 @@ const CMIUtilString
const CMIUtilString CMIDriver::ms_constAppNameLong(MIRSRC(IDS_MI_APPNAME_LONG));
//++
-//------------------------------------------------------------------------------------
// Details: CMIDriver constructor.
// Type: Method.
// Args: None.
@@ -61,7 +60,6 @@ CMIDriver::CMIDriver()
m_bHaveCommandFileNamePathOnCmdLine(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMIDriver destructor.
// Type: Overridden.
// Args: None.
@@ -71,7 +69,6 @@ CMIDriver::CMIDriver()
CMIDriver::~CMIDriver() {}
//++
-//------------------------------------------------------------------------------------
// Details: Set whether *this driver (the parent) is enabled to pass a command
// to its
// fall through (child) driver to interpret the command and do work
@@ -90,7 +87,6 @@ bool CMIDriver::SetEnableFallThru(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Get whether *this driver (the parent) is enabled to pass a command
// to its
// fall through (child) driver to interpret the command and do work
@@ -106,7 +102,6 @@ bool CMIDriver::GetEnableFallThru() cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve MI's application name of itself.
// Type: Method.
// Args: None.
@@ -118,7 +113,6 @@ const CMIUtilString &CMIDriver::GetAppNa
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve MI's application name of itself.
// Type: Method.
// Args: None.
@@ -130,7 +124,6 @@ const CMIUtilString &CMIDriver::GetAppNa
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve MI's version description of itself.
// Type: Method.
// Args: None.
@@ -142,7 +135,6 @@ const CMIUtilString &CMIDriver::GetVersi
}
//++
-//------------------------------------------------------------------------------------
// Details: Initialize setup *this driver ready for use.
// Type: Method.
// Args: None.
@@ -191,7 +183,6 @@ bool CMIDriver::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Unbind detach or release resources used by *this driver.
// Type: Method.
// Args: None.
@@ -238,7 +229,6 @@ bool CMIDriver::Shutdown() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Work function. Client (the driver's user) is able to append their
// own message
// in to the MI's Log trace file.
@@ -255,7 +245,6 @@ bool CMIDriver::WriteMessageToLog(const
}
//++
-//------------------------------------------------------------------------------------
// Details: CDriverMgr calls *this driver initialize setup ready for use.
// Type: Overridden.
// Args: None.
@@ -266,7 +255,6 @@ bool CMIDriver::WriteMessageToLog(const
bool CMIDriver::DoInitialize() { return CMIDriver::Instance().Initialize(); }
//++
-//------------------------------------------------------------------------------------
// Details: CDriverMgr calls *this driver to unbind detach or release resources
// used by
// *this driver.
@@ -279,7 +267,6 @@ bool CMIDriver::DoInitialize() { return
bool CMIDriver::DoShutdown() { return CMIDriver::Instance().Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the name for *this driver.
// Type: Overridden.
// Args: None.
@@ -296,7 +283,6 @@ const CMIUtilString &CMIDriver::GetName(
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve *this driver's last error condition.
// Type: Overridden.
// Args: None.
@@ -306,7 +292,6 @@ const CMIUtilString &CMIDriver::GetName(
CMIUtilString CMIDriver::GetError() const { return GetErrorDescription(); }
//++
-//------------------------------------------------------------------------------------
// Details: Call *this driver to return it's debugger.
// Type: Overridden.
// Args: None.
@@ -318,7 +303,6 @@ lldb::SBDebugger &CMIDriver::GetTheDebug
}
//++
-//------------------------------------------------------------------------------------
// Details: Specify another driver *this driver can call should this driver not
// be able
// to handle the client data input. DoFallThruToAnotherDriver() makes
@@ -336,7 +320,6 @@ bool CMIDriver::SetDriverToFallThruTo(co
}
//++
-//------------------------------------------------------------------------------------
// Details: Proxy function CMIDriverMgr IDriver interface implementation. *this
// driver's
// implementation called from here to match the existing function name
@@ -373,7 +356,6 @@ lldb::SBError CMIDriver::DoParseArgs(con
}
//++
-//------------------------------------------------------------------------------------
// Details: Check the arguments that were passed to this program to make sure
// they are
// valid and to get their argument values (if any). The following are
@@ -483,7 +465,6 @@ lldb::SBError CMIDriver::ParseArgs(const
}
//++
-//------------------------------------------------------------------------------------
// Details: A client can ask if *this driver is GDB/MI compatible.
// Type: Overridden.
// Args: None.
@@ -494,7 +475,6 @@ lldb::SBError CMIDriver::ParseArgs(const
bool CMIDriver::GetDriverIsGDBMICompatibleDriver() const { return true; }
//++
-//------------------------------------------------------------------------------------
// Details: Start worker threads for the driver.
// Type: Method.
// Args: None.
@@ -521,7 +501,6 @@ bool CMIDriver::StartWorkerThreads() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Stop worker threads for the driver.
// Type: Method.
// Args: None.
@@ -535,7 +514,6 @@ bool CMIDriver::StopWorkerThreads() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Call this function puts *this driver to work.
// This function is used by the application's main thread.
// Type: Overridden.
@@ -610,7 +588,6 @@ bool CMIDriver::DoMainLoop() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Set things in motion, set state etc that brings *this driver (and
// the
// application) to a tidy shutdown.
@@ -634,7 +611,6 @@ bool CMIDriver::DoAppQuit() {
}
//++
-//------------------------------------------------------------------------------------
// Details: *this driver passes text commands to a fall through driver is it
// does not
// understand them (the LLDB driver).
@@ -686,7 +662,6 @@ bool CMIDriver::InterpretCommandFallThru
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the name for *this driver.
// Type: Overridden.
// Args: None.
@@ -696,7 +671,6 @@ bool CMIDriver::InterpretCommandFallThru
const CMIUtilString &CMIDriver::GetDriverName() const { return GetName(); }
//++
-//------------------------------------------------------------------------------------
// Details: Get the unique ID for *this driver.
// Type: Overridden.
// Args: None.
@@ -706,7 +680,6 @@ const CMIUtilString &CMIDriver::GetDrive
const CMIUtilString &CMIDriver::GetDriverId() const { return GetId(); }
//++
-//------------------------------------------------------------------------------------
// Details: This function allows *this driver to call on another driver to
// perform work
// should this driver not be able to handle the client data input.
@@ -731,7 +704,6 @@ bool CMIDriver::DoFallThruToAnotherDrive
}
//++
-//------------------------------------------------------------------------------------
// Details: *this driver provides a file stream to other drivers on which *this
// driver
// write's out to and they read as expected input. *this driver is
@@ -752,7 +724,6 @@ FILE *CMIDriver::GetStdin() const {
}
//++
-//------------------------------------------------------------------------------------
// Details: *this driver provides a file stream to other pass through assigned
// drivers
// so they know what to write to.
@@ -770,7 +741,6 @@ FILE *CMIDriver::GetStdout() const {
}
//++
-//------------------------------------------------------------------------------------
// Details: *this driver provides a error file stream to other pass through
// assigned drivers
// so they know what to write to.
@@ -789,7 +759,6 @@ FILE *CMIDriver::GetStderr() const {
}
//++
-//------------------------------------------------------------------------------------
// Details: Set a unique ID for *this driver. It cannot be empty.
// Type: Overridden.
// Args: vId - (R) Text description.
@@ -809,7 +778,6 @@ bool CMIDriver::SetId(const CMIUtilStrin
}
//++
-//------------------------------------------------------------------------------------
// Details: Get the unique ID for *this driver.
// Type: Overridden.
// Args: None.
@@ -819,7 +787,6 @@ bool CMIDriver::SetId(const CMIUtilStrin
const CMIUtilString &CMIDriver::GetId() const { return m_strDriverId; }
//++
-//------------------------------------------------------------------------------------
// Details: Interpret the text data and match against current commands to see if
// there
// is a match. If a match then the command is issued and actioned on.
@@ -849,7 +816,6 @@ bool CMIDriver::InterpretCommand(const C
}
//++
-//------------------------------------------------------------------------------------
// Details: Helper function for CMIDriver::InterpretCommandThisDriver.
// Convert a CLI command to MI command (just wrap any CLI command
// into "<tokens>-interpreter-exec command \"<CLI command>\"").
@@ -925,7 +891,6 @@ CMIDriver::WrapCLICommandIntoMICommand(c
}
//++
-//------------------------------------------------------------------------------------
// Details: Interpret the text data and match against current commands to see if
// there
// is a match. If a match then the command is issued and actioned on.
@@ -998,7 +963,6 @@ bool CMIDriver::InterpretCommandThisDriv
}
//++
-//------------------------------------------------------------------------------------
// Details: Having previously had the potential command validated and found
// valid now
// get the command executed.
@@ -1015,7 +979,6 @@ bool CMIDriver::ExecuteCommand(const SMI
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the MI Driver's exit application flag. The application checks
// this flag
// after every stdin line is read so the exit may not be instantaneous.
@@ -1048,7 +1011,6 @@ void CMIDriver::SetExitApplicationFlag(c
}
//++
-//------------------------------------------------------------------------------------
// Details: Get the MI Driver's exit exit application flag.
// This is related to the running state of the MI driver.
// Type: Method.
@@ -1060,7 +1022,6 @@ void CMIDriver::SetExitApplicationFlag(c
bool CMIDriver::GetExitApplicationFlag() const { return m_bExitApp; }
//++
-//------------------------------------------------------------------------------------
// Details: Get the current running state of the MI Driver.
// Type: Method.
// Args: None.
@@ -1072,7 +1033,6 @@ CMIDriver::DriverState_e CMIDriver::GetC
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the current running state of the MI Driver to running and
// currently not in
// a debug session.
@@ -1119,7 +1079,6 @@ bool CMIDriver::SetDriverStateRunningNot
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the current running state of the MI Driver to running and
// currently not in
// a debug session. The driver's state must in the state running and in
@@ -1168,7 +1127,6 @@ bool CMIDriver::SetDriverStateRunningDeb
}
//++
-//------------------------------------------------------------------------------------
// Details: Prepare the client IDE so it will start working/communicating with
// *this MI
// driver.
@@ -1184,7 +1142,6 @@ bool CMIDriver::InitClientIDEToMIDriver(
}
//++
-//------------------------------------------------------------------------------------
// Details: The IDE Eclipse when debugging locally expects "(gdb)\n" character
// sequence otherwise it refuses to communicate and times out. This
// should be
@@ -1200,7 +1157,6 @@ bool CMIDriver::InitClientIDEEclipse() c
}
//++
-//------------------------------------------------------------------------------------
// Details: Ask *this driver whether it found an executable in the MI Driver's
// list of
// arguments which to open and debug. If so instigate commands to set
@@ -1219,7 +1175,6 @@ bool CMIDriver::HaveExecutableFileNamePa
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve from *this driver executable file name path to start a
// debug session
// with (if present see HaveExecutableFileNamePathOnCmdLine()).
@@ -1233,7 +1188,6 @@ const CMIUtilString &CMIDriver::GetExecu
}
//++
-//------------------------------------------------------------------------------------
// Details: Execute commands (by injecting them into the stdin line queue
// container) and
// other code to set up the MI Driver such that is can take the
@@ -1256,7 +1210,6 @@ bool CMIDriver::LocalDebugSessionStartup
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the MI Driver into "its debugging an executable passed as an
// argument"
// mode as against running via a client like Eclipse.
@@ -1270,7 +1223,6 @@ void CMIDriver::SetDriverDebuggingArgExe
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the MI Driver state indicating if it is operating in "its
// debugging
// an executable passed as an argument" mode as against running via a
@@ -1286,7 +1238,6 @@ bool CMIDriver::IsDriverDebuggingArgExec
}
//++
-//------------------------------------------------------------------------------------
// Details: Execute commands from command source file in specified mode, and
// set exit-flag if needed.
// Type: Method.
@@ -1352,7 +1303,6 @@ bool CMIDriver::ExecuteCommandFile(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Gets called when lldb-mi gets a signal. Stops the process if it was
// SIGINT.
//
Modified: lldb/trunk/tools/lldb-mi/MIDriverBase.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIDriverBase.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIDriverBase.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIDriverBase.cpp Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
#include "MIDriverBase.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMIDriverBase constructor.
// Type: Method.
// Args: None.
@@ -25,7 +24,6 @@ CMIDriverBase::CMIDriverBase()
: m_pDriverFallThru(nullptr), m_pDriverParent(nullptr), m_bExitApp(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMIDriverBase destructor.
// Type: Overrideable.
// Args: None.
@@ -35,7 +33,6 @@ CMIDriverBase::CMIDriverBase()
CMIDriverBase::~CMIDriverBase() { m_pDriverFallThru = NULL; }
//++
-//------------------------------------------------------------------------------------
// Details: This function allows *this driver to call on another driver to
// perform work
// should this driver not be able to handle the client data input.
@@ -55,7 +52,6 @@ bool CMIDriverBase::DoFallThruToAnotherD
}
//++
-//------------------------------------------------------------------------------------
// Details: This function allows *this driver to call on another driver to
// perform work
// should this driver not be able to handle the client data input.
@@ -74,7 +70,6 @@ bool CMIDriverBase::SetDriverToFallThruT
}
//++
-//------------------------------------------------------------------------------------
// Details: This function allows *this driver to call functionality on the
// parent driver
// ask for information for example.
@@ -93,7 +88,6 @@ bool CMIDriverBase::SetDriverParent(cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the parent driver to *this driver if one assigned. If
// assigned *this
// is the pass through driver that the parent driver passes work to.
@@ -108,7 +102,6 @@ CMIDriverBase *CMIDriverBase::GetDrivers
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the pointer to the other fall through driver *this driver
// is using
// (or not using).
@@ -123,7 +116,6 @@ CMIDriverBase *CMIDriverBase::GetDriverT
}
//++
-//------------------------------------------------------------------------------------
// Details: *this driver provides a file stream to other drivers on which *this
// driver
// write's out to and they read as expected input. *this driver is
@@ -140,7 +132,6 @@ FILE *CMIDriverBase::GetStdin() const {
}
//++
-//------------------------------------------------------------------------------------
// Details: *this driver provides a file stream to other pass through assigned
// drivers
// so they know what to write to.
@@ -155,7 +146,6 @@ FILE *CMIDriverBase::GetStdout() const {
}
//++
-//------------------------------------------------------------------------------------
// Details: *this driver provides a error file stream to other pass through
// assigned drivers
// so they know what to write to.
@@ -170,7 +160,6 @@ FILE *CMIDriverBase::GetStderr() const {
}
//++
-//------------------------------------------------------------------------------------
// Details: Set the MI Driver's exit application flag. The application checks
// this flag
// after every stdin line is read so the exit may not be instantaneous.
Modified: lldb/trunk/tools/lldb-mi/MIDriverMain.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIDriverMain.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIDriverMain.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIDriverMain.cpp Wed Apr 10 13:48:55 2019
@@ -51,7 +51,6 @@
// CODETAG_IOR_SIGNALS
//++
-//------------------------------------------------------------------------------------
// Details: The SIGINT signal is sent to a process by its controlling terminal
// when a
// user wishes to interrupt the process. This is typically initiated by
@@ -85,7 +84,6 @@ void sigint_handler(int vSigno) {
}
//++
-//------------------------------------------------------------------------------------
// Details: Init the MI driver system. Initialize the whole driver system which
// includes
// both the original LLDB driver and the MI driver.
@@ -111,7 +109,6 @@ bool DriverSystemInit() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Shutdown the debugger system. Release / terminate resources external
// to
// specifically the MI driver.
@@ -131,7 +128,6 @@ bool DriverSystemShutdown(const bool vbA
}
//++
-//------------------------------------------------------------------------------------
// Details: MI's application start point of execution. The application runs in
// two modes.
// An LLDB native driver mode where it acts no different from the LLDB
Modified: lldb/trunk/tools/lldb-mi/MIDriverMgr.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIDriverMgr.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIDriverMgr.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIDriverMgr.cpp Wed Apr 10 13:48:55 2019
@@ -19,7 +19,6 @@
#include "MIUtilSingletonHelper.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMIDriverMgr constructor.
// Type: Method.
// Args: None.
@@ -29,7 +28,6 @@
CMIDriverMgr::CMIDriverMgr() : m_pDriverCurrent(nullptr), m_bInMi2Mode(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMIDriverMgr destructor.
// Type: Overridden.
// Args: None.
@@ -39,7 +37,6 @@ CMIDriverMgr::CMIDriverMgr() : m_pDriver
CMIDriverMgr::~CMIDriverMgr() { Shutdown(); }
//++
-//------------------------------------------------------------------------------------
// Details: Initialize *this manager.
// Type: Method.
// Args: None.
@@ -76,7 +73,6 @@ bool CMIDriverMgr::Initialize() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Unbind detach or release resources used by this server in general
// common
// functionality shared between versions of any server interfaces
@@ -119,7 +115,6 @@ bool CMIDriverMgr::Shutdown() {
return bOk;
}
//++
-//------------------------------------------------------------------------------------
// Details: Unregister all the Driver registered with *this manager. The manager
// also
// deletes
@@ -146,7 +141,6 @@ bool CMIDriverMgr::UnregisterDriverAll()
}
//++
-//------------------------------------------------------------------------------------
// Details: Register a driver with *this Driver Manager. Call
// SetUseThisDriverToDoWork()
// inform the manager which driver is the one to the work. The manager
@@ -183,7 +177,6 @@ bool CMIDriverMgr::RegisterDriver(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Query the Driver Manager to see if *this manager has the driver
// already
// registered.
@@ -208,7 +201,6 @@ bool CMIDriverMgr::HaveDriverAlready(con
}
//++
-//------------------------------------------------------------------------------------
// Details: Unregister a driver from the Driver Manager. Call the
// SetUseThisDriverToDoWork()
// function to define another driver to do work if the one being
@@ -240,7 +232,6 @@ bool CMIDriverMgr::UnregisterDriver(cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Specify the driver to do work. The Driver Manager drives this
// driver. Any
// previous driver doing work is not called anymore (so be sure the
@@ -266,7 +257,6 @@ bool CMIDriverMgr::SetUseThisDriverToDoW
}
//++
-//------------------------------------------------------------------------------------
// Details: Ask *this manager which driver is currently doing the work.
// Type: Method.
// Args: None.
@@ -279,7 +269,6 @@ CMIDriverMgr::IDriver *CMIDriverMgr::Get
}
//++
-//------------------------------------------------------------------------------------
// Details: Call this function puts *this driver to work.
// Type: Method.
// Args: None.
@@ -306,7 +295,6 @@ bool CMIDriverMgr::DriverMainLoop() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Get the current driver to validate executable command line
// arguments.
// Type: Method.
@@ -356,7 +344,6 @@ bool CMIDriverMgr::DriverParseArgs(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the current driver's last error condition.
// Type: Method.
// Args: None.
@@ -375,7 +362,6 @@ CMIUtilString CMIDriverMgr::DriverGetErr
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the current driver's name.
// Type: Method.
// Args: None.
@@ -395,7 +381,6 @@ CMIUtilString CMIDriverMgr::DriverGetNam
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the current driver's debugger object.
// Type: Method.
// Args: None.
@@ -416,7 +401,6 @@ lldb::SBDebugger *CMIDriverMgr::DriverGe
}
//++
-//------------------------------------------------------------------------------------
// Details: Check the arguments given on the command line. The main purpose of
// this
// function is to check for the presence of the --interpreter option.
@@ -605,7 +589,6 @@ bool CMIDriverMgr::ParseArgs(const int a
}
//++
-//------------------------------------------------------------------------------------
// Details: Return formatted application version and name information.
// Type: Method.
// Args: None.
@@ -623,7 +606,6 @@ CMIUtilString CMIDriverMgr::GetAppVersio
}
//++
-//------------------------------------------------------------------------------------
// Details: Return formatted help information on all the MI command line
// options.
// Type: Method.
@@ -655,7 +637,6 @@ CMIUtilString CMIDriverMgr::GetHelpOnCmd
}
//++
-//------------------------------------------------------------------------------------
// Details: Search the registered drivers and return the first driver which says
// it is
// GDB/MI compatible i.e. the CMIDriver class.
@@ -684,7 +665,6 @@ CMIDriverMgr::IDriver *CMIDriverMgr::Get
}
//++
-//------------------------------------------------------------------------------------
// Details: Search the registered drivers and return the first driver which says
// it is
// not GDB/MI compatible i.e. the LLDB Driver class.
@@ -713,7 +693,6 @@ CMIDriverMgr::IDriver *CMIDriverMgr::Get
}
//++
-//------------------------------------------------------------------------------------
// Details: Search the registered drivers and return driver with the specified
// ID.
// Type: Method.
@@ -734,7 +713,6 @@ CMIDriverMgr::GetDriver(const CMIUtilStr
}
//++
-//------------------------------------------------------------------------------------
// Details: Gets called when lldb-mi gets a signal. Passed signal to current
// driver.
//
Modified: lldb/trunk/tools/lldb-mi/MIUtilDateTimeStd.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilDateTimeStd.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilDateTimeStd.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilDateTimeStd.cpp Wed Apr 10 13:48:55 2019
@@ -11,7 +11,6 @@
#include "MICmnResources.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilDateTimeStd constructor.
// Type: Method.
// Args: None.
@@ -21,7 +20,6 @@
CMIUtilDateTimeStd::CMIUtilDateTimeStd() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilDateTimeStd destructor.
// Type: Method.
// Args: None.
@@ -31,7 +29,6 @@ CMIUtilDateTimeStd::CMIUtilDateTimeStd()
CMIUtilDateTimeStd::~CMIUtilDateTimeStd() {}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve system local current date. Format is MM/DD/YYYY.
// Type: Method.
// Args: None.
@@ -50,7 +47,6 @@ CMIUtilString CMIUtilDateTimeStd::GetDat
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve system local current time. Format is HH:MM:SS 24 hour
// clock.
// Type: Method.
@@ -70,7 +66,6 @@ CMIUtilString CMIUtilDateTimeStd::GetTim
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve system local current date and time in yyyy-MM-dd--HH-mm-ss
// format for log file names.
// Type: Method.
Modified: lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp Wed Apr 10 13:48:55 2019
@@ -17,7 +17,6 @@
#include "MIUtilDebug.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilDebug constructor.
// Type: Method.
// Args: None.
@@ -27,7 +26,6 @@
CMIUtilDebug::CMIUtilDebug() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilDebug destructor.
// Type: Method.
// Args: None.
@@ -37,7 +35,6 @@ CMIUtilDebug::CMIUtilDebug() {}
CMIUtilDebug::~CMIUtilDebug() {}
//++
-//------------------------------------------------------------------------------------
// Details: Temporarily stall the process/application to give the programmer the
// opportunity to attach a debugger. How to use: Put a break in the
// programmer
@@ -61,16 +58,12 @@ void CMIUtilDebug::WaitForDbgAttachInfin
}
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
// Instantiations:
CMICmnLog &CMIUtilDebugFnTrace::ms_rLog = CMICmnLog::Instance();
MIuint CMIUtilDebugFnTrace::ms_fnDepthCnt = 0;
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilDebugFnTrace constructor.
// Type: Method.
// Args: vFnName - (R) The text to insert into the log.
@@ -85,7 +78,6 @@ CMIUtilDebugFnTrace::CMIUtilDebugFnTrace
}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilDebugFnTrace destructor.
// Type: Method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MIUtilFileStd.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilFileStd.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilFileStd.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilFileStd.cpp Wed Apr 10 13:48:55 2019
@@ -21,7 +21,6 @@
#include "llvm/Support/Errno.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilFileStd constructor.
// Type: Method.
// Args: None.
@@ -42,7 +41,6 @@ CMIUtilFileStd::CMIUtilFileStd()
}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilFileStd destructor.
// Type: Method.
// Args: None.
@@ -52,7 +50,6 @@ CMIUtilFileStd::CMIUtilFileStd()
CMIUtilFileStd::~CMIUtilFileStd() { Close(); }
//++
-//------------------------------------------------------------------------------------
// Details: Open file for writing. On the first call to this function after
// *this object
// is created the file is either created or replace, from then on open
@@ -111,7 +108,6 @@ bool CMIUtilFileStd::CreateWrite(const C
}
//++
-//------------------------------------------------------------------------------------
// Details: Write data to existing opened file.
// Type: Method.
// Args: vData - (R) Text data.
@@ -149,7 +145,6 @@ bool CMIUtilFileStd::Write(const CMIUtil
}
//++
-//------------------------------------------------------------------------------------
// Details: Write data to existing opened file.
// Type: Method.
// Args: vData - (R) Text data.
@@ -186,7 +181,6 @@ bool CMIUtilFileStd::Write(const char *v
}
//++
-//------------------------------------------------------------------------------------
// Details: Close existing opened file. Note Close() must must an open!
// Type: Method.
// Args: None.
@@ -204,7 +198,6 @@ void CMIUtilFileStd::Close() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve state of whether the file is ok.
// Type: Method.
// Args: None.
@@ -215,7 +208,6 @@ void CMIUtilFileStd::Close() {
bool CMIUtilFileStd::IsOk() const { return !m_bFileError; }
//++
-//------------------------------------------------------------------------------------
// Details: Status on a file existing already.
// Type: Method.
// Args: vFileNamePath.
@@ -239,7 +231,6 @@ bool CMIUtilFileStd::IsFileExist(const C
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the file current carriage line return characters used.
// Type: Method.
// Args: None.
@@ -251,7 +242,6 @@ const CMIUtilString &CMIUtilFileStd::Get
}
//++
-//------------------------------------------------------------------------------------
// Details: Given a file name directory path, strip off the filename and return
// the path.
// It look for either backslash or forward slash.
@@ -275,7 +265,6 @@ CMIUtilFileStd::StripOffFileName(const C
}
//++
-//------------------------------------------------------------------------------------
// Details: Return either backslash or forward slash appropriate to the OS this
// application
// is running on.
Modified: lldb/trunk/tools/lldb-mi/MIUtilMapIdToVariant.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilMapIdToVariant.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilMapIdToVariant.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilMapIdToVariant.cpp Wed Apr 10 13:48:55 2019
@@ -10,7 +10,6 @@
#include "MIUtilMapIdToVariant.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilMapIdToVariant constructor.
// Type: Method.
// Args: None.
@@ -20,7 +19,6 @@
CMIUtilMapIdToVariant::CMIUtilMapIdToVariant() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilMapIdToVariant destructor.
// Type: Method.
// Args: None.
@@ -30,7 +28,6 @@ CMIUtilMapIdToVariant::CMIUtilMapIdToVar
CMIUtilMapIdToVariant::~CMIUtilMapIdToVariant() {}
//++
-//------------------------------------------------------------------------------------
// Details: Remove at the data from *this container.
// Type: Method.
// Args: None.
@@ -40,7 +37,6 @@ CMIUtilMapIdToVariant::~CMIUtilMapIdToVa
void CMIUtilMapIdToVariant::Clear() { m_mapKeyToVariantValue.clear(); }
//++
-//------------------------------------------------------------------------------------
// Details: Check an ID is present already in *this container.
// Type: Method.
// Args: vId - (R) Unique ID i.e. GUID.
@@ -55,7 +51,6 @@ bool CMIUtilMapIdToVariant::HaveAlready(
}
//++
-//------------------------------------------------------------------------------------
// Details: Determine if *this container is currently holding any data.
// Type: Method.
// Args: None.
@@ -67,7 +62,6 @@ bool CMIUtilMapIdToVariant::IsEmpty() co
}
//++
-//------------------------------------------------------------------------------------
// Details: Check the ID is valid to be registered.
// Type: Method.
// Args: vId - (R) Unique ID i.e. GUID.
@@ -85,7 +79,6 @@ bool CMIUtilMapIdToVariant::IsValid(cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Remove from *this contain a data object specified by ID. The data
// object
// when removed also calls its destructor should it have one.
Modified: lldb/trunk/tools/lldb-mi/MIUtilMapIdToVariant.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilMapIdToVariant.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilMapIdToVariant.h (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilMapIdToVariant.h Wed Apr 10 13:48:55 2019
@@ -55,7 +55,6 @@ private:
};
//++
-//------------------------------------------------------------------------------------
// Details: Add to *this container a data object of general type identified by
// an ID.
// If the data with that ID already exists in the container it is
@@ -89,7 +88,6 @@ bool CMIUtilMapIdToVariant::Add(const CM
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve a data object from *this container identified by the
// specified ID.
// Type: Method.
Modified: lldb/trunk/tools/lldb-mi/MIUtilString.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilString.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilString.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilString.cpp Wed Apr 10 13:48:55 2019
@@ -20,7 +20,6 @@
#include "MIUtilString.h"
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilString constructor.
// Type: Method.
// Args: None.
@@ -30,7 +29,6 @@
CMIUtilString::CMIUtilString() : std::string() {}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilString constructor.
// Type: Method.
// Args: vpData - Pointer to UTF8 text data.
@@ -41,7 +39,6 @@ CMIUtilString::CMIUtilString(const char
: std::string(WithNullAsEmpty(vpData)) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilString constructor.
// Type: Method.
// Args: vpStr - Text data.
@@ -51,7 +48,6 @@ CMIUtilString::CMIUtilString(const char
CMIUtilString::CMIUtilString(const std::string &vrStr) : std::string(vrStr) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilString assignment operator.
// Type: Method.
// Args: vpRhs - Pointer to UTF8 text data.
@@ -64,7 +60,6 @@ CMIUtilString &CMIUtilString::operator=(
}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilString assignment operator.
// Type: Method.
// Args: vrRhs - The other string to copy from.
@@ -77,7 +72,6 @@ CMIUtilString &CMIUtilString::operator=(
}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilString destructor.
// Type: Method.
// Args: None.
@@ -87,7 +81,6 @@ CMIUtilString &CMIUtilString::operator=(
CMIUtilString::~CMIUtilString() {}
//++
-//------------------------------------------------------------------------------------
// Details: Perform a snprintf format style on a string data. A new string
// object is
// created and returned.
@@ -146,7 +139,6 @@ CMIUtilString CMIUtilString::FormatPriv(
}
//++
-//------------------------------------------------------------------------------------
// Details: Perform a snprintf format style on a string data. A new string
// object is
// created and returned.
@@ -167,7 +159,6 @@ CMIUtilString CMIUtilString::Format(cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Perform a snprintf format style on a string data. A new string
// object is
// created and returned.
@@ -183,7 +174,6 @@ CMIUtilString CMIUtilString::FormatValis
}
//++
-//------------------------------------------------------------------------------------
// Details: Splits string into array of strings using delimiter. If multiple
// delimiter
// are found in sequence then they are not added to the list of splits.
@@ -227,7 +217,6 @@ size_t CMIUtilString::Split(const CMIUti
}
//++
-//------------------------------------------------------------------------------------
// Details: Splits string into array of strings using delimiter. However the
// string is
// also considered for text surrounded by quotes. Text with quotes
@@ -286,7 +275,6 @@ size_t CMIUtilString::SplitConsiderQuote
}
//++
-//------------------------------------------------------------------------------------
// Details: Split string into lines using \n and return an array of strings.
// Type: Method.
// Args: vwVecSplits - (W) Container of splits found in string data.
@@ -298,7 +286,6 @@ size_t CMIUtilString::SplitLines(VecStri
}
//++
-//------------------------------------------------------------------------------------
// Details: Remove '\n' from the end of string if found. It does not alter
// *this string.
// Type: Method.
@@ -317,7 +304,6 @@ CMIUtilString CMIUtilString::StripCREndO
}
//++
-//------------------------------------------------------------------------------------
// Details: Remove all '\n' from the string and replace with a space. It does
// not alter
// *this string.
@@ -331,7 +317,6 @@ CMIUtilString CMIUtilString::StripCRAll(
}
//++
-//------------------------------------------------------------------------------------
// Details: Find and replace all matches of a sub string with another string. It
// does not
// alter *this string.
@@ -362,7 +347,6 @@ CMIUtilString::FindAndReplace(const CMIU
}
//++
-//------------------------------------------------------------------------------------
// Details: Check if *this string is a decimal number.
// Type: Method.
// Args: None.
@@ -381,7 +365,6 @@ bool CMIUtilString::IsNumber() const {
}
//++
-//------------------------------------------------------------------------------------
// Details: Check if *this string is a hexadecimal number.
// Type: Method.
// Args: None.
@@ -399,7 +382,6 @@ bool CMIUtilString::IsHexadecimalNumber(
}
//++
-//------------------------------------------------------------------------------------
// Details: Extract the number from the string. The number can be either a
// hexadecimal or
// natural number. It cannot contain other non-numeric characters.
@@ -422,7 +404,6 @@ bool CMIUtilString::ExtractNumber(MIint6
}
//++
-//------------------------------------------------------------------------------------
// Details: Extract the number from the hexadecimal string..
// Type: Method.
// Args: vwrNumber - (W) Number extracted from the string.
@@ -447,7 +428,6 @@ bool CMIUtilString::ExtractNumberFromHex
}
//++
-//------------------------------------------------------------------------------------
// Details: Determine if the text is all valid alpha numeric characters. Letters
// can be
// either upper or lower case.
@@ -471,7 +451,6 @@ bool CMIUtilString::IsAllValidAlphaAndNu
}
//++
-//------------------------------------------------------------------------------------
// Details: Check if two strings share equal contents.
// Type: Method.
// Args: vrLhs - (R) String A.
@@ -489,7 +468,6 @@ bool CMIUtilString::Compare(const CMIUti
}
//++
-//------------------------------------------------------------------------------------
// Details: Remove from either end of *this string the following: " \t\n\v\f\r".
// Type: Method.
// Args: None.
@@ -512,7 +490,6 @@ CMIUtilString CMIUtilString::Trim() cons
}
//++
-//------------------------------------------------------------------------------------
// Details: Remove from either end of *this string the specified character.
// Type: Method.
// Args: None.
@@ -531,7 +508,6 @@ CMIUtilString CMIUtilString::Trim(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Do a printf equivalent for printing a number in binary i.e. "b%llB".
// Type: Static method.
// Args: vnDecimal - (R) The number to represent in binary.
@@ -564,7 +540,6 @@ CMIUtilString CMIUtilString::FormatBinar
}
//++
-//------------------------------------------------------------------------------------
// Details: Remove from a string doubled up characters so only one set left.
// Characters
// are only removed if the previous character is already a same
@@ -580,7 +555,6 @@ CMIUtilString CMIUtilString::RemoveRepea
}
//++
-//------------------------------------------------------------------------------------
// Details: Recursively remove from a string doubled up characters so only one
// set left.
// Characters are only removed if the previous character is already a
@@ -615,7 +589,6 @@ CMIUtilString CMIUtilString::RemoveRepea
}
//++
-//------------------------------------------------------------------------------------
// Details: Is the text in *this string surrounded by quotes.
// Type: Method.
// Args: None.
@@ -633,7 +606,6 @@ bool CMIUtilString::IsQuoted() const {
}
//++
-//------------------------------------------------------------------------------------
// Details: Find first occurrence in *this string which matches the pattern.
// Type: Method.
// Args: vrPattern - (R) The pattern to search for.
@@ -648,7 +620,6 @@ size_t CMIUtilString::FindFirst(const CM
}
//++
-//------------------------------------------------------------------------------------
// Details: Find first occurrence in *this string which matches the pattern and
// isn't surrounded by quotes.
// Type: Method.
@@ -697,7 +668,6 @@ size_t CMIUtilString::FindFirst(const CM
}
//++
-//------------------------------------------------------------------------------------
// Details: Find first occurrence in *this string which doesn't match the
// pattern.
// Type: Method.
@@ -724,7 +694,6 @@ size_t CMIUtilString::FindFirstNot(const
}
//++
-//------------------------------------------------------------------------------------
// Details: Find first occurrence of not escaped quotation mark in *this string.
// Type: Method.
// Args: vnPos - Position of the first character in the string to be
@@ -755,7 +724,6 @@ size_t CMIUtilString::FindFirstQuote(siz
}
//++
-//------------------------------------------------------------------------------------
// Details: Get escaped string from *this string.
// Type: Method.
// Args: None.
@@ -777,7 +745,6 @@ CMIUtilString CMIUtilString::Escape(bool
}
//++
-//------------------------------------------------------------------------------------
// Details: Get string with backslashes in front of double quote '"' and
// backslash '\\'
// characters.
@@ -813,7 +780,6 @@ CMIUtilString CMIUtilString::AddSlashes(
}
//++
-//------------------------------------------------------------------------------------
// Details: Remove backslashes added by CMIUtilString::AddSlashes.
// Type: Method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MIUtilThreadBaseStd.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilThreadBaseStd.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilThreadBaseStd.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilThreadBaseStd.cpp Wed Apr 10 13:48:55 2019
@@ -14,7 +14,6 @@
#include "MIUtilThreadBaseStd.h"
//++
-//------------------------------------------------------------------------------------
// Details: Constructor.
// Type: None.
// Args: None.
@@ -25,7 +24,6 @@ CMIUtilThreadActiveObjBase::CMIUtilThrea
: m_references(0), m_bHasBeenKilled(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: Destructor.
// Type: None.
// Args: None.
@@ -38,7 +36,6 @@ CMIUtilThreadActiveObjBase::~CMIUtilThre
}
//++
-//------------------------------------------------------------------------------------
// Details: Check if an object is already running.
// Type: Method.
// Args: None.
@@ -52,7 +49,6 @@ bool CMIUtilThreadActiveObjBase::ThreadI
}
//++
-//------------------------------------------------------------------------------------
// Details: Set up *this thread.
// Type: Method.
// Args: None.
@@ -66,7 +62,6 @@ bool CMIUtilThreadActiveObjBase::ThreadE
}
//++
-//------------------------------------------------------------------------------------
// Details: Acquire a reference to CMIUtilThreadActiveObjBase.
// Type: Method.
// Args: None.
@@ -85,7 +80,6 @@ bool CMIUtilThreadActiveObjBase::Acquire
}
//++
-//------------------------------------------------------------------------------------
// Details: Release a reference to CMIUtilThreadActiveObjBase.
// Type: Method.
// Args: None.
@@ -104,7 +98,6 @@ bool CMIUtilThreadActiveObjBase::Release
}
//++
-//------------------------------------------------------------------------------------
// Details: Force this thread to stop, regardless of references
// Type: Method.
// Args: None.
@@ -123,7 +116,6 @@ bool CMIUtilThreadActiveObjBase::ThreadK
}
//++
-//------------------------------------------------------------------------------------
// Details: Proxy to thread join.
// Type: Method.
// Args: None.
@@ -134,7 +126,6 @@ bool CMIUtilThreadActiveObjBase::ThreadK
bool CMIUtilThreadActiveObjBase::ThreadJoin() { return m_thread.Join(); }
//++
-//------------------------------------------------------------------------------------
// Details: This function is the entry point of this object thread.
// It is a trampoline to an instances operation manager.
// Type: Static method.
@@ -158,7 +149,6 @@ MIuint CMIUtilThreadActiveObjBase::Threa
}
//++
-//------------------------------------------------------------------------------------
// Details: This function forms a small management routine, to handle the
// thread's running.
// Type: Method.
@@ -196,15 +186,11 @@ void CMIUtilThreadActiveObjBase::ThreadM
m_thread.Finish();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//
CMIUtilThread::CMIUtilThread() : m_pThread(nullptr), m_bIsActive(false) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilThread destructor.
// Type: Method.
// Args: None.
@@ -214,7 +200,6 @@ CMIUtilThread::CMIUtilThread() : m_pThre
CMIUtilThread::~CMIUtilThread() { Join(); }
//++
-//------------------------------------------------------------------------------------
// Details: Wait for thread to stop.
// Type: Method.
// Args: None.
@@ -239,7 +224,6 @@ bool CMIUtilThread::Join() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Is the thread doing work.
// Type: Method.
// Args: None.
@@ -253,7 +237,6 @@ bool CMIUtilThread::IsActive() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Finish this thread
// Type: Method.
// Args: None.
@@ -267,7 +250,6 @@ void CMIUtilThread::Finish() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Set up *this thread.
// Type: Method.
// Args: vpFn (R) - Function pointer to thread's main function.
@@ -290,12 +272,8 @@ bool CMIUtilThread::Start(FnThreadProc v
return MIstatus::success;
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: Take resource.
// Type: Method.
// Args: None.
@@ -305,7 +283,6 @@ bool CMIUtilThread::Start(FnThreadProc v
void CMIUtilThreadMutex::Lock() { m_mutex.lock(); }
//++
-//------------------------------------------------------------------------------------
// Details: Release resource.
// Type: Method.
// Args: None.
@@ -315,7 +292,6 @@ void CMIUtilThreadMutex::Lock() { m_mute
void CMIUtilThreadMutex::Unlock() { m_mutex.unlock(); }
//++
-//------------------------------------------------------------------------------------
// Details: Take resource if available. Immediately return in either case.
// Type: Method.
// Args: None.
Modified: lldb/trunk/tools/lldb-mi/MIUtilVariant.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilVariant.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilVariant.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilVariant.cpp Wed Apr 10 13:48:55 2019
@@ -10,7 +10,6 @@
#include "MIUtilVariant.h"
//++
-//------------------------------------------------------------------------------------
// Details: CDataObjectBase constructor.
// Type: Method.
// Args: None.
@@ -20,7 +19,6 @@
CMIUtilVariant::CDataObjectBase::CDataObjectBase() {}
//++
-//------------------------------------------------------------------------------------
// Details: CDataObjectBase copy constructor.
// Type: Method.
// Args: vrOther - (R) The other object.
@@ -33,7 +31,6 @@ CMIUtilVariant::CDataObjectBase::CDataOb
}
//++
-//------------------------------------------------------------------------------------
// Details: CDataObjectBase copy constructor.
// Type: Method.
// Args: vrOther - (R) The other object.
@@ -45,7 +42,6 @@ CMIUtilVariant::CDataObjectBase::CDataOb
}
//++
-//------------------------------------------------------------------------------------
// Details: CDataObjectBase move constructor.
// Type: Method.
// Args: vrwOther - (R) The other object.
@@ -57,7 +53,6 @@ CMIUtilVariant::CDataObjectBase::CDataOb
}
//++
-//------------------------------------------------------------------------------------
// Details: CDataObjectBase destructor.
// Type: Overrideable.
// Args: None.
@@ -67,7 +62,6 @@ CMIUtilVariant::CDataObjectBase::CDataOb
CMIUtilVariant::CDataObjectBase::~CDataObjectBase() { Destroy(); }
//++
-//------------------------------------------------------------------------------------
// Details: CDataObjectBase copy assignment.
// Type: Method.
// Args: vrOther - (R) The other object.
@@ -81,7 +75,6 @@ operator=(const CDataObjectBase &vrOther
}
//++
-//------------------------------------------------------------------------------------
// Details: CDataObjectBase move assignment.
// Type: Method.
// Args: vrwOther - (R) The other object.
@@ -96,7 +89,6 @@ operator=(CDataObjectBase &&vrwOther) {
}
//++
-//------------------------------------------------------------------------------------
// Details: Create a new copy of *this class.
// Type: Overrideable.
// Args: None.
@@ -110,7 +102,6 @@ CMIUtilVariant::CDataObjectBase::CreateC
}
//++
-//------------------------------------------------------------------------------------
// Details: Determine if *this object is a derived from CDataObjectBase.
// Type: Overrideable.
// Args: None.
@@ -124,7 +115,6 @@ bool CMIUtilVariant::CDataObjectBase::Ge
}
//++
-//------------------------------------------------------------------------------------
// Details: Perform a bitwise copy of *this object.
// Type: Overrideable.
// Args: vrOther - (R) The other object.
@@ -137,7 +127,6 @@ void CMIUtilVariant::CDataObjectBase::Co
}
//++
-//------------------------------------------------------------------------------------
// Details: Release any resources used by *this object.
// Type: Overrideable.
// Args: None.
@@ -148,12 +137,8 @@ void CMIUtilVariant::CDataObjectBase::De
// Do nothing - override to implement
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CDataObject copy constructor.
// Type: Method.
// Args: T - The object's type.
@@ -169,7 +154,6 @@ CMIUtilVariant::CDataObject<T>::CDataObj
}
//++
-//------------------------------------------------------------------------------------
// Details: CDataObject copy constructor.
// Type: Method.
// Args: T - The object's type.
@@ -185,7 +169,6 @@ CMIUtilVariant::CDataObject<T>::CDataObj
}
//++
-//------------------------------------------------------------------------------------
// Details: CDataObject move constructor.
// Type: Method.
// Args: T - The object's type.
@@ -202,7 +185,6 @@ CMIUtilVariant::CDataObject<T>::CDataObj
}
//++
-//------------------------------------------------------------------------------------
// Details: CDataObject copy assignment.
// Type: Method.
// Args: T - The object's type.
@@ -220,7 +202,6 @@ operator=(const CDataObject &vrOther) {
}
//++
-//------------------------------------------------------------------------------------
// Details: CDataObject move assignment.
// Type: Method.
// Args: T - The object's type.
@@ -238,12 +219,8 @@ operator=(CDataObject &&vrwOther) {
return *this;
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilVariant constructor.
// Type: Method.
// Args: None.
@@ -253,7 +230,6 @@ operator=(CDataObject &&vrwOther) {
CMIUtilVariant::CMIUtilVariant() : m_pDataObject(nullptr) {}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilVariant copy constructor.
// Type: Method.
// Args: vrOther - (R) The other object.
@@ -269,7 +245,6 @@ CMIUtilVariant::CMIUtilVariant(const CMI
}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilVariant copy constructor.
// Type: Method.
// Args: vrOther - (R) The other object.
@@ -285,7 +260,6 @@ CMIUtilVariant::CMIUtilVariant(CMIUtilVa
}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilVariant move constructor.
// Type: Method.
// Args: vrwOther - (R) The other object.
@@ -302,7 +276,6 @@ CMIUtilVariant::CMIUtilVariant(CMIUtilVa
}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilVariant destructor.
// Type: Method.
// Args: None.
@@ -312,7 +285,6 @@ CMIUtilVariant::CMIUtilVariant(CMIUtilVa
CMIUtilVariant::~CMIUtilVariant() { Destroy(); }
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilVariant copy assignment.
// Type: Method.
// Args: vrOther - (R) The other object.
@@ -328,7 +300,6 @@ CMIUtilVariant &CMIUtilVariant::operator
}
//++
-//------------------------------------------------------------------------------------
// Details: CMIUtilVariant move assignment.
// Type: Method.
// Args: vrwOther - (R) The other object.
@@ -345,7 +316,6 @@ CMIUtilVariant &CMIUtilVariant::operator
}
//++
-//------------------------------------------------------------------------------------
// Details: Release the resources used by *this object.
// Type: Method.
// Args: None.
@@ -359,7 +329,6 @@ void CMIUtilVariant::Destroy() {
}
//++
-//------------------------------------------------------------------------------------
// Details: Bitwise copy another data object to *this variant object.
// Type: Method.
// Args: vrOther - (R) The other object.
Modified: lldb/trunk/tools/lldb-mi/MIUtilVariant.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilVariant.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilVariant.h (original)
+++ lldb/trunk/tools/lldb-mi/MIUtilVariant.h Wed Apr 10 13:48:55 2019
@@ -116,12 +116,8 @@ private:
CDataObjectBase *m_pDataObject;
};
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: CDataObject constructor.
// Type: Method.
// Args: T - The object's type.
@@ -131,7 +127,6 @@ private:
template <typename T> CMIUtilVariant::CDataObject<T>::CDataObject() {}
//++
-//------------------------------------------------------------------------------------
// Details: CDataObject constructor.
// Type: Method.
// Args: T - The object's type.
@@ -145,7 +140,6 @@ CMIUtilVariant::CDataObject<T>::CDataObj
}
//++
-//------------------------------------------------------------------------------------
// Details: CDataObject destructor.
// Type: Overridden.
// Args: T - The object's type.
@@ -157,7 +151,6 @@ template <typename T> CMIUtilVariant::CD
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the data object hold by *this object wrapper.
// Type: Method.
// Args: T - The object's type.
@@ -169,7 +162,6 @@ template <typename T> T &CMIUtilVariant:
}
//++
-//------------------------------------------------------------------------------------
// Details: Create a new copy of *this class.
// Type: Overridden.
// Args: T - The object's type.
@@ -185,7 +177,6 @@ CMIUtilVariant::CDataObject<T>::CreateCo
}
//++
-//------------------------------------------------------------------------------------
// Details: Determine if *this object is a derived from CDataObjectBase.
// Type: Overridden.
// Args: T - The object's type.
@@ -199,7 +190,6 @@ bool CMIUtilVariant::CDataObject<T>::Get
}
//++
-//------------------------------------------------------------------------------------
// Details: Perform a bitwise copy of *this object.
// Type: Overrideable.
// Args: T - The object's type.
@@ -214,7 +204,6 @@ void CMIUtilVariant::CDataObject<T>::Dup
}
//++
-//------------------------------------------------------------------------------------
// Details: Release any resources used by *this object.
// Type: Overridden.
// Args: None.
@@ -225,12 +214,8 @@ template <typename T> void CMIUtilVarian
CDataObjectBase::Destroy();
}
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
-//---------------------------------------------------------------------------------------
//++
-//------------------------------------------------------------------------------------
// Details: Assign to the variant an object of a specified type.
// Type: Template method.
// Args: T - The object's type.
@@ -243,7 +228,6 @@ template <typename T> void CMIUtilVarian
}
//++
-//------------------------------------------------------------------------------------
// Details: Retrieve the data object from *this variant.
// Type: Template method.
// Args: T - The object's type.
Modified: lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp (original)
+++ lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp Wed Apr 10 13:48:55 2019
@@ -79,9 +79,7 @@ public:
#endif
}
-//----------------------------------------------------------------------
// option descriptors for getopt_long_only()
-//----------------------------------------------------------------------
static int g_debug = 0;
static int g_verbose = 0;
@@ -106,9 +104,7 @@ static struct option g_long_options[] =
{"fd", required_argument, NULL, 'F'},
{NULL, 0, NULL, 0}};
-//----------------------------------------------------------------------
// Watch for signals
-//----------------------------------------------------------------------
static int g_sighup_received_count = 0;
#ifndef _WIN32
@@ -356,9 +352,7 @@ void ConnectToRemote(MainLoop &mainloop,
printf("Connection established.\n");
}
-//----------------------------------------------------------------------
// main
-//----------------------------------------------------------------------
int main_gdbserver(int argc, char *argv[]) {
Status error;
MainLoop mainloop;
Modified: lldb/trunk/tools/lldb-server/lldb-platform.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/lldb-platform.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-server/lldb-platform.cpp (original)
+++ lldb/trunk/tools/lldb-server/lldb-platform.cpp Wed Apr 10 13:48:55 2019
@@ -39,9 +39,7 @@ using namespace lldb_private::lldb_serve
using namespace lldb_private::process_gdb_remote;
using namespace llvm;
-//----------------------------------------------------------------------
// option descriptors for getopt_long_only()
-//----------------------------------------------------------------------
static int g_debug = 0;
static int g_verbose = 0;
@@ -69,9 +67,7 @@ static struct option g_long_options[] =
#define HIGH_PORT (49151u)
#endif
-//----------------------------------------------------------------------
// Watch for signals
-//----------------------------------------------------------------------
static void signal_handler(int signo) {
switch (signo) {
case SIGHUP:
@@ -129,9 +125,7 @@ static Status save_socket_id_to_file(con
return Status();
}
-//----------------------------------------------------------------------
// main
-//----------------------------------------------------------------------
int main_platform(int argc, char *argv[]) {
const char *progname = argv[0];
const char *subcommand = argv[1];
Modified: lldb/trunk/tools/lldb-server/lldb-server.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/lldb-server.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-server/lldb-server.cpp (original)
+++ lldb/trunk/tools/lldb-server/lldb-server.cpp Wed Apr 10 13:48:55 2019
@@ -46,9 +46,7 @@ static void initialize() {
static void terminate() { g_debugger_lifetime->Terminate(); }
} // namespace llgs
-//----------------------------------------------------------------------
// main
-//----------------------------------------------------------------------
int main(int argc, char *argv[]) {
llvm::StringRef ToolName = argv[0];
llvm::sys::PrintStackTraceOnErrorSignal(ToolName);
Modified: lldb/trunk/tools/lldb-test/SystemInitializerTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-test/SystemInitializerTest.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-test/SystemInitializerTest.cpp (original)
+++ lldb/trunk/tools/lldb-test/SystemInitializerTest.cpp Wed Apr 10 13:48:55 2019
@@ -213,9 +213,7 @@ llvm::Error SystemInitializerTest::Initi
// It shouldn't be limited to __APPLE__.
StructuredDataDarwinLog::Initialize();
- //----------------------------------------------------------------------
// Platform agnostic plugins
- //----------------------------------------------------------------------
platform_gdb_server::PlatformRemoteGDBServer::Initialize();
process_gdb_remote::ProcessGDBRemote::Initialize();
Modified: lldb/trunk/tools/lldb-test/SystemInitializerTest.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-test/SystemInitializerTest.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-test/SystemInitializerTest.h (original)
+++ lldb/trunk/tools/lldb-test/SystemInitializerTest.h Wed Apr 10 13:48:55 2019
@@ -12,14 +12,12 @@
#include "lldb/Initialization/SystemInitializerCommon.h"
namespace lldb_private {
-//------------------------------------------------------------------
/// Initializes lldb.
///
/// This class is responsible for initializing all of lldb system
/// services needed to use the full LLDB application. This class is
/// not intended to be used externally, but is instead used
/// internally by SBDebugger to initialize the system.
-//------------------------------------------------------------------
class SystemInitializerTest : public SystemInitializerCommon {
public:
SystemInitializerTest();
Modified: lldb/trunk/tools/lldb-vscode/JSONUtils.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-vscode/JSONUtils.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-vscode/JSONUtils.cpp (original)
+++ lldb/trunk/tools/lldb-vscode/JSONUtils.cpp Wed Apr 10 13:48:55 2019
@@ -164,7 +164,6 @@ void FillResponse(const llvm::json::Obje
response.try_emplace("success", true);
}
-//----------------------------------------------------------------------
// "Scope": {
// "type": "object",
// "description": "A Scope is a named container for variables. Optionally
@@ -223,7 +222,6 @@ void FillResponse(const llvm::json::Obje
// },
// "required": [ "name", "variablesReference", "expensive" ]
// }
-//----------------------------------------------------------------------
llvm::json::Value CreateScope(const llvm::StringRef name,
int64_t variablesReference,
int64_t namedVariables, bool expensive) {
@@ -235,7 +233,6 @@ llvm::json::Value CreateScope(const llvm
return llvm::json::Value(std::move(object));
}
-//----------------------------------------------------------------------
// "Breakpoint": {
// "type": "object",
// "description": "Information about a Breakpoint created in setBreakpoints
@@ -284,7 +281,6 @@ llvm::json::Value CreateScope(const llvm
// },
// "required": [ "verified" ]
// }
-//----------------------------------------------------------------------
llvm::json::Value CreateBreakpoint(lldb::SBBreakpointLocation &bp_loc) {
// Each breakpoint location is treated as a separate breakpoint for VS code.
// They don't have the notion of a single breakpoint with multiple locations.
@@ -318,7 +314,6 @@ void AppendBreakpoint(lldb::SBBreakpoint
}
}
-//----------------------------------------------------------------------
// "Event": {
// "allOf": [ { "$ref": "#/definitions/ProtocolMessage" }, {
// "type": "object",
@@ -357,7 +352,6 @@ void AppendBreakpoint(lldb::SBBreakpoint
// },
// "required": [ "seq", "type" ]
// }
-//----------------------------------------------------------------------
llvm::json::Object CreateEventObject(const llvm::StringRef event_name) {
llvm::json::Object event;
event.try_emplace("seq", 0);
@@ -366,7 +360,6 @@ llvm::json::Object CreateEventObject(con
return event;
}
-//----------------------------------------------------------------------
// "ExceptionBreakpointsFilter": {
// "type": "object",
// "description": "An ExceptionBreakpointsFilter is shown in the UI as an
@@ -389,7 +382,6 @@ llvm::json::Object CreateEventObject(con
// },
// "required": [ "filter", "label" ]
// }
-//----------------------------------------------------------------------
llvm::json::Value
CreateExceptionBreakpointFilter(const ExceptionBreakpoint &bp) {
llvm::json::Object object;
@@ -399,7 +391,6 @@ CreateExceptionBreakpointFilter(const Ex
return llvm::json::Value(std::move(object));
}
-//----------------------------------------------------------------------
// "Source": {
// "type": "object",
// "description": "A Source is a descriptor for source code. It is returned
@@ -465,7 +456,6 @@ CreateExceptionBreakpointFilter(const Ex
// }
// }
// }
-//----------------------------------------------------------------------
llvm::json::Value CreateSource(lldb::SBLineEntry &line_entry) {
llvm::json::Object object;
lldb::SBFileSpec file = line_entry.GetFileSpec();
@@ -569,7 +559,6 @@ llvm::json::Value CreateSource(lldb::SBF
return llvm::json::Value(std::move(object));
}
-//----------------------------------------------------------------------
// "StackFrame": {
// "type": "object",
// "description": "A Stackframe contains the source location.",
@@ -626,7 +615,6 @@ llvm::json::Value CreateSource(lldb::SBF
// },
// "required": [ "id", "name", "line", "column" ]
// }
-//----------------------------------------------------------------------
llvm::json::Value CreateStackFrame(lldb::SBFrame &frame) {
llvm::json::Object object;
int64_t frame_id = MakeVSCodeFrameID(frame);
@@ -648,7 +636,6 @@ llvm::json::Value CreateStackFrame(lldb:
return llvm::json::Value(std::move(object));
}
-//----------------------------------------------------------------------
// "Thread": {
// "type": "object",
// "description": "A Thread",
@@ -664,7 +651,6 @@ llvm::json::Value CreateStackFrame(lldb:
// },
// "required": [ "id", "name" ]
// }
-//----------------------------------------------------------------------
llvm::json::Value CreateThread(lldb::SBThread &thread) {
llvm::json::Object object;
object.try_emplace("id", (int64_t)thread.GetThreadID());
@@ -682,7 +668,6 @@ llvm::json::Value CreateThread(lldb::SBT
return llvm::json::Value(std::move(object));
}
-//----------------------------------------------------------------------
// "StoppedEvent": {
// "allOf": [ { "$ref": "#/definitions/Event" }, {
// "type": "object",
@@ -740,7 +725,6 @@ llvm::json::Value CreateThread(lldb::SBT
// "required": [ "event", "body" ]
// }]
// }
-//----------------------------------------------------------------------
llvm::json::Value CreateThreadStopped(lldb::SBThread &thread,
uint32_t stop_id) {
llvm::json::Object event(CreateEventObject("stopped"));
@@ -799,7 +783,6 @@ llvm::json::Value CreateThreadStopped(ll
return llvm::json::Value(std::move(event));
}
-//----------------------------------------------------------------------
// "Variable": {
// "type": "object",
// "description": "A Variable is a name/value pair. Optionally a variable
@@ -862,7 +845,6 @@ llvm::json::Value CreateThreadStopped(ll
// },
// "required": [ "name", "value", "variablesReference" ]
// }
-//----------------------------------------------------------------------
llvm::json::Value CreateVariable(lldb::SBValue v, int64_t variablesReference,
int64_t varID, bool format_hex) {
llvm::json::Object object;
Modified: lldb/trunk/tools/lldb-vscode/JSONUtils.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-vscode/JSONUtils.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-vscode/JSONUtils.h (original)
+++ lldb/trunk/tools/lldb-vscode/JSONUtils.h Wed Apr 10 13:48:55 2019
@@ -16,7 +16,6 @@
namespace lldb_vscode {
-//------------------------------------------------------------------
/// Emplace a StringRef in a json::Object after enusring that the
/// string is valid UTF8. If not, first call llvm::json::fixUTF8
/// before emplacing.
@@ -29,11 +28,9 @@ namespace lldb_vscode {
///
/// \param[in] str
/// The string to emplace
-//------------------------------------------------------------------
void EmplaceSafeString(llvm::json::Object &obj, llvm::StringRef key,
llvm::StringRef str);
-//------------------------------------------------------------------
/// Extract simple values as a string.
///
/// \param[in] value
@@ -42,10 +39,8 @@ void EmplaceSafeString(llvm::json::Objec
/// \return
/// A llvm::StringRef that contains the string value, or an empty
/// string if \a value isn't a string.
-//------------------------------------------------------------------
llvm::StringRef GetAsString(const llvm::json::Value &value);
-//------------------------------------------------------------------
/// Extract the string value for the specified key from the
/// specified object.
///
@@ -59,11 +54,9 @@ llvm::StringRef GetAsString(const llvm::
/// A llvm::StringRef that contains the string value for the
/// specified \a key, or an empty string if there is no key that
/// matches or if the value is not a string.
-//------------------------------------------------------------------
llvm::StringRef GetString(const llvm::json::Object &obj, llvm::StringRef key);
llvm::StringRef GetString(const llvm::json::Object *obj, llvm::StringRef key);
-//------------------------------------------------------------------
/// Extract the unsigned integer value for the specified key from
/// the specified object.
///
@@ -77,13 +70,11 @@ llvm::StringRef GetString(const llvm::js
/// The unsigned integer value for the specified \a key, or
/// \a fail_value if there is no key that matches or if the
/// value is not an integer.
-//------------------------------------------------------------------
uint64_t GetUnsigned(const llvm::json::Object &obj, llvm::StringRef key,
uint64_t fail_value);
uint64_t GetUnsigned(const llvm::json::Object *obj, llvm::StringRef key,
uint64_t fail_value);
-//------------------------------------------------------------------
/// Extract the boolean value for the specified key from the
/// specified object.
///
@@ -97,13 +88,11 @@ uint64_t GetUnsigned(const llvm::json::O
/// The boolean value for the specified \a key, or \a fail_value
/// if there is no key that matches or if the value is not a
/// boolean value of an integer.
-//------------------------------------------------------------------
bool GetBoolean(const llvm::json::Object &obj, llvm::StringRef key,
bool fail_value);
bool GetBoolean(const llvm::json::Object *obj, llvm::StringRef key,
bool fail_value);
-//------------------------------------------------------------------
/// Extract the signed integer for the specified key from the
/// specified object.
///
@@ -117,13 +106,11 @@ bool GetBoolean(const llvm::json::Object
/// The signed integer value for the specified \a key, or
/// \a fail_value if there is no key that matches or if the
/// value is not an integer.
-//------------------------------------------------------------------
int64_t GetSigned(const llvm::json::Object &obj, llvm::StringRef key,
int64_t fail_value);
int64_t GetSigned(const llvm::json::Object *obj, llvm::StringRef key,
int64_t fail_value);
-//------------------------------------------------------------------
/// Check if the specified key exists in the specified object.
///
/// \param[in] obj
@@ -134,10 +121,8 @@ int64_t GetSigned(const llvm::json::Obje
///
/// \return
/// \b True if the key exists in the \a obj, \b False otherwise.
-//------------------------------------------------------------------
bool ObjectContainsKey(const llvm::json::Object &obj, llvm::StringRef key);
-//------------------------------------------------------------------
/// Extract an array of strings for the specified key from an object.
///
/// String values in the array will be extracted without any quotes
@@ -156,11 +141,9 @@ bool ObjectContainsKey(const llvm::json:
/// \a fail_value if there is no key that matches or if the
/// value is not an array or all items in the array are not
/// strings, numbers or booleans.
-//------------------------------------------------------------------
std::vector<std::string> GetStrings(const llvm::json::Object *obj,
llvm::StringRef key);
-//------------------------------------------------------------------
/// Fill a response object given the request object.
///
/// The \a response object will get its "type" set to "response",
@@ -174,11 +157,9 @@ std::vector<std::string> GetStrings(cons
/// \param[in,out] response
/// An empty llvm::json::Object object that will be filled
/// in as noted in description.
-//------------------------------------------------------------------
void FillResponse(const llvm::json::Object &request,
llvm::json::Object &response);
-//----------------------------------------------------------------------
/// Emplace the string value from an SBValue into the supplied object
/// using \a key as the key that will contain the value.
///
@@ -200,11 +181,9 @@ void FillResponse(const llvm::json::Obje
///
/// \param[in] key
/// The key name to use when inserting the value object we create
-//----------------------------------------------------------------------
void SetValueForKey(lldb::SBValue &v, llvm::json::Object &object,
llvm::StringRef key);
-//----------------------------------------------------------------------
/// Converts \a bp to a JSON value and appends all locations to the
/// \a breakpoints array.
///
@@ -215,10 +194,8 @@ void SetValueForKey(lldb::SBValue &v, ll
/// \param[in] breakpoints
/// A JSON array that will get a llvm::json::Value for \a bp
/// appended to it.
-//----------------------------------------------------------------------
void AppendBreakpoint(lldb::SBBreakpoint &bp, llvm::json::Array &breakpoints);
-//----------------------------------------------------------------------
/// Converts breakpoint location to a Visual Studio Code "Breakpoint"
/// JSON object and appends it to the \a breakpoints array.
///
@@ -228,10 +205,8 @@ void AppendBreakpoint(lldb::SBBreakpoint
/// \return
/// A "Breakpoint" JSON object with that follows the formal JSON
/// definition outlined by Microsoft.
-//----------------------------------------------------------------------
llvm::json::Value CreateBreakpoint(lldb::SBBreakpointLocation &bp_loc);
-//----------------------------------------------------------------------
/// Create a "Event" JSON object using \a event_name as the event name
///
/// \param[in] event_name
@@ -240,10 +215,8 @@ llvm::json::Value CreateBreakpoint(lldb:
/// \return
/// A "Event" JSON object with that follows the formal JSON
/// definition outlined by Microsoft.
-//----------------------------------------------------------------------
llvm::json::Object CreateEventObject(const llvm::StringRef event_name);
-//----------------------------------------------------------------------
/// Create a "ExceptionBreakpointsFilter" JSON object as described in
/// the Visual Studio Code debug adaptor definition.
///
@@ -253,11 +226,9 @@ llvm::json::Object CreateEventObject(con
/// \return
/// A "ExceptionBreakpointsFilter" JSON object with that follows
/// the formal JSON definition outlined by Microsoft.
-//----------------------------------------------------------------------
llvm::json::Value
CreateExceptionBreakpointFilter(const ExceptionBreakpoint &bp);
-//----------------------------------------------------------------------
/// Create a "Scope" JSON object as described in the Visual Studio Code
/// debug adaptor definition.
///
@@ -276,12 +247,10 @@ CreateExceptionBreakpointFilter(const Ex
/// \return
/// A "Scope" JSON object with that follows the formal JSON
/// definition outlined by Microsoft.
-//----------------------------------------------------------------------
llvm::json::Value CreateScope(const llvm::StringRef name,
int64_t variablesReference,
int64_t namedVariables, bool expensive);
-//----------------------------------------------------------------------
/// Create a "Source" JSON object as described in the Visual Studio Code
/// debug adaptor definition.
///
@@ -292,10 +261,8 @@ llvm::json::Value CreateScope(const llvm
/// \return
/// A "Source" JSON object with that follows the formal JSON
/// definition outlined by Microsoft.
-//----------------------------------------------------------------------
llvm::json::Value CreateSource(lldb::SBLineEntry &line_entry);
-//----------------------------------------------------------------------
/// Create a "Source" object for a given frame.
///
/// When there is no source file information for a stack frame, we will
@@ -319,10 +286,8 @@ llvm::json::Value CreateSource(lldb::SBL
/// \return
/// A "Source" JSON object with that follows the formal JSON
/// definition outlined by Microsoft.
-//----------------------------------------------------------------------
llvm::json::Value CreateSource(lldb::SBFrame &frame, int64_t &disasm_line);
-//----------------------------------------------------------------------
/// Create a "StackFrame" object for a LLDB frame object.
///
/// This function will fill in the following keys in the returned
@@ -340,10 +305,8 @@ llvm::json::Value CreateSource(lldb::SBF
/// \return
/// A "StackFrame" JSON object with that follows the formal JSON
/// definition outlined by Microsoft.
-//----------------------------------------------------------------------
llvm::json::Value CreateStackFrame(lldb::SBFrame &frame);
-//----------------------------------------------------------------------
/// Create a "Thread" object for a LLDB thread object.
///
/// This function will fill in the following keys in the returned
@@ -360,10 +323,8 @@ llvm::json::Value CreateStackFrame(lldb:
/// \return
/// A "Thread" JSON object with that follows the formal JSON
/// definition outlined by Microsoft.
-//----------------------------------------------------------------------
llvm::json::Value CreateThread(lldb::SBThread &thread);
-//----------------------------------------------------------------------
/// Create a "StoppedEvent" object for a LLDB thread object.
///
/// This function will fill in the following keys in the returned
@@ -385,10 +346,8 @@ llvm::json::Value CreateThread(lldb::SBT
/// \return
/// A "StoppedEvent" JSON object with that follows the formal JSON
/// definition outlined by Microsoft.
-//----------------------------------------------------------------------
llvm::json::Value CreateThreadStopped(lldb::SBThread &thread, uint32_t stop_id);
-//----------------------------------------------------------------------
/// Create a "Variable" object for a LLDB thread object.
///
/// This function will fill in the following keys in the returned
@@ -428,7 +387,6 @@ llvm::json::Value CreateThreadStopped(ll
/// \return
/// A "Variable" JSON object with that follows the formal JSON
/// definition outlined by Microsoft.
-//----------------------------------------------------------------------
llvm::json::Value CreateVariable(lldb::SBValue v, int64_t variablesReference,
int64_t varID, bool format_hex);
Modified: lldb/trunk/tools/lldb-vscode/LLDBUtils.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-vscode/LLDBUtils.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-vscode/LLDBUtils.h (original)
+++ lldb/trunk/tools/lldb-vscode/LLDBUtils.h Wed Apr 10 13:48:55 2019
@@ -18,7 +18,6 @@
namespace lldb_vscode {
-///----------------------------------------------------------------------
/// Run a list of LLDB commands in the LLDB command interpreter.
///
/// All output from every command, including the prompt + the command
@@ -34,12 +33,10 @@ namespace lldb_vscode {
/// \param[in] strm
/// The stream that will receive the prefix, prompt + command and
/// all command output.
-//----------------------------------------------------------------------
void RunLLDBCommands(llvm::StringRef prefix,
const llvm::ArrayRef<std::string> &commands,
llvm::raw_ostream &strm);
-///----------------------------------------------------------------------
/// Run a list of LLDB commands in the LLDB command interpreter.
///
/// All output from every command, including the prompt + the command
@@ -55,11 +52,9 @@ void RunLLDBCommands(llvm::StringRef pre
/// \return
/// A std::string that contains the prefix and all commands and
/// command output
-//----------------------------------------------------------------------
std::string RunLLDBCommands(llvm::StringRef prefix,
const llvm::ArrayRef<std::string> &commands);
-///----------------------------------------------------------------------
/// Check if a thread has a stop reason.
///
/// \param[in] thread
@@ -68,10 +63,8 @@ std::string RunLLDBCommands(llvm::String
/// \return
/// \b True if the thread has a valid stop reason, \b false
/// otherwise.
-//----------------------------------------------------------------------
bool ThreadHasStopReason(lldb::SBThread &thread);
-///----------------------------------------------------------------------
/// Given a LLDB frame, make a frame ID that is unique to a specific
/// thread and frame.
///
@@ -85,10 +78,8 @@ bool ThreadHasStopReason(lldb::SBThread
/// \return
/// A unique integer that allows us to easily find the right
/// stack frame within a thread on subsequent VS code requests.
-//----------------------------------------------------------------------
int64_t MakeVSCodeFrameID(lldb::SBFrame &frame);
-///----------------------------------------------------------------------
/// Given a VSCode frame ID, convert to a LLDB thread index id.
///
/// VSCode requires a Stackframe "id" to be unique, so we use the frame
@@ -100,10 +91,8 @@ int64_t MakeVSCodeFrameID(lldb::SBFrame
///
/// \return
/// The LLDB thread index ID.
-//----------------------------------------------------------------------
uint32_t GetLLDBThreadIndexID(uint64_t dap_frame_id);
-///----------------------------------------------------------------------
/// Given a VSCode frame ID, convert to a LLDB frame ID.
///
/// VSCode requires a Stackframe "id" to be unique, so we use the frame
@@ -115,10 +104,8 @@ uint32_t GetLLDBThreadIndexID(uint64_t d
///
/// \return
/// The LLDB frame index ID.
-//----------------------------------------------------------------------
uint32_t GetLLDBFrameID(uint64_t dap_frame_id);
-///----------------------------------------------------------------------
/// Given a LLDB breakpoint, make a breakpoint ID that is unique to a
/// specific breakpoint and breakpoint location.
///
@@ -132,10 +119,8 @@ uint32_t GetLLDBFrameID(uint64_t dap_fra
/// \return
/// A unique integer that allows us to easily find the right
/// stack frame within a thread on subsequent VS code requests.
-//----------------------------------------------------------------------
int64_t MakeVSCodeBreakpointID(lldb::SBBreakpointLocation &bp_loc);
-///----------------------------------------------------------------------
/// Given a VSCode breakpoint ID, convert to a LLDB breakpoint ID.
///
/// VSCode requires a Breakpoint "id" to be unique, so we use the
@@ -147,10 +132,8 @@ int64_t MakeVSCodeBreakpointID(lldb::SBB
///
/// \return
/// The LLDB breakpoint ID.
-//----------------------------------------------------------------------
uint32_t GetLLDBBreakpointID(uint64_t dap_breakpoint_id);
-///----------------------------------------------------------------------
/// Given a VSCode breakpoint ID, convert to a LLDB breakpoint location ID.
///
/// VSCode requires a Breakpoint "id" to be unique, so we use the
@@ -162,7 +145,6 @@ uint32_t GetLLDBBreakpointID(uint64_t da
///
/// \return
/// The LLDB breakpoint location ID.
-//----------------------------------------------------------------------
uint32_t GetLLDBBreakpointLocationID(uint64_t dap_breakpoint_id);
} // namespace lldb_vscode
Modified: lldb/trunk/tools/lldb-vscode/VSCode.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-vscode/VSCode.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-vscode/VSCode.cpp (original)
+++ lldb/trunk/tools/lldb-vscode/VSCode.cpp Wed Apr 10 13:48:55 2019
@@ -78,11 +78,9 @@ VSCode::GetExceptionBreakpoint(const lld
return nullptr;
}
-//----------------------------------------------------------------------
// Send the JSON in "json_str" to the "out" stream. Correctly send the
// "Content-Length:" field followed by the length, followed by the raw
// JSON bytes.
-//----------------------------------------------------------------------
void VSCode::SendJSON(const std::string &json_str) {
output.write_full("Content-Length: ");
output.write_full(llvm::utostr(json_str.size()));
@@ -96,10 +94,8 @@ void VSCode::SendJSON(const std::string
}
}
-//----------------------------------------------------------------------
// Serialize the JSON value into a string and send the JSON packet to
// the "out" stream.
-//----------------------------------------------------------------------
void VSCode::SendJSON(const llvm::json::Value &json) {
std::string s;
llvm::raw_string_ostream strm(s);
@@ -109,9 +105,7 @@ void VSCode::SendJSON(const llvm::json::
SendJSON(strm.str());
}
-//----------------------------------------------------------------------
// Read a JSON packet from the "in" stream.
-//----------------------------------------------------------------------
std::string VSCode::ReadJSON() {
std::string length_str;
std::string json_str;
@@ -135,7 +129,6 @@ std::string VSCode::ReadJSON() {
return json_str;
}
-//----------------------------------------------------------------------
// "OutputEvent": {
// "allOf": [ { "$ref": "#/definitions/Event" }, {
// "type": "object",
@@ -196,7 +189,6 @@ std::string VSCode::ReadJSON() {
// "required": [ "event", "body" ]
// }]
// }
-//----------------------------------------------------------------------
void VSCode::SendOutput(OutputType o, const llvm::StringRef output) {
if (output.empty())
return;
Modified: lldb/trunk/tools/lldb-vscode/VSCode.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-vscode/VSCode.h?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-vscode/VSCode.h (original)
+++ lldb/trunk/tools/lldb-vscode/VSCode.h Wed Apr 10 13:48:55 2019
@@ -99,17 +99,13 @@ struct VSCode {
int64_t GetLineForPC(int64_t sourceReference, lldb::addr_t pc) const;
ExceptionBreakpoint *GetExceptionBreakpoint(const std::string &filter);
ExceptionBreakpoint *GetExceptionBreakpoint(const lldb::break_id_t bp_id);
- //----------------------------------------------------------------------
// Send the JSON in "json_str" to the "out" stream. Correctly send the
// "Content-Length:" field followed by the length, followed by the raw
// JSON bytes.
- //----------------------------------------------------------------------
void SendJSON(const std::string &json_str);
- //----------------------------------------------------------------------
// Serialize the JSON value into a string and send the JSON packet to
// the "out" stream.
- //----------------------------------------------------------------------
void SendJSON(const llvm::json::Value &json);
std::string ReadJSON();
Modified: lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp (original)
+++ lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp Wed Apr 10 13:48:55 2019
@@ -119,9 +119,7 @@ std::vector<const char *> MakeArgv(const
return argv;
}
-//----------------------------------------------------------------------
// Send a "exited" event to indicate the process has exited.
-//----------------------------------------------------------------------
void SendProcessExitedEvent(lldb::SBProcess &process) {
llvm::json::Object event(CreateEventObject("exited"));
llvm::json::Object body;
@@ -139,10 +137,8 @@ void SendThreadExitedEvent(lldb::tid_t t
g_vsc.SendJSON(llvm::json::Value(std::move(event)));
}
-//----------------------------------------------------------------------
// Send a "terminated" event to indicate the process is done being
// debugged.
-//----------------------------------------------------------------------
void SendTerminatedEvent() {
if (!g_vsc.sent_terminated_event) {
g_vsc.sent_terminated_event = true;
@@ -152,10 +148,8 @@ void SendTerminatedEvent() {
}
}
-//----------------------------------------------------------------------
// Send a thread stopped event for all threads as long as the process
// is stopped.
-//----------------------------------------------------------------------
void SendThreadStoppedEvent() {
lldb::SBProcess process = g_vsc.target.GetProcess();
if (process.IsValid()) {
@@ -228,7 +222,6 @@ void SendThreadStoppedEvent() {
g_vsc.RunStopCommands();
}
-//----------------------------------------------------------------------
// "ProcessEvent": {
// "allOf": [
// { "$ref": "#/definitions/Event" },
@@ -283,7 +276,6 @@ void SendThreadStoppedEvent() {
// }
// ]
// }
-//----------------------------------------------------------------------
void SendProcessEvent(LaunchMethod launch_method) {
lldb::SBFileSpec exe_fspec = g_vsc.target.GetExecutable();
char exe_path[PATH_MAX];
@@ -311,10 +303,8 @@ void SendProcessEvent(LaunchMethod launc
g_vsc.SendJSON(llvm::json::Value(std::move(event)));
}
-//----------------------------------------------------------------------
// Grab any STDOUT and STDERR from the process and send it up to VS Code
// via an "output" event to the "stdout" and "stderr" categories.
-//----------------------------------------------------------------------
void SendStdOutStdErr(lldb::SBProcess &process) {
char buffer[1024];
size_t count;
@@ -324,13 +314,11 @@ void SendStdOutStdErr(lldb::SBProcess &p
g_vsc.SendOutput(OutputType::Stderr, llvm::StringRef(buffer, count));
}
-//----------------------------------------------------------------------
// All events from the debugger, target, process, thread and frames are
// received in this function that runs in its own thread. We are using a
// "FILE *" to output packets back to VS Code and they have mutexes in them
// them prevent multiple threads from writing simultaneously so no locking
// is required.
-//----------------------------------------------------------------------
void EventThreadFunction() {
lldb::SBEvent event;
lldb::SBListener listener = g_vsc.debugger.GetListener();
@@ -420,10 +408,8 @@ void EventThreadFunction() {
}
}
-//----------------------------------------------------------------------
// Both attach and launch take a either a sourcePath or sourceMap
// argument (or neither), from which we need to set the target.source-map.
-//----------------------------------------------------------------------
void SetSourceMapFromArguments(const llvm::json::Object &arguments) {
const char *sourceMapHelp =
"source must be be an array of two-element arrays, "
@@ -465,7 +451,6 @@ void SetSourceMapFromArguments(const llv
}
}
-//----------------------------------------------------------------------
// "AttachRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -494,7 +479,6 @@ void SetSourceMapFromArguments(const llv
// acknowledgement, so no body field is required."
// }]
// }
-//----------------------------------------------------------------------
void request_attach(const llvm::json::Object &request) {
llvm::json::Object response;
lldb::SBError error;
@@ -602,7 +586,6 @@ void request_attach(const llvm::json::Ob
}
}
-//----------------------------------------------------------------------
// "ContinueRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -657,7 +640,6 @@ void request_attach(const llvm::json::Ob
// "required": [ "body" ]
// }]
// }
-//----------------------------------------------------------------------
void request_continue(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -673,7 +655,6 @@ void request_continue(const llvm::json::
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "ConfigurationDoneRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -705,7 +686,6 @@ void request_continue(const llvm::json::
// just an acknowledgement, so no body field is required."
// }]
// },
-//----------------------------------------------------------------------
void request_configurationDone(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -716,7 +696,6 @@ void request_configurationDone(const llv
g_vsc.target.GetProcess().Continue();
}
-//----------------------------------------------------------------------
// "DisconnectRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -761,7 +740,6 @@ void request_configurationDone(const llv
// acknowledgement, so no body field is required."
// }]
// }
-//----------------------------------------------------------------------
void request_disconnect(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -840,7 +818,6 @@ void request_exceptionInfo(const llvm::j
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "EvaluateRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -942,7 +919,6 @@ void request_exceptionInfo(const llvm::j
// "required": [ "body" ]
// }]
// }
-//----------------------------------------------------------------------
void request_evaluate(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -992,7 +968,6 @@ void request_evaluate(const llvm::json::
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "InitializeRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -1069,7 +1044,6 @@ void request_evaluate(const llvm::json::
// }
// }]
// }
-//----------------------------------------------------------------------
void request_initialize(const llvm::json::Object &request) {
g_vsc.debugger = lldb::SBDebugger::Create(true /*source_init_files*/);
// Create an empty target right away since we might get breakpoint requests
@@ -1163,7 +1137,6 @@ void request_initialize(const llvm::json
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "LaunchRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -1198,7 +1171,6 @@ void request_initialize(const llvm::json
// acknowledgement, so no body field is required."
// }]
// }
-//----------------------------------------------------------------------
void request_launch(const llvm::json::Object &request) {
llvm::json::Object response;
lldb::SBError error;
@@ -1297,7 +1269,6 @@ void request_launch(const llvm::json::Ob
g_vsc.debugger.SetAsync(true);
}
-//----------------------------------------------------------------------
// "NextRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -1336,7 +1307,6 @@ void request_launch(const llvm::json::Ob
// acknowledgement, so no body field is required."
// }]
// }
-//----------------------------------------------------------------------
void request_next(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -1353,7 +1323,6 @@ void request_next(const llvm::json::Obje
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "PauseRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -1390,7 +1359,6 @@ void request_next(const llvm::json::Obje
// acknowledgement, so no body field is required."
// }]
// }
-//----------------------------------------------------------------------
void request_pause(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -1399,7 +1367,6 @@ void request_pause(const llvm::json::Obj
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "ScopesRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -1451,7 +1418,6 @@ void request_pause(const llvm::json::Obj
// "required": [ "body" ]
// }]
// }
-//----------------------------------------------------------------------
void request_scopes(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -1477,7 +1443,6 @@ void request_scopes(const llvm::json::Ob
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "SetBreakpointsRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -1588,7 +1553,6 @@ void request_scopes(const llvm::json::Ob
// },
// "required": [ "line" ]
// }
-//----------------------------------------------------------------------
void request_setBreakpoints(const llvm::json::Object &request) {
llvm::json::Object response;
lldb::SBError error;
@@ -1670,7 +1634,6 @@ void request_setBreakpoints(const llvm::
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "SetExceptionBreakpointsRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -1718,7 +1681,6 @@ void request_setBreakpoints(const llvm::
// just an acknowledgement, so no body field is required."
// }]
// }
-//----------------------------------------------------------------------
void request_setExceptionBreakpoints(const llvm::json::Object &request) {
llvm::json::Object response;
lldb::SBError error;
@@ -1747,7 +1709,6 @@ void request_setExceptionBreakpoints(con
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "SetFunctionBreakpointsRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -1826,7 +1787,6 @@ void request_setExceptionBreakpoints(con
// "required": [ "body" ]
// }]
// }
-//----------------------------------------------------------------------
void request_setFunctionBreakpoints(const llvm::json::Object &request) {
llvm::json::Object response;
lldb::SBError error;
@@ -1883,7 +1843,6 @@ void request_setFunctionBreakpoints(cons
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "SourceRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -1942,7 +1901,6 @@ void request_setFunctionBreakpoints(cons
// "required": [ "body" ]
// }]
// }
-//----------------------------------------------------------------------
void request_source(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -1961,7 +1919,6 @@ void request_source(const llvm::json::Ob
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "StackTraceRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -2032,7 +1989,6 @@ void request_source(const llvm::json::Ob
// "required": [ "body" ]
// }]
// }
-//----------------------------------------------------------------------
void request_stackTrace(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -2058,7 +2014,6 @@ void request_stackTrace(const llvm::json
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "StepInRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -2104,7 +2059,6 @@ void request_stackTrace(const llvm::json
// acknowledgement, so no body field is required."
// }]
// }
-//----------------------------------------------------------------------
void request_stepIn(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -2121,7 +2075,6 @@ void request_stepIn(const llvm::json::Ob
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "StepOutRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -2158,7 +2111,6 @@ void request_stepIn(const llvm::json::Ob
// acknowledgement, so no body field is required."
// }]
// }
-//----------------------------------------------------------------------
void request_stepOut(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -2175,7 +2127,6 @@ void request_stepOut(const llvm::json::O
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "ThreadsRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -2211,7 +2162,6 @@ void request_stepOut(const llvm::json::O
// "required": [ "body" ]
// }]
// }
-//----------------------------------------------------------------------
void request_threads(const llvm::json::Object &request) {
lldb::SBProcess process = g_vsc.target.GetProcess();
@@ -2233,7 +2183,6 @@ void request_threads(const llvm::json::O
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "SetVariableRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -2316,7 +2265,6 @@ void request_threads(const llvm::json::O
// "required": [ "body" ]
// }]
// }
-//----------------------------------------------------------------------
void request_setVariable(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
@@ -2426,7 +2374,6 @@ void request_setVariable(const llvm::jso
g_vsc.SendJSON(llvm::json::Value(std::move(response)));
}
-//----------------------------------------------------------------------
// "VariablesRequest": {
// "allOf": [ { "$ref": "#/definitions/Request" }, {
// "type": "object",
@@ -2500,7 +2447,6 @@ void request_setVariable(const llvm::jso
// "required": [ "body" ]
// }]
// }
-//----------------------------------------------------------------------
void request_variables(const llvm::json::Object &request) {
llvm::json::Object response;
FillResponse(request, response);
Modified: lldb/trunk/unittests/Language/Highlighting/HighlighterTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Language/Highlighting/HighlighterTest.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/unittests/Language/Highlighting/HighlighterTest.cpp (original)
+++ lldb/trunk/unittests/Language/Highlighting/HighlighterTest.cpp Wed Apr 10 13:48:55 2019
@@ -124,9 +124,7 @@ TEST_F(HighlighterTest, DefaultHighlight
style.selected.Set("<c>", "</c>");
EXPECT_EQ("a bc", highlightDefault("a bc", style, 4));
}
-//------------------------------------------------------------------------------
// Tests highlighting with the Clang highlighter.
-//------------------------------------------------------------------------------
static std::string
highlightC(llvm::StringRef code, HighlightStyle style,
Modified: lldb/trunk/unittests/Utility/StreamTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/StreamTest.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/unittests/Utility/StreamTest.cpp (original)
+++ lldb/trunk/unittests/Utility/StreamTest.cpp Wed Apr 10 13:48:55 2019
@@ -279,9 +279,7 @@ TEST_F(StreamTest, PutMaxHex64ByteOrderL
EXPECT_EQ("12341278563412efcdab9078563412", TakeValue());
}
-//------------------------------------------------------------------------------
// Shift operator tests.
-//------------------------------------------------------------------------------
TEST_F(StreamTest, ShiftOperatorChars) {
s << 'a' << 'b';
@@ -345,9 +343,7 @@ TEST_F(StreamTest, PutPtr) {
// that it should use the host byte order.
const static auto hostByteOrder = lldb::eByteOrderInvalid;
-//------------------------------------------------------------------------------
// PutRawBytes/PutBytesAsRawHex tests.
-//------------------------------------------------------------------------------
TEST_F(StreamTest, PutBytesAsRawHex8ToBigEndian) {
uint32_t value = 0x12345678;
@@ -405,9 +401,7 @@ TEST_F(StreamTest, PutRawBytesToMixedEnd
#endif
}
-//------------------------------------------------------------------------------
// ULEB128 support for binary streams.
-//------------------------------------------------------------------------------
TEST_F(BinaryStreamTest, PutULEB128OneByte) {
auto bytes = s.PutULEB128(0x74ULL);
@@ -493,9 +487,7 @@ TEST_F(BinaryStreamTest, PutULEB128One)
EXPECT_EQ(1U, bytes);
}
-//------------------------------------------------------------------------------
// SLEB128 support for binary streams.
-//------------------------------------------------------------------------------
TEST_F(BinaryStreamTest, PutSLEB128OneByte) {
auto bytes = s.PutSLEB128(0x74LL);
@@ -581,9 +573,7 @@ TEST_F(BinaryStreamTest, PutSLEB128One)
EXPECT_EQ(1U, bytes);
}
-//------------------------------------------------------------------------------
// SLEB128/ULEB128 support for non-binary streams.
-//------------------------------------------------------------------------------
// The logic for this is very simple, so it should be enough to test some basic
// use cases.
Modified: lldb/trunk/unittests/debugserver/debugserver_LogCallback.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/debugserver/debugserver_LogCallback.cpp?rev=358135&r1=358134&r2=358135&view=diff
==============================================================================
--- lldb/trunk/unittests/debugserver/debugserver_LogCallback.cpp (original)
+++ lldb/trunk/unittests/debugserver/debugserver_LogCallback.cpp Wed Apr 10 13:48:55 2019
@@ -6,11 +6,9 @@
//
//===----------------------------------------------------------------------===//
-//------------------------------------------------------------------------------
// this function is defined in debugserver.cpp, but is needed to link the
// debugserver Common library. It is for logging only, so it is left
// unimplemented here.
-//------------------------------------------------------------------------------
#include <stdint.h>
#include <stdarg.h>
More information about the lldb-commits
mailing list