[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

Aaron Smith via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 9 22:40:38 PDT 2019


asmith marked 2 inline comments as done.
asmith added inline comments.


================
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:1
 //===-- main.cpp ------------------------------------------------*- C++ -*-===//
 //
----------------
labath wrote:
> Could you (as a separate patch) convert this file to use c++ threads? That should allow us to cut down on the ifdefs by using standard std::thread and std::mutex.
Done in https://reviews.llvm.org/D60496


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56233/new/

https://reviews.llvm.org/D56233





More information about the lldb-commits mailing list