[Lldb-commits] [PATCH] D60468: Lock accesses to OptionValueFileSpecList objects

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

In D60468#1460065 <https://reviews.llvm.org/D60468#1460065>, @labath wrote:

> No opinion on the patch, but what is the reason for having settings that are shared between multiple Debugger instances? My expectation was that the debugger objects are completely independent, and I would be surprised if the value of some setting changed from under me because of something that happened in another debug session.


Two reasons:

First, because you have to prime new debuggers with something, and that lives outside any Debugger.  THen "settings set -g" is supposed to change the global settings for new debuggers, so there is both reading and writing to the global state.

Secondly, work done in the shared module cache or down in the symbol vendors and the like is generally done without a Debugger or Target, so if you need settable properties (e.g. search paths) then the global version of the property is the only one available.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60468/new/

https://reviews.llvm.org/D60468