[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

[Raphael Isemann via Phabricator via lldb-commits]

teemperor marked 2 inline comments as done.
teemperor added a comment.

Thanks for the review!



================
Comment at: lldb/include/lldb/Symbol/ClangASTImporter.h:240
   public:
     Minion(ClangASTImporter &master, clang::ASTContext *target_ctx,
            clang::ASTContext *source_ctx)
----------------
aprantl wrote:
> Bonus points for coming up with a more descriptive name for this class!
Yeah, refactoring this code here is very high on my TODO list :)


================
Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/forward_list-basic/TestBasicForwardList.py:17
+    @skipIf(compiler=no_match("clang"))
+    @skipIf(oslist=no_match(["linux"]))
+    @skipIf(debug_info=no_match(["dwarf"]))
----------------
aprantl wrote:
> Why wouldn't this work on darwin and/or with a dsym or gmodules or dwo?
That's only because I didn't get our basic modules test case working on Darwin so far. There were some issues with include paths there I was working on, but I didn't get everything fixed yet. So that's why all tests relying on modules are currently marked as 'unsupported on dwarf'. I'll add Darwin everywhere as soon as I get he basic test case working (I don't expect any more Darwin specific issues as it's also just libc++ on both Linux and Darwin, but I was wrong about that before, so... :) ).

Same with dwo which for some reason failed for the basic test case (at least on Linux). Didn't really look into possible fixes for that yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59537/new/

https://reviews.llvm.org/D59537