[Lldb-commits] [PATCH] D60400: Remove unneeded #ifdef SWIGs

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 8 02:13:12 PDT 2019

labath created this revision.
labath added reviewers: JDevlieghere, clayborg, jingham.

Some of these were present in files which should never be read by swig
(and we also had one in the interface file, which is only read by swig).
They are probably leftovers from the time when we were running swig over
lldb headers directly.

The reason I'm putting this up for review is that the patch also
contains mild functional changes. While writing this patch, I noticed
that some of the #ifdefs were guarding public functions that were
operating on lldb_private data types. While it wasn't strictly
necessary, I made these private, as nobody should really be accessing
them. This can potentially break existing code if it happened to use
these methods, though it will only break at build time -- if someone
builds against an old header, he should still be able to link to a new
lldb library, since the functions are still there.

We could keep these public for backward compatbility, but I would argue
that if anyone was actually using these functions for anything, his code
is already broken.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60400.194106.patch
Type: text/x-patch
Size: 7839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190408/ba137cb6/attachment-0001.bin>

More information about the lldb-commits mailing list