[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 5 07:07:02 PDT 2019
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
================
Comment at: lldb/tools/lldb-mi/MICmdCmdData.cpp:419
+ // Get a full path to the file.
+ static char pPathBuffer[PATH_MAX];
+ lineEntry.GetFileSpec().GetPath(pPathBuffer, sizeof(pPathBuffer));
----------------
This shouldn't be static. Probably not going to cause problems if this is always single threaded, but still you should fix this.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59015/new/
https://reviews.llvm.org/D59015
More information about the lldb-commits
mailing list