[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

[James Henderson via Phabricator via lldb-commits]

jhenderson added inline comments.


================
Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:70
   minidump::SystemInfo Info;
+  std::string CSDVersion;
 
----------------
Don't know about lifetime here, but could this be a `StringRef`?


================
Comment at: unittests/Object/MinidumpTest.cpp:270
+      0,                                    // Mis-align next string
+      2, 0, 0, 0, 'a', 0,                   // String6 - "a"
+
----------------
What about a case where the size field cannot fit in the remaining data?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59775/new/

https://reviews.llvm.org/D59775