[Lldb-commits] [PATCH] D60254: Add dropped ManualDWARFIndex assert()

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 4 02:00:05 PDT 2019


labath added a comment.

I don't exactly remember my thought processes there, but I guess I have dropped that assert during the refactor because it was obvious to me.

Now that you mention it, I don't have any particular opinion on what we should do. If it makes your job any easier, then go ahead and remove `GetBaseCompileUnit`. Otherwise, I suppose it might be good to re-add the assert.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60254/new/

https://reviews.llvm.org/D60254





More information about the lldb-commits mailing list