[Lldb-commits] [PATCH] D60180: [CMake] Don't explicitly use LLVM_LIBRARY_DIR in standalone builds
Alex Langford via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 3 14:07:37 PDT 2019
xiaobai added a comment.
So I ran the lldb test suite from a standalone build tree, and this patch didn't change anything. I added some logging to the CMake and `LLVM_LIBRARY_DIR` is being set correctly. It appears to be getting it from the LLVMConfig we get from `find_package(LLVM)`. I think we could also get rid of `LLVM_BINARY_DIR` if that's the case, since it appears we only set it for lit.
>From the looks of it, clang needs to set it manually because they rely on llvm-config instead of using `find_package`.
CHANGES SINCE LAST ACTION
More information about the lldb-commits