[Lldb-commits] [PATCH] D60152: Fix and simplify PrepareCommandsForSourcing

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth updated this revision to Diff 193515.
amccarth edited the summary of this revision.
amccarth added a comment.

Further simplification per labath's feedback.

Specifically:

1. Use a utility function from llvm to avoid making own wrapper for closing a file descriptor.
2. Don't bother resetting fd numbers right before they go out of scope.
3. Live with the Windows-deprecated spelling of fdopen in favor of more `#ifdefs`.
4. Updated summary to reflect these changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60152/new/

https://reviews.llvm.org/D60152

Files:
  lldb/tools/driver/Driver.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60152.193515.patch
Type: text/x-patch
Size: 6332 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190403/5b3ba895/attachment.bin>